Bug#392651: emacs21: bug in 'xbm_read_bitmap_data' (file xfns.c)

2006-10-12 Thread Jochen Voss
Package: emacs21
Version: 21.4a-6.2
Severity: normal

Hello,

recently I discovered the following bit of code in the source file
src/xfns.c (function 'xbm_read_bitmap_data', starting at line 6705):

  if (LA1 == XBM_TK_NUMBER);
{
  char *p = strrchr (buffer, '_');
  p = p ? p + 1 : buffer;
  if (strcmp (p, width) == 0)
*width = value;
  else if (strcmp (p, height) == 0)
*height = value;
}

Since there is a semi-colon at the end of the first line, the indented
block will be executed unconditionally.  This is at least confusing
and very probably a bug which should be fixed.

I hope this helps,
Jochen

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17.13
Locale: LANG=en_GB.iso885915, LC_CTYPE=en_GB.iso885915 (charmap=ISO-8859-15)

Versions of packages emacs21 depends on:
ii  emacs21-bin-common  21.4a-6.2The GNU Emacs editor's shared, arc
ii  libc6   2.3.6.ds1-6  GNU C Library: Shared libraries
ii  libice6 1:1.0.1-2X11 Inter-Client Exchange library
ii  libjpeg62   6b-13The Independent JPEG Group's JPEG 
ii  libncurses5 5.5-4Shared libraries for terminal hand
ii  libpng12-0  1.2.8rel-5.2 PNG library - runtime
ii  libsm6  1:1.0.1-3X11 Session Management library
ii  libtiff43.8.2-6  Tag Image File Format (TIFF) libra
ii  libungif4g  4.1.4-4  shared library for GIF images
ii  libx11-62:1.0.3-1X11 client-side library
ii  libxext61:1.0.1-2X11 miscellaneous extension librar
ii  libxmu6 1:1.0.2-2X11 miscellaneous utility library
ii  libxpm4 1:3.5.5-2X11 pixmap library
ii  libxt6  1:1.0.2-2X11 toolkit intrinsics library
ii  xaw3dg  1.5+E-14 Xaw3d widget set
ii  zlib1g  1:1.2.3-13   compression library - runtime

emacs21 recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#392651: emacs21: bug in 'xbm_read_bitmap_data' (file xfns.c)

2006-10-12 Thread Romain Francoise
Jochen Voss [EMAIL PROTECTED] writes:

 Since there is a semi-colon at the end of the first line, the indented
 block will be executed unconditionally.  This is at least confusing
 and very probably a bug which should be fixed.

Yep, that's a bug.  I fixed it upstream.  Thanks!

-- 
Romain Francoise [EMAIL PROTECTED] | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
| ever free! --Bryan W. Procter


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]