Bug#619565: deluge-console: ignores all but first argument

2011-03-28 Thread Jan Braun
Cristian Greco schrob:
 Jan Braun janbr...@gmx.net wrote:

  deluge-console ignores all its command line arguments but the first.
 
 this problem seems to be already known upstream:

 http://dev.deluge-torrent.org/ticket/1548

 Anyway, there is an ongoing effort for a complete rewrite of
 deluge-console. You may check if your changes still apply against newer
 upstream code, and possibly contribute an updated version of the patch.

It still applies (both to the main deluge repo and to nick's newconsoleui).
The upstream bug contains a virtually identical patch and no objections
(apart from rewrite in progress).

I don't know what else I could do to get this fixed. :(

regards,
Jan
-- 
()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments


signature.asc
Description: Digital signature


Bug#619565: deluge-console: ignores all but first argument

2011-03-25 Thread Jan Braun
Package: deluge-console
Version: 1.3.1-1
Severity: normal
Tags: patch

Hi,
deluge-console ignores all its command line arguments but the first.
This means I have to write
$ deluge-console add /some/torrent
rather than the natural
$ deluge-console add /some/torrent

An obvoius patch is attached.
(One might argue about spaces and other weird stuff in file names, but
since deluge-console does its own string-parsing of the arguments, you
need double quoting with or without my patch. Changing that would
require major changes.)

regards,
Jan
-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (99, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages deluge-console depends on:
ii  deluge-common   1.3.1-1  bittorrent client written in Pytho
ii  python  2.6.6-3+squeeze6 interactive high-level object-orie
ii  python-support  1.0.11   automated rebuilding support for P

deluge-console recommends no packages.

deluge-console suggests no packages.

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/pyshared/deluge/ui/console/main.py (from 
deluge-console package)

-- 
()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments
--- ui/console/main.py.orig	2011-03-25 08:16:53.0 +0100
+++ ui/console/main.py	2011-03-25 08:24:08.0 +0100
@@ -160,7 +160,7 @@
 # Set the interactive flag to indicate where we should print the output
 self.interactive = True
 if args:
-args = args[0]
+args =  .join(args)
 self.interactive = False
 
 # Try to connect to the localhost daemon


signature.asc
Description: Digital signature


Bug#619565: deluge-console: ignores all but first argument

2011-03-25 Thread Cristian Greco
tags 619565 upstream
forwarded 619565 http://dev.deluge-torrent.org/ticket/1548
thanks

On Fri, 25 Mar 2011 09:21:49 +0100
Jan Braun janbr...@gmx.net wrote:

 Package: deluge-console
 Version: 1.3.1-1
 Severity: normal
 Tags: patch
 
 Hi,
 deluge-console ignores all its command line arguments but the first.
 This means I have to write
 $ deluge-console add /some/torrent
 rather than the natural
 $ deluge-console add /some/torrent
 
 An obvoius patch is attached.
 (One might argue about spaces and other weird stuff in file names, but
 since deluge-console does its own string-parsing of the arguments, you
 need double quoting with or without my patch. Changing that would
 require major changes.)

Hi Jan,

this problem seems to be already known upstream:

http://dev.deluge-torrent.org/ticket/1548

Anyway, there is an ongoing effort for a complete rewrite of
deluge-console. You may check if your changes still apply against newer
upstream code, and possibly contribute an updated version of the patch.

Thanks,
--
Cristian Greco
GPG key ID: 0xCF4D32E4


signature.asc
Description: PGP signature