Bug#658324: mutt: smime_keys.pl fails on filenames with spaces

2015-09-05 Thread Kevin J. McCarthy
Just a note that this is fixed upstream.  There were a series of patches
cleaning up up smime_keys.  I think the relevant one for this bug was
http://dev.mutt.org/hg/mutt/rev/577987ca2d02
but it probably won't apply outside of the series of commits.

-Kevin



Bug#658324: mutt: smime_keys.pl fails on filenames with spaces

2012-02-01 Thread Andre Klärner
Package: mutt
Version: 1.5.21-5
Severity: normal
Tags: upstream

Dear Maintainer,

I recently needed to update by smime-keyring with a new version of my own
certificate to a new one, and saved it to a file named
cacert kan...@ak-online.be renewed.p12.

Unfortunately 'smime_keys add_p12 cacert kan...@ak-online.be renewed.p12'
failed with the return code 256 from openssl and a dump of it's commandline
options.

I looked into smime_keys and found that the perl-script builds the command
in line 156 directly from $ARGV[1]:

 snip 
156:my $cmd = $opensslbin pkcs12 -in $ARGV[1] -out $pem_file;
157:system $cmd and die '$cmd' returned $?;
 snip 

The error-message also contained the exact commandline it tried to execute
which was:
 snip 
'/usr/bin/openssl pkcs12 -in cacert kan...@ak-online.be renewed.p12 -out
cacert kan...@ak-online.be renewed.p12.pem' returned 256 at
/usr/bin/smime_keys line 157.
 snip 

As there were no quotation marks around the filename I tried it with a
symlink to the same file, but without any space in the filename and it
worked like a charm.

I therefore think that there is some kind of escaping of $ARGV[1] neccesary
to stop smime_keys from passing the spaces directly to the shell that
executes openssl.

Kind regards, Andre

-- Package-specific info:
Mutt 1.5.21 (2010-09-15)
Copyright (C) 1996-2009 Michael R. Elkins and others.
Mutt comes with ABSOLUTELY NO WARRANTY; for details type `mutt -vv'.
Mutt is free software, and you are welcome to redistribute it
under certain conditions; type `mutt -vv' for details.

System: Linux 3.1.0-1-amd64 (x86_64)
ncurses: ncurses 5.9.20110404 (compiled with 5.9)
libidn: 1.23 (compiled with 1.20)
hcache backend: tokyocabinet 1.4.37
Compile options:
-DOMAIN
+DEBUG
-HOMESPOOL  +USE_SETGID  +USE_DOTLOCK  +DL_STANDALONE  +USE_FCNTL  -USE_FLOCK   
+USE_POP  +USE_IMAP  +USE_SMTP  
-USE_SSL_OPENSSL  +USE_SSL_GNUTLS  +USE_SASL  +USE_GSS  +HAVE_GETADDRINFO  
+HAVE_REGCOMP  -USE_GNU_REGEX  
+HAVE_COLOR  +HAVE_START_COLOR  +HAVE_TYPEAHEAD  +HAVE_BKGDSET  
+HAVE_CURS_SET  +HAVE_META  +HAVE_RESIZETERM  
+CRYPT_BACKEND_CLASSIC_PGP  +CRYPT_BACKEND_CLASSIC_SMIME  +CRYPT_BACKEND_GPGME  
-EXACT_ADDRESS  -SUN_ATTACHMENT  
+ENABLE_NLS  -LOCALES_HACK  +COMPRESSED  +HAVE_WC_FUNCS  +HAVE_LANGINFO_CODESET 
 +HAVE_LANGINFO_YESEXPR  
+HAVE_ICONV  -ICONV_NONTRANS  +HAVE_LIBIDN  +HAVE_GETSID  +USE_HCACHE  
-ISPELL
SENDMAIL=/usr/sbin/sendmail
MAILPATH=/var/mail
PKGDATADIR=/usr/share/mutt
SYSCONFDIR=/etc
EXECSHELL=/bin/sh
MIXMASTER=mixmaster
To contact the developers, please mail to mutt-...@mutt.org.
To report a bug, please visit http://bugs.mutt.org/.

misc/am-maintainer-mode
features/ifdef
features/xtitles
features/trash-folder
features/purge-message
features/imap_fast_trash
features/sensible_browser_position
features-old/patch-1.5.4.vk.pgp_verbose_mime
features/compressed-folders
features/compressed-folders.debian
debian-specific/Muttrc
debian-specific/Md.etc_mailname_gethostbyname.diff
debian-specific/use_usr_bin_editor.diff
debian-specific/correct_docdir_in_man_page.diff
debian-specific/dont_document_not_present_features.diff
debian-specific/document_debian_defaults
debian-specific/assumed_charset-compat
debian-specific/467432-write_bcc.patch
debian-specific/566076-build_doc_adjustments.patch
misc/define-pgp_getkeys_command.diff
misc/gpg.rc-paths
misc/smime.rc
upstream/531430-imapuser.patch
upstream/537818-emptycharset.patch
upstream/543467-thread-segfault.patch
upstream/542817-smimekeys-tmpdir.patch
upstream/548577-gpgme-1.2.patch
upstream/553321-ansi-escape-segfault.patch
upstream/568295-references.patch
upstream/547980-smime_keys-chaining.patch
upstream/528233-readonly-open.patch
upstream/228671-pipe-mime.patch
upstream/383769-score-match.patch
upstream/578087-header-strchr.patch
upstream/603288-split-fetches.patch
upstream/537061-dont-recode-saved-attachments.patch
upstream/608706-fix-spelling-errors.patch
upstream/620854-pop3-segfault.patch
upstream/611412-bts-regexp.patch
upstream/624058-gnutls-deprecated-set-priority.patch
upstream/624085-gnutls-deprecated-verify-peers.patch
upstream/584138-mx_update_context-segfault.patch
upstream/619216-gnutls-CN-validation.patch
upstream/611410-no-implicit_autoview-for-text-html.patch
upstream/path_max
mutt.org

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.1.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages mutt depends on:
ii  libc6 2.13-23
ii  libcomerr21.42-1
ii  libgnutls26   2.12.14-5
ii  libgpg-error0 1.10-1
ii  libgpgme111.2.0-1.4
ii  libgssapi-krb5-2  1.10+dfsg~alpha2-1
ii  libidn11  1.23-2
ii  libk5crypto3  1.10+dfsg~alpha2-1
ii  libkrb5-3 1.10+dfsg~alpha2-1
ii  libncursesw5  5.9-4
ii  libsasl2-22.1.25.dfsg1-2
ii  libtokyocabinet8