Bug#795890: ori: FTBFS on non-Linux: "UNSUPPORTED OS"

2015-08-18 Thread Aaron M. Ucko
Afif Elghraoui  writes:

> FreeBSD is even on that whitelist, strangely enough.

__FreeBSD__ is predefined only on systems that use FreeBSD's normal
userland; systems that swap most of it out instead predefine
__kFreeBSD__.  (For the record, you could detect the Hurd with __GNU__.)

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu



Bug#795890: ori: FTBFS on non-Linux: "UNSUPPORTED OS"

2015-08-18 Thread Aaron M. Ucko
Afif Elghraoui  writes:

> FreeBSD is even on that whitelist, strangely enough.

__FreeBSD__ is predefined only on systems that use FreeBSD's normal
userland; systems that swap most of it out instead predefine
__kFreeBSD__.  (For the record, you could detect the Hurd with __GNU__.)

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu



Bug#795890: ori: FTBFS on non-Linux: "UNSUPPORTED OS"

2015-08-17 Thread Afif Elghraoui


On الإثنين 17 آب 2015 10:51, Aaron M. Ucko wrote:
> Source: ori
> Version: 0.8.1+ds1-1
> Severity: important
> Justification: fails to build from source
> 
> Builds of ori on kFreeBSD and the Hurd have been failing:
> 
>   public/oriutil/rwlock.h:33:2: error: #error "UNSUPPORTED OS"
> 
> The problem appears to be that ori has a whitelist of supported
> Unix-like architectures:
>

FreeBSD is even on that whitelist, strangely enough.


> https://anonscm.debian.org/cgit/users/afif-guest/ori.git/tree/public/oriutil/rwlock.h#n27
> 
> I'd suggest substituting __unix__, as every vaguely-modern Unixlike
> system should support pthreads.  (Certainly, all Debian architectures
> do.)
> 
> Could you please take a look?
>

Will do.


Thanks for your report

Afif


-- 
Afif Elghraoui | عفيف الغراوي
http://afif.ghraoui.name



Bug#795890: ori: FTBFS on non-Linux: "UNSUPPORTED OS"

2015-08-17 Thread Afif Elghraoui


On الإثنين 17 آب 2015 10:51, Aaron M. Ucko wrote:
> Source: ori
> Version: 0.8.1+ds1-1
> Severity: important
> Justification: fails to build from source
> 
> Builds of ori on kFreeBSD and the Hurd have been failing:
> 
>   public/oriutil/rwlock.h:33:2: error: #error "UNSUPPORTED OS"
> 
> The problem appears to be that ori has a whitelist of supported
> Unix-like architectures:
>

FreeBSD is even on that whitelist, strangely enough.


> https://anonscm.debian.org/cgit/users/afif-guest/ori.git/tree/public/oriutil/rwlock.h#n27
> 
> I'd suggest substituting __unix__, as every vaguely-modern Unixlike
> system should support pthreads.  (Certainly, all Debian architectures
> do.)
> 
> Could you please take a look?
>

Will do.


Thanks for your report

Afif


-- 
Afif Elghraoui | عفيف الغراوي
http://afif.ghraoui.name



Bug#795890: ori: FTBFS on non-Linux: "UNSUPPORTED OS"

2015-08-17 Thread Aaron M. Ucko
Source: ori
Version: 0.8.1+ds1-1
Severity: important
Justification: fails to build from source

Builds of ori on kFreeBSD and the Hurd have been failing:

  public/oriutil/rwlock.h:33:2: error: #error "UNSUPPORTED OS"

The problem appears to be that ori has a whitelist of supported
Unix-like architectures:

https://anonscm.debian.org/cgit/users/afif-guest/ori.git/tree/public/oriutil/rwlock.h#n27

I'd suggest substituting __unix__, as every vaguely-modern Unixlike
system should support pthreads.  (Certainly, all Debian architectures
do.)

Could you please take a look?

Thanks!