Bug#818874: "Bad EXE format" error message in case of arch mismatch not very informative

2016-04-15 Thread Jens Reyer
control: tags -1 + patch

I just pushed to master (src:wine-development, but if we keep it, I will
push it to stretch (src:wine), too):

3c733ad57b848262b76486efc6606093db87de21
 Fix wording of the wine32 hint.
9e6573170821325e5212c89612f023205f7a0e0c
 If wine32 is missing warn about it unless err output is disabled.

Now, whenever you use wine but wine32 is missing, you'll get this
warning (unless you've disabled err debug output):

  it looks like wine32-development is missing, you should install it.
  multiarch needs to be enabled first.  as root, please
  execute "dpkg --add-architecture i386 && apt-get update &&
  apt-get install wine32-development"

or

  it looks like wine32-development is missing, you should install it.
  as root, please execute "apt-get install wine32-development"

Previously you would only get this warning if multiarch was not enabled:

  it looks like multiarch needs to be enabled.  as root, please
  execute "dpkg --add-architecture i386 && apt-get update &&
  apt-get install wine32-development"


Now, if you get these messages first, and then "Bad EXE format", it
shouldn't be that cryptic any more.


About the implementation (see git): I slightly prefer my chosen
approach, but instead we may merge the separate wine32_hint function and
the if-construct in something like:

case x$WINEDEBUGx in
x-all*|x*,-all*|x*err-all*)
;;
*)
echo "..." >&2
...
;;
esac

And maybe we can improve the wording.

Greets
jre



Bug#818874: "Bad EXE format" error message in case of arch mismatch not very informative

2016-03-21 Thread Andras Korn
Package: wine
Version: 1.8-2
Severity: normal
Tags: upstream

Hi,

attempting to run a 32bit .exe with only 'wine' (but not 'wine32') installed
on a 64-bit system will cause wine to abort, printing "Bad EXE format".
While this message may be technically correct, it doesn't help identify the
root cause: that in order to run a 32bit executable, I need a 32bit wine
installation alongside the 64bit one.

I would suggest to print something like "64bit wine can't run 32bit
executables" or similar.

Arguably it would also make sense to Recommends: wine32, wine64 (in addition
to Depending on either), because in the real world, a 64bit-only wine
installation isn't terribly useful in most cases.

Best regards,

Andras

-- System Information:
Debian Release: stretch/sid
  APT prefers stable
  APT policy: (500, 'stable'), (350, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.13-vs2.3.8.3-hellgate (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=hu_HU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: runit

Versions of packages wine depends on:
ii  wine32  1.8-2
ii  wine64  1.8-2

wine recommends no packages.

Versions of packages wine suggests:
pn  dosbox   
pn  wine-binfmt  

Versions of packages wine is related to:
ii  fonts-wine1.8-2
ii  libwine   1.8-2
pn  libwine-dbg   
pn  libwine-dev   
ii  wine  1.8-2
ii  wine321.8-2
pn  wine32-preloader  
pn  wine32-tools  
ii  wine641.8-2
pn  wine64-preloader  
pn  wine64-tools  

-- no debconf information