Bug#822668: Processed: cloning 822386, reassign -1 to dh-golang ..., severity of -1 is important
control: severity -1 wishlist
control: retitle -1 Make dh_golang work without --buildsystem golang
Hi,
Michael Hudson-Doyle writes:
> On 27 April 2016 at 19:22, Michael Stapelberg wrote:
>> Can you please explain why dh-golang can’t be made to figure out build
>> dependencies in this particular case?
>
> Because nothing in the packaging tells dh-golang anything about the Go
> bits -- it doesn't set DH_GOPKG or Xs-Go-Import-Path or use the golang
> dh buildsystem. I guess we could put back the
> built-using-from-Build-Depends code and use both that *and* the go
> list-using code I added...
So, if I understand correctly, the use-case here was to use only the
dh_golang binary (dh --with golang, responsible for adding the
misc:Built-Using substvar) without the rest of the debhelper golang
build system (dh --buildsystem golang).
The dh_golang binary currently overwrites GOPATH (by calling
load_buildsystem("golang")->_set_gopath()), then runs 'go list' to find
all packages, then proceeds to construct a Built-Using substvar.
We could introduce an environment variable which overrides the packages,
so that dh_golang can be used without --buildsystem golang (retitled the
bug accordingly).
Since knot-resolver does not contain any Go modules anymore (tinyweb has
been superseded by the HTTP/2 module as per the debian/changelog), I’ll
not spend any time on this theoretical exercise.
If anyone else has the same use-case and would actually like to see this
issue resolved, please speak up.
--
Best regards,
Michael
Bug#822668: Processed: cloning 822386, reassign -1 to dh-golang ..., severity of -1 is important
I am fine to do whatever you suggest, so just to make it right, I should: 1. remove dh-golang from Build-Depends 2. remove --with=golang from dh invocation 3. set 'misc:Built-Using=golang-github-abh-geoip-dev' by hand when on amd64 And that's it? Cheers, -- Ondřej Surý Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server On Tue, Apr 26, 2016, at 11:29, Michael Hudson-Doyle wrote: > Hmm, that package just isn't going to work with the new way of > computing Built-Using in dh-golang. I don't want to change it back, > because it most ways the new way is better. Not sure what to suggest, > as there is only one golang-* build-dependency, maybe just do that by > hand? > > On 26 April 2016 at 21:12, Debian Bug Tracking System > wrote: > > Processing commands for cont...@bugs.debian.org: > > > >> clone 822386 -1 > > Bug #822386 [knot-resolver] knot-resolver: FTBFS: can't load package: > > package .: no buildable Go source files > > Bug 822386 cloned as bug 822668 > >> reassign -1 dh-golang > > Bug #822668 [knot-resolver] knot-resolver: FTBFS: can't load package: > > package .: no buildable Go source files > > Bug reassigned from package 'knot-resolver' to 'dh-golang'. > > No longer marked as found in versions > > knot-resolver/1.0.0~beta3-31-g79a8440-1. > > Ignoring request to alter fixed versions of bug #822668 to the same values > > previously set > >> retitle -1 dh-golang: makes packages FTBFS with 'no buildable Go source > >> files' > > Bug #822668 [dh-golang] knot-resolver: FTBFS: can't load package: package > > .: no buildable Go source files > > Changed Bug title to 'dh-golang: makes packages FTBFS with 'no buildable Go > > source files'' from 'knot-resolver: FTBFS: can't load package: package .: > > no buildable Go source files'. > >> severity -1 important > > Bug #822668 [dh-golang] dh-golang: makes packages FTBFS with 'no buildable > > Go source files' > > Severity set to 'important' from 'serious' > >> thanks > > Stopping processing here. > > > > Please contact me if you need assistance. > > -- > > 822386: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822386 > > 822668: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822668 > > Debian Bug Tracking System > > Contact ow...@bugs.debian.org with problems > >
Bug#822668: Processed: cloning 822386, reassign -1 to dh-golang ..., severity of -1 is important
On 26 April 2016 at 21:36, Ondřej Surý wrote:
> I am fine to do whatever you suggest, so just to make it right, I
> should:
>
> 1. remove dh-golang from Build-Depends
I guess this is not strictly necessary...
> 2. remove --with=golang from dh invocation
But once you've done this, you can and probably should do 1)
> 3. set 'misc:Built-Using=golang-github-abh-geoip-dev' by hand when on
> amd64
Yes. Unfortunately, as far as I know generating proper Built-Using
headers is more awkward than it should be. I think you want to do
something like:
dpkg-query --showformat '${source:Package} (= ${source:Version}), '
--show golang-github-abh-geoip-dev >> debian/knot-resolver.substvars
(-buildmode=c-shared is supported on more architectures in Go 1.6, but
that's an entirely different thing :-)
Cheers,
mwh
> And that's it?
>
> Cheers,
> --
> Ondřej Surý
> Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
>
> On Tue, Apr 26, 2016, at 11:29, Michael Hudson-Doyle wrote:
>> Hmm, that package just isn't going to work with the new way of
>> computing Built-Using in dh-golang. I don't want to change it back,
>> because it most ways the new way is better. Not sure what to suggest,
>> as there is only one golang-* build-dependency, maybe just do that by
>> hand?
>>
>> On 26 April 2016 at 21:12, Debian Bug Tracking System
>> wrote:
>> > Processing commands for cont...@bugs.debian.org:
>> >
>> >> clone 822386 -1
>> > Bug #822386 [knot-resolver] knot-resolver: FTBFS: can't load package:
>> > package .: no buildable Go source files
>> > Bug 822386 cloned as bug 822668
>> >> reassign -1 dh-golang
>> > Bug #822668 [knot-resolver] knot-resolver: FTBFS: can't load package:
>> > package .: no buildable Go source files
>> > Bug reassigned from package 'knot-resolver' to 'dh-golang'.
>> > No longer marked as found in versions
>> > knot-resolver/1.0.0~beta3-31-g79a8440-1.
>> > Ignoring request to alter fixed versions of bug #822668 to the same values
>> > previously set
>> >> retitle -1 dh-golang: makes packages FTBFS with 'no buildable Go source
>> >> files'
>> > Bug #822668 [dh-golang] knot-resolver: FTBFS: can't load package: package
>> > .: no buildable Go source files
>> > Changed Bug title to 'dh-golang: makes packages FTBFS with 'no buildable
>> > Go source files'' from 'knot-resolver: FTBFS: can't load package: package
>> > .: no buildable Go source files'.
>> >> severity -1 important
>> > Bug #822668 [dh-golang] dh-golang: makes packages FTBFS with 'no buildable
>> > Go source files'
>> > Severity set to 'important' from 'serious'
>> >> thanks
>> > Stopping processing here.
>> >
>> > Please contact me if you need assistance.
>> > --
>> > 822386: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822386
>> > 822668: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822668
>> > Debian Bug Tracking System
>> > Contact ow...@bugs.debian.org with problems
>> >
Bug#822668: Processed: cloning 822386, reassign -1 to dh-golang ..., severity of -1 is important
Can you please explain why dh-golang can’t be made to figure out build
dependencies in this particular case?
On Tue, Apr 26, 2016 at 11:56 AM, Michael Hudson-Doyle <
michael.hud...@canonical.com> wrote:
> On 26 April 2016 at 21:36, Ondřej Surý wrote:
> > I am fine to do whatever you suggest, so just to make it right, I
> > should:
> >
> > 1. remove dh-golang from Build-Depends
>
> I guess this is not strictly necessary...
>
> > 2. remove --with=golang from dh invocation
>
> But once you've done this, you can and probably should do 1)
>
> > 3. set 'misc:Built-Using=golang-github-abh-geoip-dev' by hand when on
> > amd64
>
> Yes. Unfortunately, as far as I know generating proper Built-Using
> headers is more awkward than it should be. I think you want to do
> something like:
>
> dpkg-query --showformat '${source:Package} (= ${source:Version}), '
> --show golang-github-abh-geoip-dev >> debian/knot-resolver.substvars
>
> (-buildmode=c-shared is supported on more architectures in Go 1.6, but
> that's an entirely different thing :-)
>
> Cheers,
> mwh
>
> > And that's it?
> >
> > Cheers,
> > --
> > Ondřej Surý
> > Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
> >
> > On Tue, Apr 26, 2016, at 11:29, Michael Hudson-Doyle wrote:
> >> Hmm, that package just isn't going to work with the new way of
> >> computing Built-Using in dh-golang. I don't want to change it back,
> >> because it most ways the new way is better. Not sure what to suggest,
> >> as there is only one golang-* build-dependency, maybe just do that by
> >> hand?
> >>
> >> On 26 April 2016 at 21:12, Debian Bug Tracking System
> >> wrote:
> >> > Processing commands for cont...@bugs.debian.org:
> >> >
> >> >> clone 822386 -1
> >> > Bug #822386 [knot-resolver] knot-resolver: FTBFS: can't load package:
> package .: no buildable Go source files
> >> > Bug 822386 cloned as bug 822668
> >> >> reassign -1 dh-golang
> >> > Bug #822668 [knot-resolver] knot-resolver: FTBFS: can't load package:
> package .: no buildable Go source files
> >> > Bug reassigned from package 'knot-resolver' to 'dh-golang'.
> >> > No longer marked as found in versions
> knot-resolver/1.0.0~beta3-31-g79a8440-1.
> >> > Ignoring request to alter fixed versions of bug #822668 to the same
> values previously set
> >> >> retitle -1 dh-golang: makes packages FTBFS with 'no buildable Go
> source files'
> >> > Bug #822668 [dh-golang] knot-resolver: FTBFS: can't load package:
> package .: no buildable Go source files
> >> > Changed Bug title to 'dh-golang: makes packages FTBFS with 'no
> buildable Go source files'' from 'knot-resolver: FTBFS: can't load package:
> package .: no buildable Go source files'.
> >> >> severity -1 important
> >> > Bug #822668 [dh-golang] dh-golang: makes packages FTBFS with 'no
> buildable Go source files'
> >> > Severity set to 'important' from 'serious'
> >> >> thanks
> >> > Stopping processing here.
> >> >
> >> > Please contact me if you need assistance.
> >> > --
> >> > 822386: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822386
> >> > 822668: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822668
> >> > Debian Bug Tracking System
> >> > Contact ow...@bugs.debian.org with problems
> >> >
>
--
Best regards,
Michael
Bug#822668: Processed: cloning 822386, reassign -1 to dh-golang ..., severity of -1 is important
On 27 April 2016 at 19:22, Michael Stapelberg wrote:
> Can you please explain why dh-golang can’t be made to figure out build
> dependencies in this particular case?
Because nothing in the packaging tells dh-golang anything about the Go
bits -- it doesn't set DH_GOPKG or Xs-Go-Import-Path or use the golang
dh buildsystem. I guess we could put back the
built-using-from-Build-Depends code and use both that *and* the go
list-using code I added...
Cheers,
mwh
> On Tue, Apr 26, 2016 at 11:56 AM, Michael Hudson-Doyle
> wrote:
>>
>> On 26 April 2016 at 21:36, Ondřej Surý wrote:
>> > I am fine to do whatever you suggest, so just to make it right, I
>> > should:
>> >
>> > 1. remove dh-golang from Build-Depends
>>
>> I guess this is not strictly necessary...
>>
>> > 2. remove --with=golang from dh invocation
>>
>> But once you've done this, you can and probably should do 1)
>>
>> > 3. set 'misc:Built-Using=golang-github-abh-geoip-dev' by hand when on
>> > amd64
>>
>> Yes. Unfortunately, as far as I know generating proper Built-Using
>> headers is more awkward than it should be. I think you want to do
>> something like:
>>
>> dpkg-query --showformat '${source:Package} (= ${source:Version}), '
>> --show golang-github-abh-geoip-dev >> debian/knot-resolver.substvars
>>
>> (-buildmode=c-shared is supported on more architectures in Go 1.6, but
>> that's an entirely different thing :-)
>>
>> Cheers,
>> mwh
>>
>> > And that's it?
>> >
>> > Cheers,
>> > --
>> > Ondřej Surý
>> > Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
>> >
>> > On Tue, Apr 26, 2016, at 11:29, Michael Hudson-Doyle wrote:
>> >> Hmm, that package just isn't going to work with the new way of
>> >> computing Built-Using in dh-golang. I don't want to change it back,
>> >> because it most ways the new way is better. Not sure what to suggest,
>> >> as there is only one golang-* build-dependency, maybe just do that by
>> >> hand?
>> >>
>> >> On 26 April 2016 at 21:12, Debian Bug Tracking System
>> >> wrote:
>> >> > Processing commands for cont...@bugs.debian.org:
>> >> >
>> >> >> clone 822386 -1
>> >> > Bug #822386 [knot-resolver] knot-resolver: FTBFS: can't load package:
>> >> > package .: no buildable Go source files
>> >> > Bug 822386 cloned as bug 822668
>> >> >> reassign -1 dh-golang
>> >> > Bug #822668 [knot-resolver] knot-resolver: FTBFS: can't load package:
>> >> > package .: no buildable Go source files
>> >> > Bug reassigned from package 'knot-resolver' to 'dh-golang'.
>> >> > No longer marked as found in versions
>> >> > knot-resolver/1.0.0~beta3-31-g79a8440-1.
>> >> > Ignoring request to alter fixed versions of bug #822668 to the same
>> >> > values previously set
>> >> >> retitle -1 dh-golang: makes packages FTBFS with 'no buildable Go
>> >> >> source files'
>> >> > Bug #822668 [dh-golang] knot-resolver: FTBFS: can't load package:
>> >> > package .: no buildable Go source files
>> >> > Changed Bug title to 'dh-golang: makes packages FTBFS with 'no
>> >> > buildable Go source files'' from 'knot-resolver: FTBFS: can't load
>> >> > package:
>> >> > package .: no buildable Go source files'.
>> >> >> severity -1 important
>> >> > Bug #822668 [dh-golang] dh-golang: makes packages FTBFS with 'no
>> >> > buildable Go source files'
>> >> > Severity set to 'important' from 'serious'
>> >> >> thanks
>> >> > Stopping processing here.
>> >> >
>> >> > Please contact me if you need assistance.
>> >> > --
>> >> > 822386: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822386
>> >> > 822668: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822668
>> >> > Debian Bug Tracking System
>> >> > Contact ow...@bugs.debian.org with problems
>> >> >
>
>
>
>
> --
> Best regards,
> Michael
