Bug#916034: sl-modem-dkms: module FTBFS for 4.18.0-3-amd64, 4.9.0-8-amd64

2018-12-30 Thread Ben Hutchings 
On Sun, 09 Dec 2018 15:06:49 +0100 Andreas Beckmann  wrote:
> Package: sl-modem-dkms
> Version: 2.9.11~20110321-13
> Severity: serious
> User: debian...@lists.debian.org
> Usertags: piuparts
> Control: found -1 2.9.11~20110321-12
> 
> Hi,
> 
> sl-modem-dkms fails to build a module for 4.18.0-3-amd64 and 4.9.0-8-amd64

In fact it fails to build for any kernel version beginning with a 4,
because it doesn't recognise this as a "new" (2.6+) version.

[...]
> DKMS make.log for sl-modem-2.9.11~20110321 for kernel 4.18.0-3-amd64 (x86_64)
> Sun Dec  9 13:53:21 UTC 2018
> make: Entering directory 
> '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
> doing %.o: %.c
> cc -Wall -pipe -O3 -fomit-frame-pointer -D__KERNEL__ -DMODULE -DEXPORT_SYMTAB 
> `test -f /lib/modules/4.18.0-3-amd64/build/include/linux/modversions.h && 
> echo -DMODVERSIONS --include 
> /lib/modules/4.18.0-3-amd64/build/include/linux/modversions.h 
> -I/lib/modules/4.18.0-3-amd64/build/include`  -I. -I./../modem   -o 
> old_st7554.o -c old_st7554.c
> old_st7554.c:49:10: fatal error: linux/init.h: No such file or directory
>  #include 
>   ^~
> compilation terminated.
[...]

Here it's invoking the compiler directly rather than using Kbuild.

This should be fixable with something like:

--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -86,7 +86,7 @@ remove-devices:
$(RM) ${DESTDIR}/dev/slusb$(minor) ; ) echo -n
 
 else
-ifeq ($(shell grep 'UTS.*"\(2\.6\|3\)' 
$(KERNEL_DIR)/include/generated/utsrelease.h 
$(KERNEL_DIR)/include/linux/utsrelease.h $(KERNEL_DIR)/include/linux/version.h 
2>/dev/null),)
+ifeq ($(shell grep 'UTS.*"\(2\.6\|[3-9]\)' 
$(KERNEL_DIR)/include/generated/utsrelease.h 
$(KERNEL_DIR)/include/linux/utsrelease.h $(KERNEL_DIR)/include/linux/version.h 
2>/dev/null),)
 
 slusb-objs:= old_st7554.o
 obj:=.
--- END ---

Ben.

-- 
Ben Hutchings
Power corrupts.  Absolute power is kind of neat. - John Lehman




signature.asc
Description: This is a digitally signed message part

Bug#916034: sl-modem-dkms: module FTBFS for 4.18.0-3-amd64, 4.9.0-8-amd64

2018-12-29 Thread أحمد المحمودي 
On Wed, Dec 12, 2018 at 01:56:11PM +0100, Andreas Beckmann wrote:
> You you get the compile flags from Kbuild, or do you reinvent them on
> your own?
---end quoted text---

This is the DKMS build line:
MAKE[0]="cd ${dkms_tree}/sl-modem/#MODULE_VERSION#/build; make -C drivers USB=1 
KERNEL_DIR=$kernel_source_dir KERNEL_VER=$kernelver; make -C ungrab-winmodem 
KERNEL_DIR=$kernel_source_dir KERNEL_VER=$kernelver; cd .."

-- 
‎أحمد المحمودي (Ahmed El-Mahmoudy)
 Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
 6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7


signature.asc
Description: PGP signature

Bug#916034: sl-modem-dkms: module FTBFS for 4.18.0-3-amd64, 4.9.0-8-amd64

2018-12-15 Thread أحمد المحمودي 
On Wed, Dec 12, 2018 at 01:56:11PM +0100, Andreas Beckmann wrote:
> linux-headers-4.18.0-3-amd64 is installed, but maybe it has changed its
> layout?

This shoul pull linux-headers-4.18.0-3-common which contains the 
header files that are reported missing.

> You you get the compile flags from Kbuild, or do you reinvent them on
> your own?

As far as I recall, they are from kbuild

-- 
‎أحمد المحمودي (Ahmed El-Mahmoudy)
 Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
 6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7


signature.asc
Description: PGP signature

Bug#916034: sl-modem-dkms: module FTBFS for 4.18.0-3-amd64, 4.9.0-8-amd64

2018-12-12 Thread Andreas Beckmann 
On 2018-12-12 12:46, أحمد المحمودي wrote:
> On Sun, Dec 09, 2018 at 03:06:49PM +0100, Andreas Beckmann wrote:
>> old_st7554.c:49:10: fatal error: linux/init.h: No such file or directory
>> old_st7554.c:48:26: fatal error: linux/module.h: No such file or directory
> ---end quoted text---
> 
> Are you sure that you havethe appropriate linux headers package 
> installed ?

linux-headers-4.18.0-3-amd64 is installed, but maybe it has changed its
layout?

There is
/usr/src/linux-headers-4.18.0-3-amd64/include/generated/uapi/linux/version.h

You you get the compile flags from Kbuild, or do you reinvent them on
your own?


Andreas

Bug#916034: sl-modem-dkms: module FTBFS for 4.18.0-3-amd64, 4.9.0-8-amd64

2018-12-12 Thread أحمد المحمودي 
On Sun, Dec 09, 2018 at 03:06:49PM +0100, Andreas Beckmann wrote:
> old_st7554.c:49:10: fatal error: linux/init.h: No such file or directory
> old_st7554.c:48:26: fatal error: linux/module.h: No such file or directory
---end quoted text---

Are you sure that you havethe appropriate linux headers package 
installed ?

-- 
‎أحمد المحمودي (Ahmed El-Mahmoudy)
 Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
 6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7


signature.asc
Description: PGP signature

Bug#916034: sl-modem-dkms: module FTBFS for 4.18.0-3-amd64, 4.9.0-8-amd64

2018-12-09 Thread Andreas Beckmann 
Package: sl-modem-dkms
Version: 2.9.11~20110321-13
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts
Control: found -1 2.9.11~20110321-12

Hi,

sl-modem-dkms fails to build a module for 4.18.0-3-amd64 and 4.9.0-8-amd64

Selecting previously unselected package sl-modem-dkms.
(Reading database ... 33401 files and directories currently installed.)
Preparing to unpack .../sl-modem-dkms_2.9.11~20110321-13_amd64.deb ...
Unpacking sl-modem-dkms (2.9.11~20110321-13) ...
Setting up sl-modem-dkms (2.9.11~20110321-13) ...
Loading new sl-modem-2.9.11~20110321 DKMS files...
grep: /lib/modules/4.9.0-6-amd64/build/.config: No such file or directory
It is likely that 4.9.0-6-amd64 belongs to a chroot's host
Building for 4.18.0-3-amd64
Building initial module for 4.18.0-3-amd64
Error!  Build of slusb.ko failed for: 4.18.0-3-amd64 (x86_64)
Consult the make.log in the build directory
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ for more information.
dpkg: error processing package sl-modem-dkms (--configure):
 installed sl-modem-dkms package post-installation script subprocess returned 
error exit status 7
Errors were encountered while processing:
 sl-modem-dkms

# cat /var/lib/dkms/sl-modem/2.9.11~20110321/build/make.log 
DKMS make.log for sl-modem-2.9.11~20110321 for kernel 4.18.0-3-amd64 (x86_64)
Sun Dec  9 13:53:21 UTC 2018
make: Entering directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
doing %.o: %.c
cc -Wall -pipe -O3 -fomit-frame-pointer -D__KERNEL__ -DMODULE -DEXPORT_SYMTAB 
`test -f /lib/modules/4.18.0-3-amd64/build/include/linux/modversions.h && echo 
-DMODVERSIONS --include 
/lib/modules/4.18.0-3-amd64/build/include/linux/modversions.h 
-I/lib/modules/4.18.0-3-amd64/build/include`  -I. -I./../modem   -o 
old_st7554.o -c old_st7554.c
old_st7554.c:49:10: fatal error: linux/init.h: No such file or directory
 #include 
  ^~
compilation terminated.
make: *** [Makefile:129: old_st7554.o] Error 1
make: Leaving directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
make: Entering directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'
make modules -C /lib/modules/4.18.0-3-amd64/build 
SUBDIRS=/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem
make[1]: Entering directory '/usr/src/linux-headers-4.18.0-3-amd64'
  CC [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.o
  Building modules, stage 2.
  MODPOST 1 modules
  CC  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.mod.o
  LD [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko
make[1]: Leaving directory '/usr/src/linux-headers-4.18.0-3-amd64'
make: Leaving directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'

# cat /var/lib/dkms/sl-modem/2.9.11~20110321/build/make.log 
DKMS make.log for sl-modem-2.9.11~20110321 for kernel 4.9.0-8-amd64 (x86_64)
Sun Dec  9 14:02:25 UTC 2018
make: Entering directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
doing %.o: %.c
cc -Wall -pipe -O3 -fomit-frame-pointer -D__KERNEL__ -DMODULE -DEXPORT_SYMTAB 
`test -f /lib/modules/4.9.0-8-amd64/build/include/linux/modversions.h && echo 
-DMODVERSIONS --include 
/lib/modules/4.9.0-8-amd64/build/include/linux/modversions.h 
-I/lib/modules/4.9.0-8-amd64/build/include`  -I. -I./../modem   -o old_st7554.o 
-c old_st7554.c
old_st7554.c:48:26: fatal error: linux/module.h: No such file or directory
 #include 
  ^
compilation terminated.
Makefile:128: recipe for target 'old_st7554.o' failed
make: *** [old_st7554.o] Error 1
make: Leaving directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
make: Entering directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'
make modules -C /lib/modules/4.9.0-8-amd64/build 
SUBDIRS=/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem
make[1]: Entering directory '/usr/src/linux-headers-4.9.0-8-amd64'
  CC [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.o
  Building modules, stage 2.
  MODPOST 1 modules
  CC  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.mod.o
  LD [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko
make[1]: Leaving directory '/usr/src/linux-headers-4.9.0-8-amd64'
make: Leaving directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'


Andreas