Bug#948706: Polite ping
On Mon, Oct 05, 2020 at 07:53:05AM +0100, Julian Gilbey wrote: > On Mon, Oct 05, 2020 at 12:57:59AM +0100, Julian Gilbey wrote: > > 4) The output of "greylist list" is now somewhat mangled: the "Data" > > field shows something like: > > [ ' 1 . 2 . 3 . 4 / 2 4 ' , ' i n f o @ e x a m p l e . c o m ' , ' j d > > g @ d e b i a n . o r g ' ] > > rather than > > 1.2.3.4/24 i...@example.com j...@debian.org > > I guess this should be easy to fix? > > Oh, it turns out that this is not so straightforward: the command > greylist add 1.2.3.4/24 i...@example.com j...@debian.org > yields the following line in /var/lib/greylistd/triplets, which will > probably break things: > 4921632547390726349 = 1.2.3.4/24 i...@example.com j...@debian.org > > So it seems the triplets need turning into simple strings before they > are stored in the triplets file / triplets hash, rather than being > stored as Python literals with lots of excess spaces. Hi Benedikt and Thorsten, I've found the cause of this and made a pull request on your GitHub repository. If you're happy with it or a week or so passes and I don't hear from you or the maintainer (Thorsten), I'll upload an NMU to the delayed queue. Thorsten: there are many more changes here than would usually be permitted in an NMU. But the package is currently completely broken and won't get into testing. This set of patches fixes the critical issues and several other lintian warnings (as well as Benedikt's other cleaning-up). The big remaining lintian warning is that there is no systemd service file. This will take some effort to do, as systemd will happily look after the socket creation, but then the Python code will need adapting to accept the systemd socket rather than creating one itself. I've never done this and don't really have time right now to do so. Best wishes, Julian
Bug#948706: Polite ping
On Mon, Oct 05, 2020 at 12:57:59AM +0100, Julian Gilbey wrote: > 4) The output of "greylist list" is now somewhat mangled: the "Data" > field shows something like: > [ ' 1 . 2 . 3 . 4 / 2 4 ' , ' i n f o @ e x a m p l e . c o m ' , ' j d g > @ d e b i a n . o r g ' ] > rather than > 1.2.3.4/24 i...@example.com j...@debian.org > I guess this should be easy to fix? Oh, it turns out that this is not so straightforward: the command greylist add 1.2.3.4/24 i...@example.com j...@debian.org yields the following line in /var/lib/greylistd/triplets, which will probably break things: 4921632547390726349 = 1.2.3.4/24 i...@example.com j...@debian.org So it seems the triplets need turning into simple strings before they are stored in the triplets file / triplets hash, rather than being stored as Python literals with lots of excess spaces. Best wishes, Julian
Bug#948706: Polite ping
On Wed, Jun 03, 2020 at 02:01:33PM +0200, Benedikt Spranger wrote: > Hi, > > are there any updates or is more help needed? > > Regards > Benedikt Spranger Hi Benedikt, Thanks so much for doing all of this - I've only just looked to see if there's an update to my report. I'd be happy to upload your version as an NMU. There are a small number of issues remaining before I do so: 1) Lintian complains that there's a debian/substvars in the source file, which needs removing. 2) Does your patch fix the bug reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872734 ? 3) A Python 2.x -> 3.x change: int / int now gives a float rather than int; the only place I've noticed this is in the output of "greylist stats", and this can be fixed by replacing / by // several times in the duration() function (around line 138 onwards in greylistd). 4) The output of "greylist list" is now somewhat mangled: the "Data" field shows something like: [ ' 1 . 2 . 3 . 4 / 2 4 ' , ' i n f o @ e x a m p l e . c o m ' , ' j d g @ d e b i a n . o r g ' ] rather than 1.2.3.4/24 i...@example.com j...@debian.org I guess this should be easy to fix? There are a few other lintian warnings generated, though I'm not sure about fixing them: W: greylistd: missing-systemd-service-for-init.d-script greylistd W: greylistd source: national-encoding debian/po/de.po W: greylistd source: national-encoding debian/po/fr.po W: greylistd source: national-encoding debian/po/it.po W: greylistd source: national-encoding debian/po/ja.po W: greylistd source: national-encoding debian/po/nb.po W: greylistd: recursive-privilege-change postinst:131 W: greylistd: too-long-extended-description-in-templates greylistd/autoconfig_notdone_exim4 Writing a systemd service file should be straightforward, as should converting the national encodings into UTF-8 (if it is clear what the national encodings are). The recursive-privilege-change warning seems harmless, and I'm not going to suggest changing the template description. Best wishes, Julian
Bug#948706: Polite ping
Is there a recommended alternative way to implement greylisting with exim? On Wed, 3 Jun 2020 at 14:18, Eugene Berdnikov wrote: > > Hi. > > On Wed, Jun 03, 2020 at 02:01:33PM +0200, Benedikt Spranger wrote: > > Hi, > > > > are there any updates or is more help needed? > > Unfortunately, this package seems to be not maintained. > -- > Eugene Berdnikov > > -- > To unsubscribe, send mail to 948706-unsubscr...@bugs.debian.org.
Bug#948706: Polite ping
Hi. On Wed, Jun 03, 2020 at 02:01:33PM +0200, Benedikt Spranger wrote: > Hi, > > are there any updates or is more help needed? Unfortunately, this package seems to be not maintained. -- Eugene Berdnikov
Bug#948706: Polite ping
Hi, are there any updates or is more help needed? Regards Benedikt Spranger
