Bug#977027: [Pkg-javascript-devel] Bug#977027: rhino breaks dojo autopkgtest: Cannot set property "dojo" of null to "[object Object]"

2023-04-06 Thread Paul Gevers

Hi,

On 06-04-2023 14:50, Bastien ROUCARIES wrote:

On 06-04-2023 12:54, Paul Gevers wrote:

I'm going to prepare NMU's for rhino and dojo and upload to DELAYED/5


Please find the debdiffs attached.


Go ahead


Thanks, I have rescheduled dojo to 0 days and it got accepted.

Paul


OpenPGP_signature
Description: OpenPGP digital signature


Bug#977027: [Pkg-javascript-devel] Bug#977027: rhino breaks dojo autopkgtest: Cannot set property "dojo" of null to "[object Object]"

2023-04-06 Thread Bastien ROUCARIES
Le jeu. 6 avr. 2023 à 11:24, Paul Gevers  a écrit :
>
> Control: tags -1 pending patch
>
> On 06-04-2023 12:54, Paul Gevers wrote:
> > I'm going to prepare NMU's for rhino and dojo and upload to DELAYED/5
>
> Please find the debdiffs attached.

Go ahead
>
> Paul
> --
> Pkg-javascript-devel mailing list
> pkg-javascript-de...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel



Bug#977027: [Pkg-javascript-devel] Bug#977027: rhino breaks dojo autopkgtest: Cannot set property "dojo" of null to "[object Object]"

2023-03-27 Thread Bastien ROUCARIES
Le dim. 26 mars 2023 à 21:39, Markus Koschany  a écrit :

> Hi Graham,
>
> Am Sonntag, dem 26.03.2023 um 19:28 +0200 schrieb Graham Inggs:
> > Hi Markus
> >
> > On Sun, 26 Mar 2023 at 16:34, Markus Koschany  wrote:
> > > 1. There is no transition needed because only shrinksafe is affected
> by the
> > > new
> > > rhino version.
>
>
> > How did you determine this?
>
> Rhino 1.7.14 was mostly API compatible meaning I only had to fix an issue
> in
> closure-compiler. All other packages can be built from source without
> modifications. I didn't find any other runtime / ABI issues so far.
>
> >
> > > 2. shrinksafe has no reverse-dependencies
> >
> > That is true, but src:dojo has ledgersmb and tt-rss as
> reverse-dependencies.
>
> I used codesearch.debian.net and found only documentation or other minor
> references of shrinksafe in affected packages.
>
> https://codesearch.debian.net/search?q=shrinksafe=1
>
> Since all Java tests in dojo pass after the rebuild and almost all of the
> code
> in dojo is Javascript anyway, I don't see how ledgersmb and tt-rss can be
> affected by the new rhino version. Wouldn't those packages depend on rhino
> in
> some way? To me it seems rhino is only required to build shrinksafe which
> can
> be used for compressing Javascript files. But maybe the dojo maintainers
> can
> chime in here.
>

Yes shrinksafe is only used for compression.

Bastien

>
>
> Regards,
>
> Markus
> --
> Pkg-javascript-devel mailing list
> pkg-javascript-de...@alioth-lists.debian.net
>
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
>