Bug#870829: Contradicting warnings/errors: useless-autoreconf-build-depends vs. missing-build-dependency-for-dh-addon
Package: lintian Version: 2.5.52 Severity: normal When packaging mdocml 1.14.3, lintian noted that the autotools-dev build-dependency was unnecessary with debhelper ≥ 10 and should be removed: W: mdocml source: useless-autoreconf-build-depends autotools-dev After doing that, lintian noted that the autotools_dev addon was missing a dependency on autotools-dev: E: mdocml source: missing-build-dependency-for-dh-addon autotools_dev => autotools-dev This error seems to directly contradict the earlier warning. Not only src:mdocml is affected: e.g. src:teg removed the build dependency in https://anonscm.debian.org/viewvc/pkg-games/packages/trunk/teg/debian/control?r1=15952&r2=15990 and now shows up in https://lintian.debian.org/tags/missing-build-dependency-for-dh-addon.html. What course of action is correct? Which warning should be removed from lintian? -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386, armel, mipsel, arm64 Kernel: Linux 4.11.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages lintian depends on: ii binutils 2.28-6 ii bzip2 1.0.6-8.1 ii diffstat 1.61-1+b1 ii dpkg 1.18.24 ii file 1:5.30-1 ii gettext 0.19.8.1-2+b1 ii intltool-debian 0.35.0+20060710.4 ii libapt-pkg-perl 0.1.32+b2 ii libarchive-zip-perl 1.59-1 ii libclass-accessor-perl0.34-1 ii libclone-perl 0.38-2+b2 ii libdpkg-perl 1.18.24 ii libemail-valid-perl 1.202-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl 0.94-1 ii liblist-moreutils-perl0.416-1+b3 ii libparse-debianchangelog-perl 1.2.0-12 ii libperl5.22 [libdigest-sha-perl] 5.22.2-5 ii libperl5.26 [libdigest-sha-perl] 5.26.0-4 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl 1.71-1 ii libxml-simple-perl2.22-1 ii libyaml-libyaml-perl 0.63-2+b2 ii man-db2.7.6.1-2 ii patchutils0.3.4-2 ii perl 5.26.0-4 ii t1utils 1.39-2 ii xz-utils 5.2.2-1.3 Versions of packages lintian recommends: pn libperlio-gzip-perl Versions of packages lintian suggests: pn binutils-multiarch ii dpkg-dev 1.18.24 ii libhtml-parser-perl3.72-3+b2 ii libtext-template-perl 1.46-1 -- no debconf information
Bug#870829: Contradicting warnings/errors: useless-autoreconf-build-depends vs. missing-build-dependency-for-dh-addon
On Sat, Aug 05, 2017 at 05:47:39PM +0200, Michael Stapelberg wrote: > build-dependency was unnecessary with debhelper ≥ 10 and should be removed: > > W: mdocml source: useless-autoreconf-build-depends autotools-dev > > After doing that, lintian noted that the autotools_dev addon was missing a > dependency on autotools-dev: > > E: mdocml source: missing-build-dependency-for-dh-addon autotools_dev => > autotools-dev > > This error seems to directly contradict the earlier warning. > > Not only src:mdocml is affected: e.g. src:teg removed the build dependency in > https://anonscm.debian.org/viewvc/pkg-games/packages/trunk/teg/debian/control?r1=15952&r2=15990 > and now shows up in > https://lintian.debian.org/tags/missing-build-dependency-for-dh-addon.html. > > What course of action is correct? Which warning should be removed from > lintian? Neither of them. The description might be a bit misleading, but it's an actual "problem" in your package: you need not use --with autotools_dev anymore, as starting with debhelper version 9.20160114 debhelper includes an dh_update_autotools_config helper that is run for all debhelper compat level. Also, dropping that `--with autotools_dev` switch will cast away all the lintian warnings. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#870829: Contradicting warnings/errors: useless-autoreconf-build-depends vs. missing-build-dependency-for-dh-addon
On Sat, Aug 5, 2017 at 6:25 PM, Mattia Rizzolo wrote: > On Sat, Aug 05, 2017 at 05:47:39PM +0200, Michael Stapelberg wrote: > > build-dependency was unnecessary with debhelper ≥ 10 and should be > removed: > > > > W: mdocml source: useless-autoreconf-build-depends autotools-dev > > > > After doing that, lintian noted that the autotools_dev addon was missing > a > > dependency on autotools-dev: > > > > E: mdocml source: missing-build-dependency-for-dh-addon autotools_dev > => autotools-dev > > > > This error seems to directly contradict the earlier warning. > > > > Not only src:mdocml is affected: e.g. src:teg removed the build > dependency in > > https://anonscm.debian.org/viewvc/pkg-games/packages/ > trunk/teg/debian/control?r1=15952&r2=15990 > > and now shows up in > > https://lintian.debian.org/tags/missing-build-dependency- > for-dh-addon.html. > > > > What course of action is correct? Which warning should be removed from > lintian? > > > Neither of them. The description might be a bit misleading, but it's an > actual "problem" in your package: you need not use > --with autotools_dev > anymore, as starting with debhelper version 9.20160114 debhelper > includes an dh_update_autotools_config helper that is run for all > debhelper compat level. > Wow, I would have never guessed that. Can we add a more specific warning to lintian for this case? I expect the maintainers of all 372 source packages found by the search https://codesearch.debian.net/search?q=path%3Adebian%2Frules+with.*autotools_dev&perpkg=1 to eventually face this problem. > > Also, dropping that `--with autotools_dev` switch will cast away all the > lintian warnings. > Done with https://anonscm.debian.org/git/collab-maint/mdocml.git/commit/?id=e655a7998c6e4b32c4cb55d48366f74e1bb1a194, thanks! > > -- > regards, > Mattia Rizzolo > > GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. > more about me: https://mapreri.org : :' : > Launchpad user: https://launchpad.net/~mapreri `. `'` > Debian QA page: https://qa.debian.org/developer.php?login=mattia `- > -- Best regards, Michael