Bug#803519: lintian: Search for the string "legal" in every file, as it is gererally misused
Him Bjarni Ingi Gislason wrote: > The word "(il)legal" is too often used in a wrong sense, both in > documentation, diagnostic messages, and in a code as a part of a name > of an identifier. [...] > "Lintian" should therefor search for this text string in every file > and report it. Files with all correct use of "(il)legal" can then > later be put on the "overrides" list, if they are unchanged from the > last run of "lintian". I think that "every file" is a little bit overzealous. I'd restrict it to packaging (i.e. the debian/ directory) and explicitly exclude the file debian/copyright as any appearance of the word "legal" or "illegal" in there is very likely a valid (sic!) usage. Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Bug#804082: lintian: false positive for source-is-missing: ckeditor-config.js (maybe caused by a BOM)
Package: lintian Version: 2.5.38 Control: affects -1 + elog Hi, while reviewing a new version of elog for sponsoring, lintian emitted "E: elog source: source-is-missing scripts/ckeditor-config.js" for the following file (non-printable characteres included in escaped form): ---snip--- /** * @license Copyright (c) 2003-2013, CKSource - Frederico Knabben. All rights reserved. * For licensing, see LICENSE.html or http://ckeditor.com/license */ CKEDITOR.editorConfig = function( config ) { // Define changes to default configuration here. For example: // config.language = 'fr'; // config.uiColor = '#AADC6E'; config.extraPlugins = 'timestamp,dndfiles,eqneditor,fileupload'; config.toolbarCanCollapse = true; // Toolbar configuration config.toolbar = [ { name: 'document', groups: [ 'mode', 'document', 'doctools' ], items: [ 'Source', '-', 'Save', 'Preview', 'Print', '-', 'Templates' ] }, { name: 'clipboard', groups: [ 'clipboard', 'undo' ], items: [ 'Cut', 'Copy', 'Paste', 'PasteText', 'PasteFromWord', '-', 'Undo', 'Redo' ] }, { name: 'editing', groups: [ 'find', 'selection', 'spellchecker' ], items: [ 'Find', 'Replace', '-', 'SelectAll', '-', 'Scayt' ] }, '/', { name: 'basicstyles', groups: [ 'basicstyles', 'cleanup' ], items: [ 'Bold', 'Italic', 'Underline', 'Strike', 'Subscript', 'Superscript', '-', 'RemoveFormat' ] }, { name: 'paragraph', groups: [ 'list', 'indent', 'blocks', 'align', 'bidi' ], items: [ 'NumberedList', 'BulletedList', '-', 'Outdent', 'Indent', '-', 'Blockquote', 'CreateDiv', '-', 'JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock', '-', 'BidiLtr', 'BidiRtl', 'Language' ] }, { name: 'links', items: [ 'Link', 'Unlink', 'Anchor' ] }, { name: 'insert', items: [ 'Image', 'Table', 'HorizontalRule', 'Smiley', 'SpecialChar', 'PageBreak', 'FileUpload', 'Timestamp', 'EqnEditor' ] }, '/', { name: 'styles', items: [ 'Styles', 'Format', 'Font', 'FontSize' ] }, { name: 'colors', items: [ 'TextColor', 'BGColor' ] }, { name: 'tools', items: [ 'Maximize', 'ShowBlocks' ] }, { name: 'others', items: [ '-' ] }, { name: 'about', items: [ 'About' ] } ]; }; ---snap--- Longest line in there is just around 305 characters, so this should not be the trigger. I haven't checked the lintian code yet, but maybe the Unicode character (probably a BOM) at the very beginning of the file may have caused this tag to be emitted. -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (990, 'unstable'), (600, 'testing'), (500, 'buildd-unstable'), (400, 'stable'), (110, 'experimental'), (1, 'buildd-experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.2.0-trunk-amd64 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) Versions of packages lintian depends on: ii binutils 2.25.1-7 ii bzip2 1.0.6-8 ii diffstat 1.60-1 ii file 1:5.25-2 ii gettext0.19.6-1 ii hardening-includes 2.7 ii intltool-debian0.35.0+20060710.4 ii libapt-pkg-perl0.1.29+b3 ii libarchive-zip-perl1.53-1 ii libclass-accessor-perl 0.34-1 ii libclone-perl 0.38-1 ii libdigest-sha-perl 5.95-2 ii libdpkg-perl 1.18.3 ii libemail-valid-perl1.198-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl0.94-1 ii liblist-moreutils-perl 0.413-1 ii libparse-debianchangelog-perl 1.2.0-8 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl1.69-1 ii man-db 2.7.4-1 ii patchutils 0.3.4-1 ii perl [libdigest-sha-perl] 5.20.2-6 ii t1utils1.38-4 ii xz-utils 5.1.1alpha+20120614-2.1 Versions of packages lintian recommends: ii dpkg1.18.3 ii libautodie-perl 2.29-1 ii libperlio-gzip-perl 0.18-3+b1 ii perl5.20.2-6 ii perl-modules [libautodie-perl] 5.20.2-6 Versions of packages lintian suggests: ii binutils-multiarch 2.25.1-7 ii dpkg-dev 1.18.3 ii libhtml-parser-perl3.71-2 ii libtext-template-perl 1.46-1 ii libyaml-perl 1.15-1 -- no debconf information
[lintian] branch master updated (07c0657 -> 2b4e1f6)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from 07c0657 Relax line length for minified javascript new 2b4e1f6 data/spelling/corrections: Add correction for "arround" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/spelling/corrections | 1 + debian/changelog | 1 + 2 files changed, 2 insertions(+) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: data/spelling/corrections: Add correction for "arround"
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit 2b4e1f690dbdc5cb9864af2e5e844bf6adac2bf4 Author: Axel Beckert Date: Tue Dec 8 00:04:27 2015 +0100 data/spelling/corrections: Add correction for "arround" Signed-off-by: Axel Beckert --- data/spelling/corrections | 1 + debian/changelog | 1 + 2 files changed, 2 insertions(+) diff --git a/data/spelling/corrections b/data/spelling/corrections index d861fe9..16349a6 100644 --- a/data/spelling/corrections +++ b/data/spelling/corrections @@ -116,6 +116,7 @@ aritmetic||arithmetic arne't||aren't aroung||around arraival||arrival +arround||around artifical||artificial artillary||artillery arugment||argument diff --git a/debian/changelog b/debian/changelog index 4c0cc52..ec7fbef 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,7 @@ lintian (2.5.39) UNRELEASED; urgency=medium * data/spelling/corrections: + [JW] Add more corrections. ++ [AB] Add correction for "arround". * doc/examples/profiles/my-vendor/main.profile: + [JW] Fix typo. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Merge two similar changelog items into one
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit 91e4b8c46f0bfe9c98784ed9bbe520f56b0e118a Author: Axel Beckert Date: Tue Dec 8 00:09:59 2015 +0100 Merge two similar changelog items into one --- debian/changelog | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/debian/changelog b/debian/changelog index ec7fbef..0b8a56b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -11,8 +11,7 @@ lintian (2.5.39) UNRELEASED; urgency=medium + [JW] Fix typo. * data/spelling/corrections: -+ [JW] Add more corrections. -+ [AB] Add correction for "arround". ++ [JW, AB] Add more corrections. * doc/examples/profiles/my-vendor/main.profile: + [JW] Fix typo. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (2b4e1f6 -> 91e4b8c)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from 2b4e1f6 data/spelling/corrections: Add correction for "arround" new 91e4b8c Merge two similar changelog items into one The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: debian/changelog | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#807695: lintian: false positive for command-with-path-in-maintainer-script
Hi, Thorsten Glaser wrote: > I got a false positive for FusionForge in sid: > > W: gforge-db-postgresql: command-with-path-in-maintainer-script postinst:8 > /usr/bin/pg_lsclusters > […] > N:See particularly the function pathfind() in devref. > > The line in question: > > if [ -x /usr/bin/pg_lsclusters ]; then > > OK, I looked into devref, and it explicitly says: > > If you need to check for the existence of a command, you should > use something like > > if [ -x /usr/sbin/install-docs ]; then ... And if you read just one paragraph further: If you don't wish to hard-code the path of a command in your maintainer script, the following POSIX-compliant shell function may help: pathfind() { OLDIFS="$IFS" IFS=: for p in $PATH; do if [ -x "$p/$*" ]; then IFS="$OLDIFS" return 0 fi done IFS="$OLDIFS" return 1 } I guess _that_ is the part, Lintian refers, too. But besides that, I'm also annoyed by that warning and tend to ignore it. I don't think, forbidding "if [ -x /usr/*bin/* ];" adds any value. Especially not if you're supposed to add like a dozen lines of sh code instead which is surely more error-prone than that single line. (In case someone disagrees: Have a look at one of the reasons why systemd is said to be s much better since it has no more init scripts... :-P) Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Bug#807695: lintian: false positive for command-with-path-in-maintainer-script
Hi, Jakub Wilk wrote: > >If you don't wish to hard-code the path of a command in your > >maintainer script, the following POSIX-compliant shell function > >may help: > > > > pathfind() { > > OLDIFS="$IFS" > > IFS=: > > for p in $PATH; do > > if [ -x "$p/$*" ]; then > > IFS="$OLDIFS" > > return 0 > > fi > > done > > IFS="$OLDIFS" > > return 1 > > } > > Eww. There's no reason to use this monster in maintainer scripts. Exactly. > Please use which(1) instead. See also bug #747320. Feel free to file a bug report against the Developer Reference. ("which" is mentioned there, too, but since it's under /usr/bin, it has the restriction that it may not be available at early boot times.) Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
[lintian] branch master updated (9b196e4 -> b7c7d5f)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from 9b196e4 spelling: Add "pallete" new b7c7d5f spelling: Add "unsued" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/spelling/corrections | 1 + 1 file changed, 1 insertion(+) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: spelling: Add "unsued"
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit b7c7d5f4ab076f491aef91ede0fa12b1084a0a81 Author: Axel Beckert Date: Fri Dec 18 23:16:19 2015 +0100 spelling: Add "unsued" --- data/spelling/corrections | 1 + 1 file changed, 1 insertion(+) diff --git a/data/spelling/corrections b/data/spelling/corrections index 116a27a..6f4e718 100644 --- a/data/spelling/corrections +++ b/data/spelling/corrections @@ -931,6 +931,7 @@ unkown||unknown unneedingly||unnecessarily unoffical||unofficial unrecogized||unrecognized +unsued||unused unuseful||useless unusuable||unusable unversionned||unversioned -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (d1e02f4 -> 8eb9611)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from d1e02f4 checks/fields: Relax build profile dep checks to allow ~ new 8eb9611 Add S-V 3.9.8 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/standards-version/release-dates| 1 + debian/changelog| 7 +++ debian/control | 4 ++-- t/runtests | 2 +- t/source/changelog-file-symlink/dsc.in | 2 +- t/source/control-field-traversal-2/dsc.in | 2 +- t/source/control-file-duplicate-field/dsc.in| 2 +- t/source/control-file-missing-separator/dsc.in | 2 +- t/source/control-file-syntax-error/dsc.in | 2 +- t/source/debconf-traversal/dsc.in | 2 +- t/source/debian-source-dir-traversal-1/dsc.in | 2 +- t/source/debian-source-dir-traversal-2/dsc.in | 2 +- t/source/debian-source-dir-unknown-source-format/dsc.in | 2 +- t/source/debian-symlink/dsc.in | 2 +- t/source/fields-src-bad-version/dsc.in | 2 +- t/source/fields-src-fields-filename/dsc.in | 2 +- t/tests/cruft-empty-diff/debian/debian/control | 2 +- t/tests/cruft-empty-diff/upstream/debian/control| 2 +- 18 files changed, 25 insertions(+), 17 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Add S-V 3.9.8
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit 8eb9611e3ecf992a1c8f1575d2f2b9713e4551af Author: Axel Beckert Date: Fri Apr 8 20:51:52 2016 +0200 Add S-V 3.9.8 Signed-off-by: Axel Beckert --- data/standards-version/release-dates| 1 + debian/changelog| 7 +++ debian/control | 4 ++-- t/runtests | 2 +- t/source/changelog-file-symlink/dsc.in | 2 +- t/source/control-field-traversal-2/dsc.in | 2 +- t/source/control-file-duplicate-field/dsc.in| 2 +- t/source/control-file-missing-separator/dsc.in | 2 +- t/source/control-file-syntax-error/dsc.in | 2 +- t/source/debconf-traversal/dsc.in | 2 +- t/source/debian-source-dir-traversal-1/dsc.in | 2 +- t/source/debian-source-dir-traversal-2/dsc.in | 2 +- t/source/debian-source-dir-unknown-source-format/dsc.in | 2 +- t/source/debian-symlink/dsc.in | 2 +- t/source/fields-src-bad-version/dsc.in | 2 +- t/source/fields-src-fields-filename/dsc.in | 2 +- t/tests/cruft-empty-diff/debian/debian/control | 2 +- t/tests/cruft-empty-diff/upstream/debian/control| 2 +- 18 files changed, 25 insertions(+), 17 deletions(-) diff --git a/data/standards-version/release-dates b/data/standards-version/release-dates index 1463fbb..cba105d 100644 --- a/data/standards-version/release-dates +++ b/data/standards-version/release-dates @@ -9,6 +9,7 @@ # # You'll need libtimedate-perl installed. +3.9.8 1459914598 3.9.7 1454364231 3.9.6 1410977000 3.9.5 1382920848 diff --git a/debian/changelog b/debian/changelog index ea8f296..b854f24 100644 --- a/debian/changelog +++ b/debian/changelog @@ -9,6 +9,13 @@ lintian (2.5.44) UNRELEASED; urgency=medium trailing tilde. (Closes: #819509) Thanks to Felix Geyer for the bug report. + * data/standards-version/release-dates: ++ [AB] Add 3.9.8. + + * debian/control: ++ [AB] Declare compliance with Debian Policy 3.9.8. (No other changes + required.) + -- Niels Thykier Sun, 03 Apr 2016 18:48:59 + lintian (2.5.43) unstable; urgency=medium diff --git a/debian/control b/debian/control index 161c1b1..1b35eb2 100644 --- a/debian/control +++ b/debian/control @@ -70,7 +70,7 @@ Build-Depends: aspell, unzip, xz-utils, zip -Standards-Version: 3.9.7 +Standards-Version: 3.9.8 Vcs-Git: https://anonscm.debian.org/git/lintian/lintian.git Vcs-Browser: https://anonscm.debian.org/git/lintian/lintian.git Testsuite: autopkgtest @@ -135,4 +135,4 @@ Description: Debian package checker should check packages with this tool before uploading them to the archive. . - This version of Lintian is calibrated for policy version 3.9.7. + This version of Lintian is calibrated for policy version 3.9.8. diff --git a/t/runtests b/t/runtests index 6e8d767..bbe7588 100755 --- a/t/runtests +++ b/t/runtests @@ -107,7 +107,7 @@ our @DPKG_BUILDPACKAGE_CMD = ( qw(-iNEVER_MATCH_ANYTHING -INEVER_MATCH_ANYTHING), qw(--source-option=--auto-commit), ); -our $STANDARDS_VERSION = '3.9.7'; +our $STANDARDS_VERSION = '3.9.8'; our $ARCHITECTURE = safe_qx(qw(dpkg-architecture -qDEB_HOST_ARCH)); my $RUNNER_TS = (stat($0))[9]; chomp $ARCHITECTURE; diff --git a/t/source/changelog-file-symlink/dsc.in b/t/source/changelog-file-symlink/dsc.in index 1340103..678bda4 100644 --- a/t/source/changelog-file-symlink/dsc.in +++ b/t/source/changelog-file-symlink/dsc.in @@ -4,7 +4,7 @@ Binary: changelog-file-symlink Architecture: all Version: 1 Maintainer: Debian Lintian Maintainers -Standards-Version: 3.9.7 +Standards-Version: 3.9.8 Build-Depends: debhelper (>= 9) Checksums-Sha1: @SHA1@ @SIZE@ changelog-file-symlink_1.tar.gz diff --git a/t/source/control-field-traversal-2/dsc.in b/t/source/control-field-traversal-2/dsc.in index 74e9bd0..2615db7 100644 --- a/t/source/control-field-traversal-2/dsc.in +++ b/t/source/control-field-traversal-2/dsc.in @@ -4,7 +4,7 @@ Binary: ../../control-field-traversal-2 Architecture: all Version: 1 Maintainer: Debian Lintian Maintainers -Standards-Version: 3.9.7 +Standards-Version: 3.9.8 Build-Depends: debhelper (>= 7) Checksums-Sha1: @SHA1@ @SIZE@ control-field-traversal-2_1.tar.gz diff --git a/t/source/control-file-duplicate-field/dsc.in b/t/source/control-file-duplicate-field/dsc.in index 06de62c..60232c2 100644 --- a/t/source/control-file-duplicate-field/dsc.in +++ b/t/source/control-file-duplicate-field/dsc.in @@ -4,7 +4,7 @@ Binary: control-file-duplicate-field Architecture: all Version: 1 Maintainer: Debian Lintian Maintainers -Standards-Version: 3.9.7 +Standards-Version:
[lintian] 01/01: Fix test broken by S-V 3.9.8 addition
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit ff2787bd06a4b6b58c85e8eac54fb0c856577a3f Author: Axel Beckert Date: Fri Apr 8 21:24:34 2016 +0200 Fix test broken by S-V 3.9.8 addition Signed-off-by: Axel Beckert --- t/tests/changelog-file-wrong-weekday/debian/debian/changelog.in | 2 +- t/tests/changelog-file-wrong-weekday/tags | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/tests/changelog-file-wrong-weekday/debian/debian/changelog.in b/t/tests/changelog-file-wrong-weekday/debian/debian/changelog.in index e7ea3c3..62aca5a 100644 --- a/t/tests/changelog-file-wrong-weekday/debian/debian/changelog.in +++ b/t/tests/changelog-file-wrong-weekday/debian/debian/changelog.in @@ -6,5 +6,5 @@ * A bit of wishful thinking that the date below was a Friday. - -- {$author} Fri, 15 Feb 2016 17:00:00 + + -- {$author} Fri, 07 Apr 2016 17:00:00 + diff --git a/t/tests/changelog-file-wrong-weekday/tags b/t/tests/changelog-file-wrong-weekday/tags index b4401d0..b422b4a 100644 --- a/t/tests/changelog-file-wrong-weekday/tags +++ b/t/tests/changelog-file-wrong-weekday/tags @@ -1 +1 @@ -W: changelog-file-wrong-weekday: debian-changelog-has-wrong-weekday 2016-02-15 is a Monday +W: changelog-file-wrong-weekday: debian-changelog-has-wrong-weekday 2016-04-07 is a Thursday -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (8eb9611 -> ff2787bd)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from 8eb9611 Add S-V 3.9.8 new ff2787bd Fix test broken by S-V 3.9.8 addition The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: t/tests/changelog-file-wrong-weekday/debian/debian/changelog.in | 2 +- t/tests/changelog-file-wrong-weekday/tags | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (ff2787bd -> 1bc5526)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from ff2787bd Fix test broken by S-V 3.9.8 addition new 1bc5526 Hopefully really fix test broken by S-V 3.9.8 addition The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: t/tests/cruft-empty-diff/debian/debian/changelog | 2 +- t/tests/cruft-empty-diff/upstream/debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Hopefully really fix test broken by S-V 3.9.8 addition
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit 1bc5526ddad20c9a05fefa9d49da576f56806fb3 Author: Axel Beckert Date: Fri Apr 8 22:02:09 2016 +0200 Hopefully really fix test broken by S-V 3.9.8 addition Thanks Niels Thykier for hints! :-) Signed-off-by: Axel Beckert --- t/tests/cruft-empty-diff/debian/debian/changelog | 2 +- t/tests/cruft-empty-diff/upstream/debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/tests/cruft-empty-diff/debian/debian/changelog b/t/tests/cruft-empty-diff/debian/debian/changelog index d1439b4..1e78a38 100644 --- a/t/tests/cruft-empty-diff/debian/debian/changelog +++ b/t/tests/cruft-empty-diff/debian/debian/changelog @@ -5,4 +5,4 @@ cruft-empty-diff (1.0-1) unstable; urgency=low * Suppress "should close ITP bug" messages. (Closes: #123456) - -- Debian Lintian Maintainers Mon, 15 Feb 2016 07:00:00 + + -- Debian Lintian Maintainers Fri, 08 Apr 2016 07:00:00 + diff --git a/t/tests/cruft-empty-diff/upstream/debian/changelog b/t/tests/cruft-empty-diff/upstream/debian/changelog index d1439b4..1e78a38 100644 --- a/t/tests/cruft-empty-diff/upstream/debian/changelog +++ b/t/tests/cruft-empty-diff/upstream/debian/changelog @@ -5,4 +5,4 @@ cruft-empty-diff (1.0-1) unstable; urgency=low * Suppress "should close ITP bug" messages. (Closes: #123456) - -- Debian Lintian Maintainers Mon, 15 Feb 2016 07:00:00 + + -- Debian Lintian Maintainers Fri, 08 Apr 2016 07:00:00 + -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (c1dd5c2 -> a204083)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from c1dd5c2 checks/phppear: Apply perltidy new a204083 package-relation-with-perl-modules: Remove "experimental" flag The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.desc | 1 - debian/changelog| 2 ++ t/tests/fields-depends-general/tags | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: package-relation-with-perl-modules: Remove "experimental" flag
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit a2040837894733182b374a7cd65a5743fcccae4b Author: Axel Beckert Date: Thu Apr 21 11:33:19 2016 +0200 package-relation-with-perl-modules: Remove "experimental" flag Asked for by Dominic Hargreaves. --- checks/fields.desc | 1 - debian/changelog| 2 ++ t/tests/fields-depends-general/tags | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/checks/fields.desc b/checks/fields.desc index 85ca944..8495abb 100644 --- a/checks/fields.desc +++ b/checks/fields.desc @@ -1263,7 +1263,6 @@ Info: libmodule-build-tiny-perl needs to be in Build-Depends, not Tag: package-relation-with-perl-modules Severity: important Certainty: certain -Experimental: yes Info: No package should (build-) depend on 'perl-modules'. Instead, a suitable dependency on 'perl' should be used. The existence of the perl-modules package is an implementation detail of the perl diff --git a/debian/changelog b/debian/changelog index 93afd3e..4ff9f88 100644 --- a/debian/changelog +++ b/debian/changelog @@ -23,6 +23,8 @@ lintian (2.5.44) UNRELEASED; urgency=medium + [NT] Use https URL in the correction for canonical VCS URLs. (Closes: #813587) + [NT] Bump known python 3 version to include 3.4 and 3.5. ++ [AB] package-relation-with-perl-modules: Remove "experimental" flag. + Asked for by Dominic Hargreaves. * checks/files.pm: + [JW] Apply patch from Mathieu Parent to fix directories for PHP INI files. diff --git a/t/tests/fields-depends-general/tags b/t/tests/fields-depends-general/tags index b2e8573..8501408 100644 --- a/t/tests/fields-depends-general/tags +++ b/t/tests/fields-depends-general/tags @@ -1,10 +1,13 @@ +E: fields-depends-general source: package-relation-with-perl-modules build-depends: perl-modules E: fields-depends-general: conflicts-with-dependency depends conflict-dep E: fields-depends-general: depends-on-essential-package-without-using-version depends: bash E: fields-depends-general: depends-on-metapackage depends: xorg E: fields-depends-general: depends-on-obsolete-package depends: gaim (>= 0.1) E: fields-depends-general: needlessly-depends-on-awk depends E: fields-depends-general: package-depends-on-an-x-font-package depends: xfont-a +E: fields-depends-general: package-relation-with-perl-modules depends: perl-modules E: libfields-depends-general: depends-on-libdb1-compat depends +E: libfields-depends-general: package-relation-with-perl-modules depends: perl-modules-5.22 E: py-fields-depends-general: depends-on-python-minimal depends I: fields-depends-general: conflicts-with-version package-with-version (<< 3.0) I: fields-depends-general: ored-depends-on-obsolete-package depends: xbase-clients (>= 0.1) @@ -24,6 +27,3 @@ W: fields-depends-general: depends-on-packaging-dev depends W: fields-depends-general: package-relation-with-self breaks: fields-depends-general (<< 0.1) W: fields-depends-general: versioned-dependency-satisfied-by-perl depends: libtest-simple-perl (>= 0.98) W: libfields-depends-general: lib-recommends-documentation recommends: debconf-doc -X: fields-depends-general source: package-relation-with-perl-modules build-depends: perl-modules -X: fields-depends-general: package-relation-with-perl-modules depends: perl-modules -X: libfields-depends-general: package-relation-with-perl-modules depends: perl-modules-5.22 -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#823628: lintian: Please add autopkgtest-pkg-python to known test suites
Control: tag -1 +pending Hi Barry, Barry Warsaw wrote: > In Python packages, with autopkg8, you can now say this in your > d/control file: > > Testsuite: autopkgtest-pkg-python > > but lintian doesn't know about this yet: > > Now running lintian... > W: pyparsing source: unknown-testsuite autopkgtest-pkg-python > Finished running lintian. Lintian in git already knows about this (for about a week :-), hence marking as pending. See https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=8fdfa88f23bec650b9fa1a3055ec262662f08d37 Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Bug#824916: lintian: Check for weak signatures in source packages
Package: lintian Version: 2.5.44 Severity: wishlist Tags: patch User: debian-p...@lists.debian.org Usertags: zrh2016 Control: owner -1 ! Hi, during the (ongoing) Debian Perl Team Sprint, one of the discussed topics was dpkg-source now issuing warnings about weak signatures when extracting source packages. (For some time, in versions1.18.5 and 1.18.6, it even bailed out, failing to extract source packages as they are currently in Sid -- which is the reason why the default was reverted and it only prints a warning since 1.18.7.) Some more context is in https://bugs.debian.org/823428 An affected example source package is libclass-default-perl_1.51-2.dsc from the archive: last uploaded in 2008. We wondered if it would be helpful to have a Lintian tag for that: * It would give a nice statistic over the archive, which packages are affected like some recently introduced (or at least discussed) categorizing tags. * The according tag will likely never be emitted while building/developing a package as this won't be triggered by packages build with more recent dpkg-source versions. So it will _only_ show up on https://lintian.debian.org/ for source packages not uploaded for years, because they automatically be fixed when uploading a new package. Especially the latter may confuse people because they won't be able to rpeproduce the warning locally if they rebuild or work on the package. Still, it would be a nice way to get a list of these pacakges. Following is my patch so far (without the test case). I'm not sure if the severity "serious" is the proper value, so please feel free to comment on that. diff --git a/checks/fields.desc b/checks/fields.desc index 22b426c..1168a8d 100644 --- a/checks/fields.desc +++ b/checks/fields.desc @@ -1276,3 +1276,18 @@ Info: No package should (build-) depend on 'perl-modules'. Instead, a suitable dependency on 'perl' should be used. The existence of the perl-modules package is an implementation detail of the perl packaging. + +Tag: no-strong-checksums-in-dsc +Severity: serious +Certainty: certain +Info: This .dsc file contains no Checksum-Sha256 field and hence only + weak checksums. + . + This issue will only show up for source packages built with + dpkg-source before 1.14.17 (March 2008) and hence will probably never + show up when you run lintian locally but only on + https://lintian.debian.org/ for source packages in the archive. + . + Accordingly it can be fixed by simply rebuilding the source package + with a more recent dpkg-source version, i.e. by uploading a new + debian release of the package. diff --git a/checks/fields.pm b/checks/fields.pm index 1f59652..732be43 100644 --- a/checks/fields.pm +++ b/checks/fields.pm @@ -1309,6 +1309,14 @@ sub run { } } +# Checksums + +if ($type eq 'source') { +if (!$info->field('checksums-sha256')) { +tag 'no-strong-checksums-in-dsc'; +} +} + #- Field checks (without checking the value) for my $field (keys %{$info->field}) { -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), (111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), (105, 'experimental-debug') Architecture: amd64 (x86_64) Kernel: Linux 4.6.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages lintian depends on: ii binutils 2.26-9 ii bzip2 1.0.6-8 ii diffstat 1.61-1 ii file 1:5.25-2 ii gettext 0.19.7-2 ii hardening-includes2.8+nmu2 ii intltool-debian 0.35.0+20060710.4 ii libapt-pkg-perl 0.1.29+b5 ii libarchive-zip-perl 1.57-1 ii libclass-accessor-perl0.34-1 ii libclone-perl 0.38-1+b1 ii libdata-alias-perl1.20-1+b1 ii libdigest-sha-perl5.95-2+b1 ii libdpkg-perl 1.18.7 ii libemail-valid-perl 1.198-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl 0.94-1 ii liblist-moreutils-perl0.413-1+b1 ii libparse-debianchangelog-perl 1.2.0-8 ii libperl5.22 [libdigest-sha-perl] 5.22.2-1 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl 1.71-1 ii libyaml-libyaml-perl 0.41-6+b1 ii man-db2.7.5-1 ii patchutils0.3.4-1 ii perl 5.22.2-1 ii t1utils 1.39-2 ii xz-utils 5.1.1alpha+20120614-2.1 Versions of packages lintian recommends: ii dpkg
[lintian] 01/01: New check for weak checksums in .dsc (Closes: #824916)
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit 6fb8804acd4c188008c14f1ec0ead4748a344c4f Author: Axel Beckert Date: Sat May 21 11:03:39 2016 +0200 New check for weak checksums in .dsc (Closes: #824916) --- checks/fields.desc| 15 +++ checks/fields.pm | 8 debian/changelog | 2 ++ t/source/no-sha256-checksum/Makefile | 14 ++ t/source/no-sha256-checksum/desc | 4 t/source/no-sha256-checksum/dsc.in.in | 12 t/source/no-sha256-checksum/tags | 1 + 7 files changed, 56 insertions(+) diff --git a/checks/fields.desc b/checks/fields.desc index 22b426c..1168a8d 100644 --- a/checks/fields.desc +++ b/checks/fields.desc @@ -1276,3 +1276,18 @@ Info: No package should (build-) depend on 'perl-modules'. Instead, a suitable dependency on 'perl' should be used. The existence of the perl-modules package is an implementation detail of the perl packaging. + +Tag: no-strong-checksums-in-dsc +Severity: serious +Certainty: certain +Info: This .dsc file contains no Checksum-Sha256 field and hence only + weak checksums. + . + This issue will only show up for source packages built with + dpkg-source before 1.14.17 (March 2008) and hence will probably never + show up when you run lintian locally but only on + https://lintian.debian.org/ for source packages in the archive. + . + Accordingly it can be fixed by simply rebuilding the source package + with a more recent dpkg-source version, i.e. by uploading a new + debian release of the package. diff --git a/checks/fields.pm b/checks/fields.pm index 1f59652..732be43 100644 --- a/checks/fields.pm +++ b/checks/fields.pm @@ -1309,6 +1309,14 @@ sub run { } } +# Checksums + +if ($type eq 'source') { +if (!$info->field('checksums-sha256')) { +tag 'no-strong-checksums-in-dsc'; +} +} + #- Field checks (without checking the value) for my $field (keys %{$info->field}) { diff --git a/debian/changelog b/debian/changelog index 468e06a..5771011 100644 --- a/debian/changelog +++ b/debian/changelog @@ -10,6 +10,8 @@ lintian (2.5.45) UNRELEASED; urgency=medium /usr/share/cdbs/1/rules/debhelper.mk. * checks/fields.{desc,pm}: + [JW] Fix typos. ++ [AB] Add new check for weak checksums in source packages: + new tag no-strong-checksums-in-dsc (Closes: #824916) * checks/files.desc: + [BR] Do not suggest unsupported Multi-arch: no. (Closes: #816455) diff --git a/t/source/no-sha256-checksum/Makefile b/t/source/no-sha256-checksum/Makefile new file mode 100644 index 000..4e6543b --- /dev/null +++ b/t/source/no-sha256-checksum/Makefile @@ -0,0 +1,14 @@ +name = no-sha256-checksum +dir = $(name)-1 + +all: + mkdir -p $(dir)/debian/source + cp changelog copyright control rules $(dir)/debian/ + echo 9 > $(dir)/debian/compat + echo "3.0 (native)" > $(dir)/debian/source/format + tar cfz $(name)_1.tar.gz $(dir) + subst-dsc $(name)_1.tar.gz < dsc.in > $(name)_1.dsc + +clean: + rm -rf $(dir) + rm -f $(name)_1* diff --git a/t/source/no-sha256-checksum/desc b/t/source/no-sha256-checksum/desc new file mode 100644 index 000..6e64f22 --- /dev/null +++ b/t/source/no-sha256-checksum/desc @@ -0,0 +1,4 @@ +Testname: no-sha256-checksum +Sequence: 6000 +Version: 1.0 +Description: Test for missing Checksums-Sha256 field diff --git a/t/source/no-sha256-checksum/dsc.in.in b/t/source/no-sha256-checksum/dsc.in.in new file mode 100644 index 000..e169c45 --- /dev/null +++ b/t/source/no-sha256-checksum/dsc.in.in @@ -0,0 +1,12 @@ +Format: 1.0 +Source: no-sha256-checksum +Binary: no-sha256-checksum +Architecture: all +Version: 1 +Maintainer: Debian Lintian Maintainers +Standards-Version: {$standards_version} +Build-Depends: debhelper (>= 9) +Checksums-Sha1: + @SHA1@ @SIZE@ no-sha256-checksum_1.tar.gz +Files: + @MD5@ @SIZE@ no-sha256-checksum_1.tar.gz diff --git a/t/source/no-sha256-checksum/tags b/t/source/no-sha256-checksum/tags new file mode 100644 index 000..84ad849 --- /dev/null +++ b/t/source/no-sha256-checksum/tags @@ -0,0 +1 @@ +E: no-sha256-checksum source: no-strong-checksums-in-dsc -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (393651c -> 6fb8804)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from 393651c spelling: Add more corrections new 6fb8804 New check for weak checksums in .dsc (Closes: #824916) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.desc | 15 +++ checks/fields.pm | 8 debian/changelog | 2 ++ t/source/{debian-symlink => no-sha256-checksum}/Makefile | 10 -- t/source/no-sha256-checksum/desc | 4 t/source/no-sha256-checksum/dsc.in.in| 12 t/source/no-sha256-checksum/tags | 1 + 7 files changed, 46 insertions(+), 6 deletions(-) copy t/source/{debian-symlink => no-sha256-checksum}/Makefile (56%) create mode 100644 t/source/no-sha256-checksum/desc create mode 100644 t/source/no-sha256-checksum/dsc.in.in create mode 100644 t/source/no-sha256-checksum/tags -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Relax regexp for missing-dependency-on-perlapi (Closes: #823437)
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit b3c326c5b364ed861ace44d81f6932bfbd9b7d47 Author: Axel Beckert Date: Sat May 21 11:18:58 2016 +0200 Relax regexp for missing-dependency-on-perlapi (Closes: #823437) --- checks/binaries.pm | 2 +- debian/changelog | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/checks/binaries.pm b/checks/binaries.pm index 207a5ab..ad90be8 100644 --- a/checks/binaries.pm +++ b/checks/binaries.pm @@ -614,7 +614,7 @@ sub run { if ($has_perl_lib) { # It is a virtual package, so no version is allowed and # alternatives probably does not make sense here either. -my $re = qr/^perlapi-[\d.]+(?:\s*\[[^\]]+\])?$/; +my $re = qr/^perlapi-[-\w.]+(?:\s*\[[^\]]+\])?$/; unless ($depends->matches($re, VISIT_OR_CLAUSE_FULL)) { tag 'missing-dependency-on-perlapi'; } diff --git a/debian/changelog b/debian/changelog index 5771011..d84c1fb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,9 +2,11 @@ lintian (2.5.45) UNRELEASED; urgency=medium XXX: generate tag summary with private/generate-tag-summary - * checks/binaries.desc: + * checks/binaries.{desc,pm}: + [NT] Rewrite description for hardening-no-bindnow. There is no references to why bindnow would cause issues. ++ [AB] Relax regexp for missing-dependency-on-perlapi to allow letters + inside the API name. Thanks Niko Tyni! (Closes: #823437) * checks/debhelper.pm: + [NT] The /usr/share/R/debian/r-cran.mk file implies /usr/share/cdbs/1/rules/debhelper.mk. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (6fb8804 -> b3c326c)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from 6fb8804 New check for weak checksums in .dsc (Closes: #824916) new b3c326c Relax regexp for missing-dependency-on-perlapi (Closes: #823437) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/binaries.pm | 2 +- debian/changelog | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (f1d7c63 -> d84a929)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from f1d7c63 debian/changelog: Clarify that checks/shared-libs.desc was modified new d84a929 Don't emit application-in-library-section if package starts with "cpan" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/application-not-library.pm | 2 +- debian/changelog | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Don't emit application-in-library-section if package starts with "cpan"
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit d84a929aa9e058d6e3d0c58f4d80028267b69e6e Author: Axel Beckert Date: Sun May 22 19:48:07 2016 +0200 Don't emit application-in-library-section if package starts with "cpan" Previously only the two packages cpanplus and cpanminus were excluded. --- checks/application-not-library.pm | 2 +- debian/changelog | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/checks/application-not-library.pm b/checks/application-not-library.pm index a212bd2..60e318d 100644 --- a/checks/application-not-library.pm +++ b/checks/application-not-library.pm @@ -33,7 +33,7 @@ sub run { $pkg =~ /^perl(?:-base)?$/or # perl itself $pkg =~ /^ruby[\d.]*$/or # ruby itself $pkg =~ /^python[\d.]*(?:-dev|-minimal)?$/or # python itself - $pkg =~ /^cpan(?:plus|minus)$/or # cpan package managers + $pkg =~ /^cpan/ or # cpan related tools $pkg =~ /^libmodule-.*-perl$/ or # perl module tools $pkg =~ /^libdevel-.*-perl$/ or # perl debugging tools $pkg =~ /^libperl.*-perl$/or # perl-handling tools diff --git a/debian/changelog b/debian/changelog index 3d06db2..38d1a3a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,8 +2,10 @@ lintian (2.5.45) UNRELEASED; urgency=medium XXX: generate tag summary with private/generate-tag-summary - * checks/application-not-library.desc: + * checks/application-not-library.{desc,pm}: + [JW] Use HTTPS for Alioth URLs. ++ [AB] Don't emit application-in-library-section for packages starting + with "cpan", not only "cpanplus" and "cpanminus". * checks/binaries.{desc,pm}: + [NT] Rewrite description for hardening-no-bindnow. There is no references to why bindnow would cause issues. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#825348: lintian: check for packages containing upstart configuration in /etc/init/
Hi, Paul Wise wrote: > Please add a check for packages containing upstart configuration in the > /etc/init/ directory. Upstart was removed Debian for stretch and so > these files are no longer useful for Debian stretch and later. But they don't hurt either. So I'd say this should be P(edantic) or (I)nformational at most. P.S.: I assume there's no chance that upstream will ever come back, right? Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
[lintian] branch master updated (d84a929 -> 7f94ae2)
This is an automated email from the git hooks/post-receive script. abe pushed a change to branch master in repository lintian. from d84a929 Don't emit application-in-library-section if package starts with "cpan" new 7f94ae2 Rename (unreleased) tag no-strong-checksums-in-dsc to no-strong-digests-in-dsc The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.desc | 4 ++-- checks/fields.pm | 2 +- debian/changelog | 2 +- t/source/no-sha256-checksum/tags | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Rename (unreleased) tag no-strong-checksums-in-dsc to no-strong-digests-in-dsc
This is an automated email from the git hooks/post-receive script. abe pushed a commit to branch master in repository lintian. commit 7f94ae211eb53de487f231718781e2698a0dfcb6 Author: Axel Beckert Date: Fri May 27 21:54:01 2016 +0200 Rename (unreleased) tag no-strong-checksums-in-dsc to no-strong-digests-in-dsc Suggested by dkg, thanks! --- checks/fields.desc | 4 ++-- checks/fields.pm | 2 +- debian/changelog | 2 +- t/source/no-sha256-checksum/tags | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/checks/fields.desc b/checks/fields.desc index 1168a8d..5c21a04 100644 --- a/checks/fields.desc +++ b/checks/fields.desc @@ -1277,11 +1277,11 @@ Info: No package should (build-) depend on 'perl-modules'. Instead, a perl-modules package is an implementation detail of the perl packaging. -Tag: no-strong-checksums-in-dsc +Tag: no-strong-digests-in-dsc Severity: serious Certainty: certain Info: This .dsc file contains no Checksum-Sha256 field and hence only - weak checksums. + weak digests. . This issue will only show up for source packages built with dpkg-source before 1.14.17 (March 2008) and hence will probably never diff --git a/checks/fields.pm b/checks/fields.pm index 732be43..37ce500 100644 --- a/checks/fields.pm +++ b/checks/fields.pm @@ -1313,7 +1313,7 @@ sub run { if ($type eq 'source') { if (!$info->field('checksums-sha256')) { -tag 'no-strong-checksums-in-dsc'; +tag 'no-strong-digests-in-dsc'; } } diff --git a/debian/changelog b/debian/changelog index 38d1a3a..e6efdcb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -17,7 +17,7 @@ lintian (2.5.45) UNRELEASED; urgency=medium * checks/fields.{desc,pm}: + [JW] Fix typos. + [AB] Add new check for weak checksums in source packages: - new tag no-strong-checksums-in-dsc (Closes: #824916) + new tag no-strong-digests-in-dsc (Closes: #824916) * checks/files.desc: + [BR] Do not suggest unsupported Multi-arch: no. (Closes: #816455) diff --git a/t/source/no-sha256-checksum/tags b/t/source/no-sha256-checksum/tags index 84ad849..8ed6eca 100644 --- a/t/source/no-sha256-checksum/tags +++ b/t/source/no-sha256-checksum/tags @@ -1 +1 @@ -E: no-sha256-checksum source: no-strong-checksums-in-dsc +E: no-sha256-checksum source: no-strong-digests-in-dsc -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#824916: lintian: Check for weak signatures in source packages
Control: retitle -1 lintian: Check for weak digest algorithms in source packages Hi Daniel, thanks for your comments. Daniel Kahn Gillmor wrote: > On Sat 2016-05-21 04:57:15 -0400, Axel Beckert wrote: > > during the (ongoing) Debian Perl Team Sprint, one of the discussed > > topics was dpkg-source now issuing warnings about weak signatures when > > extracting source packages. (For some time, in versions1.18.5 and > > 1.18.6, it even bailed out, failing to extract source packages as they > > are currently in Sid -- which is the reason why the default was reverted > > and it only prints a warning since 1.18.7.) Some more context is in > > https://bugs.debian.org/823428 > > fwiw, the lintian check you propose is actually a check for a weak > digest algorithm in the manifest that a .dsc or .changes file > represents. Correct. But the currently implemented variant only checks .dsc files. I wonder if it makes sense to broaden that check to also check .changes files: * AFAIK the archive does not contain/archive .changes files, i.e. the check will not trigger for the archive wide tests as published on lintian.debian.org. * Current dpkg-genchanges versions don't generate changes files without strong digest algorithms. So this would only make sense, if * Someone uses a current lintian version with an ancient dpkg-dev version. Why should someone? And if so, he can't fix it except by using a more modern dpkg-dev version. * Someone tests the result of an alternative dpkg(-dev) implementation by checking the results with lintian. AFAIK no such implementation exists. * Someone uploads a package built with an ancient dpkg-dev version to ftp.debian.org and there is not yet a check for weak digest at that point. > It does *not* cover any test for a weak signature (so the > subject line of this bug report is a little off. Fixed. But that misleading Subject does exist for a reason. See below. > I'd name the message no-strong-digests-in-dsc, rather than > no-strong-checksums-in-dsc, but i'd be fine with it as it stands. We still have the chance to do that as no lintian version has been released since I initially committed the code. So I changed and pushed it. > fwiw, a signed .dsc file itself might also use a weak digest algorithm > in its signature itself. Correct. About the first two hours working on an implementation for that check I actually tried to check that -- until I realised that it's nearly impossible to get that information out of GnuPG, not to speak about the three Perl interfaces to GnuPG I looked at. Only then I realised that the proposer(s) meant something different. That's probably why the Subject was misleading initially -- I was misled, too. :-) > I'd love to see an additional check for that, but i guess that's a > separate question. And it probably would be a performance penalty, because Lintian currently passes options to dpkg-source to bypass all (GnuPG) signature checks. Checking them will cost quite some more time. This might not be so much of an issue when checking single packages, but it will be an issue when rechecking all packages in the archive on lintian.debian.org. Additionally, Lintian would also need a keyring with all the relevant keys -- especially for source packages in the archive, as they may be signed with no more valid keys or keys removed from the keyring. > > An affected example source package is libclass-default-perl_1.51-2.dsc > > from the archive: last uploaded in 2008. Actually, this example package is a very good example, because it represents both issues mentioned above: * It's signed with a 1024 bits key no more in the keyring. * The key has been revoked because it was considered compromised. > It would be a very good thing indeed, thanks for suggesting it. IIRC the credit for the idea go to Niko Tyni. :-) > > Following is my patch so far (without the test case). I'm not sure if > > the severity "serious" is the proper value, so please feel free to > > comment on that. > > I agree that it is "serious". This is 2016, we should be requiring > strong digests. Good. Let's leave it that way. :-) Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Bug#831864: lintian: Should warn about python packages which ship coverage information
Package: lintian Version: 2.5.45 Severity: wishlist Hi, I don't know too much about doing coverage computations in Python, but this looks wrong twice (i.e. for both packages): Unpacking python-rows (0.2.0-1) over (0.1.1-3) ... dpkg: error processing archive /var/cache/apt/archives/python-rows_0.2.0-1_all.deb (--unpack): trying to overwrite '/usr/lib/python2.7/dist-packages/.coverage', which is also in package python-jwt 1.4.0-1 IMHO lintian should throw an "Error" level warning if a file matching /usr/lib/python*/dist-packages/.coverage exists in a binary package. But maybe the list of avoided file names should be even larger. Someone fit in python ooverage should probably look at this. I'd implement the test once it's clear what exactly needs to be looked at. -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), (111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), (105, 'experimental-debug') Architecture: amd64 (x86_64) Kernel: Linux 4.6.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages lintian depends on: ii binutils 2.26.1-1 ii bzip2 1.0.6-8 ii diffstat 1.61-1 ii file 1:5.28-3 ii gettext 0.19.8.1-1 ii hardening-includes2.8+nmu2 ii intltool-debian 0.35.0+20060710.4 ii libapt-pkg-perl 0.1.29+b5 ii libarchive-zip-perl 1.57-1 ii libclass-accessor-perl0.34-1 ii libclone-perl 0.38-2 ii libdata-alias-perl1.20-1+b1 ii libdigest-sha-perl5.95-2+b1 ii libdpkg-perl 1.18.9 ii libemail-valid-perl 1.200-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl 0.94-1 ii liblist-moreutils-perl0.416-1 ii libparse-debianchangelog-perl 1.2.0-10 ii libperl5.22 [libdigest-sha-perl] 5.22.2-2 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl 1.71-1 ii libyaml-libyaml-perl 0.41-6+b1 ii man-db2.7.5-1 ii patchutils0.3.4-1 ii perl 5.22.2-2 ii t1utils 1.39-2 ii xz-utils 5.1.1alpha+20120614-2.1 Versions of packages lintian recommends: ii dpkg 1.18.9 ii libautodie-perl 2.29-2 ii libperlio-gzip-perl 0.19-1+b1 ii perl 5.22.2-2 ii perl-modules-5.22 [libautodie-perl] 5.22.2-2 Versions of packages lintian suggests: ii binutils-multiarch 2.26.1-1 ii dpkg-dev 1.18.9 ii libhtml-parser-perl3.72-2 ii libtext-template-perl 1.46-1 -- no debconf information
Bug#831864: lintian: Should warn about python packages which ship coverage information
Hi, Axel Beckert wrote: > I don't know too much about doing coverage computations in Python, but > this looks wrong twice (i.e. for both packages): > > Unpacking python-rows (0.2.0-1) over (0.1.1-3) ... > dpkg: error processing archive > /var/cache/apt/archives/python-rows_0.2.0-1_all.deb (--unpack): > trying to overwrite '/usr/lib/python2.7/dist-packages/.coverage', which is > also in package python-jwt 1.4.0-1 There are now two bug reports against those two packages: https://bugs.debian.org/831867 https://bugs.debian.org/831868 > IMHO lintian should throw an "Error" level warning if a file matching > /usr/lib/python*/dist-packages/.coverage exists in a binary package. In the bug reports mentioned above there's also the idea mentioned that this might be fixed via the python packaging helpers. It still might be a good idea to implement a lintian tag for this to be able to identify this issue in already built packages. Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Bug#840998: lintian: False positives for ancient-autotools-helper-file with debhelper compat level 10
Package: lintian Version: 2.5.48 Severity: normal Hi, with a package with very old upstream files, I got the following lintian error-level tags since converting the package to debhelper and source format "3.0 (quilt)" -- where I of course removed all patches touching files which get updated via the implicit dh_autoreconf call anyways: E: ccze source: ancient-autotools-helper-file config.guess 2002-07-09 N: N:The referenced file has a time stamp older than year 2004 and the N:package does not build-depend on autotools-dev or automake and therefore N:apparently does not update it. This usually means that the source N:package will not build correctly on all currently released N:architectures. N: N:For packages using debhelper, the tools from the dh-autoreconf package N:should handle this issue. cdbs will automatically update these files if N:autotools-dev is installed during build, but the build dependency on N:autotools-dev is still necessary. N: N:Otherwise, read /usr/share/doc/autotools-dev/README.Debian.gz (from the N:autotools-dev package) for information on how to fix this problem. N: N:Severity: important, Certainty: possible N: N:Check: cruft, Type: source N: E: ccze source: ancient-autotools-helper-file config.sub 2002-07-03 If I add an explicit dh-autoreconf buil-dependency, these errors vanish. But the dependency on "debhelper (>= 10)" and debian/compat = 10 already imply that. So this smells a lot like a false positive to me. (I'd though appreciate some confirmation before I start trying to make up a patch for this. :-) -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), (111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), (105, 'experimental-debug') Architecture: amd64 (x86_64) Kernel: Linux 4.8.0-rc5-amd64 (SMP w/4 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages lintian depends on: ii binutils 2.27-8 ii bzip2 1.0.6-8 ii diffstat 1.61-1 ii file 1:5.28-4 ii gettext 0.19.8.1-1 ii intltool-debian 0.35.0+20060710.4 ii libapt-pkg-perl 0.1.29+b6 ii libarchive-zip-perl 1.59-1 ii libclass-accessor-perl0.34-1 ii libclone-perl 0.38-2+b1 ii libdigest-sha-perl5.96-1+b1 ii libdpkg-perl 1.18.10 ii libemail-valid-perl 1.202-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl 0.94-1 ii liblist-moreutils-perl0.416-1+b1 ii libparse-debianchangelog-perl 1.2.0-11 ii libperl5.24 [libdigest-sha-perl] 5.24.1~rc3-3 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl 1.71-1 ii libyaml-libyaml-perl 0.63-1+b1 ii man-db2.7.5-1 ii patchutils0.3.4-1 ii perl 5.24.1~rc3-3 ii t1utils 1.39-2 ii xz-utils 5.2.2-1.2 Versions of packages lintian recommends: ii dpkg 1.18.10 ii libautodie-perl 2.29-2 ii libperlio-gzip-perl 0.19-1+b2 ii perl 5.24.1~rc3-3 ii perl-modules-5.24 [libautodie-perl] 5.24.1~rc3-3 Versions of packages lintian suggests: ii binutils-multiarch 2.27-8 ii dpkg-dev 1.18.10 ii libhtml-parser-perl3.72-2+b1 ii libtext-template-perl 1.46-1 -- no debconf information
Bug#858039: lintian: Graph (SVG) files on https://lintian.debian.org/ lack tag name
Package: lintian Version: 2.5.50.1 Severity: wishlist Hi, today I was talking with a colleague about the result of some action which had a severe impact on some lintian tag. Since it was irrelevant which packages were affected and it was only relevant how the number shrunk over time, I only sent him the link the graph: https://lintian.debian.org/resources/beeef37b8e3ee13c9d12dc0374b1f60f3f16c2acec234986cdabc5d2ad429ef8.svg He was totally confused by the graph and asked "What does «Tags» mean? Is that good or bad?". Only when I saw the graphic on his screen without the surrounding context, I realized that the graph actually doesn't contain the tag name at all. (Or said the other way round: Try to guess for which Lintian tag the above mentioned graph is. I assume that a few Debianers will recognize it, but also that it won't be too many people. See the hint at the very end of this mail. :-) So I propose to add at least the tag name to the SVG somewhere, e.g. below the X axis, as a title or instead of "Tags". If we can afford using more vertical space, I'd suggest to changing the legend as follows: Tags ⇒ Tag emitted Packages ⇒ Packages which emitted Overridden ⇒ Tag overridden (Maybe we need to use a smaller font, too.) Another thing which is very similar is the file name of that images. Are there reasons why the above mentioned graph file is named "beeef37b8e3ee13c9d12dc0374b1f60f3f16c2acec234986cdabc5d2ad429ef8.svg" and not ".svg"? That would probably also provide permanent URLs for passing links to just the graph around. -- System Information: Debian Release: 9.0 APT prefers unstable APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) Versions of packages lintian depends on: ii binutils 2.28-2 ii bzip2 1.0.6-8.1 ii diffstat 1.61-1+b1 ii file 1:5.29-3 ii gettext 0.19.8.1-2 ii intltool-debian 0.35.0+20060710.4 ii libapt-pkg-perl 0.1.30 ii libarchive-zip-perl 1.59-1 ii libclass-accessor-perl0.34-1 ii libclone-perl 0.38-2+b1 ii libdigest-sha-perl5.96-1+b1 ii libdpkg-perl 1.18.23 ii libemail-valid-perl 1.202-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl 0.94-1 ii liblist-moreutils-perl0.416-1+b1 ii libparse-debianchangelog-perl 1.2.0-12 ii libperl5.24 [libdigest-sha-perl] 5.24.1-1 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl 1.71-1 ii libyaml-libyaml-perl 0.63-2 ii man-db2.7.6.1-2 ii patchutils0.3.4-2 ii perl 5.24.1-1 ii t1utils 1.39-2 ii xz-utils 5.2.2-1.2+b1 Versions of packages lintian recommends: ii dpkg 1.18.23 ii libautodie-perl 2.29-2 ii libperlio-gzip-perl 0.19-1+b2 ii perl 5.24.1-1 ii perl-modules-5.24 [libautodie-perl] 5.24.1-1 Versions of packages lintian suggests: ii binutils-multiarch 2.28-2 ii dpkg-dev 1.18.23 ii libhtml-parser-perl3.72-3 ii libtext-template-perl 1.46-1 -- no debconf information -- Hint mentioned inside the bug report above It's the graph from https://lintian.debian.org/tags/hardening-no-pie.html :-)
Re: Bug#786808: would adequate be still in stretch or thrown out ?
Hi shirish, shirish शिरीष wrote: > couple of weeks back I saw in how-can-i-help that adequate might be > thrown out. Does not seem to be the case anymore. Maybe due to a dependency being RC-buggy for more than a week which got fixed in the meanwhile? P.S.: I'm interested in seeing adequate properly maintained, too. Since it's written in Perl, I wonder if the Lintian Maintainers (Cc'ed) could pick it up as it's more or less a companion to Lintian. I would also help with that. Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: Digital signature
[Git][lintian/lintian][master] Replace all occurrences of "Copyright ©" with "Copyright (C)" again until...
Axel Beckert pushed to branch master at lintian / lintian Commits: d53aff54 by Axel Beckert at 2022-06-11T16:49:27+02:00 Replace all occurrences of "Copyright ©" with "Copyright (C)" again until https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed This more or less reverts 1a3f6eeeaef3f31aa28e699a82f509b7a7d50fc3 (Replace "Copyright (C)" with the Unicode copyright symbol in our own code for consistency.) for now. - - - - - 30 changed files: - bin/lintian - bin/lintian-annotate-hints - bin/lintian-explain-tags - bin/spellintian - commands/reporting-harness.pm - commands/reporting-html-reports.pm - commands/reporting-lintian-harness.pm - commands/reporting-sync-state.pm - lib/Lintian/Archive.pm - lib/Lintian/Changelog.pm - lib/Lintian/Changelog/Entry.pm - lib/Lintian/Changelog/Version.pm - lib/Lintian/Check.pm - lib/Lintian/Check/Apache2.pm - lib/Lintian/Check/ApplicationNotLibrary.pm - lib/Lintian/Check/AppstreamMetadata.pm - lib/Lintian/Check/Apt.pm - lib/Lintian/Check/Archive/File/Name/Length.pm - lib/Lintian/Check/Archive/Liberty/Mismatch.pm - lib/Lintian/Check/Archive/NonFree/Autobuild.pm - lib/Lintian/Check/Binaries.pm - lib/Lintian/Check/Binaries/Architecture.pm - lib/Lintian/Check/Binaries/Architecture/Other.pm - lib/Lintian/Check/Binaries/Corrupted.pm - lib/Lintian/Check/Binaries/DebugSymbols.pm - lib/Lintian/Check/Binaries/DebugSymbols/Detached.pm - lib/Lintian/Check/Binaries/Hardening.pm - lib/Lintian/Check/Binaries/LargeFileSupport.pm - lib/Lintian/Check/Binaries/Location.pm - lib/Lintian/Check/Binaries/Obsolete/Crypt.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d53aff545cd8e66e5137e6f24a031cb8d1adad07 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d53aff545cd8e66e5137e6f24a031cb8d1adad07 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 9 commits: Update copyright years in debian/copyright
Axel Beckert pushed to branch master at lintian / lintian Commits: 1b26acec by Axel Beckert at 2022-06-11T17:00:27+02:00 Update copyright years in debian/copyright … before lintian starts complaining about it. ;-) - - - - - 648144e9 by Axel Beckert at 2022-06-11T18:59:43+02:00 Run perltidy over bin/lintian and private/{runtests,refresh-perl-provides} Lintian's own tests t/scripts/01-critic/{bin,private}.t fail otherwise. - - - - - 625526b0 by Axel Beckert at 2022-06-11T18:59:48+02:00 Remove unnecessary usage of UTF-8 from bin/lintian until https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed - - - - - a60e8001 by Axel Beckert at 2022-06-11T18:59:48+02:00 Run perltidy over t/scripts/{spellintian,…/hintextract,…/tag-coverage}.t Lintian's own test t/scripts/01-critic/scripts.t fails otherwise. - - - - - 5651c63f by Axel Beckert at 2022-06-11T19:24:51+02:00 Run perltidy over lib Lintian's own test t/scripts/01-critic/libs.t fails otherwise. It still fails, but no more for 167 files, now only for 64 files. - - - - - 615d6623 by Axel Beckert at 2022-06-11T22:03:40+02:00 Replace UTF-8 characters in mostly Copyright comments until https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed Actually all of them are copyright comment except for a single Unicode SECTION SIGN character somewhere else. - - - - - 1c04b37c by Axel Beckert at 2022-06-11T22:03:40+02:00 Replace UTF-8 characters in code with \N{…} until https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed Lintian's own test t/scripts/01-critic/libs.t fails otherwise. - - - - - fe229196 by Axel Beckert at 2022-06-11T22:07:49+02:00 Remove literal unicode character U+0334 COMBINING TILDE OVERLAY which likely had been added accidentally … slightly over 10 years ago and nobody noticed so far. For more details see https://lists.debian.org/msgid-search/20220611194509.ykyasxuwnss6m...@sym.noone.org - - - - - 34198690 by Axel Beckert at 2022-06-11T22:13:50+02:00 data/…/perl-provides updated by running "d…/rules refresh-perl-provides" - - - - - 30 changed files: - bin/lintian - data/fields/perl-provides - debian/copyright - lib/Lintian/Archive.pm - lib/Lintian/Changelog.pm - lib/Lintian/Check/Apache2.pm - lib/Lintian/Check/ApplicationNotLibrary.pm - lib/Lintian/Check/AppstreamMetadata.pm - lib/Lintian/Check/Binaries/Architecture/Other.pm - lib/Lintian/Check/Binaries/Hardening.pm - lib/Lintian/Check/Binaries/LargeFileSupport.pm - lib/Lintian/Check/Binaries/Location.pm - lib/Lintian/Check/Binaries/Obsolete/Crypt.pm - lib/Lintian/Check/Binaries/Prerequisites.pm - lib/Lintian/Check/Binaries/Prerequisites/Numpy.pm - lib/Lintian/Check/Binaries/Rpath.pm - lib/Lintian/Check/Binaries/Spelling.pm - lib/Lintian/Check/Binaries/Static.pm - lib/Lintian/Check/BuildSystems/Autotools.pm - lib/Lintian/Check/BuildSystems/Autotools/Libtool.pm - lib/Lintian/Check/BuildSystems/Cmake.pm - lib/Lintian/Check/BuildSystems/Waf.pm - lib/Lintian/Check/Cruft.pm - lib/Lintian/Check/DebFormat.pm - lib/Lintian/Check/Debhelper.pm - lib/Lintian/Check/Debian/Changelog.pm - lib/Lintian/Check/Debian/Control/Field/BuiltUsing.pm - lib/Lintian/Check/Debian/Control/Field/Relation.pm - lib/Lintian/Check/Debian/Copyright.pm - lib/Lintian/Check/Debian/Copyright/ApacheNotice.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/d53aff545cd8e66e5137e6f24a031cb8d1adad07...3419869095c6d8d05e7e770c0281af51855db3ef -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/d53aff545cd8e66e5137e6f24a031cb8d1adad07...3419869095c6d8d05e7e770c0281af51855db3ef You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Update data for Debian policy releases (4.6.1 added)
Axel Beckert pushed to branch master at lintian / lintian Commits: f274aa0e by Damyan Ivanov at 2022-06-13T22:17:00+00:00 Update data for Debian policy releases (4.6.1 added) - - - - - 3ad582e2 by Damyan Ivanov at 2022-06-13T22:17:00+00:00 update releases.json via lintian itself magic incantation: perl -Ilib -wE'use Lintian::Deb822; use Lintian::Data::Policy::Releases; my $r = Lintian::Data::Policy::Releases->new; $r->refresh(0, "data");' Downloads the debian-policy changelog from salsa - - - - - 1 changed file: - data/debian-policy/releases.json Changes: = data/debian-policy/releases.json = @@ -8,18 +8,42 @@ "author" : "Sean Whitton ", "changes" : [ "", -"debian-policy (4.6.0.2) UNRELEASED; urgency=medium", +"debian-policy (4.6.1.0) unstable; urgency=medium", +"", +" * Policy: Allow non-64-bit packages to install to /usr/lib64", +"Wording: Sean Whitton ", +"Seconded: Simon McVittie ", +"Seconded: Russ Allbery ", +"Closes: #992601", +" * Policy: Define 'upstream' & document several version conventions", +"Wording: Russ Allbery ", +"Seconded: Sam Hartman ", +"Seconded: Sean Whitton ", +"Closes: #542288, #850729", +" * virtual-package-names-list: Add {default,}dbus-system-bus (Closes: #998063).", +"Thanks to Simon McVittie for the patch.", +" * Update 9.7.2 and 9.7.3 for package split of bin:mime-support into", +"bin:media-types and bin:mailcap (Closes: #1008480).", +"Thanks to Charles Plessy for the patch.", "", " * Fix several problems with footnote regarding the autobuilders and", "build dependency alternatives (Closes: #999826).", -"Thanks to Johannes Schauer Marin Rodrigues for the report and patch." +"Thanks to Johannes Schauer Marin Rodrigues for the report and patch.", +" * Use syntax highlighting for some source code blocks (Closes: #999566).", +"Thanks to Stéphane Blondon for the patch." ], "closes" : [ -999826.0 - ], - "epoch" : 1640320759, - "timestamp" : "2021-12-24T04:39:19Z", - "version" : "4.6.0.2" +542288, +850729, +992601, +998063, +999566, +999826, +1008480 + ], + "epoch" : 1652292179, + "timestamp" : "2022-05-11T18:02:59Z", + "version" : "4.6.1.0" }, { "author" : "Sean Whitton ", View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/ccd30b72f3ad9b9d7621a0058f07aee52ae49a73...3ad582e27b1fc690dbbc81623173c7513a9124bc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/ccd30b72f3ad9b9d7621a0058f07aee52ae49a73...3ad582e27b1fc690dbbc81623173c7513a9124bc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] README.developers.pod: Explain the difference between a check and a test
Axel Beckert pushed to branch master at lintian / lintian Commits: f28bde63 by Axel Beckert at 2022-06-20T01:32:51+02:00 README.developers.pod: Explain the difference between a check and a test - - - - - 1 changed file: - doc/README.developers.pod Changes: = doc/README.developers.pod = @@ -100,6 +100,11 @@ most important ones: =over 4 +=item Check + +A library checking specific aspects of a package, changes file, +etc. which usually can emit multiple tags. + =item Emit (Tag) Tag that was not suppressed and was triggered. @@ -133,6 +138,10 @@ counted in statistics. Not to be confused with "Overridden". Issue reported by Lintian. +=item Test + +An internal test of Lintian. + =back =head2 Useful tricks View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f28bde63f1c4c00ddaf65b80ba4aee10186d205b -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f28bde63f1c4c00ddaf65b80ba4aee10186d205b You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch brackets-in-overrides-rc-bug-1003353
Axel Beckert pushed new branch brackets-in-overrides-rc-bug-1003353 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/brackets-in-overrides-rc-bug-1003353 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.115.0
Axel Beckert pushed new tag 2.115.0 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.115.0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 4 commits: Write a test which catches run-time errors of lightweight private scripts
Axel Beckert pushed to branch master at lintian / lintian Commits: 8ec7fc75 by Axel Beckert at 2022-06-21T12:43:39+02:00 Write a test which catches run-time errors of lightweight private scripts Triggered by autopkgtest failure of libconfig-model-dpkg-perl which runs private/latest-policy-version and failed. Gbp-Dch: Full - - - - - 74e9fe65 by Axel Beckert at 2022-06-21T12:45:13+02:00 Fix private/latest-policy-version: $p…->policy_releases → $p…->data->policy_releases Seems to have been forgotten when policy_releases() moved from Lintian::Profile to Lintian::Data. Should fix libconfig-model-dpkg-perl autopkgtest. Gbp-Dch: Full - - - - - 65a0c7db by Axel Beckert at 2022-06-21T12:45:13+02:00 Fix documentation of Lintian::Data->new() - - - - - 6dd3c1b1 by Axel Beckert at 2022-06-21T12:45:13+02:00 Switch all GPL URLs in boilerplates to HTTPS - - - - - 30 changed files: - bin/lintian - bin/lintian-annotate-hints - bin/lintian-explain-tags - commands/reporting-harness.pm - commands/reporting-html-reports.pm - commands/reporting-lintian-harness.pm - commands/reporting-sync-state.pm - lib/Lintian/Archive.pm - lib/Lintian/Changelog.pm - lib/Lintian/Changelog/Version.pm - lib/Lintian/Check.pm - lib/Lintian/Check/Apache2.pm - lib/Lintian/Check/ApplicationNotLibrary.pm - lib/Lintian/Check/AppstreamMetadata.pm - lib/Lintian/Check/Apt.pm - lib/Lintian/Check/Archive/File/Name/Length.pm - lib/Lintian/Check/Archive/Liberty/Mismatch.pm - lib/Lintian/Check/Archive/NonFree/Autobuild.pm - lib/Lintian/Check/Binaries.pm - lib/Lintian/Check/Binaries/Architecture.pm - lib/Lintian/Check/Binaries/Architecture/Other.pm - lib/Lintian/Check/Binaries/Corrupted.pm - lib/Lintian/Check/Binaries/DebugSymbols.pm - lib/Lintian/Check/Binaries/DebugSymbols/Detached.pm - lib/Lintian/Check/Binaries/Hardening.pm - lib/Lintian/Check/Binaries/LargeFileSupport.pm - lib/Lintian/Check/Binaries/Location.pm - lib/Lintian/Check/Binaries/Obsolete/Crypt.pm - lib/Lintian/Check/Binaries/Prerequisites.pm - lib/Lintian/Check/Binaries/Prerequisites/Numpy.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/9891622bd15d0a72c0ff1802706be863b2811fbe...6dd3c1b15e2e58fb2dfd0d5507850e115e798251 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/9891622bd15d0a72c0ff1802706be863b2811fbe...6dd3c1b15e2e58fb2dfd0d5507850e115e798251 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch salsa-debug
Axel Beckert pushed new branch salsa-debug at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/salsa-debug You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.115.1
Axel Beckert pushed new tag 2.115.1 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.115.1 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] perltidy lib/Lintian/Check/Documentation.pm
Axel Beckert pushed to branch master at lintian / lintian Commits: 133b4c74 by Axel Beckert at 2022-06-22T09:19:23+02:00 perltidy lib/Lintian/Check/Documentation.pm Gbp-Dch: Ignore - - - - - 1 changed file: - lib/Lintian/Check/Documentation.pm Changes: = lib/Lintian/Check/Documentation.pm = @@ -132,7 +132,7 @@ sub visit_installed_files { || ( $item->basename =~ m{^README}xi && $item->bytes =~ m{this directory}xi) # see Bug#1009679 - || $item->name =~ m{^var/lib/ocaml/lintian/.+[.]info$}; + || $item->name =~ m{^var/lib/ocaml/lintian/.+[.]info$}; } if ($item->name =~ m{^usr/share/doc/\S}) { View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/133b4c74f10db401c1650a52ee184a86e2feb376 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/133b4c74f10db401c1650a52ee184a86e2feb376 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Move libio-prompt-tiny-perl dependency to debian/tests/control
Axel Beckert pushed to branch master at lintian / lintian Commits: 9593ee76 by Axel Beckert at 2022-06-22T23:57:05+02:00 Move libio-prompt-tiny-perl dependency to debian/tests/control Cherry-picked from Ubuntu's patches. LP: #1959004 Gbp-Dch: Full - - - - - 47239102 by Axel Beckert at 2022-06-22T23:57:12+02:00 Recognise Mac OS X icons (.icns) as binary files - - - - - 3 changed files: - data/files/binary-file-extensions - debian/control - debian/tests/control Changes: = data/files/binary-file-extensions = @@ -11,3 +11,4 @@ tif tiff wav xcf +icns = debian/control = @@ -56,7 +56,6 @@ Depends: libhtml-html5-entities-perl, libhtml-tokeparser-simple-perl, libio-interactive-perl, - libio-prompt-tiny-perl, libipc-run3-perl, libjson-maybexs-perl, liblist-compare-perl, = debian/tests/control = @@ -18,6 +18,7 @@ Depends: gcc-mingw-w64-x86-64, gpg-agent, javahelper, + libio-prompt-tiny-perl, libmce-perl, libperl-critic-freenode-perl, libperl-critic-pulp-perl, View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/133b4c74f10db401c1650a52ee184a86e2feb376...472391022600f4421ba140d6c6c8f87be5f2a2c7 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/133b4c74f10db401c1650a52ee184a86e2feb376...472391022600f4421ba140d6c6c8f87be5f2a2c7 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.115.2
Axel Beckert pushed new tag 2.115.2 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.115.2 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch migrate-overrides
Axel Beckert pushed new branch migrate-overrides at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/migrate-overrides You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: Add extensions of colour profiles: icc, icm
Axel Beckert pushed to branch master at lintian / lintian Commits: 39452842 by Pino Toscano at 2022-07-06T21:18:19+02:00 Add extensions of colour profiles: icc, icm - - - - - a1addb26 by Pino Toscano at 2022-07-06T21:50:34+02:00 Add more extensions of document files - various OpenDocument formats - EPUB - Comic Book archives - CHM - some Microsoft Office formats Gbp-Dch: Short - - - - - 21b3c002 by Pino Toscano at 2022-07-06T21:51:10+02:00 Add extensions of image files: emf Gbp-Dch: Short - - - - - 1 changed file: - data/files/binary-file-extensions Changes: = data/files/binary-file-extensions = @@ -9,15 +9,25 @@ avi avif avifs bmp +cb7 +cbr +cbt +cbz +chm der djvu dll dmg +doc +emf +epub exe flac gif gmo gpg +icc +icm icns ico jar @@ -34,16 +44,21 @@ mov mp3 mp4 mpg +odg +odp ods +odt oga ogg ogv opus otf +otp p12 pdf pfx png +ppt psd spx sqlite View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/ecc04980869462c5c71f4f71e9b8a71bd5b944b5...21b3c0022c2d82146bbae437d5d8b7ab9cce64cc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/ecc04980869462c5c71f4f71e9b8a71bd5b944b5...21b3c0022c2d82146bbae437d5d8b7ab9cce64cc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch dpatch-removal
Axel Beckert pushed new branch dpatch-removal at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/dpatch-removal You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch fix-cruft-perlcritic
Axel Beckert pushed new branch fix-cruft-perlcritic at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/fix-cruft-perlcritic You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] .gitignore: Also ignore debian/*.debhelper files and drop wrong trailing slash for doc/lintian.html
Axel Beckert pushed to branch master at lintian / lintian Commits: e048f0e7 by Axel Beckert at 2022-09-10T17:52:51+02:00 .gitignore: Also ignore debian/*.debhelper files and drop wrong trailing slash for doc/lintian.html Merge potentially three very similar ignore rules into a single one. - - - - - 1 changed file: - .gitignore Changes: = .gitignore = @@ -1,6 +1,5 @@ /*-stamp -/debian/.debhelper/ -/debian/*.debhelper.* +/debian/*.debhelper* /debian/debhelper-build-stamp /debian/files /debian/lintian.substvars @@ -10,7 +9,7 @@ /doc/api.html/ /doc/README /doc/help.tmp -/doc/lintian.html/ +/doc/lintian.html /doc/lintian.txt /l10n/ /man/man*/ View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e048f0e74ff77cd4853e1f35620b04f8ca48405b -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e048f0e74ff77cd4853e1f35620b04f8ca48405b You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 4 commits: Replace egrep and fgrep in all test suite dummy packages with grep -E/-F
Axel Beckert pushed to branch master at lintian / lintian Commits: 99fb9320 by Axel Beckert at 2022-09-11T01:08:19+02:00 Replace egrep and fgrep in all test suite dummy packages with grep -E/-F - - - - - 96735a72 by Axel Beckert at 2022-09-11T01:08:19+02:00 Add build-dependencies of the test suite They have been forgotten in commit 258fb7fb. Taken from debian/tests/control and added "<!notest>" to each. - - - - - 29cb2a01 by Axel Beckert at 2022-09-11T01:13:05+02:00 Fix test broken by dpatch removal - - - - - c4998558 by Axel Beckert at 2022-09-11T01:13:29+02:00 Fix test broken by updating the list of virtual packages - - - - - 30 changed files: - debian/control - t/recipes/checks/build-systems/debhelper/maintainer-script/token/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/debhelper/debhelper-no-depends/eval/hints - t/recipes/checks/debhelper/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/debian/changelog/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/debian/copyright/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/debian/watch/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/documentation/files-uses-dpkg-database-directly/build-spec/orig/test-1 - t/recipes/checks/fields/dm-upload-allowed/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/fields/mail-address/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/fields/package-relations/fields-depends-general/eval/hints - t/recipes/checks/fields/standards-version/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/files/contents/files-uses-dpkg-database-directly/build-spec/orig/test-1 - t/recipes/checks/files/contents/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/files/contents/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/init-d/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/init-d/maintainer-script/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/empty/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/generated/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/maintainer-scripts/helper/dpkg/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/maintainer-scripts/ldconfig/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/mknod/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/maintainer-scripts/temporary-files/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/temporary-files/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/md5sums/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/nmu/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/script/syntax/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/script/syntax/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/scripts/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/scripts/legacy-maintainer-scripts/eval/hints The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/be8c92f08d16a4a151e8f81d1c1d5922ab5b7ec8...c49985584b737628c6dde27b6d71e84dfa715ae9 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/be8c92f08d16a4a151e8f81d1c1d5922ab5b7ec8...c49985584b737628c6dde27b6d71e84dfa715ae9 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Add "lunar" as a known Ubuntu distribution.
Axel Beckert pushed to branch master at lintian / lintian Commits: f52fe078 by Simon Quigley at 2022-10-28T13:32:42-05:00 Add "lunar" as a known Ubuntu distribution. - - - - - 1 changed file: - vendors/ubuntu/main/data/changes-file/known-dists Changes: = vendors/ubuntu/main/data/changes-file/known-dists = @@ -32,3 +32,4 @@ hirsute impish jammy kinetic +lunar View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f52fe078adaf55310b49cd2d21d55669f67a34bc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f52fe078adaf55310b49cd2d21d55669f67a34bc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Declare compliance with Debian Policy 4.6.2
Axel Beckert pushed to branch master at lintian / lintian Commits: 36a9bf61 by Axel Beckert at 2022-12-18T12:00:54+01:00 Declare compliance with Debian Policy 4.6.2 No other seem necessary for that. - - - - - 1 changed file: - debian/control Changes: = debian/control = @@ -59,7 +59,7 @@ Build-Depends: wamerican , wbritish , zip -Standards-Version: 4.6.1 +Standards-Version: 4.6.2 Rules-Requires-Root: no Vcs-Git: https://salsa.debian.org/lintian/lintian.git Vcs-Browser: https://salsa.debian.org/lintian/lintian View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/36a9bf61b8b05a1cea92fd1ed118ef063e8e8149 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/36a9bf61b8b05a1cea92fd1ed118ef063e8e8149 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Make test for generate-tag-summary more precise and properly cover all cases
Axel Beckert pushed to branch master at lintian / lintian Commits: 2dab187d by Axel Beckert at 2022-12-22T01:56:58+01:00 Make test for generate-tag-summary more precise and properly cover all cases See also MR !435. Thanks @pollo! - - - - - 1 changed file: - t/scripts/run-private-scripts.t Changes: = t/scripts/run-private-scripts.t = @@ -60,7 +60,11 @@ sub t { } t('auto-reject-diff', qr/Found \d+ certain/); -t('generate-tag-summary', qr/Assuming commit range to be/, qr/tags/); +t( +'generate-tag-summary', +qr/Assuming commit range to be/, +qr/^No tags were added or removed$|\A\Z/ +); t('latest-policy-version', qr/^(\d+\.){3}/); done_testing(); View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/2dab187df35671f7ce867871fa4ee0753912 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/2dab187df35671f7ce867871fa4ee0753912 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Salsa CI: Override the lintian version being used to the just built version
Axel Beckert pushed to branch master at lintian / lintian Commits: f0f98771 by Axel Beckert at 2023-01-02T06:42:02+01:00 Salsa CI: Override the lintian version being used to the just built version Should fix Salsa CI autopokgtest failures due to e.g. newer-standards-version if lintian in unstable doesn't know about the new debian-policy release yet. - - - - - 1 changed file: - debian/salsa-ci.yml Changes: = debian/salsa-ci.yml = @@ -26,3 +26,10 @@ build-buster-backports: variables: SALSA_CI_LINTIAN_FAIL_WARNING: 1 DEB_BUILD_OPTIONS: 'nocheck' + +# Try to override the lintian version being used to the just built +# version. +.test-lintian: &test-lintian + before_script: + - apt-get update + - apt-get install -y ${WORKING_DIR}/lintian_*.deb View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f0f98771e8ebab8bc86c959c023a65339532e167 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f0f98771e8ebab8bc86c959c023a65339532e167 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][salsa-debug] Make "lintian --version" emit versions unique per commit
Axel Beckert pushed to branch salsa-debug at lintian / lintian Commits: 287d4230 by Axel Beckert at 2023-01-02T14:23:18+01:00 Make "lintian --version" emit versions unique per commit It previously only added the amount of commits since last release to the patch version if it was at zero. Which is anything but the claimed "Semantic Versioning". - - - - - 1 changed file: - lib/Lintian/Version.pm Changes: = lib/Lintian/Version.pm = @@ -83,15 +83,20 @@ sub version_from_git { return $EMPTY unless -d $git_path; +# Example outputs: +# 2.115.3-49-g086a9a113 +# 2.115.3-49-g086a9a113-dirty my $describe - = decode_utf8(safe_qx('git', "--git-dir=$git_path", 'describe')); + = decode_utf8(safe_qx('git', "--git-dir=$git_path", 'describe', '--dirty')); chomp $describe; -my ($guess, $step, $commit) = split(/-/, $describe); -return $EMPTY - unless defined $step; - -$guess =~ s/ [.] 0 $/.$step/sx; +# Modify it to make it a valid native version number and make it +# look more debianish like these: +# 2.115.3+49commits+git086a9a113 +# 2.115.3+49commits+git086a9a113+dirty +my $guess = $describe; +$guess =~ s/ - ( \d+ ) -g /+${1}commits+git/sx; +$guess =~ s/ - /+/sxg; return ($guess // $EMPTY); } View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/287d4230e7f234afcb2a814efbf0cff01f58f61a -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/287d4230e7f234afcb2a814efbf0cff01f58f61a You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch dh-vim-addon
Axel Beckert pushed new branch dh-vim-addon at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/dh-vim-addon You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: dh-sequence-vim-addon pulls in dh-vim-addon
Axel Beckert pushed to branch master at lintian / lintian Commits: 4cc5a245 by Edward Betts at 2023-01-02T14:39:38+01:00 dh-sequence-vim-addon pulls in dh-vim-addon Fix false positive for missing-build-dependency-for-dh-addon when a package Build-Depends on dh-sequence-vim-addon. - - - - - 089a22f4 by Russ Allbery at 2023-01-02T14:48:45+01:00 Fix typo in "dh-sequence-vim-addon pulls in dh-vim-addon" Gbp-Dch: Ignore - - - - - 1 changed file: - lib/Lintian/Check/Debhelper.pm Changes: = lib/Lintian/Check/Debhelper.pm = @@ -125,6 +125,7 @@ my %DH_ADDON_MANUAL_PREREQUISITES = ( 'sphinx:any | python-sphinx:any | python3-sphinx:any | dh-sequence-sphinxdoc:any', systemd => 'debhelper:any (>= 9.20160709~) | debhelper-compat:any | dh-sequence-systemd:any | dh-systemd:any', +vim_addon => 'dh-vim-addon:any | dh-sequence-vim-addon:any', ); sub visit_patched_files { View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/f0f98771e8ebab8bc86c959c023a65339532e167...089a22f48baa8cb8aca42cb8a4b53471a94e3fcf -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/f0f98771e8ebab8bc86c959c023a65339532e167...089a22f48baa8cb8aca42cb8a4b53471a94e3fcf You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] missing-systemd-service-for-init.d-script: Mention future deprecation of generator
Axel Beckert pushed to branch master at lintian / lintian Commits: 4ce38e3c by Luca Boccassi at 2023-01-02T17:02:59+01:00 missing-systemd-service-for-init.d-script: Mention future deprecation of generator The generator will be deprecated in the future, so packages without a unit file will stop working. [Committer's note: This is half of MR !407 which was authored by Luca as a single commit. Hence I've changed to first line of the commit message accordingly.] - - - - - 1 changed file: - tags/m/missing-systemd-service-for-init.d-script.tag Changes: = tags/m/missing-systemd-service-for-init.d-script.tag = @@ -5,6 +5,7 @@ Explanation: The specified init.d script has no equivalent systemd service. . Whilst systemd has a SysV init.d script compatibility mode, providing native systemd support has many advantages such as being able to specify - security hardening features. + security hardening features. Moreover, the systemd SysV generator will be + deprecated in the future. . Please provide a suitable .service file for this script. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/4ce38e3ccb9c5fee9e4f99d55b3bc93b7f3d7c61 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/4ce38e3ccb9c5fee9e4f99d55b3bc93b7f3d7c61 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Make "lintian --version" emit versions unique per commit
Axel Beckert pushed to branch master at lintian / lintian Commits: 9b6ce500 by Axel Beckert at 2023-01-02T21:15:13+01:00 Make "lintian --version" emit versions unique per commit It previously only added the amount of commits since last release to the patch version if it was at zero. Which is anything but the claimed "Semantic Versioning". - - - - - e45c1668 by Axel Beckert at 2023-01-02T21:15:13+01:00 Make lib/Lintian/Version.pm perltidy again Gbp-Dch: Ignore - - - - - 1 changed file: - lib/Lintian/Version.pm Changes: = lib/Lintian/Version.pm = @@ -83,15 +83,20 @@ sub version_from_git { return $EMPTY unless -d $git_path; -my $describe - = decode_utf8(safe_qx('git', "--git-dir=$git_path", 'describe')); +# Example outputs: +# 2.115.3-49-g086a9a113 +# 2.115.3-49-g086a9a113-dirty +my $describe = decode_utf8( +safe_qx('git', "--git-dir=$git_path", 'describe', '--dirty')); chomp $describe; -my ($guess, $step, $commit) = split(/-/, $describe); -return $EMPTY - unless defined $step; - -$guess =~ s/ [.] 0 $/.$step/sx; +# Modify it to make it a valid native version number and make it +# look more debianish like these: +# 2.115.3+49commits+git086a9a113 +# 2.115.3+49commits+git086a9a113+dirty +my $guess = $describe; +$guess =~ s/ - ( \d+ ) -g /+${1}commits+git/sx; +$guess =~ s/ - /+/sxg; return ($guess // $EMPTY); } View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/37770b159e9cb222c8357fcb645456507445f3ca...e45c166839b78dbbe8f1b30d3c64d1fe7f504ce0 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/37770b159e9cb222c8357fcb645456507445f3ca...e45c166839b78dbbe8f1b30d3c64d1fe7f504ce0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 4 commits: inconsistent-appstream-metadata-license: Versions with trailing ".0" are...
Axel Beckert pushed to branch master at lintian / lintian Commits: 2348bca3 by Axel Beckert at 2023-01-16T01:10:28+01:00 inconsistent-appstream-metadata-license: Versions with trailing ".0" are equivalent to versions without Fixes false positives as the Debian Copyright Format 1.0 explicitly states that versions with trailing dot-zeroes are considered to be equivalent to versions without. Closes: #1002053 Relevant documentation: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name - - - - - 3721f292 by Axel Beckert at 2023-01-16T01:10:39+01:00 inconsistent-appstream-metadata-license: Normalize comparison (-or-later/+, -only suffix) Further normalize comparison of Debian style and SPDX style license identifiers to -or-later suffix vs + suffix, -only suffix vs no suffix. Still display the original variant in the tag. Relevant documentation/policy: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name (Also make new code perltidy.) - - - - - e48f1d48 by Axel Beckert at 2023-01-16T01:27:45+01:00 inconsistent-appstream-metadata-license description: Text improvements; direct ref to tag specification Closes: #1014956 - - - - - bf82908d by Christoph Biedl at 2023-01-16T01:40:03+01:00 Lintian::Index::FileTypes: Call "file" with "--raw" to unbreak test suite with file/libmagic ≥ 5.42 Closes: #1026920 - - - - - 3 changed files: - lib/Lintian/Check/Debian/Copyright/Dep5.pm - lib/Lintian/Index/FileTypes.pm - tags/i/inconsistent-appstream-metadata-license.tag Changes: = lib/Lintian/Check/Debian/Copyright/Dep5.pm = @@ -852,8 +852,30 @@ sub check_dep5_copyright { next unless $seen; +# Compare and also normalize the seen and wanted license +# identifier wrt. to redundant trailing dot-zeros, +# -or-later suffix vs + suffix, -only suffix vs no +# suffix. Still display the original variant in the tag. +my $seen_normalized = $seen; +$seen_normalized =~ s/-or-later$/+/i; +$seen_normalized =~ s/-only$//i; +my $seen_nozero = $seen_normalized; +$seen_nozero =~ s/\.0//g; + my @wanted = @{$license_identifiers_by_file{$name}}; -my @mismatched = grep { $_ ne $seen } @wanted; +my @mismatched = grep { +my $want = $_; +my $want_normalized = $want; +$want_normalized =~ s/-or-later$/+/i; +$want_normalized =~ s/-only$//i; +my $want_nozero = $want_normalized; +$want_nozero =~ s/\.0//g; + +$want_normalized ne $seen_normalized + and $want_nozero ne $seen_normalized + and $want_normalized ne $seen_nozero + and $want_nozero ne $seen_nozero; +} @wanted; $self->pointed_hint('inconsistent-appstream-metadata-license', $copyright_file->pointer, $name, "($seen != $_)") = lib/Lintian/Index/FileTypes.pm = @@ -72,7 +72,7 @@ sub add_file_types { my @files = grep { $_->is_file } @{$self->sorted_list}; my @names = map { $_->name } @files; -my @command = qw(file --no-pad --print0 --print0 --); +my @command = qw(file --raw --no-pad --print0 --print0 --); my %file_types; = tags/i/inconsistent-appstream-metadata-license.tag = @@ -2,7 +2,9 @@ Tag: inconsistent-appstream-metadata-license Severity: warning Check: debian/copyright/dep5 Explanation: The specified AppStream metadata file specifies a - metadata_license field but this does not match the files in + metadata_license field but this does not match + its entry (possibly via the Files: * stanza) in debian/copyright. See-Also: https://wiki.debian.org/AppStream/Guidelines, - https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ + https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, + https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/6bf8452625fb7ebbbad0af23a225557ac146dd99...bf82908d338b9125ed5ba737d50bdfd85f829bee -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/6bf8452625fb7ebbbad0af23a225557ac146dd99...bf82908d338b9125ed5ba737d50bdfd85f829bee You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix false positive for license-problem-php-license for pear.php.net source code
Axel Beckert pushed to branch master at lintian / lintian Commits: 53f5b4d2 by William Desportes at 2023-01-16T02:54:14+00:00 Fix false positive for license-problem-php-license for pear.php.net source code - - - - - 2 changed files: - lib/Lintian/Check/Cruft.pm - tags/l/license-problem-php-license.tag Changes: = lib/Lintian/Check/Cruft.pm = @@ -657,7 +657,7 @@ sub php_source_whitelist { return 0 if defined $copyright_path && $copyright_path->bytes - =~ m{^Source: https?://pecl.php.net/package/.*$}m; + =~ m{^Source: https?://(pecl|pear).php.net/package/.*$}m; return 0 if $self->processable->source_name =~ /^php\d*(?:\.\d+)?$/xms; = tags/l/license-problem-php-license.tag = @@ -5,6 +5,6 @@ Explanation: This package appears to be covered by version 3.0 (exactly) of the PHP license. This license is not applicable to anything that is not PHP and has no contributions from the PHP Group. . - This tag is not emitted for packages from pecl.php.net as determined by + This tag is not emitted for packages from pecl.php.net or pear.php.net as determined by the Source: field in debian/copyright. See-Also: https://ftp-master.debian.org/REJECT-FAQ.html View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/53f5b4d23ae17d7468efe92b999cfb38d8b6c799 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/53f5b4d23ae17d7468efe92b999cfb38d8b6c799 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: debian/control: Bump Standards-Version in Description to 4.6.2
Axel Beckert pushed to branch master at lintian / lintian Commits: 861bcc1e by Axel Beckert at 2023-01-17T01:53:09+01:00 debian/control: Bump Standards-Version in Description to 4.6.2 Gbp-Dch: Ignore - - - - - abf85a66 by Axel Beckert at 2023-01-17T02:15:44+01:00 run-private-scripts.t: Do not run auto-reject-diff as it requires network access. - - - - - 08d50d35 by Axel Beckert at 2023-01-17T02:42:56+01:00 run-private-scripts.t: Skip generate-tag-summary without git - - - - - 2 changed files: - debian/control - t/scripts/run-private-scripts.t Changes: = debian/control = @@ -168,4 +168,4 @@ Description: Debian package checker compliance with Debian policy. Every Debian maintainer should check packages with this tool before uploading them to the archive. . - This version of Lintian is calibrated for Debian Policy version 4.6.1. + This version of Lintian is calibrated for Debian Policy version 4.6.2. = t/scripts/run-private-scripts.t = @@ -24,7 +24,7 @@ use warnings; use Const::Fast; use IPC::Run3; -use Test::More tests => 3; +use Test::More tests => 2; const my $DOT => q{.}; const my $WAIT_STATUS_SHIFT => 8; @@ -59,12 +59,15 @@ sub t { return; } -t('auto-reject-diff', qr/Found \d+ certain/); -t( -'generate-tag-summary', -qr/Assuming commit range to be/, -qr/^No tags were added or removed$|\A\Z/ -); +SKIP: { +skip('Only works with git', 1) unless -x '/usr/bin/git' && -d '.git'; + +t( +'generate-tag-summary', +qr/Assuming commit range to be/, +qr/^No tags were added or removed$|\A\Z/ +); +} t('latest-policy-version', qr/^(\d+\.){3}/); done_testing(); View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/a3c688e61d78413f3c631a6db720c14f4e6e46b2...08d50d35e7a6481808e9b54f3f3d77d09309a445 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/a3c688e61d78413f3c631a6db720c14f4e6e46b2...08d50d35e7a6481808e9b54f3f3d77d09309a445 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.0
Axel Beckert pushed new tag 2.116.0 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] bitbucket.org no more supports Mercurial
Axel Beckert pushed to branch master at lintian / lintian Commits: 78d9ec4f by Axel Beckert at 2023-01-17T08:06:55+01:00 bitbucket.org no more supports Mercurial https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket - - - - - 1 changed file: - data/fields/vcs-hosters Changes: = data/fields/vcs-hosters = @@ -28,4 +28,4 @@ git://gitorious\.org/ ~~ Git git://[a-zA-Z0-9]+\.branchable\.com/ ~~ Git git://repo\.or\.cz/~~ Git https?://repo\.or\.cz/ ~~ Git -https?://bitbucket\.org/ ~~ Git,Hg +https?://bitbucket\.org/ ~~ Git View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/78d9ec4f37cc61125c9ad2b694b04512010700e2 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/78d9ec4f37cc61125c9ad2b694b04512010700e2 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix a boolean precedence issue in the additional condition of MR !442
Axel Beckert pushed to branch master at lintian / lintian Commits: 438a8252 by Axel Beckert at 2023-01-18T12:18:48+01:00 Fix a boolean precedence issue in the additional condition of MR !442 Gbp-Dch: Ignore - - - - - 1 changed file: - lib/Lintian/Check/Documentation.pm Changes: = lib/Lintian/Check/Documentation.pm = @@ -124,8 +124,8 @@ sub visit_installed_files { =~ m{^ usr/share/doc/ (?:.+/)? (?:doxygen|html) / .* [.]map [.] $regex }sx; if ($item->is_file -&& any { $item->basename =~ m{$_}xi } @DOCUMENTATION_FILE_REGEXES -&& any { $item->basename !~ m{$_}xi } @NOT_DOCUMENTATION_FILE_REGEXES) { +and any { $item->basename =~ m{$_}xi } @DOCUMENTATION_FILE_REGEXES +and any { $item->basename !~ m{$_}xi } @NOT_DOCUMENTATION_FILE_REGEXES) { $self->pointed_hint( 'package-contains-documentation-outside-usr-share-doc', View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/438a82523dc66c765d356df4205dff90647d63ea -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/438a82523dc66c765d356df4205dff90647d63ea You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.1
Axel Beckert pushed new tag 2.116.1 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.1 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Release and upload as 2.116.1 to unstable
Axel Beckert pushed to branch master at lintian / lintian Commits: 0a783122 by Axel Beckert at 2023-01-23T03:37:24+01:00 Release and upload as 2.116.1 to unstable - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,8 +1,34 @@ -lintian (2.116.1~git) UNRELEASED; urgency=medium +lintian (2.116.1) unstable; urgency=medium - * WIP (generated at release time: please do not add entries below). + The "No More Neglected Autopkgtest Architectures" Release. - -- Axel Beckert Tue, 17 Jan 2023 08:03:32 +0100 + [ Axel Beckert ] + * bitbucket.org no more supports Mercurial. + * [Testsuite] Fix armhf+i386-only test binaries-missing-lfs. Should fix +autopkgtest on these architectures. + * unknown-section description: Factorize explanations to avoid repitions +as suggested by Cyril Brulebois. (See also below.) + * Fix remaining i386 testsuite issues due to missing brackets. + * Don't emit inconsistent-appstream-metadata-license with "MIT != +Expat". (Closes: #1029055) + * Update Lintian User's Manual for pointed hints in tags and overrides. +Thanks to Soren Stoutner. (Closes: #1029177) + * Whitelist Autobuild, Go-Import-Path, and Ruby-Versions from +unknown-field. (Closes: #1014885) + * Don't emit spare-manual-page for binaries in /usr/libexec/. +(Closes: #1027744) + * Refresh static data. + * data/java/constants: Default is now Java17, versions available up to Java21. + + [ Cyril Brulebois ] + * Add non-free-firmware to known archive areas. + + [ William Desportes ] + * Fix lintian package-contains-documentation-outside-usr-share-doc +matches python files and robots.txt. (Closes: #997987, #976636) + * Add more typo fixes. + + -- Axel Beckert Mon, 23 Jan 2023 03:32:04 +0100 lintian (2.116.0) unstable; urgency=medium View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/0a783122b55c331290d8d4956447d6b8ce02 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/0a783122b55c331290d8d4956447d6b8ce02 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Add testsuite check for missing-pkg-php-tools-addon false positive with...
Axel Beckert pushed to branch master at lintian / lintian Commits: 1a794ba7 by Axel Beckert at 2023-01-28T23:18:17+01:00 Add testsuite check for missing-pkg-php-tools-addon false positive with dh-sequence-phpcomposer (see MR !438) - - - - - 472de40c by William Desportes at 2023-01-28T23:23:58+01:00 missing-pkg-php-tools-addon: Allow dh-sequence-phpcomposer as alternative to pkg-php-tools-addon (perltidy variant of MR !438) - - - - - 7 changed files: - lib/Lintian/Check/Languages/Php/Pear.pm - + t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/debian/control.in - + t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/fill-values - + t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/composer.json - + t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/foo.php - + t/recipes/checks/languages/php/pear/phppear-composerok/eval/desc - + t/recipes/checks/languages/php/pear/phppear-composerok/eval/hints Changes: = lib/Lintian/Check/Languages/Php/Pear.pm = @@ -149,7 +149,8 @@ sub source { $self->pointed_hint('composer-package-without-pkg-php-tools-builddep', $composer_json->pointer) if defined $composer_json - && !$build_depends->satisfies('pkg-php-tools') + && !($build_depends->satisfies('pkg-php-tools') +|| $build_depends->satisfies('dh-sequence-phpcomposer')) && !defined $package_xml && !defined $package2_xml; = t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/debian/control.in = @@ -0,0 +1,20 @@ +Source: [% $source %] +Priority: optional +Section: [% $section %] +Maintainer: [% $author %] +Standards-Version: [% $standards_version %] +Build-Depends: [% $build_depends %], dh-sequence-phpcomposer, php-dev, dh-php +Rules-Requires-Root: no + +Package: [% $source %] +Architecture: [% $package_architecture %] +Depends: ${misc:Depends}, ${phppear:Debian-Depends} +Recommends: ${phppear:Debian-Recommends} +Breaks: ${phppear:Debian-Breaks} +Description: ${phppear:summary} + This is a test package designed to exercise some feature or tag of + Lintian. It is part of the Lintian test suite and may do very odd + things. It should not be installed like a regular package. It may + be an empty package. + . + ${phppear:description} = t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/fill-values = @@ -0,0 +1,3 @@ +Testname: phppear-composerok +Description: Composer phppear tests with dh-sequence-phpcomposer +Skeleton: upload-non-native = t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/composer.json = @@ -0,0 +1 @@ +{} = t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/foo.php = = t/recipes/checks/languages/php/pear/phppear-composerok/eval/desc = @@ -0,0 +1,4 @@ +Testname: phppear-composerok +Test-Against: + missing-pkg-php-tools-addon +Check: languages/php/pear = t/recipes/checks/languages/php/pear/phppear-composerok/eval/hints = View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/5400667211bf4af86265d579cfe743c7a43cc992...472de40cabc960117f18ca0cb7562840ed36fe18 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/5400667211bf4af86265d579cfe743c7a43cc992...472de40cabc960117f18ca0cb7562840ed36fe18 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Lintian::Check::Files::SourceMissing: Ignore files in debian/missing-sources/
Axel Beckert pushed to branch master at lintian / lintian Commits: 81c4d841 by William Desportes at 2023-01-29T00:22:23+01:00 Lintian::Check::Files::SourceMissing: Ignore files in debian/missing-sources/ Fixes false positives in tags source-is-missing, source-contains-prebuilt-javascript-object and friends. Gbp-Dch: Full - - - - - 1 changed file: - lib/Lintian/Check/Files/SourceMissing.pm Changes: = lib/Lintian/Check/Files/SourceMissing.pm = @@ -55,6 +55,9 @@ sub visit_patched_files { return unless $item->is_file; +return + if $item->dirname =~ m{^debian/missing-sources/}; + # prebuilt-file or forbidden file type $self->pointed_hint('source-contains-prebuilt-wasm-binary', $item->pointer) if $item->file_type =~ m{^WebAssembly \s \(wasm\) \s binary \s module}x; View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/81c4d8416161a5e69004d22e8760b2f5d0e0e1e5 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/81c4d8416161a5e69004d22e8760b2f5d0e0e1e5 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.2
Axel Beckert pushed new tag 2.116.2 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.2 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Release as 2.116.2 and upload to unstable
Axel Beckert pushed to branch master at lintian / lintian Commits: a89ceb5f by Axel Beckert at 2023-01-29T09:54:24+01:00 Release as 2.116.2 and upload to unstable - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,11 +1,61 @@ -lintian (2.116.2~git) UNRELEASED; urgency=medium +lintian (2.116.2) unstable; urgency=medium + The "FFP2 (Fixing False Positives, too)" Release. + + [ Axel Beckert ] * Add private script to automate post release version bump. * Fix typo in previous debian/changelog entry. Thanks Lintian! ;-) - --- - * WIP (generated at release time: please do not add entries below.) + * Mention that #1024039 got closed by 2.116.1 in its changelog entry. + * [Testsuite] Check tag files and docs with spellintian. Thanks to +Sylvestre Ledru for noticing the typos this check now finds. + * Fix duplicate words and one more typo found by +spellintian-textual-content.t. + * "currectly" can be a misspelling of "correctly" or "currently" + * Fix spellintian false positives found by spellintian-textual-content.t: ++ "these package" followed by a plural, e.g. "these package sections", ++ Double word with closing parenthesis inbetween. (So far only opening + parentheses were whitelisted.) + * Add testsuite check for missing-pkg-php-tools-addon false positive +with dh-sequence-phpcomposer. (See MR !438.) + * Add testsuite check for a vcs-field-has-unexpected-spaces false +positive. (See #1023155 and MR !422.) + * debian-rules-uses-unnecessary-dh-argument: Also report found and +minimum dh compat level. Additionally also rephrase tag description to +no more say "this debhelper compatibility level". Thanks to Anthony +Fok for making us aware of the issue in MR !451. + + [ Cyril Brulebois ] + * Teach the is_non_free attribute about the non-free-firmware section. + * Stop checking for Standards-Version for installer-only (i.e. udeb) +packages. (Closes: #991533) + + [ Andreas Beckmann ] + * backports-upload-has-incorrect-version-number: Fix salsaci version +regexp again. (Closes: #1024361) + + [ Sylvestre Ledru ] + * Fix some typos in the doc. + + [ William Desportes ] + * missing-pkg-php-tools-addon: Allow dh-sequence-phpcomposer as +alternative to pkg-php-tools-addon. + * Lintian::Check::Files::SourceMissing: Ignore files in +debian/missing-sources/. Fixes false positives in source-is-missing, +source-contains-prebuilt-javascript-object and friends. + + [ Tino Didriksen ] + * vcs-field-has-unexpected-spaces: Allow any order of git branch and +path. (Closes: #1023155) Thanks to Bradford D. Boyle for the bug +report. + + [ Johannes Schauer Marin Rodrigues ] + * Multiarch terminology: Use "qualifier" instead of "acceptor": Update +tag descriptions of rules-require-build-prerequisite and +missing-build-depends-for-clean-target-in-debian-rules. Also rename +method multiarch_acceptor() to multiarch_qualifier() in + Lintian::Relation::Predicate. - -- Axel Beckert Mon, 23 Jan 2023 12:46:07 +0100 + -- Axel Beckert Sun, 29 Jan 2023 09:32:16 +0100 lintian (2.116.1) unstable; urgency=medium @@ -27,7 +77,8 @@ lintian (2.116.1) unstable; urgency=medium * Don't emit spare-manual-page for binaries in /usr/libexec/. (Closes: #1027744) * Refresh static data. - * data/java/constants: Default is now Java17, versions available up to Java21. + * data/java/constants: Default is now Java17, versions available up to +Java21. (Closes: #1024039) [ Cyril Brulebois ] * Add non-free-firmware to known archive areas. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/a89ceb5f25e5e45d97a7f26c7dd9971a7a1de51d -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/a89ceb5f25e5e45d97a7f26c7dd9971a7a1de51d You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Post-release version bump
Axel Beckert pushed to branch master at lintian / lintian Commits: d59fdac4 by Axel Beckert at 2023-01-29T16:34:44+01:00 Post-release version bump Gbp-Dch: Ignore - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,3 +1,9 @@ +lintian (2.116.3~git) UNRELEASED; urgency=medium + + * WIP (generated at release time: please do not add entries below.) + + -- Axel Beckert Sun, 29 Jan 2023 16:34:44 +0100 + lintian (2.116.2) unstable; urgency=medium The "FFP2 (Fixing False Positives, too)" Release. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d59fdac4686191ad9605fa8a51c9348017b840ab -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d59fdac4686191ad9605fa8a51c9348017b840ab You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Release and upload as 2.116.3 to unstable
Axel Beckert pushed to branch master at lintian / lintian Commits: cac78dd8 by Axel Beckert at 2023-02-05T10:29:00+01:00 Release and upload as 2.116.3 to unstable - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,8 +1,19 @@ -lintian (2.116.3~git) UNRELEASED; urgency=medium +lintian (2.116.3) unstable; urgency=medium - * WIP (generated at release time: please do not add entries below.) + The "FFP3 (Fixing False Positives, Three Small Changes)" Release. - -- Axel Beckert Sun, 29 Jan 2023 16:34:44 +0100 + [ Axel Beckert ] + * Refresh data. (Loong64 removed from two lists, some fonts and dh_cruft +added.) + + [ Simon McVittie ] + * obsolete-packages: libegl1-mesa-dev is not obsolete. + + [ Andreas Beckmann ] + * archive-liberty-mismatch: Add exception for 'non-free-firmware binary +package build from non-free source package'. (Closes: #1030325) + + -- Axel Beckert Sun, 05 Feb 2023 09:10:20 +0100 lintian (2.116.2) unstable; urgency=medium View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cac78dd88e1171e88ee8c3d6f5b1155b8081863d -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cac78dd88e1171e88ee8c3d6f5b1155b8081863d You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.3
Axel Beckert pushed new tag 2.116.3 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.3 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Post-release version bump
Axel Beckert pushed to branch master at lintian / lintian Commits: 1e177f85 by Axel Beckert at 2023-02-05T11:30:30+01:00 Post-release version bump Gbp-Dch: Ignore - - - - - d50a732a by Andreas Beckmann at 2023-02-05T11:37:36+01:00 dh_dkms is now provided by dh-dkms instead of dkms (See #1013417) Gbp-Dch: Full - - - - - 2 changed files: - debian/changelog - lib/Lintian/Check/Debhelper.pm Changes: = debian/changelog = @@ -1,3 +1,9 @@ +lintian (2.116.4~git) UNRELEASED; urgency=medium + + * WIP (generated at release time: please do not add entries below.) + + -- Axel Beckert Sun, 05 Feb 2023 11:30:30 +0100 + lintian (2.116.3) unstable; urgency=medium The "FFP3 (Fixing False Positives, Three Small Changes)" Release. = lib/Lintian/Check/Debhelper.pm = @@ -81,7 +81,7 @@ my %DH_COMMAND_MANUAL_PREREQUISITES = ( 'dh-autoreconf:any | debhelper:any (>= 9.20160403~) | debhelper-compat:any', dh_autoreconf => 'dh-autoreconf:any | debhelper:any (>= 9.20160403~) | debhelper-compat:any', -dh_dkms => 'dkms:any | dh-sequence-dkms:any', +dh_dkms => 'dh-dkms:any | dh-sequence-dkms:any', dh_girepository => 'gobject-introspection:any | dh-sequence-gir:any', dh_gnome => 'gnome-pkg-tools:any | dh-sequence-gnome:any', dh_gnome_clean => 'gnome-pkg-tools:any | dh-sequence-gnome:any', View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/cac78dd88e1171e88ee8c3d6f5b1155b8081863d...d50a732a00a7596d078a9e8f6919cb6362ca0067 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/cac78dd88e1171e88ee8c3d6f5b1155b8081863d...d50a732a00a7596d078a9e8f6919cb6362ca0067 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix "Use of uninitialized value $LINTIAN_CFG" in debug output
Axel Beckert pushed to branch master at lintian / lintian Commits: f03fc15a by Axel Beckert at 2023-03-05T16:26:04+01:00 Fix "Use of uninitialized value $LINTIAN_CFG" in debug output - - - - - 1 changed file: - bin/lintian Changes: = bin/lintian = @@ -614,7 +614,7 @@ unless (@ARGV || $selected{'packages-from-file'}) { if ($selected{debug}) { say {*STDERR} encode_utf8("Lintian v$ENV{LINTIAN_VERSION}"); say {*STDERR} encode_utf8("Lintian root directory: $ENV{LINTIAN_BASE}"); -say {*STDERR} encode_utf8("Configuration file: $LINTIAN_CFG"); +say {*STDERR} encode_utf8('Configuration file: '.($LINTIAN_CFG//'(none)')); } if (defined $selected{LINTIAN_PROFILE}) { View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f03fc15a45df4965e374b1e3a40c51cf6fe545ed -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f03fc15a45df4965e374b1e3a40c51cf6fe545ed You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Add "noble" as a known Ubuntu distribution.
Axel Beckert pushed to branch master at lintian / lintian Commits: e48c525b by Simon Quigley at 2023-10-20T08:53:59-05:00 Add "noble" as a known Ubuntu distribution. - - - - - 1 changed file: - vendors/ubuntu/main/data/changes-file/known-dists Changes: = vendors/ubuntu/main/data/changes-file/known-dists = @@ -34,3 +34,4 @@ jammy kinetic lunar mantic +noble View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e48c525bacef15a9a22d4ccba88084fcfe531109 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e48c525bacef15a9a22d4ccba88084fcfe531109 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] arch-regex: add loong64 support
Axel Beckert pushed to branch master at lintian / lintian Commits: 32710afb by Jiajie Chen at 2023-10-25T23:55:22+08:00 arch-regex: add loong64 support - - - - - 1 changed file: - data/binaries/arch-regex Changes: = data/binaries/arch-regex = @@ -35,6 +35,7 @@ i386 ~~^ELF 32-bit LSB .* 80386, .* (?:GNU/Linux|(?!GNU)).*$ ia64 ~~^ELF 64-bit LSB .* IA-64 kfreebsd-amd64~~^ELF 64-bit LSB .* x86-64, .* (?:GNU/kFreeBSD|(?!GNU)).*$ kfreebsd-i386 ~~^ELF 32-bit LSB .* 80386, .* (?:GNU/kFreeBSD|(?!GNU)).*$ +loong64 ~~^ELF 64-bit LSB .* LoongArch lpia ~~^ELF 32-bit LSB .* 80386, .* (?:GNU/Linux|(?!GNU)).*$ m32r ~~^ELF 32-bit MSB .* M32R m68k ~~^ELF 32-bit MSB .* 680[02]0 View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/32710afb323d923fe3d188c765d75ce1f395e448 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/32710afb323d923fe3d188c765d75ce1f395e448 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Run perltidy on lib/Lintian/Check/AppstreamMetadata.pm
Axel Beckert pushed to branch master at lintian / lintian Commits: f1c99de5 by Axel Beckert at 2024-02-04T21:13:09+01:00 Run perltidy on lib/Lintian/Check/AppstreamMetadata.pm Gbp-Dch: Ignore - - - - - 1 changed file: - lib/Lintian/Check/AppstreamMetadata.pm Changes: = lib/Lintian/Check/AppstreamMetadata.pm = @@ -97,8 +97,8 @@ sub installable { foreach my $lib_dir (qw(usr/lib lib)) { if ( defined( -my $dir = -$processable->installed->resolve_path("$lib_dir/udev/rules.d/") +my $dir = $processable->installed->resolve_path( +"$lib_dir/udev/rules.d/") ) ) { for my $item ($dir->descendants) { View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f1c99de500180c2b67ed3f383401f36a20ab1d32 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f1c99de500180c2b67ed3f383401f36a20ab1d32 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Some more usrmerge-related test suite fine-tuning
Axel Beckert pushed to branch master at lintian / lintian Commits: b69e7747 by Axel Beckert at 2024-02-05T00:10:20+01:00 Some more usrmerge-related test suite fine-tuning Git-Dch: Ignore - - - - - 2 changed files: - t/recipes/checks/systemd/kill-mode-none/eval/hints - t/recipes/checks/systemd/service-file-no-install-key/build-spec/debian/install Changes: = t/recipes/checks/systemd/kill-mode-none/eval/hints = @@ -1,2 +1,2 @@ kill-mode-none (binary): systemd-service-file-missing-hardening-features [usr/lib/systemd/system/kill-mode-none.service] -kill-mode-none (binary): kill-mode-none lib/systemd/system/kill-mode-none.service [usr/lib/systemd/system/kill-mode-none.service] +kill-mode-none (binary): kill-mode-none usr/lib/systemd/system/kill-mode-none.service [usr/lib/systemd/system/kill-mode-none.service] = t/recipes/checks/systemd/service-file-no-install-key/build-spec/debian/install = @@ -1 +1 @@ -debian/no-install.service lib/systemd/system/ +debian/no-install.service usr/lib/systemd/system/ View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b69e774798c3c63992b869739421ac3bb2c2948f -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b69e774798c3c63992b869739421ac3bb2c2948f You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Add build-depedency on debhleper ≥ 13.11.8~ if the test suite is run at build-time
Axel Beckert pushed to branch master at lintian / lintian Commits: 6940c6a8 by Axel Beckert at 2024-02-05T01:28:37+01:00 Add build-depedency on debhleper ≥ 13.11.8~ if the test suite is run at build-time - - - - - c9b6c94c by Axel Beckert at 2024-02-05T01:28:52+01:00 L::C::B::Corrupted::check_elf_issues(): Return immediately if file is no ELF file Thanks: Corvin Köhne via MR !486 I implemented it differently than Corvin to avoid code duplication and to be more future proof in case non-ELF issues will be checked in the future with visit_*_files(). - - - - - 2 changed files: - debian/control - lib/Lintian/Check/Binaries/Corrupted.pm Changes: = debian/control = @@ -9,6 +9,7 @@ Build-Depends: aspell , aspell-en , cdbs , + debhelper (>= 13.11.8~) , debhelper-compat (= 13), default-jdk-headless | default-jdk , dh-elpa | bash (<< 4.4) , = lib/Lintian/Check/Binaries/Corrupted.pm = @@ -53,6 +53,8 @@ sub visit_installed_files { sub check_elf_issues { my ($self, $item) = @_; +return unless $item->is_elf; + for (uniq @{$item->elf->{ERRORS} // []}) { $self->pointed_hint('elf-error',$item->pointer, $_) unless ( View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/b69e774798c3c63992b869739421ac3bb2c2948f...c9b6c94c91e3c142c172dce9d51f82b08dfad69d -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/b69e774798c3c63992b869739421ac3bb2c2948f...c9b6c94c91e3c142c172dce9d51f82b08dfad69d You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] obsolete-packages: another common old Builld-Dep
Axel Beckert pushed to branch master at lintian / lintian Commits: 151989ab by Alexandre Detiste at 2024-02-05T00:42:44+00:00 obsolete-packages: another common old Builld-Dep - - - - - 1 changed file: - data/fields/obsolete-packages Changes: = data/fields/obsolete-packages = @@ -151,6 +151,7 @@ libgsasl7-dev => libgsasl-dev libidn11-dev => libidn-dev policykit-1 => polkitd and optionally pkexec lsb-base +pkg-config => pkgconf # Deprecated in trixie gnome-common => https://wiki.gnome.org/Projects/GnomeCommon/Migration View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/151989ab43db9082c02a75e5d3683fe0bbd6c4cc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/151989ab43db9082c02a75e5d3683fe0bbd6c4cc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: Add *~ to .gitignore
Axel Beckert pushed to branch master at lintian / lintian Commits: 5bffcd9a by Richard Lewis at 2024-02-05T00:50:58+00:00 Add *~ to .gitignore - - - - - 40f26ce4 by Richard Lewis at 2024-02-05T00:50:58+00:00 Add test that demonstrates bug #1019690 lintian exits with code 2 when --show-overrides is given and an error is fixed. The test added will fail: the next commit will fix lintian so it passes. - - - - - 372ac9c8 by Richard Lewis at 2024-02-05T00:50:58+00:00 Fix exit code when --show-overrides is given and an 'error' tag is overridden Previously, if an error tag was overridden but --show-overrides was given, lintian would correctly override the tag, but incorrectly give an exit code of 2. The reason is a logic error in lib/Lintian/Pool.pm in the code from lines 173-212 The whole block seems to be attempting to: - skip hints (tags) that should not be displayed (experimental, or at a too-low display-level) - count number of errors/warnings that remain (used in line 217 to set exit code) - keep hints that should be displayed (line 211) Because on line 194, if an 'error' tag is overridden and --show-overrides is given the block decided not to call next (because keeping the hint doesnt happen until line 211). But then line 197 is executed which means that the hint is counted as a warning/error/etc whenever show-overrides was present: effectively show-overrides makes it look like no override was present. (And then on line 217 the exit_code will be set to 2). This patch therefore changes 197 to only run the sub-block if an override was not defined. - - - - - 8 changed files: - .gitignore - lib/Lintian/Pool.pm - + t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/install - + t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/lintian-overrides - + t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/fill-values - + t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/orig/file - + t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/desc - + t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/literal Changes: = .gitignore = @@ -17,6 +17,7 @@ /.idea/ /.nobackup *.bak +*~ *.rej cover_db* /coverage-report = lib/Lintian/Pool.pm = @@ -191,8 +191,7 @@ sub process{ next unless $PROFILE->display_level_for_tag($hint->tag_name); -if (!defined $hint->override -|| $option->{'show-overrides'}) { +if (!defined $hint->override) { ++$reported_count{$tag->visibility} if !$tag->experimental; = t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/install = @@ -0,0 +1 @@ +file /usr/share/file = t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/lintian-overrides = @@ -0,0 +1,2 @@ +# package installs a d/rules template not a script +missing-dep-for-interpreter /usr/bin/make * = t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/fill-values = @@ -0,0 +1,3 @@ +Skeleton: upload-native +Testname: show-overrides-exit-status +Description: Bug #1019690 correct exit status when show-overrides = t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/orig/file = @@ -0,0 +1,4 @@ +#!/usr/bin/make -f + +%: + dh $@ --with elpa = t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/desc = @@ -0,0 +1,6 @@ +Testname: show-overrides-exit-status +Check: scripts +Exit-Status: 0 +Match-Strategy: literal +Output-Format: EWI +Default-Lintian-Options: --show-overrides --fail-on error = t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/literal = @@ -0,0 +1,2 @@ +N: package installs a d/rules template not a script +O: show-overrides-exit-status: missing-dep-for-interpreter /usr/bin/make (does not satisfy make:any | build-essential:any | dpkg-dev:any) [usr/share/file/file] View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/151989ab43db9082c02a75e5d3683fe0bbd6c4cc...372ac9c821c29df356378c9ec3f66dd7cefb94ce -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/151989ab43db9082c02a75e5d3683fe0bbd6c4cc...372ac9
[Git][lintian/lintian][master] Don't emit source-nmu-has-incorrect-version-number for stable updates
Axel Beckert pushed to branch master at lintian / lintian Commits: 79d146ac by Emilio Pozuelo Monfort at 2024-02-05T00:56:05+00:00 Don't emit source-nmu-has-incorrect-version-number for stable updates Closes: #1022759 - - - - - 1 changed file: - lib/Lintian/Check/Nmu.pm Changes: = lib/Lintian/Check/Nmu.pm = @@ -102,6 +102,7 @@ sub source { my $version_nmuness = 0; my $version_local = 0; my $upload_is_backport = $version =~ m/~bpo(\d+)\+(\d+)$/; +my $upload_is_stable_update = $version =~ m/~deb(\d+)u(\d+)$/; if ($version =~ /-[^.-]+(\.[^.-]+)?(\.[^.-]+)?$/) { $version_nmuness = 1 if defined $1; @@ -158,6 +159,7 @@ sub source { $pointer, $version) if $upload_is_nmu && $version_nmuness != 1 + && !$upload_is_stable_update && !$upload_is_backport; } View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/79d146acb7b4784cea4e7cd705de9f9854e98bd6 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/79d146acb7b4784cea4e7cd705de9f9854e98bd6 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Allow @recommends@ as autopkgtest dependency
Axel Beckert pushed to branch master at lintian / lintian Commits: c738fa47 by Valentin Vidic at 2024-02-05T02:30:13+00:00 Allow @recommends@ as autopkgtest dependency Replaces deprecated needs-recommends. - - - - - 1 changed file: - lib/Lintian/Check/Testsuite.pm Changes: = lib/Lintian/Check/Testsuite.pm = @@ -62,6 +62,7 @@ our $PYTHON3_ALL_DEPEND my %KNOWN_SPECIAL_DEPENDS = map { $_ => 1 } qw( @ @builddeps@ + @recommends@ ); sub source { View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/c738fa474b4b0e737edece78c8553a6fc76442d7 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/c738fa474b4b0e737edece78c8553a6fc76442d7 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Salsa CI: Drop backports to bullseye (oldstable): We expect a newer debhelper
Axel Beckert pushed to branch master at lintian / lintian Commits: cd755962 by Axel Beckert at 2024-02-05T03:55:52+01:00 Salsa CI: Drop backports to bullseye (oldstable): We expect a newer debhelper ... for the test suite to pass as it now uses path as present after dh_movetousr has been run. And despite the build profile "nocheck" is passed, "apt build-dep" in bullseye tries to satisfy "<!nocheck>" build-dependencies nevertheless and hence fails to install an older version of debhelper, despite it would have been fine. - - - - - 1 changed file: - debian/salsa-ci.yml Changes: = debian/salsa-ci.yml = @@ -16,13 +16,6 @@ build-bookworm-backports: extends: .build-package allow_failure: true -build-bullseye-backports: - variables: -RELEASE: 'bullseye-backports' -DEB_BUILD_OPTIONS: 'nocheck' - extends: .build-package - allow_failure: true - variables: SALSA_CI_DISABLE_BLHC: 1 SALSA_CI_DISABLE_BUILD_PACKAGE_ANY: 1 View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cd7559626912ade82df64ea4474008fb56ec3970 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cd7559626912ade82df64ea4474008fb56ec3970 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] private/generate-tag-summary --in-place: Avoid mojibake by not double-encoding UTF-8
Axel Beckert pushed to branch master at lintian / lintian Commits: 4fd76dc5 by Axel Beckert at 2024-02-05T21:34:04+01:00 private/generate-tag-summary --in-place: Avoid mojibake by not double-encoding UTF-8 - - - - - 1 changed file: - private/generate-tag-summary Changes: = private/generate-tag-summary = @@ -95,7 +95,7 @@ if ($opt{'in-place'}) { or die encode_utf8("Cannot open $infile"); my $outfile = 'debian/changelog.tmp'; -open(my $out_fd, '>:encoding(UTF-8)', $outfile) +open(my $out_fd, '>', $outfile) or die encode_utf8("Cannot open $outfile"); while (my $line = <$in_fd>) { View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/4fd76dc585013a0a5ff646797385514721f1ad3b -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/4fd76dc585013a0a5ff646797385514721f1ad3b You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.117.0
Axel Beckert pushed new tag 2.117.0 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.117.0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Post-release version bump
Axel Beckert pushed to branch master at lintian / lintian Commits: f2746dd7 by Axel Beckert at 2024-02-05T23:25:47+01:00 Post-release version bump Gbp-Dch: Ignore - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,3 +1,9 @@ +lintian (2.117.1~git) UNRELEASED; urgency=medium + + * WIP (generated at release time: please do not add entries below.) + + -- Axel Beckert Mon, 05 Feb 2024 23:25:47 +0100 + lintian (2.117.0) unstable; urgency=low The "One Year Later" Release. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Retroactively mention #1033894 in previous changelog entry
Axel Beckert pushed to branch master at lintian / lintian Commits: 66e9477a by Axel Beckert at 2024-02-06T08:16:00+01:00 Retroactively mention #1033894 in previous changelog entry We normaly should never do that as it breaks "gbp dch". Unless nothing else than the debian/changelog has been changed since a release. As in this case. :-) - - - - - 27896ef1 by Axel Beckert at 2024-02-06T08:24:22+01:00 data/changes-file/known-dists: Add trixie and forky - - - - - 2 changed files: - data/changes-file/known-dists - debian/changelog Changes: = data/changes-file/known-dists = @@ -11,6 +11,8 @@ stretch buster bullseye bookworm +trixie +forky sid # Aliases @@ -19,4 +21,3 @@ stable testing unstable experimental - = debian/changelog = @@ -1,5 +1,8 @@ lintian (2.117.1~git) UNRELEASED; urgency=medium + [ Axel Beckert ] + * Retroactively mention #1033894 in previous changelog entry. + * WIP (generated at release time: please do not add entries below.) -- Axel Beckert Mon, 05 Feb 2024 23:25:47 +0100 @@ -55,7 +58,7 @@ lintian (2.117.0) unstable; urgency=low [ Nilesh Patra ] * Make lintian recognize fasttrack as a dist. - * Update known dists and oldstable epoch. + * Update known dists and oldstable epoch. (Closes: #1033894) * autopkgtest fix: Update badnocredit.raw for updated Adobe license tag check. * Fix rootless-builds.txt location in lintian tags. (Closes: #1051538) View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a...27896ef12c526253ca5f9d49967d1670550f6597 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a...27896ef12c526253ca5f9d49967d1670550f6597 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] ci: check longer timeout for autopkgtest
Axel Beckert pushed to branch master at lintian / lintian Commits: 3678cc5a by Kentaro Hayashi at 2024-05-06T00:08:56+09:00 ci: check longer timeout for autopkgtest The default value of CI_JOB_TIMEOUT is 1h (3600), but autopkgtest will not finish in 1 hour generally. lintian/lintian CI/CD setting of timeout is extended to 3h, but not true for forked/contributors lintian CI/CD settings - so it always fail. This MR aimed to fix warn such a situation in advance. Signed-off-by: Kentaro Hayashi <ken...@gmail.com> - - - - - 1 changed file: - debian/salsa-ci.yml Changes: = debian/salsa-ci.yml = @@ -28,3 +28,13 @@ variables: before_script: - apt-get update - apt-get install -y ${WORKING_DIR}/lintian_*.deb + +# Try to check whether the maximum job timeout is extended to longer one. +.test-autopkgtest: &test-autopkgtest + before_script: +- 'echo "CI/CD Settings / General pipelines / Timeout: $CI_JOB_TIMEOUT seconds"' +- | + if [[ $CI_JOB_TIMEOUT -le 3600 ]]; then +echo -e "\e[31;1mERROR: CI/CD Settings / General pipelines / Timeout is too short ($CI_JOB_TIMEOUT). Use longer timeout - e.g. 7200 (2h) is enough.\e[0m" +exit 1 + fi View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/3678cc5ac32075ce91496168b692aa7c2fbd7d85 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/3678cc5ac32075ce91496168b692aa7c2fbd7d85 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Upgrade the severity of missing-systemd-service-for-init.d-script from warning to error
Axel Beckert pushed to branch master at lintian / lintian Commits: 5faaefd9 by Luca Boccassi at 2024-05-05T21:17:29+00:00 Upgrade the severity of missing-systemd-service-for-init.d-script from warning to error The generator will be deprecated during the Trixie dev cycle, so packages without a unit file will stop working. Policy has been updated accordingly: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039102 - - - - - 1 changed file: - tags/m/missing-systemd-service-for-init.d-script.tag Changes: = tags/m/missing-systemd-service-for-init.d-script.tag = @@ -1,5 +1,5 @@ Tag: missing-systemd-service-for-init.d-script -Severity: warning +Severity: error Check: systemd Explanation: The specified init.d script has no equivalent systemd service. . View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/5faaefd9f0c11c4bc5ab12b0bc713459e041de93 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/5faaefd9f0c11c4bc5ab12b0bc713459e041de93 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: Fix regex replacement for transition suffix g
Axel Beckert pushed to branch master at lintian / lintian Commits: b2561ac7 by Mattias Ellert at 2024-05-06T00:04:04+00:00 Fix regex replacement for transition suffix g The replacement should remove a final g after a digit, but leave the digit in place, e.g. libpam0g → libpam0 and libgjs0g → libgjs0. - - - - - a4c658ff by Mattias Ellert at 2024-05-06T00:04:04+00:00 Only remove transition suffices when preceded by a digit - - - - - 07167eeb by Mattias Ellert at 2024-05-06T00:04:04+00:00 Add transition suffix t64 for 64 bit time_t transition - - - - - 1 changed file: - lib/Lintian/Check/Libraries/Shared/Soname.pm Changes: = lib/Lintian/Check/Libraries/Shared/Soname.pm = @@ -83,11 +83,12 @@ sub installable { # try to strip transition strings my $shortened_name = $self->processable->name; -$shortened_name =~ s/c102\b//; -$shortened_name =~ s/c2a?\b//; -$shortened_name =~ s/\dg$//; -$shortened_name =~ s/gf$//; -$shortened_name =~ s/v[5-6]$//; # GCC-5 / libstdc++6 C11 ABI breakage +$shortened_name =~ s/(\d)c102$/$1/; +$shortened_name =~ s/(\d)c2a?$/$1/; +$shortened_name =~ s/(\d)g$/$1/; +$shortened_name =~ s/(\d)gf$/$1/; +$shortened_name =~ s/(\d)v[56]$/$1/; # GCC-5 / libstdc++6 C11 ABI breakage +$shortened_name =~ s/(\d)t64$/$1/; # 64 bit time_t $shortened_name =~ s/-udeb$//; $shortened_name =~ s/^lib64/lib/; View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/dfc03ef87409473bc76e287fa2fd25b388f2e214...07167eebb697d74d84627b275d8aeff4ebf32f7e -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/dfc03ef87409473bc76e287fa2fd25b388f2e214...07167eebb697d74d84627b275d8aeff4ebf32f7e You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Improve CONTRIBUTING.md
Axel Beckert pushed to branch master at lintian / lintian Commits: 1df38cf7 by William Desportes at 2024-05-06T00:25:44+00:00 Improve CONTRIBUTING.md - - - - - 1 changed file: - CONTRIBUTING.md Changes: = CONTRIBUTING.md = @@ -152,7 +152,7 @@ will show you further options. ### Calibrating tests to fix test failures -If tests fail, the teststuite will use an interactive 'calibration' +If tests fail, the testsuite will use an interactive 'calibration' process to help you write or amend a 'hints' file. Simply follow the instructions on the screen. In many cases, it is best to "accept all" and examine the changes in git. In complex cases, you can use @@ -173,6 +173,25 @@ configure perltidy in a special way. Please run it from the repository's base directory. Otherwise it will not find the custom configuration, and the test suite will not pass. +### Run perltidy + +The program perltidy is provided by the package [perltidy](https://packages.debian.org/perltidy). +The program prove is provided by the package [perl](https://packages.debian.org/perl). + + On all files + +```sh +prove -l t/scripts/01-critic/ +``` + +### On recently changed files + +On the 10 last commits + +```sh +git diff --name-only HEAD~10 HEAD | grep -F ".pm" | xargs perltidy -b +``` + ### Submit a merge request Once all the above is done, please push your changes to your Lintian View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/1df38cf7438ff9fd8b389f61be715ec85e4d3e98 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/1df38cf7438ff9fd8b389f61be715ec85e4d3e98 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] wrong-path-for-interpreter: allow aliased locations
Axel Beckert pushed to branch master at lintian / lintian Commits: 9266486e by Luca Boccassi at 2024-05-06T01:57:46+01:00 wrong-path-for-interpreter: allow aliased locations merged-usr is mandatory in Debian since Bookworm (and much longer ago in Ubuntu), so /usr/bin/bash is a valid path, as is /bin/python3. Detect and ignore these instances. Closes: #1051338 - - - - - 2 changed files: - lib/Lintian/Check/Scripts.pm - t/recipes/checks/scripts/scripts-control-interpreters/eval/hints Changes: = lib/Lintian/Check/Scripts.pm = @@ -47,6 +47,7 @@ const my $NOT_EQUAL => q{!=}; const my $BAD_MAINTAINER_COMMAND_FIELDS => 5; const my $UNVERSIONED_INTERPRETER_FIELDS => 2; const my $VERSIONED_INTERPRETER_FIELDS => 5; +const my $USR_PREFIX_LENGTH => 4; use Moo; use namespace::clean; @@ -692,10 +693,17 @@ sub visit_control_files { 'incorrect-path-for-interpreter' : 'wrong-path-for-interpreter'; +# Debian is now mandatory usr-merged, so /bin/sh and /usr/bin/sh are both acceptable +if ($expected =~ '^(/bin/|/sbin/)') { +$expected = '(?:/usr)?' . $expected; +} elsif ($expected =~ '^/usr(/bin/|/sbin/)') { +$expected = '(?:/usr)?' . substr($expected, $USR_PREFIX_LENGTH); +} + $self->pointed_hint( $tag_name, $item->pointer, $interpreter, $NOT_EQUAL, $expected -)unless $interpreter eq $expected; +)unless $interpreter =~ $expected; } elsif ($item->name eq 'config') { $self->pointed_hint('forbidden-config-interpreter', @@ -716,10 +724,17 @@ sub visit_control_files { 'incorrect-path-for-interpreter' : 'wrong-path-for-interpreter'; +# Debian is now mandatory usr-merged, so /bin/sh and /usr/bin/sh are both acceptable +if ($expected =~ '^(/bin/|/sbin/)') { +$expected = '(?:/usr)?' . $expected; +} elsif ($expected =~ '^/usr(/bin/|/sbin/)') { +$expected = '(?:/usr)?' . substr($expected, $USR_PREFIX_LENGTH); +} + $self->pointed_hint( $tag_name, $item->pointer, $interpreter, $NOT_EQUAL, $expected -)unless $interpreter eq $expected; +)unless $interpreter =~ $expected; $self->pointed_hint('unusual-control-interpreter', $item->pointer, $interpreter); = t/recipes/checks/scripts/scripts-control-interpreters/eval/hints = @@ -9,8 +9,6 @@ scripts-control-interpreters-prepython (binary): unusual-control-interpreter /us scripts-control-interpreters-prepython (binary): unusual-control-interpreter /usr/bin/python3 [postinst] scripts-control-interpreters-prepython (binary): maintainer-script-interpreter /usr/bin/python3 [preinst] scripts-control-interpreters-prepython (binary): maintainer-script-interpreter /usr/bin/python3 [postinst] -scripts-control-interpreters-paths (binary): wrong-path-for-interpreter /usr/bin/bash != /bin/bash [postinst] -scripts-control-interpreters-paths (binary): wrong-path-for-interpreter /bin/python3 != /usr/bin/python3 [prerm] scripts-control-interpreters-paths (binary): unusual-control-interpreter /bin/python3 [prerm] scripts-control-interpreters-paths (binary): maintainer-script-interpreter /usr/local/bin/bash [preinst] scripts-control-interpreters-paths (binary): maintainer-script-interpreter /usr/bin/bash [postinst] View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/9266486e228fa9dcc20e6500f909c7b3c07b93b0 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/9266486e228fa9dcc20e6500f909c7b3c07b93b0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix inconsistencies in documentation of lintian-explain-tags
Axel Beckert pushed to branch master at lintian / lintian Commits: b5146d82 by Edu Gómez Escandell at 2024-05-06T01:20:20+00:00 Fix inconsistencies in documentation of lintian-explain-tags - - - - - 2 changed files: - bin/lintian-explain-tags - man/lintian-explain-tags.pod Changes: = bin/lintian-explain-tags = @@ -151,7 +151,7 @@ Usage: $NEW_PROGRAM_NAME [log-file...] ... Options: -l, --list-tagslist all tags Lintian knows about --t, --tag, --tags display tag descriptions +-t, --tag, --tags this option has no effect. --include-dir DIR check for Lintian data in DIR --profile Xuse vendor profile X to determine severities --output-width NUM set output width instead of probing terminal = man/lintian-explain-tags.pod = @@ -26,7 +26,7 @@ lintian-explain-tags - offer more information about Lintian's tags =head1 SYNOPSIS -B B<--tags> I ... +B I ... =head1 DESCRIPTION View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b5146d82b452c0503f98a836e40409fb20cd09d7 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b5146d82b452c0503f98a836e40409fb20cd09d7 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Salsa-CI: Extend autopkgtest job timeout to 3h by default
Axel Beckert pushed to branch master at lintian / lintian Commits: 2b05a303 by Otto Kekäläinen at 2024-05-22T20:25:13-07:00 Salsa-CI: Extend autopkgtest job timeout to 3h by default Looking at current open MRs for Lintian, nearly all of them fail on autopkgtest timing out. Seems contributors are not looking at the CI output and reading the error. Fix this by forcing the timeout to 3h directly from within the GitLab CI definition. This renders the existing `before_script` section obsolete, but keep it still around as fall-back to satisfy those who have concerns that the `timeout` might not always work. - - - - - 1 changed file: - debian/salsa-ci.yml Changes: = debian/salsa-ci.yml = @@ -29,8 +29,11 @@ variables: - apt-get update - apt-get install -y ${WORKING_DIR}/lintian_*.deb -# Try to check whether the maximum job timeout is extended to longer one. .test-autopkgtest: &test-autopkgtest + # Extend Salsa-CI build jobs to have longer timeout as the default GitLab + # timeout (1h) is often not enough. + timeout: 3h + # Try to check whether the maximum job timeout is extended to longer one. before_script: - 'echo "CI/CD Settings / General pipelines / Timeout: $CI_JOB_TIMEOUT seconds"' - | View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/2b05a303b2ebe4afa92b4b79e61f31c8bee0ae47 -- This project does not include diff previews in email notifications. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/2b05a303b2ebe4afa92b4b79e61f31c8bee0ae47 You're receiving this email because of your account on salsa.debian.org.