Re: RFS: hivex
On Sun, 2010-05-09 at 12:35 +0800, Paul Wise wrote:
Looks like some symbols dissappeared from libhivex0, which now causes
the package to FTBFS because dpkg-gensymbols fails. I'm assuming they
were the private symbols that are now hidden. I'd suggest removing
them from the symbols file in that case.
Yes, done. I think I was asleep at the wheel because I totally neglected
to do any build tests for some reason - sorry for wasting your time on
that!
Apart from that, the package looks fairly good. I'm unable to commit
to sponsoring it though, hopefully you'll find someone else with the
ongoing time to do so.
Thanks, I'll work on that.
Remaining minor stuff:
lintian:
W: libwin-hivex-perl: maintainer-not-full-name TJ
I: libwin-hivex-perl: unused-override libhivex-perl binary:
maintainer-not-full-name
Aha! I forgot to change the specified library name when making the Perl
package-name adjustments.
I: libwin-hivex-perl: spelling-error-in-manpage
usr/share/man/man3/Win::Hivex::Regedit.3pm.gz reencode re-encode
Looks like this one escaped upstream when they patched. I'll chase that
up and add a manual patch for now.
E: libwin-hivex-perl: binary-or-shlib-defines-rpath
./usr/lib/perl5/auto/Win/Hivex/Hivex.so
/tmp/buildd/hivex-1.2.2/perl/../lib/.libs
Hmmm, another rpath issue. Don't recall seeing that in previous reports.
I'll ask upstream about it. Hope I don't have to re-implement the
chrpath workaround again.
As a matter of interest, would you mind sharing the lintian commands you
use since it is still something of a mystery to me. I use one command
against the source package but I'm guessing now you're running it
against each binary package too? In fact, it'd help me a great deal to
understand the entire process you go through in doing the review - if I
can do that before uploading it'd probably make for cleaner, better,
uploads and less iterations.
dpkg-gencontrol: warning: package hivex: unused substitution variable
${perl:Depends}
I recall removing this from debian/control and it resulting in a bunch
of other messages so I put it back in. I'll remove it again and look
more closely at the build log this time.
You may want to look at debhelper 7 instead of cdbs:
https://penta.debconf.org/dc9_schedule/events/418.en.html
I feel more comfortable with CDBS since I like simple-patchsys, although
now upstream has incorporated my patches it is no longer used. Reading
those slides didn't really help and I don't have time to listen to the
presentation but it mostly made my eyes glaze over :p
You may want to look at DEP-5 for the copyright file:
http://dep.debian.net/deps/dep5/
Crikey, another format to master :p
I've started on it but it looks to be slightly involved for hivex since
the current copyright is different for Makefiles and programs and
libraries and language bindings - figuring out the patterns for the
File specifications is going to be 'fun'.
debian/libhivex0.install can be reduced to one line: usr/lib/libhivex.so.*
Ahh yes, that list of libraries was a leftover from getting the split
between the -dev and library packages correct.
Is it nessecary to ship the static library? and the .la file?
Probably not, but which would be preferred in the -dev package? Looking
at other -dev packages there doesn't seem to be a clear preference.
README probably isn't nessecary to ship in libhivex0, possibly the
same for libhivex-ocaml and perl packages.
I think I was enjoying the easy life of not having to figure out/write
the rules to prevent the installation. I'm finding after a certain point
the need to find yet more documentation on how to fine-tune the package
becomes tiresome.
It would be nice if the package descriptions were less template-like
and describe the individual packages instead of the whole hivex
project. Consider the audience for each package description when
writing them. For example libhivex0 will almost always be
auto-installed, so it can have a minimal description.
I see your point - changed.
I'll upload the changes in the next day or so. Thanks for the great
feedback.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1273501743.10980.81.ca...@hephaestion
Re: RFS: hivex
I've uploaded 1.2.2-1 to mentors. This version is based on the new
upstream release that incorporates various changes to fix issues
discovered during Debian packaging.
This version still contains my packaging tracking notes in debian/. If
this version is considered ready I'll remove those notes and upload a
final 1.2.2-2 ready for the archive.
The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/h/hivex
- Source repository: deb-src http://mentors.debian.net/debian unstable main
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/h/hivex/hivex_1.2.2-1.dsc
Summary of actions for this iteration:
* ACTION: Add quilt debian/patches/series with current patch listed.
* ACTION: Added project mailing-list posting URL to patch according to DEP-3.
* ACTION: Add *.lintian-overrides for binary packages.
* ACTION: Run automake to update various Makefile.in.
* ACTION: Moved hivex man-page to libhivex-dev.
* ACTION: removed some ${shlibs:Depends} to quiet build warnings.
* PENDING: Reported RPATH issue to project mailing-list.
UPDATE: upstream accept this is a bug but not sure how to fix as yet.
UPDATE: fixed upstream.
* PENDING: man-page spelling errors reported to project mailing-list.
UPDATE: upstream applied corrected spelling.
* PENDING: Reported internal/foreign exported symbols issue to project
mailing-list.
UPDATE: upstream accepted this and will correct.
* PENDING: Asked on project mailing list about hivexsh dependency on
libncurses.
UPDATE: upstream has offered a patch for testing which resolves this.
* PENDING: Asked on debian-perl mailing list about correct naming of
libhivex-perl.
UPDATE: Binary package name *should* be libwin-hivex-perl. Changed.
* TODO: wait for upstream to release new tarball incorporating accepted fixes
and rebuild
with new version number.
UPDATE: New upstream release 1.2.2
* TODO: remove build-depend on chrpath and debian/rules statement after
upstream publish new release.
UPDATE: Done.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1273312259.10980.15.ca...@hephaestion
Re: RFS: hivex
On Fri, 2010-04-02 at 12:00 +0800, Paul Wise wrote:
A review of your package:
Great, thanks. As a result I've learned a lot about areas of Debian
packaging I've never really needed to master before, but I've got a
headache and vacant expression to go with it :)
I've uploaded 1.2.1-2 to mentors for further review.
The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/h/hivex
- Source repository: deb-src http://mentors.debian.net/debian unstable main
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/h/hivex/hivex_1.2.1-2.dsc
I'm keeping track of RFS responses and my actions in the file
debian/Debian-Mentor-RFS-Feedback.txt. This and other superfluous text
files will be removed once the package is ready.
I've figured out how to use lintian now - beforehand I was quite hazy on
it. Aside from some trivial issues (documented in my feedback) none of
the warnings or errors you revealed occur for this build.
Here's a summary of my actions:
* INFO: debian/copyright-questions.txt,
debian/ubuntu-bug-report-needs-packaging.txt and
debian/Debian-Mentor-RFS-Feedback.txt
and other text files are being kept as working notes and records of
actions whilst doing the packaging
and will be removed once the package is ready for the 'real' world.
* INFO: lintian override maintainer-not-full-name is to make clear I *am*
using my *full name* and don't want
to be told don't use initials when I'm not (had that several times in
past few years with Ubuntu).
* ACTION: Removed comments and blank lines from debian/watch.
* ACTION: Removed debian/patches/02_Do_not_clean_pkg-config_script.patch:
It is the debian/rules clean that is removing
./hivex.pc by doing a make distclean on the source. As ./configure
rebuilds it this isn't a real problem except
when building the debian source package.
* TODO: removal of hivex.pc by packaging distclean needs investigating and
fixing.
* PENDING: Have mailed the libguestfs list regarding the Makefile patches to
fully clean up, and regarding the pod2html
complaints.
UPDATE: upstream replied accepting my Makefile patch once their git repo
is working (hardware problems). pod2html issues
are caused by a bug in pod2html; upstream author is happy with the output
(which is primarily for the libguestfs web-site,
not the binary packages).
* ACTION: Have added Forwarded and Last-Update to
debian/patches/01_Makefiles_clean_all_built_files.patch
* ACTION: Finally understand what 3.0 (quilt) means: that there is now an
additional package-version-debian.tar.gz
that contains the debian/ directory. Removed CDBS simplepatchsys rule from
debian/rules.
* ACTION: Have mailed the libguestfs list questioning the copyrights: whether
the use of GPL v2 is intentional or the result of
template files. Will await a reply before making changes.
UPDATE: reply received: GPL applies to build scripts and programs, LGPL to
libraries and bindings. Updated debian/copyright.
* ACTION: rename lib package to libhivex0 to match SO-name of library.
* ACTION: move .a .la static libraries .install rules to -dev package.
* ACTION: remove hard-coded Depends: from binary packages in debian/control.
* ACTION: modified debian/control to avoid lintian
duplicate-short-description warnings.
* ACTION: added Section: libdevel to libhivex-dev.
* ACTION: corrected debian/changelog Closes: to Debian bug. (originally
package for my Ubuntu PPA, hence the LP reference).
* ACTION: moved libhivex.so.0 symlink to -dev package.
* ACTION: generated debian/libhivex0.symbols (relaxed version to 1.2.1 from
1.2.1-1).
* ACTION: changed libhivex-perl to Section: perl.
* ACTION: Debian Perl Policy section 2.3
(http://www.debian.org/doc/packaging-manuals/perl-policy/ch-perl.html#s-paths)
seems to
require that perl-module-in-core-directory be resolved by installing these
files to the vendor location.
* ACTION: added ${perl:Depends} to -perl package as recommended in Perl
Policy 4.4.3.
* ACTION: added dh_install excludes for unwanted Perl library files
perllocal.pod and .packlist.
* ACTION: added libhivex-ocaml-dev package to contain development files.
* ACTION: added usr/share/locale to debian/hivex.install to install missing
translations.
* QUESTION: I'm not clear what the expected 'fix' is for libhivex-perl:
binary-or-shlib-defines-rpath? I've read about RPATH
issues (http://wiki.debian.org/RpathIssue) but can't see how it applies in
this case. I'm presuming upstream know what they're
doing setting installation targets for the Perl bindings.
RESOLVED: Build-depend on chrpath and add override to debian/rules.
* QUESTION: Perl Policy 4.2 suggests package name convention ...for module
Foo::Bar is libfoo-bar-perl. That suggests
the package name here should be libwin-hivex-perl, which doesn't 'feel'
correct. Is libhivex-perl acceptable?
*
RFS: hivex
Dear mentors, I am looking for a sponsor for my package hivex. * Package name: hivex Version : 1.2.1-1 Upstream Author : Richard W.M. Jones rjo...@redhat.com * URL : http://libguestfs.org/ * License : LGPL 2.1 Section : utils It builds these binary packages: hivex - Tools for reading and writing Windows Registry hive files libhivex - Tools for reading and writing Windows Registry hive files libhivex-dev - Tools for reading and writing Windows Registry hive files libhivex-ocaml - Tools for reading and writing Windows Registry hive files libhivex-perl - Tools for reading and writing Windows Registry hive files The package appears to be lintian clean. My motivation for maintaining this package is: The library and tools provide a useful facility for os-probe tools to accurately determine the name of the default boot entry in Windows partitions of dual+ boot PCs that can be used by GRUB to correctly name boot entries. The library and tools can also be used by Linux-based diagnostic/repair/configuration tools for Wine and native Windows installations in virtual machine images or on bare hardware. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/h/hivex - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/h/hivex/hivex_1.2.1-1.dsc I would be glad if someone uploaded this package for me. Kind regards TJ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1270169894.2595.19.ca...@hephaestion
