Bug#878909: RFS: xabacus/8.1.3+dfsg1-1 [ITA]

2017-10-19 Thread Adam Borowski
On Thu, Oct 19, 2017 at 06:40:26PM +0200, Innocent De Marchi wrote:
> El Thu, 19 Oct 2017 00:33:52 +0200
> > 
> > There's no need to bother the upstream for a distribution-specific
> > change. That's why the packaging allows arbitrary patches atop what's
> > shipped in the tarball.
> 
> Consequently, what is your proposal? 

Something akin to:

.--==[ debian/{xabacus,xmabacus}.install ]
play.sh /usr/share/games/xabacus/
`

.--==[ debian/rules ]
CONFIGURE_FLAGS := ... \
--enable-def-play=/usr/share/games/xabacus/play.sh
`
(untested)

If the configure rule works, and at the first glance I see no reason why it
wouldn't, there's even no need to patch the source.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ Laws we want back: Poland, Dz.U. 1921 nr.30 poz.177 (also Dz.U. 
⣾⠁⢰⠒⠀⣿⡁ 1920 nr.11 poz.61): Art.2: An official, guilty of accepting a gift
⢿⡄⠘⠷⠚⠋⠀ or another material benefit, or a promise thereof, [in matters
⠈⠳⣄ relevant to duties], shall be punished by death by shooting.



Bug#878909: RFS: xabacus/8.1.3+dfsg1-1 [ITA]

2017-10-18 Thread Adam Borowski
On Wed, Oct 18, 2017 at 07:05:41PM +0200, Innocent De Marchi wrote:
> > 
> > The new version puts a helper script into $PATH: /usr/games/play.sh
> > This doesn't look like a good place for a private helper.  Its name
> > is also pretty generic, not conflicting with other programs only
> > because filename extensions are banned in $PATH (Policy §10.4).
> > 
> > Thus, could you please move it into a private dir?
> > 
> Yes, I see that this is new in version 8.1.0 (not published in Debian). 
> If you change the installation of play.sh to another directory (for
> example to usr/share/games/xabacus) simply the sound does not
> work. If this is to be changed, I will ask the author to change the
> operation of play.sh either by placing it in another directory or by
> changing the name (for example xabacus-play).

There's no need to bother the upstream for a distribution-specific change.
That's why the packaging allows arbitrary patches atop what's shipped in
the tarball.

> It is possible that the author thinks some other system to manage this
> subject.  what do you think?

The helper script's approach doesn't look wrong to me.  It's quite amusing
to see what operating systems are supported by it, though...


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢰⠒⠀⣿⡁ Imagine there are bandits in your house, your kid is bleeding out,
⢿⡄⠘⠷⠚⠋⠀ the house is on fire, and seven big-ass trumpets are playing in the
⠈⠳⣄ sky.  Your cat demands food.  The priority should be obvious...



Bug#878909: RFS: xabacus/8.1.3+dfsg1-1 [ITA]

2017-10-17 Thread Adam Borowski
On Tue, Oct 17, 2017 at 06:39:02PM +0200, Innocent De Marchi wrote:
>  * Package name: xabacus
>Version : 8.1.3+dfsg1-1

>   Changes since the last upload:
> 
>   * New maintainer (Closes: #870519).
>   * Deleted unnecessary sources directory win32 and repackaging.
>   * Update debian/watch file to version 4 and added dversionmangle
> option.
>   * Update Standards-Version (4.1.1):
> - Removed autotools-dev dependency on debian/control.
>   * Added Chris Lamb patch on debian/rules (Closes: #865994).
  ^^
Could you please explain what the patch does?

Kind of like: "Make the build reproducible, thanks Chris Lamb.".

>   * Changed the Priority field to optional from xmabacus 
> on debian/control.
>   * Removed duplicate field Priority on debian/control.
>   * Added Keywords field on debian/*.desktop files.
>   * Removed obsolete menu files on debian directory.
>   * Re-written the debian/copyright file to the standard 1.0 format.

The new version puts a helper script into $PATH: /usr/games/play.sh
This doesn't look like a good place for a private helper.  Its name is also
pretty generic, not conflicting with other programs only because
filename extensions are banned in $PATH (Policy §10.4).

Thus, could you please move it into a private dir?


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢰⠒⠀⣿⡁ Imagine there are bandits in your house, your kid is bleeding out,
⢿⡄⠘⠷⠚⠋⠀ the house is on fire, and seven big-ass trumpets are playing in the
⠈⠳⣄ sky.  Your cat demands food.  The priority should be obvious...



Bug#878909: RFS: xabacus/8.1.3+dfsg1-1 [ITA]

2017-10-17 Thread Innocent De Marchi
Package: sponsorship-requests
Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "xabacus"

 * Package name: xabacus
   Version : 8.1.3+dfsg1-1
   Upstream Author : David A. Bagley 
 * URL : http://www.sillycycle.com/abacus/
 * License : Custom
   Section : games

  It builds those binary packages:

  xabacus- simulation of the ancient calculator (plain X version)
  xmabacus   - simulation of the ancient calculator (Motif version)

  To access further information about this package, please visit the
  following URL:

  https://mentors.debian.net/package/xabacus


  Alternatively, one can download the package with dget using this
  command:

dget -x

https://mentors.debian.net/debian/pool/main/x/xabacus/xabacus_8.1.3+dfsg1-1.dsc

  More information about xabacus can be obtained from
  http://www.sillycycle.com/abacus.html

  Changes since the last upload:

  * New maintainer (Closes: #870519).
  * Deleted unnecessary sources directory win32 and repackaging.
  * Update debian/watch file to version 4 and added dversionmangle
option.
  * Update Standards-Version (4.1.1):
- Removed autotools-dev dependency on debian/control.
  * Added Chris Lamb patch on debian/rules (Closes: #865994).
  * Changed the Priority field to optional from xmabacus 
on debian/control.
  * Removed duplicate field Priority on debian/control.
  * Added Keywords field on debian/*.desktop files.
  * Removed obsolete menu files on debian directory.
  * Re-written the debian/copyright file to the standard 1.0 format.


  Regards,
   Innocent De Marchi