Re: RFS: whohas (bug fixes)
On Sun, Jan 4, 2009 at 9:38 AM, Jonathan Wiltshire > On Wed, Dec 31, 2008 at 11:51:26AM +0900, Paul Wise wrote: >> It might be a good idea to allow some kind of config file to override >> the URLs/regexes, this would be useful for when the external websites >> change and the package has not been updated yet. Could you suggest >> this upstream? > > Yes, it had already occurred to me and I'll suggest it to Philipp > upstream. Another longer-term idea would be to invent an XMLRPC/SOAP/JSON/etc API for enumerating and searching package lists and convince each distro to add that to their package information servers. >> I'd like to wait a few more days before uploading - see how many more >> bugs testers can shake out. If there are no more changes by Sunday, >> I'll upload then. > > I've added another patch to the version on m.d.n under the same number, > but thankfully it's been much quieter the last few days :-) Uploaded, thanks. Also, please ask upstream to remove the .DS_Store file from the tarball. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: whohas (bug fixes)
Hi Paul On Wed, Dec 31, 2008 at 11:51:26AM +0900, Paul Wise wrote: > It might be a good idea to allow some kind of config file to override > the URLs/regexes, this would be useful for when the external websites > change and the package has not been updated yet. Could you suggest > this upstream? Yes, it had already occurred to me and I'll suggest it to Philipp upstream. > I'd like to wait a few more days before uploading - see how many more > bugs testers can shake out. If there are no more changes by Sunday, > I'll upload then. I've added another patch to the version on m.d.n under the same number, but thankfully it's been much quieter the last few days :-) Cheers Jonathan -- Jonathan Wiltshire PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52 Sending of encrypted mail is encouraged signature.asc Description: Digital signature
Re: RFS: whohas (bug fixes)
On Wed, Dec 31, 2008 at 11:38 AM, Jonathan Wiltshire wrote: > Ok, sorry for the noise. I wasn't sure how closely you were watching > -mentors. NP. I watch it quite closely, reading all the mails at least daily. > I've uploaded 0.21-4 to m.d.n which closes bugs 510189, 510231, 510259, > 510152 and 510203. If you've time to take a look and upload that would > be great, I've also sent all the bugs and patches upstream. > > I wondered, with this many bugs opened so soon, if whohas wouldn't be > better suited in experimental, but then again most of them have been > because of incorrect urls in the various package searchers, so perhaps > not. Do you have any thoughts? Its the usual post-accept bug flood, nothing to worry about IMO. It might be a good idea to allow some kind of config file to override the URLs/regexes, this would be useful for when the external websites change and the package has not been updated yet. Could you suggest this upstream? I'd like to wait a few more days before uploading - see how many more bugs testers can shake out. If there are no more changes by Sunday, I'll upload then. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: whohas (bug fixes)
On Tue, Dec 30, 2008 at 10:59:44AM +0900, Paul Wise wrote:
>
> Next time, please depend on ${DPATCH_STAMPFN} instead of patch-stamp
> in debian/rules.
Done.
> For the manual page change, once the manual page is accepted upstream,
> I would suggest a sed command in debian/rules install or binary rather
> than a patch. The file in question will be uncompressed on most
> systems and compressed on Debian, so upstream's manual page should
> just refer to uncompressed intro.txt and Debian should modify it at
> install time. See the nsis package for an (ugly) example of how to do
> this. This way you won't have to refresh the patch every time upstream
> modifies the manual page around the change.
That makes sense; I'll set it up once the manual goes into upstream.
> In future, it is a good idea to document the status of patches
> upstream in the patch header/description.
Done for all existing and new patches.
> PS: I prefer not to be CCed on RFS mails. If have time I'll upload, if
> not someone else will.
Ok, sorry for the noise. I wasn't sure how closely you were watching
-mentors.
I've uploaded 0.21-4 to m.d.n which closes bugs 510189, 510231, 510259,
510152 and 510203. If you've time to take a look and upload that would
be great, I've also sent all the bugs and patches upstream.
I wondered, with this many bugs opened so soon, if whohas wouldn't be
better suited in experimental, but then again most of them have been
because of incorrect urls in the various package searchers, so perhaps
not. Do you have any thoughts?
TIA.
Jonathan
--
Jonathan Wiltshire
PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52
Sending of encrypted mail is encouraged
signature.asc
Description: Digital signature
Re: RFS: whohas (bug fixes)
On Tue, Dec 30, 2008 at 4:48 AM, Jonathan Wiltshire
wrote:
> I've uploaded whohas/0.21-3 to m.d.n which has patches to close bugs
> 5099975, 510019 and 509981. They have gone upstream for his next
> release.
Uploaded.
Next time, please depend on ${DPATCH_STAMPFN} instead of patch-stamp
in debian/rules.
For the manual page change, once the manual page is accepted upstream,
I would suggest a sed command in debian/rules install or binary rather
than a patch. The file in question will be uncompressed on most
systems and compressed on Debian, so upstream's manual page should
just refer to uncompressed intro.txt and Debian should modify it at
install time. See the nsis package for an (ugly) example of how to do
this. This way you won't have to refresh the patch every time upstream
modifies the manual page around the change.
In future, it is a good idea to document the status of patches
upstream in the patch header/description.
PS: I prefer not to be CCed on RFS mails. If have time I'll upload, if
not someone else will.
--
bye,
pabs
http://wiki.debian.org/PaulWise
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
