Re: BTS bot in #debian-python IRC channel

2016-08-14 Thread Ondrej Novy 
Hi,

cool, thanks guys for your opinions.

Created this PL:
https://github.com/sebastinas/debian-devel-changes-bot/pull/1/commits/4988ab91882dbf5f440f6ab2c0024fba022192d5

+1 for moving VCS commits too. Can I send request to KBG-* admins?

-- 
Best regards
 Ondřej Nový

Re: BTS bot in #debian-python IRC channel

2016-08-14 Thread Barry Warsaw 
On Aug 14, 2016, at 01:01 PM, Scott Kitterman wrote:

>On August 14, 2016 12:51:18 PM MDT, "Piotr Ożarowski"  wrote:
>>[Ben Finney, 2016-08-14]  
>>> Would it be a good idea to first have it running in an analogous
>>> channel, ‘#debian-python-changes’?  
>>
>>+1 (I'd move VCS commits messages there too)  
>
>+1 for both.

WFM.  (That's a +1 without just +1'ing :).

-Barry

Re: BTS bot in #debian-python IRC channel

2016-08-14 Thread Scott Kitterman 


On August 14, 2016 12:51:18 PM MDT, "Piotr Ożarowski"  wrote:
>[Ben Finney, 2016-08-14]
>> Would it be a good idea to first have it running in an analogous
>> channel, ‘#debian-python-changes’?
>
>+1 (I'd move VCS commits messages there too)

+1 for both.

Scott K

Re: Help for Python mock test suite needed

2016-08-14 Thread Ben Finney 
Andreas Tille  writes:

> https://paste.debian.net/789238/

That appears to be a simple failure when the test suite is run. The
assertions, as reported, are in the ‘test_srst2’ module:

=
[…]
  File "test_srst2.py", line 213, in test_run_bowtie_with_defaults
run_mock.assert_called_once_with(expected_bowtie2_command)
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 947, in 
assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'run_command' to be called once. Called 0 times.

[…]

  File "test_srst2.py", line 180, in test_run_bowtie_with_overide
run_mock.assert_called_once_with(expected_bowtie2_command)
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 947, in 
assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'run_command' to be called once. Called 0 times.
=

The tracebacks tell you what test case functions are emitting failures:

  File "test_srst2.py", line 213, in test_run_bowtie_with_defaults
  File "test_srst2.py", line 180, in test_run_bowtie_with_overide

Within those test case functions you can see the exact command that was
expected to be run. The assertion is that ‘srst2.run_command’ is
expected to be called (with specific arguments), but is not called,
hence the assertion fails.

-- 
 \ “Don't be afraid of missing opportunities. Behind every failure |
  `\ is an opportunity somebody wishes they had missed.” —Jane |
_o__)  Wagner, via Lily Tomlin |
Ben Finney

Re: BTS bot in #debian-python IRC channel

2016-08-14 Thread Piotr Ożarowski 
[Ben Finney, 2016-08-14]
> Would it be a good idea to first have it running in an analogous
> channel, ‘#debian-python-changes’?

+1 (I'd move VCS commits messages there too)
-- 
Piotr Ożarowski Debian GNU/Linux Developer
www.ozarowski.pl  www.griffith.cc   www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

Re: BTS bot in #debian-python IRC channel

2016-08-14 Thread Ben Finney 
Barry Warsaw  writes:

> On Aug 13, 2016, at 10:48 PM, Ondrej Novy wrote:
>
> >I would like to add BTS bot to IRC channel #debian-python with same
> >notifications (uploads, bug reports) as in #debian-devel-changes
> >filtered to maintainer/uploaders:
>
> I don't *think* I'd mind getting these notifications in irc, but I
> guess I won't know for sure until it happens.

Would it be a good idea to first have it running in an analogous
channel, ‘#debian-python-changes’?

-- 
 \   “You can never entirely stop being what you once were. That's |
  `\   why it's important to be the right person today, and not put it |
_o__) off until tomorrow.” —Larry Wall |
Ben Finney

Re: BTS bot in #debian-python IRC channel

2016-08-14 Thread Barry Warsaw 
On Aug 13, 2016, at 10:48 PM, Ondrej Novy wrote:

>I would like to add BTS bot to IRC channel #debian-python with same
>notifications (uploads, bug reports) as in #debian-devel-changes filtered
>to maintainer/uploaders:

I don't *think* I'd mind getting these notifications in irc, but I guess I
won't know for sure until it happens.  If it's disruptive to real-time
communications (which I think is the most important function of the channel),
then I'd be against it.  But I don't mind an experiment to see if it helps,
hurts, or is neutral.

Cheers,
-Barry

Re: Help for Python mock test suite needed

2016-08-14 Thread Andreas Tille 
On Sun, Aug 14, 2016 at 10:39:37AM +1000, Ben Finney wrote:
> > There is no such link.
> 
> You could make one:
> 
> * Build the package using Sbuild (you are doing this already to ensure
>   the build works cleanly, right?)

I actually uses pbuilder / cowbuilder for this purpose.
 
> * Take the output from the Sbuild run.

I made sure my pbuilder log has LC_ALL=C.

> * Paste that file on .

https://paste.debian.net/789238/

> * Reply here with the link to that complete build log.

Done.  Hope this helps.

> This is an essential tool of collaborating on packaging: Ensure your
> builds are initiated in their entirety with a single command, and all
> output is captured for later inspect. This is why it's important to use
> Sbuild or something equivalent.

I admit I assumed that reproducing the log by doing a local build would
be more interesting but I'm perfectly fine by providing the log as well.
:-)

Kind regards

 Andreas.

-- 
http://fam-tille.de