Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-10-03 Thread Adam Cecile
For the record,

I usually go for github upstream because (as state by other) documentation and 
unittests are usually missing from pypi.
And IMHO, no package should be uploaded without running unittest :-)

Regards, Adam

On September 29, 2021 9:44:13 PM GMT+02:00, Dominik George 
 wrote:
>Hi,
>
>> Could someone please upload this little package ? It's a dependency of
>> xsdata, an awesome XML/dataclasses library I'd like to get into the archive.
>
>uploaded, thanks for your contribution!
>
>One note: I'd consider watching for PyPI instead of GitHub.
>
>Cheers,
>Nik
>


Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Ghislain Vaillant
Le mer. 29 sept. 2021 à 23:14, Dominik George  a
écrit :

>
> > and that will require an upstream new release, which does not help
> > when you want/need to package the current one
>
> Most upstreams kindly make . post releases immediately.
>

I found that to be pretty rare in my own experience.

>
Maybe I am just lucky with upstreams...
>

You are, indeed.


Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Dominik George


> and that will require an upstream new release, which does not help
> when you want/need to package the current one

Most upstreams kindly make . post releases immediately.

Maybe I am just lucky with upstreams...

-nik



Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Sandro Tosi
> That's an upstream bug then, and upstream should fix that and ship a complete 
> source tarball.
>
> I always submit pull requests updating MANIFEST.in and until now, all 
> upstreams have accepted them.

and that will require an upstream new release, which does not help
when you want/need to package the current one.

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi



Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Jeremy Stanley
On 2021-09-29 16:32:05 -0400 (-0400), Sandro Tosi wrote:
> > One note: I'd consider watching for PyPI instead of GitHub.
> 
> there was actually a recent discussion on this list, discouraging
> from using PyPI in favor of github, since GH tarball usually
> contains docs, tests, and other files useful when building from
> source, usually not included in tarball released to users, ie pypi

And as was also pointed out in that discussion, this depends a lot
on the upstream maintainers and their workflow. Some upstreams are
careful to always include all files from the Git worktree within
their sdist tarballs, but may also include required files which
aren't contained in their Git worktree (such as version information,
copyright holders, or release notes extracted from Git tags,
revision history, Git "notes" refs, and so on)... in which cases you
either need their sdist or the full Git repository, since a "GitHub
tarball" of the worktree alone is insufficient to reproduce this
information.

Also since the advent of "wheels" a lot of maintainers are more
willing to make their sdists full archives of their projects (as was
the original intent for a "source distribution" package), since most
users installing directly from PyPI are going to pull a wheel
instead of an sdist when available, and wheels are expected to be
much more pared down anyway.

Like many things in the packaging realm, there is no
one-size-fits-all answer.
-- 
Jeremy Stanley


signature.asc
Description: PGP signature


Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Dominik George


> there was actually a recent discussion on this list, discouraging from
> using PyPI in favor of github, since GH tarball usually contains docs,
> tests, and other files useful when building from source, usually not
> included in tarball released to users, ie pypi

That's an upstream bug then, and upstream should fix that and ship a complete 
source tarball.

I always submit pull requests updating MANIFEST.in and until now, all upstreams 
have accepted them.

-nik



Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Sandro Tosi
> One note: I'd consider watching for PyPI instead of GitHub.

there was actually a recent discussion on this list, discouraging from
using PyPI in favor of github, since GH tarball usually contains docs,
tests, and other files useful when building from source, usually not
included in tarball released to users, ie pypi

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi



Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-29 Thread Dominik George
Hi,

> Could someone please upload this little package ? It's a dependency of
> xsdata, an awesome XML/dataclasses library I'd like to get into the archive.

uploaded, thanks for your contribution!

One note: I'd consider watching for PyPI instead of GitHub.

Cheers,
Nik



Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-28 Thread Adam Cecile
Hi,

Great, I'll be available tomorrow (UTC+2) if you want me to do some changes.

Adam.

On September 28, 2021 11:38:15 PM GMT+02:00, Dominik George 
 wrote:
>Hi,
>
>
>> Could someone please upload this little package ? It's a dependency of 
>> xsdata, an awesome XML/dataclasses library I'd like to get into the archive.
>
>I will check it tomorrow.
>
>-nik


Re: RFS: python-click-default-group: Extension for Python click adding default subcommand to group

2021-09-28 Thread Dominik George
Hi,


> Could someone please upload this little package ? It's a dependency of 
> xsdata, an awesome XML/dataclasses library I'd like to get into the archive.

I will check it tomorrow.

-nik