Re: Request for review/upload of libpff 20180714
Hello, On Wed, Jan 2, 2019 at 4:09 AM Samuel Henrique wrote: > I just noticed another thing, you can update d/watch now to follow github > tags, the upstream started tagging releases recently. Could you please > commit that? I'm not sure if it's worth another upload, but at least it > will be already fixed on git. > Done > Uploaded, Thanks for your work! I suppose reviewing so many changes was not simple :) > Could you please forward the applicable patches upstream? I'll do. Just waited for these patches to pass review. ;) Best wishes, Aleksey
Re: Request for review/upload of libpff 20180714
Hello Aleksey, I just noticed another thing, you can update d/watch now to follow github tags, the upstream started tagging releases recently. Could you please commit that? I'm not sure if it's worth another upload, but at least it will be already fixed on git. Thanks, -- Samuel Henrique
Re: Request for review/upload of libpff 20180714
Sorry, I'm a little tight on time and I forgot to mention that 2. Bumping debhelper compatibility level, I've chosen to test new feature > to use b-depends: debhelper-compat (= 11) without a debian/compat file. > It you insist on the old way (I know no arguments agains the new one), it > can be easily changed. > Doing this becomes a problem if you want to backport a package, I've read somewhere that this is not supported on backported packages and you still have to use the old way. I don't have time to go after the url where I've read that right now (maybe it was on the email that this was announced), but there's a chance that's only gonna be a problem until we release Buster. Anyway that is not a problem as long as you're aware that you have to roll it back for backports, at least for now. Regards, -- Samuel Henrique
Re: Request for review/upload of libpff 20180714
Uploaded, Could you please forward the applicable patches upstream? I sponsored the upload now because we are close to the freeze, but under normal circumstances I would ask you to forward all patches upstream (the ones which are "upstreamable") before sponsoring it, and also use the "Forwarded" tag[0]. Thanks for your work, and a happy new year. [0]https://dep-team.pages.debian.net/deps/dep3/ -- Samuel Henrique
Re: Request for review/upload of libpff 20180714
Hello Aleksey, I was planing to do the upload today, but I ended up not having enough time to review all of the changes. I will do it on 1st January max if nobody does it before myself, so worst case scenario there will still be enough time to fix RC bugs before the freeze and make the package migrate to Testing. -- Samuel Henrique
Request for review/upload of libpff 20180714
Hello team! Freeze is comming! So I would like to remember, that lipff package [1] needs review and to be uploaded. The package contains many changes, the main changes are: 1. New upstream release libpff 20180714 2. Bumping debhelper compatibility level, I've chosen to test new feature to use b-depends: debhelper-compat (= 11) without a debian/compat file. It you insist on the old way (I know no arguments agains the new one), it can be easily changed. 3. The package closes CVE-2018-11723 since the new release fixed the bug beneath the CVE (issues #64 and #66 on libpff github). 4. Fixing lintian warnings of the package manpages required big patches. I've reduced warnings to an unfixable "can't break line" and overrode this one. Please review it! And happy new year! Aleksey. [1] https://salsa.debian.org/pkg-security-team/libpff Forwarded Message Subject:Re: Working as a team, let's take care of all problems Date: Mon, 12 Nov 2018 01:47:47 +0300 From: Aleksey Kravchenko To: Debian Security Tools CC: Eriberto Hello, I've prepared a new release of the libpff package [1]. Please review it. [1] https://salsa.debian.org/pkg-security-team/libpff/ Best wishes, Aleksey. P.S. Thanks to Eriberto, for his suggestions and patches. signature.asc Description: OpenPGP digital signature
