Bug#95951: xlibs: [libICE] message replies do not work properly for subprotocols
Hi Branden, On Tue, Nov 26, 2002 at 07:56:42PM -0500, Branden Robinson wrote: I've attached an updated version of your patch, which applies to xf-4_2-branch. Did you? I've not seen the patch, neither in the mail nor in the bug report log. I hope this helps, Jochen -- Omm (0)-(0) http://www.mathematik.uni-kl.de/~wwwstoch/voss/privat.html msg04917/pgp0.pgp Description: PGP signature
Bug#95951: xlibs: [libICE] message replies do not work properly for subprotocols
On Thu, Nov 28, 2002 at 10:29:38AM +0100, Jochen Voss wrote:
On Tue, Nov 26, 2002 at 07:56:42PM -0500, Branden Robinson wrote:
I've attached an updated version of your patch, which applies to
xf-4_2-branch.
Did you? I've not seen the patch, neither in the mail nor in
the bug report log.
Oops.
--
G. Branden Robinson|
Debian GNU/Linux | // // // / /
[EMAIL PROTECTED] | EI 'AANIIGOO 'AHOOT'E
http://people.debian.org/~branden/ |
--- xc/lib/ICE/process.c~ 2002-11-26 19:40:40.0 -0500
+++ xc/lib/ICE/process.c2002-11-26 19:55:11.0 -0500
@@ -254,9 +254,24 @@
* for the message the client is blocking on. The second is
* the replyWait for the message currently being processed
* by IceProcessMessages. We call it useThisReplyWait.
+*
+* Note also that we translate the opcodes before comparing them,
+* to avoid errors.
*/
- useThisReplyWait = _IceSearchReplyWaits (iceConn, header-majorOpcode);
+ {
+ int op;
+ if (header-majorOpcode == 0)
+ {
+ op = 0;
+ }
+ else
+ {
+ int idx = header-majorOpcode - iceConn-his_min_opcode;
+ op = iceConn-process_msg_info[idx].my_opcode;
+ }
+useThisReplyWait = _IceSearchReplyWaits (iceConn, op);
+ }
}
if (header-majorOpcode == 0)
msg04928/pgp0.pgp
Description: PGP signature
Bug#95951: xlibs: [libICE] message replies do not work properly for subprotocols
Hi Branden, On Tue, Nov 26, 2002 at 07:56:42PM -0500, Branden Robinson wrote: I've attached an updated version of your patch, which applies to xf-4_2-branch. Did you? I've not seen the patch, neither in the mail nor in the bug report log. I hope this helps, Jochen -- Omm (0)-(0) http://www.mathematik.uni-kl.de/~wwwstoch/voss/privat.html pgp7mq8lVaGFg.pgp Description: PGP signature
Bug#95951: xlibs: [libICE] message replies do not work properly for subprotocols
On Thu, Nov 28, 2002 at 10:29:38AM +0100, Jochen Voss wrote:
On Tue, Nov 26, 2002 at 07:56:42PM -0500, Branden Robinson wrote:
I've attached an updated version of your patch, which applies to
xf-4_2-branch.
Did you? I've not seen the patch, neither in the mail nor in
the bug report log.
Oops.
--
G. Branden Robinson|
Debian GNU/Linux | // // // / /
[EMAIL PROTECTED] | EI 'AANIIGOO 'AHOOT'E
http://people.debian.org/~branden/ |
--- xc/lib/ICE/process.c~ 2002-11-26 19:40:40.0 -0500
+++ xc/lib/ICE/process.c2002-11-26 19:55:11.0 -0500
@@ -254,9 +254,24 @@
* for the message the client is blocking on. The second is
* the replyWait for the message currently being processed
* by IceProcessMessages. We call it useThisReplyWait.
+*
+* Note also that we translate the opcodes before comparing them,
+* to avoid errors.
*/
- useThisReplyWait = _IceSearchReplyWaits (iceConn, header-majorOpcode);
+ {
+ int op;
+ if (header-majorOpcode == 0)
+ {
+ op = 0;
+ }
+ else
+ {
+ int idx = header-majorOpcode - iceConn-his_min_opcode;
+ op = iceConn-process_msg_info[idx].my_opcode;
+ }
+useThisReplyWait = _IceSearchReplyWaits (iceConn, op);
+ }
}
if (header-majorOpcode == 0)
pgpeSO8XTySkq.pgp
Description: PGP signature
Bug#95951: xlibs: [libICE] message replies do not work properly for subprotocols
Hi Jochen,
I'm sorry I forgot about this bug. I'm paying attention to it now,
however your code appears to have uncovered another bug in the ICE
library, or maybe in Xtrans:
Core was generated by `./server'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /usr/X11R6/lib/debug/libICE.so.6...done.
Loaded symbols for /usr/X11R6/lib/debug/libICE.so.6
Reading symbols from /lib/libc.so.6...done.
Loaded symbols for /lib/libc.so.6
Reading symbols from /lib/ld-linux.so.2...done.
Loaded symbols for /lib/ld-linux.so.2
Reading symbols from /lib/libnss_files.so.2...done.
Loaded symbols for /lib/libnss_files.so.2
#0 0x40021706 in _IceTransClose (ciptr=0x804b090) at ../../lib/xtrans/Xtrans.c:876
876 ret = ciptr-transptr-Close (ciptr);
(gdb) bt full
#0 0x40021706 in _IceTransClose (ciptr=0x804b090) at ../../lib/xtrans/Xtrans.c:876
ciptr = 0x804b090
ret = 24
#1 0x4001e815 in _IceFreeConnection (iceConn=0x804b0d8) at shutdown.c:287
No locals.
#2 0x4001e68e in IceCloseConnection (iceConn=0x804b0d8) at shutdown.c:130
iceConn = 0x804b0d8
refCountReachedZero = 24
status = 1073905664
#3 0x08048f09 in do_process (ice_conn=0x804b0d8) at server.c:135
ice_conn = 0x804b0d8
status = IceProcessMessagesSuccess
#4 0x08049030 in wait_for_input () at server.c:172
rfds = {__fds_bits = {32, 0 repeats 31 times}}
i = 2
res = 0
#5 0x08049378 in main (argc=1, argv=0xb744) at server.c:311
argc = 0
argv = (char **) 0x0
error_string =
\0\030\001@6\207\004\bÀöÿ¿d\0@\0\0\0\0\017S\216\a öÿ¿\0\027\001@P\030\001@\002\0\0\0\214¦\004@\0à\003@\001\0\0\0\\öÿ¿¨\024\001@\030\034\001@pI\001@löÿ¿ð\217\0@´\035\001@ðâ\003@\001\0\0\0\0\0\0\0dÔ\024@\0\0\0\0\216ÿw\001ðöÿ¿\0\027\001@=Ã\022@ÄÓ\024@|\235\004@¨\024\001@\0\027\001@\210\004\b°öÿ¿ð\217\0@\234\030\001@Àâ\003@\001\0\0\0\0\0\0\0\002V\001@\220]\002@à`\002@Äöÿ¿p\004\b=Ã\022@ÄÓ\024@,\230\004\bÈöÿ¿ßÃ\022@...
opcode = 0
port = 134525072
status = 0
listen_objs = (IceListenObj *) 0x804ae98
listen_count = 2
i = 2
IIRC, some commits were made to Xtrans recently. I'll check this out.
I've attached an updated version of your patch, which applies to
xf-4_2-branch.
--
G. Branden Robinson|If you wish to strive for peace of
Debian GNU/Linux |soul, then believe; if you wish to
[EMAIL PROTECTED] |be a devotee of truth, then
http://people.debian.org/~branden/ |inquire. -- Friedrich Nietzsche
msg04897/pgp0.pgp
Description: PGP signature
Bug#95951: xlibs: [libICE] message replies do not work properly for subprotocols
Hi Jochen,
I'm sorry I forgot about this bug. I'm paying attention to it now,
however your code appears to have uncovered another bug in the ICE
library, or maybe in Xtrans:
Core was generated by `./server'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /usr/X11R6/lib/debug/libICE.so.6...done.
Loaded symbols for /usr/X11R6/lib/debug/libICE.so.6
Reading symbols from /lib/libc.so.6...done.
Loaded symbols for /lib/libc.so.6
Reading symbols from /lib/ld-linux.so.2...done.
Loaded symbols for /lib/ld-linux.so.2
Reading symbols from /lib/libnss_files.so.2...done.
Loaded symbols for /lib/libnss_files.so.2
#0 0x40021706 in _IceTransClose (ciptr=0x804b090) at
../../lib/xtrans/Xtrans.c:876
876 ret = ciptr-transptr-Close (ciptr);
(gdb) bt full
#0 0x40021706 in _IceTransClose (ciptr=0x804b090) at
../../lib/xtrans/Xtrans.c:876
ciptr = 0x804b090
ret = 24
#1 0x4001e815 in _IceFreeConnection (iceConn=0x804b0d8) at shutdown.c:287
No locals.
#2 0x4001e68e in IceCloseConnection (iceConn=0x804b0d8) at shutdown.c:130
iceConn = 0x804b0d8
refCountReachedZero = 24
status = 1073905664
#3 0x08048f09 in do_process (ice_conn=0x804b0d8) at server.c:135
ice_conn = 0x804b0d8
status = IceProcessMessagesSuccess
#4 0x08049030 in wait_for_input () at server.c:172
rfds = {__fds_bits = {32, 0 repeats 31 times}}
i = 2
res = 0
#5 0x08049378 in main (argc=1, argv=0xb744) at server.c:311
argc = 0
argv = (char **) 0x0
error_string = [EMAIL PROTECTED]@[EMAIL PROTECTED]@[EMAIL
PROTECTED]@[EMAIL PROTECTED]@[EMAIL PROTECTED]@[EMAIL PROTECTED]@[EMAIL
PROTECTED]@[EMAIL PROTECTED]@|[EMAIL PROTECTED]@\0\027\001@[EMAIL
PROTECTED]@[EMAIL PROTECTED]@[EMAIL PROTECTED]@[EMAIL
PROTECTED]@,\230\004\bÈöÿ¿ßÃ\022@...
opcode = 0
port = 134525072
status = 0
listen_objs = (IceListenObj *) 0x804ae98
listen_count = 2
i = 2
IIRC, some commits were made to Xtrans recently. I'll check this out.
I've attached an updated version of your patch, which applies to
xf-4_2-branch.
--
G. Branden Robinson|If you wish to strive for peace of
Debian GNU/Linux |soul, then believe; if you wish to
[EMAIL PROTECTED] |be a devotee of truth, then
http://people.debian.org/~branden/ |inquire. -- Friedrich Nietzsche
pgpStdSt1VGYI.pgp
Description: PGP signature
