Re: [jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
"Knut Anders Hatlen (JIRA)" writes: > [ > http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12421766 > ] > > Knut Anders Hatlen commented on DERBY-1395: > --- > > Hi David, > I think the patch looks good. +1 to commit. That is, +1 to commit if derbyall passes. I guess there are a couple of master files to update (I noticed that jdbcapi/checkDataSource.java failed). -- Knut Anders
[jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
[ http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12421766 ] Knut Anders Hatlen commented on DERBY-1395: --- Hi David, I think the patch looks good. +1 to commit. > Change the client SQLState to match that of embedded for the exception thrown > on a closed statement whose connection is also closed > --- > > Key: DERBY-1395 > URL: http://issues.apache.org/jira/browse/DERBY-1395 > Project: Derby > Issue Type: Improvement > Components: Network Client >Affects Versions: 10.2.0.0, 10.1.3.0 >Reporter: Deepa Remesh > Assigned To: David Van Couvering >Priority: Trivial > Attachments: DERBY-1395.diff > > > Scenario: Both connection and statement are closed and an operation is > performed on a closed statement. SQLStates are as follows: > Embedded: SQLSTATE: XJ012, Message: Statement Closed > Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed > Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed > This issue is related to the effort started in DERBY-254. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
[ http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12421746 ] David Van Couvering commented on DERBY-1395: Note: this passes the jdbc40 suite for both embedded and network clients. > Change the client SQLState to match that of embedded for the exception thrown > on a closed statement whose connection is also closed > --- > > Key: DERBY-1395 > URL: http://issues.apache.org/jira/browse/DERBY-1395 > Project: Derby > Issue Type: Improvement > Components: Network Client >Affects Versions: 10.2.0.0, 10.1.3.0 >Reporter: Deepa Remesh > Assigned To: David Van Couvering >Priority: Trivial > Attachments: DERBY-1395.diff > > > Scenario: Both connection and statement are closed and an operation is > performed on a closed statement. SQLStates are as follows: > Embedded: SQLSTATE: XJ012, Message: Statement Closed > Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed > Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed > This issue is related to the effort started in DERBY-254. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
[ http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12420761 ] David Van Couvering commented on DERBY-1395: When the connection is closed, I think it's more informative on the client side, where it tells you that the connection is closed rather than just saying the statement is closed. I would argue that I should fix the embedded side to return 08003 when the connection is closed, that would actually be more consistent with the standard. However, in the case when the connection is open and the statement is closed, I will fix the client to use XJ012 instead of XCL31. > Change the client SQLState to match that of embedded for the exception thrown > on a closed statement whose connection is also closed > --- > > Key: DERBY-1395 > URL: http://issues.apache.org/jira/browse/DERBY-1395 > Project: Derby > Type: Improvement > Components: Network Client > Versions: 10.2.0.0, 10.1.3.0 > Reporter: Deepa Remesh > Assignee: David Van Couvering > Priority: Trivial > > Scenario: Both connection and statement are closed and an operation is > performed on a closed statement. SQLStates are as follows: > Embedded: SQLSTATE: XJ012, Message: Statement Closed > Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed > Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed > This issue is related to the effort started in DERBY-254. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
[ http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12417318 ] Deepa Remesh commented on DERBY-1395: - I had seen the first scenario (both connection and statement closed) in jdbcapi/checkDataSource.java.This is in the checkConnection method. The scenario Knut mentions is covered in ClosedObjectTest.java. > Change the client SQLState to match that of embedded for the exception thrown > on a closed statement whose connection is also closed > --- > > Key: DERBY-1395 > URL: http://issues.apache.org/jira/browse/DERBY-1395 > Project: Derby > Type: Improvement > Components: Network Client > Versions: 10.2.0.0, 10.1.3.0 > Reporter: Deepa Remesh > Assignee: David Van Couvering > Priority: Trivial > > Scenario: Both connection and statement are closed and an operation is > performed on a closed statement. SQLStates are as follows: > Embedded: SQLSTATE: XJ012, Message: Statement Closed > Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed > Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed > This issue is related to the effort started in DERBY-254. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
[ http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12417215 ] David Van Couvering commented on DERBY-1395: Deepa, is there a particular test that exemplifies this behavior? I could poke around but if there are existing tests that demonstrate this that would be great. > Change the client SQLState to match that of embedded for the exception thrown > on a closed statement whose connection is also closed > --- > > Key: DERBY-1395 > URL: http://issues.apache.org/jira/browse/DERBY-1395 > Project: Derby > Type: Improvement > Components: Network Client > Versions: 10.2.0.0, 10.1.3.0 > Reporter: Deepa Remesh > Assignee: David Van Couvering > Priority: Trivial > > Scenario: Both connection and statement are closed and an operation is > performed on a closed statement. SQLStates are as follows: > Embedded: SQLSTATE: XJ012, Message: Statement Closed > Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed > Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed > This issue is related to the effort started in DERBY-254. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1395) Change the client SQLState to match that of embedded for the exception thrown on a closed statement whose connection is also closed
[ http://issues.apache.org/jira/browse/DERBY-1395?page=comments#action_12415827 ] Knut Anders Hatlen commented on DERBY-1395: --- The SQL states are different when the statement is closed and the connection still open too: Embedded: SQLSTATE = XJ012 Client before: SQLSTATE = null Client after: SQLSTATE = XCL31 > Change the client SQLState to match that of embedded for the exception thrown > on a closed statement whose connection is also closed > --- > > Key: DERBY-1395 > URL: http://issues.apache.org/jira/browse/DERBY-1395 > Project: Derby > Type: Improvement > Components: Network Client > Versions: 10.2.0.0, 10.1.3.0 > Reporter: Deepa Remesh > Priority: Trivial > > Scenario: Both connection and statement are closed and an operation is > performed on a closed statement. SQLStates are as follows: > Embedded: SQLSTATE: XJ012, Message: Statement Closed > Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed > Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed > This issue is related to the effort started in DERBY-254. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
