[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[
https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849739#comment-13849739
]
Matt Pavlovich commented on AMQ-4819:
-
Looking for feedback on impl approach.. with SLF4j, there isn't a way to pass
in the log level in a single line.. anyone have an approach that would allow us
to avoid this mess:
{{ if(usage.getCheckLimitsLogLevel().equalsIgnoreCase("warn")) {
LOG.warn(logMsg);
} else if(usage.getCheckLimitsLogLevel().equalsIgnoreCase("error"))
{
LOG.error(logMsg);
} else if(usage.getCheckLimitsLogLevel().equalsIgnoreCase("trace"))
{
LOG.trace(logMsg);
} else if(usage.getCheckLimitsLogLevel().equalsIgnoreCase("info")) {
LOG.info(logMsg);
}else if(usage.getCheckLimitsLogLevel().equalsIgnoreCase("fatal")) {
LOG.error(logMsg);
} else if(usage.getCheckLimitsLogLevel().equalsIgnoreCase("debug"))
{
LOG.debug(logMsg);
} else {
LOG.warn("Invalid SystemUsage checkLimitsLogLevel: " +
usage.getCheckLimitsLogLevel());
LOG.warn(logMsg);
}
}}
> Reducing memory usage should log at INFO/WARN level instead of ERROR
>
>
> Key: AMQ-4819
> URL: https://issues.apache.org/jira/browse/AMQ-4819
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 5.9.0
>Reporter: Claus Ibsen
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 5.10.0
>
>
> For example when using unit tests we will see. There is other limits that is
> being logged as well such as when disk space is also less than expected. That
> is logged at INFO level AFAIR
> 2013-10-22 10:24:44,002 [main ] ERROR BrokerService
> - Memory Usage for the Broker (1024 mb) is more than the maximum available
> for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb
> I suggest to make this logging level INFO or maybe at WARN?
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847518#comment-13847518 ] Matt Pavlovich commented on AMQ-4819: - Yep, looking to have it wrapped up this weekend > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Assignee: Matt Pavlovich >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846756#comment-13846756 ] Timothy Bish commented on AMQ-4819: --- Any progress on a patch for this? > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Assignee: Matt Pavlovich >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801843#comment-13801843 ] Matt Pavlovich commented on AMQ-4819: - Sure thing. I'll work up a patch in the next day or so. Can you check out my patch for AMQ-4818? I want to make sure I'm going through the motions properly. Thanks > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Assignee: Matt Pavlovich >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801808#comment-13801808 ] Claus Ibsen commented on AMQ-4819: -- Sounds good Matt, do you wanna take a stab at implementing this? > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801803#comment-13801803 ] Matt Pavlovich commented on AMQ-4819: - Configurable log level sounds good.. any issue with using WARN as the default log level if not specifically configured? > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801792#comment-13801792 ] Claus Ibsen commented on AMQ-4819: -- Yeah we could introduce a configurable logging level for when the broker resizes the memory or disk space sizes. > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801787#comment-13801787 ] Rob Davies commented on AMQ-4819: - There was another issue raised where it was requested to change from WARN to ERROR - we should make it configurable - as everybody is going to have a different opinion on this one > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801783#comment-13801783 ] Matt Pavlovich commented on AMQ-4819: - +1 agreed. > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801718#comment-13801718 ] Gary Tully commented on AMQ-4819: - that makes sense, initially that was just information so you could get oom. but now that we reset/override to a sensible max - warn is more suitable. > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (AMQ-4819) Reducing memory usage should log at INFO/WARN level instead of ERROR
[ https://issues.apache.org/jira/browse/AMQ-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801610#comment-13801610 ] Claus Ibsen commented on AMQ-4819: -- The warning about disk space is at WARN level. > Reducing memory usage should log at INFO/WARN level instead of ERROR > > > Key: AMQ-4819 > URL: https://issues.apache.org/jira/browse/AMQ-4819 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.9.0 >Reporter: Claus Ibsen >Priority: Minor > Fix For: 5.10.0 > > > For example when using unit tests we will see. There is other limits that is > being logged as well such as when disk space is also less than expected. That > is logged at INFO level AFAIR > 2013-10-22 10:24:44,002 [main ] ERROR BrokerService > - Memory Usage for the Broker (1024 mb) is more than the maximum available > for the JVM: 156 mb - resetting to 70% of maximum available: 109 mb > I suggest to make this logging level INFO or maybe at WARN? -- This message was sent by Atlassian JIRA (v6.1#6144)
