[GitHub] ant pull request #77: Avoid FileInputStream and FileOutputStream.
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/77 Avoid FileInputStream and FileOutputStream. Avoid FileInputStream and FileOutputStream. These classes override the finalize method. As a result, their objects are only cleaned when the garbage collector performs a sweep. Since Java 7, programmers can use Files.newInputStream and Files.newOutputStream instead of FileInputStream and FileOutputStream to improve performance as recommended in this Java JDK bug-report. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant newstream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit 0950db58654ff0f853dcfd7110f7d27500acbf5b Author: = Date: 2018-11-04T16:31:37Z Avoid FileInputStream and FileOutputStream. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user reudismam commented on the issue: https://github.com/apache/ant/pull/62 Actually, I do not have a documentation, but there are discussions in programming community about the benefits of this change, such as this: [https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x](https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x) This edit is known to have improved performance on other projects such as Guava Project where they improve performance from 10-25%. [https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x](https://github.com/google/guava/commit/8f48177132547cee2943c93837d76b898154d722) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #62: Use char notation to represent a character to improve ...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/62 Use char notation to represent a character to improve performance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant character Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 4df60d6b21f4c85df039037531aa1627fc40b68d Author: reudismam <reudismam@...> Date: 2018-02-16T12:49:15Z Use char notation to represent a character to improve performance. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/61 Use the isEmpty method instead of comparing the value of size() to 0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 25315d0c28cf81c8c23944d3f368c76c6da02ac2 Author: reudismam <reudismam@...> Date: 2018-02-15T17:30:25Z Use the isEmpty method instead of comparing the value of size() to 0. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...
Github user reudismam commented on the issue: https://github.com/apache/ant/pull/58 Undo edits to src/main/org/apache/tools/ant/listener/MailLogger.java and src/main/org/apache/tools/ant/taskdefs/Parallel.java --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/58 Use StringBuilder instead of StringBuffer as it offers high performan⦠â¦ce in single thread places as it is generally the case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant builder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit bf3d0b448ed055eea7dcc036397e8b0f7cbc50fe Author: reudismam <reudismam@...> Date: 2018-02-05T16:18:05Z Use StringBuilder instead of StringBuffer as it offers high performance in single thread places as it is generally the case. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/56 Use equals method of a string literal to prevent NPE and isEmpty() me⦠â¦thod instead of comparing a String object with an empty string. This change has already been done for some locations in the commit: https://github.com/apache/ant/commit/b7d1e9bde44cb8e5233d6e70bb96e14cbb2f3e2d You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant equals Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit debf404d170cfd771a517e9c5b408bc9735e2f70 Author: reudismam <reudismam@...> Date: 2018-02-01T17:03:19Z Use equals method of a string literal to prevent NPE and isEmpty() method instead of comparing a String object with an empty string. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...
Github user reudismam commented on the issue: https://github.com/apache/ant/pull/55 Thank you. Reudismam Rolim is good for me. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #55: Use valueOf method instead of constructor since valueO...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/55 Use valueOf method instead of constructor since valueOf has higher pe⦠â¦rformance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 51acedc82ee0bb7472041825937c4c139c93195e Author: reudismam <reudismam@...> Date: 2018-01-24T13:57:12Z Use valueOf method instead of constructor since valueOf has higher performance. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
