Re: Review Request 67622: ATLAS-2708: added model for AWS types

2018-06-18 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67622/#review204910
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 18, 2018, 12:44 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67622/
> ---
> 
> (Updated June 18, 2018, 12:44 a.m.)
> 
> 
> Review request for atlas, Barbara Eckman and Don Bosco Durai.
> 
> 
> Bugs: ATLAS-2708
> https://issues.apache.org/jira/browse/ATLAS-2708
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Models for AWS types from @Barbara Eckman: AWSBucket, AWSPseudoDir, 
> AWSObject; and related structs and relationships
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3010-aws_common_typedefs.json PRE-CREATION 
>   addons/models/3000-Cloud/3020-aws_s3_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67622/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the models load in Atlas successfully without any 
> errors/warning.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 67622: ATLAS-2708: added model for AWS types

2018-06-17 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67622/
---

(Updated June 18, 2018, 12:44 a.m.)


Review request for atlas, Barbara Eckman and Don Bosco Durai.


Changes
---

Removed attribute aws_s3_bucket.bucketName as super-type attribute DataSet.name 
can be used instead


Bugs: ATLAS-2708
https://issues.apache.org/jira/browse/ATLAS-2708


Repository: atlas


Description
---

Models for AWS types from @Barbara Eckman: AWSBucket, AWSPseudoDir, AWSObject; 
and related structs and relationships


Diffs (updated)
-

  addons/models/3000-Cloud/3010-aws_common_typedefs.json PRE-CREATION 
  addons/models/3000-Cloud/3020-aws_s3_typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/67622/diff/2/

Changes: https://reviews.apache.org/r/67622/diff/1-2/


Testing
---

Verified that the models load in Atlas successfully without any errors/warning.


Thanks,

Madhan Neethiraj



Re: Review Request 67622: ATLAS-2708: added model for AWS types

2018-06-17 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67622/
---

(Updated June 17, 2018, 5:19 p.m.)


Review request for atlas, Barbara Eckman and Don Bosco Durai.


Bugs: ATLAS-2708
https://issues.apache.org/jira/browse/ATLAS-2708


Repository: atlas


Description (updated)
---

Models for AWS types from @Barbara Eckman: AWSBucket, AWSPseudoDir, AWSObject; 
and related structs and relationships


Diffs
-

  addons/models/3000-Cloud/3010-aws_common_typedefs.json PRE-CREATION 
  addons/models/3000-Cloud/3020-aws_s3_typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/67622/diff/1/


Testing
---

Verified that the models load in Atlas successfully without any errors/warning.


Thanks,

Madhan Neethiraj



Review Request 67622: ATLAS-2708: added model for AWS types

2018-06-17 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67622/
---

Review request for atlas, Barbara Eckman and Don Bosco Durai.


Bugs: ATLAS-2708
https://issues.apache.org/jira/browse/ATLAS-2708


Repository: atlas


Description
---

Models for AWS types: AWSBucket, AWSPseudoDir, AWSObject; and related structs 
and relationships


Diffs
-

  addons/models/3000-Cloud/3010-aws_common_typedefs.json PRE-CREATION 
  addons/models/3000-Cloud/3020-aws_s3_typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/67622/diff/1/


Testing
---

Verified that the models load in Atlas successfully without any errors/warning.


Thanks,

Madhan Neethiraj