[jira] [Created] (ATLAS-1788) UI : Wildcard search with "?" throws exception in basic search
Sharmadha Sainath created ATLAS-1788: Summary: UI : Wildcard search with "?" throws exception in basic search Key: ATLAS-1788 URL: https://issues.apache.org/jira/browse/ATLAS-1788 Project: Atlas Issue Type: Bug Components: atlas-webui Affects Versions: trunk, 0.9-incubating Reporter: Sharmadha Sainath Attachments: wildcard_search.txt Wildcard search with "?" throws 500 internal error. Example : Basic search : type name : kafka_topic query : kakfa_topic_iAEz? throws 500 Internal server error . The corresponding query fired is {code} http://172.27.19.74:21000/api/atlas/v2/search?limit=25=kakfa_topic_iAEz {code} if query is "kafka_topic_?AEzb" corresponding query fired is : {code} http://172.27.19.74:21000/api/atlas/v2/search?limit=25=kafka_topic_ {code} Note : content after "?" is ignored and query is not formed correctly (basic keyword is missed) The following curl command runs fine returns 200 Ok with correct results. {code} curl -u admin:admin -X GET "http://172.27.19.74:21000/api/atlas/v2/search/basic?limit=25=true=kakfa_topic_iAEz?=kafka_topic; {code} Attached the WebApplication exception thrown while making the query. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (ATLAS-1787) Replace explicit type with diamond operator
[ https://issues.apache.org/jira/browse/ATLAS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated ATLAS-1787: - Attachment: ATLAS-1787.001.patch > Replace explicit type with diamond operator > --- > > Key: ATLAS-1787 > URL: https://issues.apache.org/jira/browse/ATLAS-1787 > Project: Atlas > Issue Type: Improvement >Reporter: Jan Hentschel >Priority: Trivial > Attachments: ATLAS-1787.001.patch > > > Because Atlas uses Java 7 explicit types can be replaced with the diamond > operator. Most of the code already uses the diamond operator, but there are > still some places left throughout the codebase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 59264: ATLAS-1787: Replace explicit type with diamond operator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59264/ --- Review request for atlas. Bugs: ATLAS-1787 https://issues.apache.org/jira/browse/ATLAS-1787 Repository: atlas Description --- Replaced the remaining places where explicit types are used. Diffs - graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java 6a61075 graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java 5ec1180 graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java 1670e92 graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java df67a83 graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java 26abe2e graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java eb99fae graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java 45fbbea graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java ab2c8c9 intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java fb4a183 repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java a48a007 repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java 7902100 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java d1e8cb7 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ca7fad0 repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ac13586 repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java 8b38152 repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a4a596a repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 18573fc repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 1dd7276 webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java e55d2cf Diff: https://reviews.apache.org/r/59264/diff/1/ Testing --- Thanks, Jan Hentschel
[jira] [Created] (ATLAS-1787) Replace explicit type with diamond operator
Jan Hentschel created ATLAS-1787: Summary: Replace explicit type with diamond operator Key: ATLAS-1787 URL: https://issues.apache.org/jira/browse/ATLAS-1787 Project: Atlas Issue Type: Improvement Reporter: Jan Hentschel Priority: Trivial Because Atlas uses Java 7 explicit types can be replaced with the diamond operator. Most of the code already uses the diamond operator, but there are still some places left throughout the codebase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (ATLAS-1786) Remove duplicate dependency for atlas-graphdb-impls
[ https://issues.apache.org/jira/browse/ATLAS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated ATLAS-1786: - Attachment: ATLAS-1786.001.patch > Remove duplicate dependency for atlas-graphdb-impls > --- > > Key: ATLAS-1786 > URL: https://issues.apache.org/jira/browse/ATLAS-1786 > Project: Atlas > Issue Type: Improvement >Reporter: Jan Hentschel >Priority: Minor > Attachments: ATLAS-1786.001.patch > > > Currently the main pom file defines the dependency for *atlas-graphdb-impls* > twice. One of it should be removed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59263/ --- Review request for atlas. Bugs: ATLAS-1786 https://issues.apache.org/jira/browse/ATLAS-1786 Repository: atlas Description --- Removed one of the dependencies for **atlas-graphdb-impls** from the main pom file. Diffs - webapp/pom.xml 045ccdb Diff: https://reviews.apache.org/r/59263/diff/1/ Testing --- Thanks, Jan Hentschel
[jira] [Created] (ATLAS-1786) Remove duplicate dependency for atlas-graphdb-impls
Jan Hentschel created ATLAS-1786: Summary: Remove duplicate dependency for atlas-graphdb-impls Key: ATLAS-1786 URL: https://issues.apache.org/jira/browse/ATLAS-1786 Project: Atlas Issue Type: Improvement Reporter: Jan Hentschel Priority: Minor Currently the main pom file defines the dependency for *atlas-graphdb-impls* twice. One of it should be removed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (ATLAS-1785) Fix Findbugs problems in falcon-bridge module
[ https://issues.apache.org/jira/browse/ATLAS-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated ATLAS-1785: - Attachment: ATLAS-1785.001.patch > Fix Findbugs problems in falcon-bridge module > - > > Key: ATLAS-1785 > URL: https://issues.apache.org/jira/browse/ATLAS-1785 > Project: Atlas > Issue Type: Improvement >Reporter: Jan Hentschel >Priority: Minor > Attachments: ATLAS-1785.001.patch > > > Currently Findbugs complains about the following two problems in the > *falcon-bridge* > {code} > [INFO] Repeated conditional test in > org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, > ConfigurationStore) [org.apache.atlas.falcon.bridge.FalconBridge, > org.apache.atlas.falcon.bridge.FalconBridge] At FalconBridge.java:[line > 184]At FalconBridge.java:[line 184] > [INFO] Switch statement found in > org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where > default case is missing [org.apache.atlas.falcon.hook.FalconHook] At > FalconHook.java:[lines 161-163] > {code} > They should be fixed to get the code more reliable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/ --- Review request for atlas. Bugs: ATLAS-1785 https://issues.apache.org/jira/browse/ATLAS-1785 Repository: atlas Description --- Fixed the following Findbugs warnings: * Repeated conditional test in org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, ConfigurationStore) * Switch statement found in org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where default case is missing Diffs - addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java 349da66 addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 842b2ce Diff: https://reviews.apache.org/r/59262/diff/1/ Testing --- Thanks, Jan Hentschel
[jira] [Created] (ATLAS-1785) Fix Findbugs problems in falcon-bridge module
Jan Hentschel created ATLAS-1785: Summary: Fix Findbugs problems in falcon-bridge module Key: ATLAS-1785 URL: https://issues.apache.org/jira/browse/ATLAS-1785 Project: Atlas Issue Type: Improvement Reporter: Jan Hentschel Priority: Minor Currently Findbugs complains about the following two problems in the *falcon-bridge* {code} [INFO] Repeated conditional test in org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, ConfigurationStore) [org.apache.atlas.falcon.bridge.FalconBridge, org.apache.atlas.falcon.bridge.FalconBridge] At FalconBridge.java:[line 184]At FalconBridge.java:[line 184] [INFO] Switch statement found in org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where default case is missing [org.apache.atlas.falcon.hook.FalconHook] At FalconHook.java:[lines 161-163] {code} They should be fixed to get the code more reliable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (ATLAS-1784) Use explicit imports instead of wildcards
[ https://issues.apache.org/jira/browse/ATLAS-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated ATLAS-1784: - Attachment: ATLAS-1784.001.patch > Use explicit imports instead of wildcards > - > > Key: ATLAS-1784 > URL: https://issues.apache.org/jira/browse/ATLAS-1784 > Project: Atlas > Issue Type: Improvement >Reporter: Jan Hentschel >Priority: Minor > Attachments: ATLAS-1784.001.patch > > > Currently there are a lot of wildcard imports, especially with *java.util.**. > To follow best practices, for better readability and to prevent future > collisions they should be changed to explicit class imports. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 59261: ATLAS-1784: Use explicit imports instead of wildcards
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59261/ --- Review request for atlas. Bugs: ATLAS-1784 https://issues.apache.org/jira/browse/ATLAS-1784 Repository: atlas Description --- Changed wildcard imports to explicit imports. Diffs - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 979e729 authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java b36c9c7 catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java cee102a catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java c2a843b catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java a63309e catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java b59dcae catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 3202d04 catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 966a3ae catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java 6a67b25 catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java 052a21d catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java c5a4213 catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 434a189 catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java 51ef65a catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java e435628 catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java 4adf861 catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java b4d759a catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java b915877 catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java a4fd4ad catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java a228546 catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java 67af409 catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 96cb523 catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java 60cc210 catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java 146ca0c catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java 8dfce5e catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 7d61579 catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java 41d934f catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java 41f50c7 catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java 1af8d14 catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java b7b23da catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 528c83a graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java d454f37 graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 54ff7cb intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java a9aaed2 intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 385a9ae intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e882473 intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java aaf4a6a intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java accba77 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java d9bc924 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 560b338 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 075b9b6 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java 8a6a0e3 repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ac13586 repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java a7cb2e5 repository/src/test/java/org/apache/atlas/TestUtils.java cf39d8d repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 18573fc repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 4fd416c repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 65cd938 typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090 typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java