[GitHub] [camel-website] zregvart commented on issue #74: Add search for Hugo (more polishing need to do)
zregvart commented on issue #74: Add search for Hugo (more polishing need to do) URL: https://github.com/apache/camel-website/pull/74#issuecomment-521719394 Thanks for this. Can you move the bits that refactor the microdata/seo into a separate PR, from what I understand it's not a requirement for the search to function. The JavaScript bits need to go to the Antora UI theme, the reason for that is that there's a gulp pipeline that minifies and merges all JavaScript into a single JavaScript file that also has cache bursting filename. This is important because otherwise changes to the script code might not be reflected in the browser as it's using cached version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #74: Add search for Hugo (more polishing need to do)
zregvart commented on issue #74: Add search for Hugo (more polishing need to do) URL: https://github.com/apache/camel-website/pull/74#issuecomment-521724187 The build is currently failing with: ``` [2019-08-15T16:38:45.078Z] $ antora --require ./menu.js --clean --fetch site.yml [2019-08-15T16:40:36.833Z] error: The partial seo/main could not be found ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #74: Add search for Hugo (more polishing need to do)
zregvart commented on issue #74: Add search for Hugo (more polishing need to do) URL: https://github.com/apache/camel-website/pull/74#issuecomment-522977061 I think I'll pick bits from this into separate pull requests. I've read a bit about [Algolia docsearch](https://community.algolia.com/docsearch/). I'm not sure if we should [run our own crawler job](https://community.algolia.com/docsearch/run-your-own.html) or let Algolia index our documentation on it's own. Either way I think we need to include [just the JavaScript bits](https://community.algolia.com/docsearch/dropdown.html) for the docusearch dropdown. So, perhaps as a first start we just add the docsearch dropdown and let Algolia index the site. I'll pick the changes from here needed to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
