[jira] Commented: (COCOON-1779) [PATCH] JUnit tests for LocaleAction
[ http://issues.apache.org/jira/browse/COCOON-1779?page=comments#action_12369981 ] Jorg Heymans commented on COCOON-1779: -- nevermind, my patching skills are getting rusty... Synchronized to trunk, please check and close this issue. > [PATCH] JUnit tests for LocaleAction > > > Key: COCOON-1779 > URL: http://issues.apache.org/jira/browse/COCOON-1779 > Project: Cocoon > Type: Test > Components: * Cocoon Core > Versions: 2.1.9-dev (current SVN) > Reporter: Andrew Stevens > Assignee: Jorg Heymans > Priority: Minor > Attachments: LocaleActionTestCase.java, LocaleActionTestCase.xtest, > mockrequest.diff > > While looking into the patch on COCOON-1592, I figured some test cases for > the existing action would be useful, to be sure that the patch didn't break > any existing functionality. > Attached are the testcase and .xtest files, to go in > src/test/org/apache/cocoon/acting. Also, in order to test the case where the > locale is read from the browser's Accept-Language or server default, I had to > add a setLocale method to the MockRequest; the attached diff is for this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1779) [PATCH] JUnit tests for LocaleAction
[ http://issues.apache.org/jira/browse/COCOON-1779?page=comments#action_12369978 ] Jorg Heymans commented on COCOON-1779: -- Actually, could have a look in porting the patch to trunk ? mockrequest.diff does not seem to apply there. > [PATCH] JUnit tests for LocaleAction > > > Key: COCOON-1779 > URL: http://issues.apache.org/jira/browse/COCOON-1779 > Project: Cocoon > Type: Test > Components: * Cocoon Core > Versions: 2.1.9-dev (current SVN) > Reporter: Andrew Stevens > Assignee: Jorg Heymans > Priority: Minor > Attachments: LocaleActionTestCase.java, LocaleActionTestCase.xtest, > mockrequest.diff > > While looking into the patch on COCOON-1592, I figured some test cases for > the existing action would be useful, to be sure that the patch didn't break > any existing functionality. > Attached are the testcase and .xtest files, to go in > src/test/org/apache/cocoon/acting. Also, in order to test the case where the > locale is read from the browser's Accept-Language or server default, I had to > add a setLocale method to the MockRequest; the attached diff is for this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1779) [PATCH] JUnit tests for LocaleAction
[ http://issues.apache.org/jira/browse/COCOON-1779?page=comments#action_12369977 ] Jorg Heymans commented on COCOON-1779: -- Applied, thanks . Please have a look if all went in ok and close this issue. > [PATCH] JUnit tests for LocaleAction > > > Key: COCOON-1779 > URL: http://issues.apache.org/jira/browse/COCOON-1779 > Project: Cocoon > Type: Test > Components: * Cocoon Core > Versions: 2.1.9-dev (current SVN) > Reporter: Andrew Stevens > Assignee: Jorg Heymans > Priority: Minor > Attachments: LocaleActionTestCase.java, LocaleActionTestCase.xtest, > mockrequest.diff > > While looking into the patch on COCOON-1592, I figured some test cases for > the existing action would be useful, to be sure that the patch didn't break > any existing functionality. > Attached are the testcase and .xtest files, to go in > src/test/org/apache/cocoon/acting. Also, in order to test the case where the > locale is read from the browser's Accept-Language or server default, I had to > add a setLocale method to the MockRequest; the attached diff is for this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira