[GitHub] cordova-plugin-whitelist pull request #19: Update README.md

2016-08-29 Thread vladimirnani
Github user vladimirnani closed the pull request at:

https://github.com/apache/cordova-plugin-whitelist/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-whitelist issue #19: Update README.md

2016-08-29 Thread vladimirnani
Github user vladimirnani commented on the issue:

https://github.com/apache/cordova-plugin-whitelist/pull/19
  
@stevengill Surely, thanks great plugin. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-whitelist pull request #19: Update README.md

2016-08-29 Thread vladimirnani
GitHub user vladimirnani reopened a pull request:

https://github.com/apache/cordova-plugin-whitelist/pull/19

Update README.md

Install docs updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimirnani/cordova-plugin-whitelist patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-whitelist/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit ebdefc05e82373d4bd5d97bcd5c98f5859e711d5
Author: Vladimir Nani 
Date:   2016-08-30T06:44:05Z

Updated installation section




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: To merge fixed bug

2016-08-29 Thread Steven Gill
Thanks Sanjeewa! Merged in.

On Mon, Aug 29, 2016 at 10:01 PM, sanjeewa kumara 
wrote:

> I have fixed CB-11085
>
> AudioHandler logs should use system log, not println and made PR.
> Can you check there is anything to fix or not.  If there is anything
> to fix again please mention it otherwise can you merge it?
>
> Thank you.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[GitHub] cordova-plugin-media pull request #110: CB-11085 (Android) Fixed AudioHandle...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media issue #110: CB-11085 (Android) Fixed AudioHandler logs ...

2016-08-29 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/110
  
LGTM. I'll merge it in. Thanks @sanjeewa894 for sending the PR!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer issue #156: CB-9027 (android, ios): Expose HTTP...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/156
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/156/commits/eeb07f34eb5e4f11de5cc91d8ae1034928d81a6f)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/38//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



To merge fixed bug

2016-08-29 Thread sanjeewa kumara
I have fixed CB-11085

AudioHandler logs should use system log, not println and made PR.
Can you check there is anything to fix or not.  If there is anything
to fix again please mention it otherwise can you merge it?

Thank you.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request #156: CB-9027 (android, ios): Expo...

2016-08-29 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/156

CB-9027 (android, ios): Expose HTTP client read timeout as an option

### Platforms affected
Android
iOS

### What does this PR do?
Expose HTTP Client Read Timeout as option

### What testing has been done on this change?
Android undefined / 60 / 180
iOS undefined / 60 / 180

### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buzzcard/cordova-plugin-file-transfer CB-9027

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit eeb07f34eb5e4f11de5cc91d8ae1034928d81a6f
Author: Ryan Williams 
Date:   2016-08-30T00:36:37Z

CB-9027 (android, ios): Expose HTTP client read timeout as an option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request #155: CB-9027 (android, ios): Expo...

2016-08-29 Thread ryanwilliams83
Github user ryanwilliams83 closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/155


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Nightly build #122 for cordova has succeeded!

2016-08-29 Thread Apache Jenkins Server
Nightly build #122 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/122/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #155: CB-9027 (android, ios): Expose HTTP...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/155
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/155/commits/34f16f0c9f2879006b05e875dc36ee4f303cd241)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/37//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request #155: CB-9027 (android, ios): Expo...

2016-08-29 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/155

CB-9027 (android, ios): Expose HTTP client read timeout as option

### Platforms affected
Android
iOS

### What does this PR do?
Expose HTTP Client Read Timeout as option

### What testing has been done on this change?
Android undefined / 60 / 180
iOS undefined / 60 / 180

### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buzzcard/cordova-plugin-file-transfer CB-9027

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #155


commit 34f16f0c9f2879006b05e875dc36ee4f303cd241
Author: Ryan Williams 
Date:   2016-08-30T00:36:37Z

CB-9027 (android, ios): Expose HTTP client read timeout as an option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-whitelist issue #19: Update README.md

2016-08-29 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-whitelist/pull/19
  
Hey @vladimirnani, we generally don't put third party tools in cordova 
readmes. If you remove the stuff about PhoneGap, I can merge this in. The 
readme should include a install section. 

If you aren't interested, please let me know. I can add the change manually 
myself


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-console pull request #14: add JIRA issue tracker link

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-console/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts pull request #131: CB-11455: (ios) Add mandatory iOS...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/131


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #262: CB-10680 Expose isFirstAttempt API in ICo...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #262: CB-10680 Expose isFirstAttempt API in ICordovaHt...

2016-08-29 Thread infil00p
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/262
  
I guess not? I'm going to close this.  If you can give us more information 
on how to review this thing, that'd be awesome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #243: Include native libraries from armeabi dir...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/243


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #242: Update CordovaWebViewImpl.java

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/242


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #243: Include native libraries from armeabi directory ...

2016-08-29 Thread infil00p
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/243
  
This appears to be abandoned, so I'm going to close this.  If not, can you 
please give us a test cases so we can test this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #227: Move CordovaWebView to CordovaWebInterfac...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/227


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #219: Fixed CB-9697 Cordova emulate for Android...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/219


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #185: CB-8965 Copy cordova-js-src directory to ...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/185


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-29 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/197
  
Merged! Thanks again @swbradshaw 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #183: CB-11783: (android) Add intent schem...

2016-08-29 Thread GavinPacini
Github user GavinPacini commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/183
  
Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request #197: [CB-5195][CB-4078]: correctOrientat...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request #28: Events are not firing on Black...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request #78: I need when user hit hardware ...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/78


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #183: CB-11783: (android) Add intent schem...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/183
  
Thanks for the PR, I've merged it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request #183: CB-11783: (android) Add inten...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/183


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/55
  
The ICLA has been received, can you make the code changes I proposed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #631: Added iPad Pro icon

2016-08-29 Thread monove
GitHub user monove opened a pull request:

https://github.com/apache/cordova-docs/pull/631

Added iPad Pro icon



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/monove/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #631


commit f60a63849f2346787490ba8abc81efccd300b5b7
Author: monove 
Date:   2016-08-29T19:29:09Z

Added iPad Pro icon




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #183: CB-11783: (android) Add intent schem...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/183
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/183/commits/df084ff869cc33213171f4ffaef01c54838a472a)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/65//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request #197: [CB-5195][CB-4078]: correctOrientat...

2016-08-29 Thread stevengill
Github user stevengill commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#discussion_r76660583
  
--- Diff: src/android/CameraLauncher.java ---
@@ -927,6 +859,21 @@ private void writeUncompressedImage(Uri src, Uri dest) 
throws FileNotFoundExcept
 }
 }
 }
+/**
+ * In the special case where the default width, height and quality are 
unchanged
+ * we just write the file out to disk saving the expensive 
Bitmap.compress function.
+ *
+ * @param src
+ * @throws FileNotFoundException
+ * @throws IOException
+ */
+private void writeUncompressedImage(Uri src, Uri dest) throws 
FileNotFoundException,
--- End diff --

Actually, i guess you are just overloading. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request #197: [CB-5195][CB-4078]: correctOrientat...

2016-08-29 Thread stevengill
Github user stevengill commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#discussion_r76660251
  
--- Diff: src/android/CameraLauncher.java ---
@@ -927,6 +859,21 @@ private void writeUncompressedImage(Uri src, Uri dest) 
throws FileNotFoundExcept
 }
 }
 }
+/**
+ * In the special case where the default width, height and quality are 
unchanged
+ * we just write the file out to disk saving the expensive 
Bitmap.compress function.
+ *
+ * @param src
+ * @throws FileNotFoundException
+ * @throws IOException
+ */
+private void writeUncompressedImage(Uri src, Uri dest) throws 
FileNotFoundException,
--- End diff --

I see two writeUncompressedImage functions. Is this correct? The second one 
is right above this definition. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #491: Update config.md

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/491


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: CI Build Status

2016-08-29 Thread Steven Gill
wooo!

On Mon, Aug 29, 2016 at 6:00 AM, Alexander Sorokin (Akvelon) <
v-als...@microsoft.com> wrote:

> Hi guys,
>
> Here's the last week's report
>
>
>
> # of legitimate test failures:
>
> 0  - Android
>
> 0 - iOS
>
> 0  - WP 8.1
>
> 0  - Windows 8.1
>
> 0  - Windows 10
>
> There are some new and old infrastructure issues: for example, the
> cordova-vm is down at the moment which means we cannot effectively run
> tests for the file-transfer plugin. We're doing our best to resolve these
> issues.
> Apart from that, everything look pretty good and stable.
>
> Thanks,
> Alexander Sorokin
>
>


[GitHub] cordova-plugin-inappbrowser pull request #183: CB-11783: (android) Add inten...

2016-08-29 Thread GavinPacini
GitHub user GavinPacini opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/183

CB-11783: (android) Add intent scheme to be handled by OS

### Platforms affected
Android

### What does this PR do?
The intent scheme `intent://` is [recommended by Google 
](https://developer.chrome.com/multidevice/android/intents) for launching apps. 
Cordova should forward this to the OS to handle appropriately.

### What testing has been done on this change?
Intent is forwarded to the OS and provides the application handler dialog 
for the user to select an app.

### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/GavinPacini/cordova-plugin-inappbrowser 
patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #183


commit df084ff869cc33213171f4ffaef01c54838a472a
Author: Gavin Pacini 
Date:   2016-08-29T15:20:12Z

Add intent scheme to be handled by OS

The intent scheme `intent://` is [recommended by Google 
](https://developer.chrome.com/multidevice/android/intents) for launching apps. 
Cordova should forward this to the OS to handle appropriately.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
There is a google+ plugin 
https://github.com/EddyVerbruggen/cordova-plugin-googleplus

BTW, I'm not saying that this shouldn't be merged, I'm saying that it 
shouldn't change the default modal behaviour, this should be added in a way 
that you can configure it to be modal or not, being modal the default as it is 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread dotNetkow
Github user dotNetkow commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
Thanks for sharing.  Really good to know - someone needs to start building 
a "Google Sign-In" plugin! ;)

Naturally, I disagree on this, what with an infinite amount of 3rd party 
apps, sites, and APIs to connect accounts to, but I understand. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Adding NSB/AppStudio to Tools section of Cordova home page

2016-08-29 Thread George Henne
I'd like to nominate NSB/AppStudio for inclusion in the Cordova Tools section 
of Cordova home page. See
https://github.com/apache/cordova-docs/pull/626

NSB/AppStudio is a tool for developing apps using Apache Cordova. It has 
supported PhoneGap since its initial release in December, 2010.

AppStudio includes a drag and drop Design Screen, using built-in definitions 
for Bootstrap, jQuery Mobile and jqWidgets controls. Their events hook into the 
Code Window for JavaScript development. A BASIC to JavaScript transpiler is 
included. The Properties Window guides customization of the controls.

AppStudio creates all the dependent code and feeds the resulting package of 
files, HTML, CSS and JavaScript to Apache Cordova or PhoneGap Build to create 
native apps.

AppStudio is used to develop commercial and personal apps. It is also used for 
teaching: more than a million high school students have learned programming 
with AppStudio. It is in use in over 70 countries and has been localized in 16 
languages. It's an important way people learn about Apache Cordova.

Disclosure: I am one of the developers of AppStudio. Let me know if you have 
questions!

George Henne
NS BASIC Corporation
http://www.nsbasic.com


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/62
  
The ICLA is for individuals, so if you already sent it that is good. 
It's recommended to use a personal email, but you can use any email you 
want, I can't really see your email, so seeing your name on the 
[list](http://home.apache.org/unlistedclas.html) is good enough for me, and you 
are, so no need to send another one with the personal email.

Next time you send a PR you can check the box "ICLA has been signed and 
submitted to secret...@apache.org." in the PR checklist so people don't ask for 
it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-29 Thread jonathanli2
Github user jonathanli2 commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/62
  
Hi,
I believe I have signed the agreement a while ago (on November 2014) when 
suggested by John Wargo, but I think at that time I signed the agreement using 
my company's email address jonathan...@sap.com, instead of my personal email 
address used for the pull request (jonathan_li2...@yahoo.ca). 

In that case, do I need to submit the agreement again using my personal 
email address?

Thanks
Jonathan 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



CI Build Status

2016-08-29 Thread Alexander Sorokin (Akvelon)
Hi guys,

Here's the last week's report



# of legitimate test failures:

0  - Android

0 - iOS

0  - WP 8.1

0  - Windows 8.1

0  - Windows 10

There are some new and old infrastructure issues: for example, the cordova-vm 
is down at the moment which means we cannot effectively run tests for the 
file-transfer plugin. We're doing our best to resolve these issues.
Apart from that, everything look pretty good and stable.

Thanks,
Alexander Sorokin



Re: [Discuss] plugins release

2016-08-29 Thread Kerri Shotts
I've got iPads that support multitasking, so I'll take a look. 

~ Kerri 



On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar sanchez" 
 wrote:










If somebody with an iPad that supports multitasking can test this PR...
https://github.com/apache/cordova-plugin-statusbar/pull/62

I have reviewed the code and looks good, bud I don't have an iPad that
supports multitasking to test it, and I don't trust the simulator in this
case as I tried to fix that issue in a different way, got it working on the
simulator but the reporter said that it didn't work as expected on a real
device.

2016-08-25 0:54 GMT+02:00 julio cesar sanchez :

> PRs to review
> https://github.com/apache/cordova-plugin-contacts/pull/131
> https://github.com/apache/cordova-plugin-camera/pull/229
>
> 2016-08-24 20:20 GMT+02:00 Steven Gill :
>
>> Hey Scott,
>>
>> Thanks for pointing out the PR. I'll take a look.
>>
>> The reality of the situation is that cordova has many repos and not enough
>> committers currently. This leads to PRs sitting unreviewed. Plugin PRs are
>> unique in that they can involve various different native language changes.
>> This could require more than 1 committer needing to review. For example,
>> some committers are more experienced with android vs ios, so they won't be
>> able to review the ios portion of the plugin PR. Another issue with plugin
>> PRs is that they may try to add a new feature (without discussion) and may
>> not add similar functionality for other platforms that support the plugin.
>> And of course lots of PRs don't include tests.
>>
>> The name being attached to component doesn't mean anything. Issues by
>> default go unassigned.
>>
>> I can only speak on behalf of the regular Adobe cordova commiters (4 of
>> us). Our focus is usually spent on platforms + tools fixes and
>> improvements.
>>
>> The best way to get attention for your PR is to post it to slack + here. I
>> usually do a review of PRs when I do a plugins release, but I won't be
>> able
>> to go through them all. This is why I ask for people to bring some to my
>> attention during releases.
>>
>> Lastly, we would love to help onboard new committers to help manage
>> plugins. If you are interested in such a role, LMK!
>>
>> Cheers,
>> -Steve
>>
>> On Wed, Aug 24, 2016 at 6:14 AM, Scott Bradshaw 
>> wrote:
>>
>> > Hi Steven - Can you look at camera PR 197
>> > ? This
>> addresses
>> > a major bug in the Android camera plugin where it won't rotate pictures
>> > chosen from the library. This bug has been around since Android 4.4 was
>> > released.  I worked on this at the beginning of the year, but it's just
>> > sitting there.  I'm new to Cordova, so I don't know exactly what the
>> > process is to get someone to look at it. I've joined Slack to find
>> someone
>> > to look at it, but no luck. Your name appears to be a attached
>> > > > com.atlassian.jira.jira-projects-plugin:components-panel>
>> > to most of the plugins, including camera. This also isn't the only PR
>> out
>> > there for camera. Several are just sitting there waiting for review. At
>> > what point do they get reviewed?
>> >
>> > On Wed, Aug 24, 2016 at 1:16 AM, Steven Gill 
>> > wrote:
>> >
>> > > Thoughts? Any PRs to bring to my attention?
>> > >
>> > > Will aim to start it later this week.
>> > >
>> >
>>
>
>







Re: [Discuss] plugins release

2016-08-29 Thread julio cesar sanchez
If somebody with an iPad that supports multitasking can test this PR...
https://github.com/apache/cordova-plugin-statusbar/pull/62

I have reviewed the code and looks good, bud I don't have an iPad that
supports multitasking to test it, and I don't trust the simulator in this
case as I tried to fix that issue in a different way, got it working on the
simulator but the reporter said that it didn't work as expected on a real
device.

2016-08-25 0:54 GMT+02:00 julio cesar sanchez :

> PRs to review
> https://github.com/apache/cordova-plugin-contacts/pull/131
> https://github.com/apache/cordova-plugin-camera/pull/229
>
> 2016-08-24 20:20 GMT+02:00 Steven Gill :
>
>> Hey Scott,
>>
>> Thanks for pointing out the PR. I'll take a look.
>>
>> The reality of the situation is that cordova has many repos and not enough
>> committers currently. This leads to PRs sitting unreviewed. Plugin PRs are
>> unique in that they can involve various different native language changes.
>> This could require more than 1 committer needing to review. For example,
>> some committers are more experienced with android vs ios, so they won't be
>> able to review the ios portion of the plugin PR. Another issue with plugin
>> PRs is that they may try to add a new feature (without discussion) and may
>> not add similar functionality for other platforms that support the plugin.
>> And of course lots of PRs don't include tests.
>>
>> The name being attached to component doesn't mean anything. Issues by
>> default go unassigned.
>>
>> I can only speak on behalf of the regular Adobe cordova commiters (4 of
>> us). Our focus is usually spent on platforms + tools fixes and
>> improvements.
>>
>> The best way to get attention for your PR is to post it to slack + here. I
>> usually do a review of PRs when I do a plugins release, but I won't be
>> able
>> to go through them all. This is why I ask for people to bring some to my
>> attention during releases.
>>
>> Lastly, we would love to help onboard new committers to help manage
>> plugins. If you are interested in such a role, LMK!
>>
>> Cheers,
>> -Steve
>>
>> On Wed, Aug 24, 2016 at 6:14 AM, Scott Bradshaw 
>> wrote:
>>
>> > Hi Steven - Can you look at camera PR 197
>> > ? This
>> addresses
>> > a major bug in the Android camera plugin where it won't rotate pictures
>> > chosen from the library. This bug has been around since Android 4.4 was
>> > released.  I worked on this at the beginning of the year, but it's just
>> > sitting there.  I'm new to Cordova, so I don't know exactly what the
>> > process is to get someone to look at it. I've joined Slack to find
>> someone
>> > to look at it, but no luck. Your name appears to be a attached
>> > > > com.atlassian.jira.jira-projects-plugin:components-panel>
>> > to most of the plugins, including camera. This also isn't the only PR
>> out
>> > there for camera. Several are just sitting there waiting for review. At
>> > what point do they get reviewed?
>> >
>> > On Wed, Aug 24, 2016 at 1:16 AM, Steven Gill 
>> > wrote:
>> >
>> > > Thoughts? Any PRs to bring to my attention?
>> > >
>> > > Will aim to start it later this week.
>> > >
>> >
>>
>
>


[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/62
  
It looks good now.
Sadly I don't have an iPad Pro to test it, I'm going to send a mail on the 
developer mailing list to see if somebody can test it.

In the meantime, can you sign the Individual Contributor Licenser Agreement 
http://www.apache.org/licenses/#clas and mail it to secret...@apache.org?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media pull request #113: CB-11757 (ios) Error out if trying t...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/113
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [iOS] Feature change - updates in config.xml

2016-08-29 Thread julio cesar sanchez
+1

2016-08-29 10:51 GMT+02:00 Shazron :

> Due to lazy consensus, I will proceed with this change.
>
> On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts 
> wrote:
>
> > +1; totally fine with this. :-)
> >
> > ~ Kerri
> >
> > > On Aug 24, 2016, at 20:30, Shazron  wrote:
> > >
> > > More details and discussion in:
> > > https://issues.apache.org/jira/browse/CB-11712
> > >
> > > In brief, the proposed change is:
> > >  changes in config.xml will not be allowed, and cordova will
> print
> > an
> > > error, with instructions on what to do instead. The instructions will
> > tell
> > > the user to do a `cordova platform rm ios` then a `cordova platform add
> > > ios`. This should be pretty quick since we cache platforms.
> > >
> > > Before hitting "Reply" to this email with your comment, check out the
> > issue
> > > where we discuss this in length.
> >
> >
>


Re: [iOS] Feature change - updates in config.xml

2016-08-29 Thread Shazron
Due to lazy consensus, I will proceed with this change.

On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts 
wrote:

> +1; totally fine with this. :-)
>
> ~ Kerri
>
> > On Aug 24, 2016, at 20:30, Shazron  wrote:
> >
> > More details and discussion in:
> > https://issues.apache.org/jira/browse/CB-11712
> >
> > In brief, the proposed change is:
> >  changes in config.xml will not be allowed, and cordova will print
> an
> > error, with instructions on what to do instead. The instructions will
> tell
> > the user to do a `cordova platform rm ios` then a `cordova platform add
> > ios`. This should be pretty quick since we cache platforms.
> >
> > Before hitting "Reply" to this email with your comment, check out the
> issue
> > where we discuss this in length.
>
>


Nightly builds - npm publish issue

2016-08-29 Thread Shazron
See: https://issues.apache.org/jira/browse/CB-11778

Long story short -- we need to use node 6.x to publish the npm nightlies.

I know the nightly CI uses coho, is it a matter of just updating coho code
and the CI picks it up, or do we have to do something else?


[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/113
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/113/commits/22f99bcc8f7ab98d3115fb06f7deb0abfab8d84c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/77//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
Starting in October 20th google won't allow to use WebViews (like 
inAppBrowser) for OAuth, so I think that's another reason to not change the 
behaviour of the plugin just to fix the OAuth


https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org