[GitHub] cordova-js pull request #141: CB-12017 : updated npm dependency for browseri...

2017-10-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/141


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request #145: CB-12762 : point package.json repo items to gi...

2017-10-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/145


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #503 for cordova has succeeded!

2017-10-03 Thread Apache Jenkins Server 
Nightly build #503 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/503/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #596: CB-13303 : added save_exact and production op...

2017-10-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/596


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option

2017-10-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/286


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...

2017-10-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/287


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova iOS 4.5.2 Release

2017-10-03 Thread Suraj Pindoria 
We just did a release a few weeks ago but there were some other iOS 11 /
Xcode 9 issues that came up shorty afterwards. That particular issue has
been resolved and is already merged in to master.

https://issues.apache.org/jira/browse/CB-13315

I'd also like to include another that updates the icon mapping so we
properly handle the new devices as well as Apple Watch icons.

https://issues.apache.org/jira/browse/CB-12896

Is there anything else people are aware of that should be apart of this
next release?

[GitHub] cordova-lib pull request #596: CB-13303 : added save_exact and production op...

2017-10-03 Thread audreyso 
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/596

CB-13303 : added save_exact and production opts



### Platforms affected


### What does this PR do?

Added save-exact and production opts

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-13303

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #596


commit cdcfb60d3b5172c2c52ac7afe72e43610068af05
Author: Audrey So 
Date:   2017-10-03T22:57:52Z

CB-13303 : added save_exact and production opts




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...

2017-10-03 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/287#discussion_r142530184
  
--- Diff: src/cli.js ---
@@ -475,8 +491,11 @@ function cli (inputArgs) {
 link: args.link || false,
 save: args.save,
 shrinkwrap: args.shrinkwrap || false,
-force: args.force || false
+force: args.force || false,
+production: args.production,
+noprod: args.noprod || false
--- End diff --

no need to pass noprod, it is only used to figure out production. Which you 
do on L454


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...

2017-10-03 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/287#discussion_r142529980
  
--- Diff: src/cli.js ---
@@ -465,6 +473,14 @@ function cli (inputArgs) {
 // User explicitly did not pass in searchpath
 args.searchpath = conf.get('searchpath');
 }
+if (args.production === undefined) {
+// User explicitly did not pass in noprod
+args.production = conf.get('production');
+}
+if (args.noprod === undefined) {
--- End diff --

lets not offer `noprod` in config. Just `args.production`. We only need 
noprod like you have in line 454. Used to figure out of args.production is true 
or false. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...

2017-10-03 Thread audreyso 
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-cli/pull/287

CB-13303 : added noprod/production as an option, no prod turns off pr…

…oduction



### Platforms affected


### What does this PR do?
Added noprod/production as an option

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-cli CB-13303

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #287


commit 145c1e6acc9152e39aeb3d2ebae5a1d4d5843e43
Author: Audrey So 
Date:   2017-10-03T21:14:18Z

CB-13303 : added noprod/production as an option, no prod turns off 
production




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option

2017-10-03 Thread audreyso 
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/286#discussion_r142508791
  
--- Diff: src/cli.js ---
@@ -449,6 +450,10 @@ function cli (inputArgs) {
 args.save = true;
 }
 
+if (args['save-exact']) {
--- End diff --

@stevengill Hmm you are right, I don't think these are needed. I will take 
it out. The test still passes without these lines and manual tests work too.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #591: CB-13274 : updated readme.md & removed refere...

2017-10-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/591


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option

2017-10-03 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/286#discussion_r142484800
  
--- Diff: src/cli.js ---
@@ -449,6 +450,10 @@ function cli (inputArgs) {
 args.save = true;
 }
 
+if (args['save-exact']) {
--- End diff --

what happens if you don't have lines 453-456? Are they needed?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option

2017-10-03 Thread audreyso 
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/286#discussion_r142480887
  
--- Diff: src/cli.js ---
@@ -443,12 +444,16 @@ function cli (inputArgs) {
 });
 }
 
-if (args.nosave) {
+if (args.nosave || args['save-exact']) {
--- End diff --

kk updated! thanks!


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #286: CB-13353 : added save-exact option

2017-10-03 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/286#discussion_r142475924
  
--- Diff: src/cli.js ---
@@ -443,12 +444,16 @@ function cli (inputArgs) {
 });
 }
 
-if (args.nosave) {
+if (args.nosave || args['save-exact']) {
--- End diff --

this change is probably not needed since we handle the save or save-exact 
or no-save flags in cordova-fetch. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org