[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/129#discussion_r80821223 --- Diff: src/platform-release.js --- @@ -131,15 +133,15 @@ exports.prepareReleaseBranchCommand = function*() { var repos = flagutil.computeReposFromFlag(argv.r); var version = flagutil.validateVersionString(argv.version); var branchName = getVersionBranchName(version); - +var platform = repos.id; --- End diff -- this is the wrong way to get platform. Instead get it from the `repo.id` from within the foreach below --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/129#discussion_r80821237 --- Diff: src/platform-release.js --- @@ -162,6 +164,30 @@ exports.prepareReleaseBranchCommand = function*() { yield versionutil.updateRepoVersion(repo, devVersion); yield updateJsSnapshot(repo, devVersion); yield gitutil.gitCheckout(branchName); + +print(repo.repoName + ': ' + 'Setting VERSION to "' + version + '" on branch + "4.2.x".'); --- End diff -- This line is not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/129#discussion_r75238702 --- Diff: src/platform-release.js --- @@ -162,6 +164,30 @@ exports.prepareReleaseBranchCommand = function*() { yield versionutil.updateRepoVersion(repo, devVersion); yield updateJsSnapshot(repo, devVersion); yield gitutil.gitCheckout(branchName); + +print(repo.repoName + ': ' + 'Setting VERSION to "' + version + '" on branch + "4.2.x".'); --- End diff -- 4.2.x is hardcoded here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
GitHub user juliascript reopened a pull request: https://github.com/apache/cordova-coho/pull/129 CB-11642 Update CDVAvailability.h See https://issues.apache.org/jira/browse/CB-11642 You can merge this pull request into a Git repository by running: $ git pull https://github.com/juliascript/cordova-coho CB-11642 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit 3bbaf2d5efa8fc2de3c324d5de9662bd5ee0e24b Author: juliascript Date: 2016-07-29T00:44:52Z CB-11642 update CDVAvailability.h commit 8df4d0f43fee407b41b8069b515a07525637d0bb Author: juliascript Date: 2016-07-29T00:48:21Z CB-11642 update CDVAvailability.h --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
Github user juliascript closed the pull request at: https://github.com/apache/cordova-coho/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
GitHub user juliascript opened a pull request: https://github.com/apache/cordova-coho/pull/129 CB-11642 Update CDVAvailability.h See https://issues.apache.org/jira/browse/CB-11642 You can merge this pull request into a Git repository by running: $ git pull https://github.com/juliascript/cordova-coho CB-11642 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit 3bbaf2d5efa8fc2de3c324d5de9662bd5ee0e24b Author: juliascript Date: 2016-07-29T00:44:52Z CB-11642 update CDVAvailability.h commit 8df4d0f43fee407b41b8069b515a07525637d0bb Author: juliascript Date: 2016-07-29T00:48:21Z CB-11642 update CDVAvailability.h --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org