[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/398#issuecomment-188710263
  
Thanks for advice, @TimBarham. Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/398#issuecomment-188545978
  
A simpler fix might be: since all we're looking for is the project's `id`, 
why not fall back on the main Cordova project's `config.xml` if we don't find a 
platform specific one? We could change this in 
`cordova-lib\src\plugman\platforms\browser.js`. Or, since this code is fairly 
common across several platforms, we could provide a single implementation (in 
`common.js`, perhaps?) for those that need it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/398#issuecomment-188373756
  
Looking into failures...

Another possible fix here - update `browser` platform rather than 
introducing additional complexity to platform adding process. We just need to 
generate valid `config.xml` in browser's `bin/create` script according to 
passed parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/398#issuecomment-188327164
  
@TimBarham, could you take a look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/398

CB-10662 Apply project config to platform before installing any plugins

JIRA: [CB-10662](https://issues.apache.org/jira/browse/CB-10662)

This change is needed because some platforms (`browser` in particular)  
doesn't contain own `config.xml` and rely on cordova, which generates one from 
defaults during `prepare`. However, prepare now called after plugin 
installation (after b04db5feaf5516836c8a157cc3331b75d6dca0eb) and hence fails 
due to abscence of config.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10662

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #398


commit 890fb8ea27baef5d384c906756e4c01eaaf5ed7e
Author: Vladimir Kotikov 
Date:   2016-02-24T16:03:41Z

CB-10662 Apply project config to platform before installing any plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org