Re: cli docs - spaces in main activity name
I've patched CB-4198 so this should no longer be an issue on both windows and nix On 7/22/13 10:44 AM, Don Coleman don.cole...@gmail.com wrote: Had those backwards https://issues.apache.org/jira/browse/CB-4198 is the issue. On Mon, Jul 22, 2013 at 1:41 PM, Don Coleman don.cole...@gmail.com wrote: Stripping spaces and other invalid chars seems preferable to adding another parameter. There is an issue https://issues.apache.org/jira/browse/CB-4074, which appears to be *incorrectly* marked as a dup of CB-4198. On Mon, Jul 22, 2013 at 1:10 PM, Michael Sierra msie...@adobe.com wrote: I just added a JIRA CB-4343 for bb10 modified it to include android. This appears new to 3.0; had no problem with Hello World prior. --Mike S From: brian.ler...@gmail.com [brian.ler...@gmail.com] On Behalf Of Brian LeRoux [b...@brian.io] Sent: Monday, July 22, 2013 12:21 PM To: dev@cordova.apache.org Subject: Re: cli docs - spaces in main activity name At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-l ine%20Interface_create_the_app
Re: cli docs - spaces in main activity name
I've patched the android create bash script and pushed to master. Will do windows tomorrow. On 7/22/13 10:44 AM, Don Coleman don.cole...@gmail.com wrote: Had those backwards https://issues.apache.org/jira/browse/CB-4198 is the issue. On Mon, Jul 22, 2013 at 1:41 PM, Don Coleman don.cole...@gmail.com wrote: Stripping spaces and other invalid chars seems preferable to adding another parameter. There is an issue https://issues.apache.org/jira/browse/CB-4074, which appears to be *incorrectly* marked as a dup of CB-4198. On Mon, Jul 22, 2013 at 1:10 PM, Michael Sierra msie...@adobe.com wrote: I just added a JIRA CB-4343 for bb10 modified it to include android. This appears new to 3.0; had no problem with Hello World prior. --Mike S From: brian.ler...@gmail.com [brian.ler...@gmail.com] On Behalf Of Brian LeRoux [b...@brian.io] Sent: Monday, July 22, 2013 12:21 PM To: dev@cordova.apache.org Subject: Re: cli docs - spaces in main activity name At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-l ine%20Interface_create_the_app
cli docs - spaces in main activity name
The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface_create_the_app
Re: cli docs - spaces in main activity name
At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface_create_the_app
Re: cli docs - spaces in main activity name
The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface_create_the_app
RE: cli docs - spaces in main activity name
I just added a JIRA CB-4343 for bb10 modified it to include android. This appears new to 3.0; had no problem with Hello World prior. --Mike S From: brian.ler...@gmail.com [brian.ler...@gmail.com] On Behalf Of Brian LeRoux [b...@brian.io] Sent: Monday, July 22, 2013 12:21 PM To: dev@cordova.apache.org Subject: Re: cli docs - spaces in main activity name At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface_create_the_app
Re: cli docs - spaces in main activity name
Stripping spaces and other invalid chars seems preferable to adding another parameter. There is an issue https://issues.apache.org/jira/browse/CB-4074, which appears to be *incorrectly* marked as a dup of CB-4198. On Mon, Jul 22, 2013 at 1:10 PM, Michael Sierra msie...@adobe.com wrote: I just added a JIRA CB-4343 for bb10 modified it to include android. This appears new to 3.0; had no problem with Hello World prior. --Mike S From: brian.ler...@gmail.com [brian.ler...@gmail.com] On Behalf Of Brian LeRoux [b...@brian.io] Sent: Monday, July 22, 2013 12:21 PM To: dev@cordova.apache.org Subject: Re: cli docs - spaces in main activity name At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface_create_the_app
Re: cli docs - spaces in main activity name
Had those backwards https://issues.apache.org/jira/browse/CB-4198 is the issue. On Mon, Jul 22, 2013 at 1:41 PM, Don Coleman don.cole...@gmail.com wrote: Stripping spaces and other invalid chars seems preferable to adding another parameter. There is an issue https://issues.apache.org/jira/browse/CB-4074, which appears to be *incorrectly* marked as a dup of CB-4198. On Mon, Jul 22, 2013 at 1:10 PM, Michael Sierra msie...@adobe.com wrote: I just added a JIRA CB-4343 for bb10 modified it to include android. This appears new to 3.0; had no problem with Hello World prior. --Mike S From: brian.ler...@gmail.com [brian.ler...@gmail.com] On Behalf Of Brian LeRoux [b...@brian.io] Sent: Monday, July 22, 2013 12:21 PM To: dev@cordova.apache.org Subject: Re: cli docs - spaces in main activity name At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-line%20Interface_create_the_app
Re: cli docs - spaces in main activity name
I think it's an issue with Android's underlying create script. It should be smart enough to know to munge the title-with-spaces for its code purposes (Java package name, Activity, etc), but leave it as-is for the labeling. Thx for filing I will look into it when I can. On 7/22/13 10:44 AM, Don Coleman don.cole...@gmail.com wrote: Had those backwards https://issues.apache.org/jira/browse/CB-4198 is the issue. On Mon, Jul 22, 2013 at 1:41 PM, Don Coleman don.cole...@gmail.com wrote: Stripping spaces and other invalid chars seems preferable to adding another parameter. There is an issue https://issues.apache.org/jira/browse/CB-4074, which appears to be *incorrectly* marked as a dup of CB-4198. On Mon, Jul 22, 2013 at 1:10 PM, Michael Sierra msie...@adobe.com wrote: I just added a JIRA CB-4343 for bb10 modified it to include android. This appears new to 3.0; had no problem with Hello World prior. --Mike S From: brian.ler...@gmail.com [brian.ler...@gmail.com] On Behalf Of Brian LeRoux [b...@brian.io] Sent: Monday, July 22, 2013 12:21 PM To: dev@cordova.apache.org Subject: Re: cli docs - spaces in main activity name At some point we just stripped spaces. I imagine this created a bug and my guess is we removed the functionality rather than addressing the issue. We def do not want titles with no spaces! Maybe we add a fourth param. On Mon, Jul 22, 2013 at 12:10 PM, Andrew Grieve agri...@chromium.org wrote: The third parameter is the app's title, so I think it should be made to work with spaces. On Mon, Jul 22, 2013 at 12:07 PM, Don Coleman don.cole...@gmail.com wrote: The CLI docs for creating an app, use a main activity name containing a space $ cordova create HelloWorld com.example.hello Hello World This works for iOS but fails on Android. Should we adjust the docs, or attempt to make the Android scripts remove spaces? http://docs.phonegap.com/en/edge/guide_cli_index.md.html#The%20Command-l ine%20Interface_create_the_app
