Re: Copied classes in cxf-rt-management.jar with JDK11
Hi Jim, I mean remove it from CXF 4.x which is JDK11 minimum. Freeman On Wed, Apr 20, 2022 at 8:45 PM Jim Ma wrote: > Hi Freeman, > Are you saying we can remove this java9-plus profile completely from 3.4.x > to 4.x? > > Cheers, > Jim > > On Wed, Apr 20, 2022 at 10:45 PM Freeman Fang > wrote: > >> Hi Jim, >> >> Without it, on JDK11 we will see META-INF.versions.11 from the export >> package part, and we don't want it. And this META-INF.versions.11 thing is >> from the maven-compiler-plugin in java9-plus profile. >> The expected Export-Package should be like >> Export-Package: >> org.apache.cxf.tracing;version="4.0.0", >> org.apache.cxf.management.jmx;version="4.0.0", >> org.apache.cxf.management.jmx.type;version="4.0.0", >> org.apache.cxf.management.jmx.export.runtime;version="4.0.0", >> org.apache.cxf.management.utils;version="4.0.0", >> org.apache.cxf.management.persistence;version="4.0.0", >> org.apache.cxf.management.counters;version="4.0.0", >> org.apache.cxf.management.interceptor;version="4.0.0" >> >> The mystery in this profile was introduced in the first place to both >> support JDK8 and JDK11. Since for CXF 4.x the minimum JDK version is >> JDK11(don't need to consider JDK8 compatible anymore), I believe we are >> safe to remove java9-plus profile in management/pom.xml all together. >> >> Cheers >> Freeman >> >> On Tue, Apr 19, 2022 at 10:34 PM Jim Ma wrote: >> >>> Hi Freeman, >>> Do you know why we don't require this with JDK8 and only for JDK9 and >>> plus ? >>> I see the Export package info in META-INF built with JDK11 without this >>> configuration already has this >>> export package entry : >>> >>> Export-Package: org.apache.cxf.tracing;version="3.5.3",org.apache.cxf. >>> management.jmx;version="3.5.3",org.apache.cxf.management.jmx.type;ver >>> sion="3.5.3",org.apache.cxf.management.jmx.export.runtime;version="3. >>> 5.3",org.apache.cxf.management.utils;version="3.5.3",org.apache.cxf.m >>> anagement.persistence;version="3.5.3",org.apache.cxf.management.count >>> ers;version="3.5.3",org.apache.cxf.management.interceptor;version="3. >>> 5.3",META-INF.versions.11.org.apache.cxf.tracing;version="3.5.3",META >>> -INF.versions.11.org.apache.cxf.management.jmx;version="3.5.3",META-I >>> NF.versions.11.org.apache.cxf.management.jmx.type;version="3.5.3",MET >>> A-INF.versions.11.org.apache.cxf.management.jmx.export.runtime;versio >>> n="3.5.3",META-INF.versions.11.org.apache.cxf.management.utils;versio >>> n="3.5.3",META-INF.versions.11.org.apache.cxf.management.persistence; >>> version="3.5.3",META-INF.versions.11.org.apache.cxf.management.counte >>> rs;version="3.5.3",META-INF.versions.11.org.apache.cxf.management.int >>> erceptor;version="3.5.3" >>> >>> >>> Cheers, >>> Jim >>> >>> >>> On Wed, Apr 20, 2022 at 3:04 AM Freeman Fang >>> wrote: >>> Hi Jim, Please change the rt/management/pom.xml like this. NONE - org.apache.cxf.management*,org.apache.cxf.tracing* + + org.apache.cxf.management.counters, + org.apache.cxf.management.interceptor, + org.apache.cxf.management.persistence, + org.apache.cxf.management.utils, + org.apache.cxf.management.jmx, + org.apache.cxf.management.jmx.export.runtime, +org.apache.cxf.tracing* + true This fine-grained export package can avoid including the package from cxf-core module. Best Regards Freeman On Mon, Apr 18, 2022 at 11:50 PM Jim Ma wrote: > Thanks Andriy. Jira is filled : > https://issues.apache.org/jira/browse/CXF-8695 > and PRs are sent. > > > On Sun, Apr 17, 2022 at 9:28 AM Andriy Redko wrote: > > > Hey Jim, > > > > This is interesting, I believe it is not needed, only some compiler > args > > need > > tailoring (for JDK-11) but the classes should not be copied to > versions/11. > > Thanks! > > > > Best Regards, > > Andriy Redko > > > > JM> When building cxf-rt-management 3.5.1 with JDK11, some api > classes are > > JM> copied to the jar file. It looks like these classes are copied > by the > > JM> maven-bundle-plugin from java9-plus profile : > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > JM> *java9-plus > > [9,) > > JM> > > JM> org.apache.felix > > JM> maven-bundle-plugin > > JM> true > > JM> NONE > > > > > > JM> > > >
Re: Copied classes in cxf-rt-management.jar with JDK11
Hi Freeman, Are you saying we can remove this java9-plus profile completely from 3.4.x to 4.x? Cheers, Jim On Wed, Apr 20, 2022 at 10:45 PM Freeman Fang wrote: > Hi Jim, > > Without it, on JDK11 we will see META-INF.versions.11 from the export > package part, and we don't want it. And this META-INF.versions.11 thing is > from the maven-compiler-plugin in java9-plus profile. > The expected Export-Package should be like > Export-Package: > org.apache.cxf.tracing;version="4.0.0", > org.apache.cxf.management.jmx;version="4.0.0", > org.apache.cxf.management.jmx.type;version="4.0.0", > org.apache.cxf.management.jmx.export.runtime;version="4.0.0", > org.apache.cxf.management.utils;version="4.0.0", > org.apache.cxf.management.persistence;version="4.0.0", > org.apache.cxf.management.counters;version="4.0.0", > org.apache.cxf.management.interceptor;version="4.0.0" > > The mystery in this profile was introduced in the first place to both > support JDK8 and JDK11. Since for CXF 4.x the minimum JDK version is > JDK11(don't need to consider JDK8 compatible anymore), I believe we are > safe to remove java9-plus profile in management/pom.xml all together. > > Cheers > Freeman > > On Tue, Apr 19, 2022 at 10:34 PM Jim Ma wrote: > >> Hi Freeman, >> Do you know why we don't require this with JDK8 and only for JDK9 and >> plus ? >> I see the Export package info in META-INF built with JDK11 without this >> configuration already has this >> export package entry : >> >> Export-Package: org.apache.cxf.tracing;version="3.5.3",org.apache.cxf. >> management.jmx;version="3.5.3",org.apache.cxf.management.jmx.type;ver >> sion="3.5.3",org.apache.cxf.management.jmx.export.runtime;version="3. >> 5.3",org.apache.cxf.management.utils;version="3.5.3",org.apache.cxf.m >> anagement.persistence;version="3.5.3",org.apache.cxf.management.count >> ers;version="3.5.3",org.apache.cxf.management.interceptor;version="3. >> 5.3",META-INF.versions.11.org.apache.cxf.tracing;version="3.5.3",META >> -INF.versions.11.org.apache.cxf.management.jmx;version="3.5.3",META-I >> NF.versions.11.org.apache.cxf.management.jmx.type;version="3.5.3",MET >> A-INF.versions.11.org.apache.cxf.management.jmx.export.runtime;versio >> n="3.5.3",META-INF.versions.11.org.apache.cxf.management.utils;versio >> n="3.5.3",META-INF.versions.11.org.apache.cxf.management.persistence; >> version="3.5.3",META-INF.versions.11.org.apache.cxf.management.counte >> rs;version="3.5.3",META-INF.versions.11.org.apache.cxf.management.int >> erceptor;version="3.5.3" >> >> >> Cheers, >> Jim >> >> >> On Wed, Apr 20, 2022 at 3:04 AM Freeman Fang >> wrote: >> >>> Hi Jim, >>> >>> Please change the rt/management/pom.xml like this. >>> >>> >>> NONE >>> >>> - >>> >>> org.apache.cxf.management*,org.apache.cxf.tracing* >>> + >>> + >>> org.apache.cxf.management.counters, >>> + >>> org.apache.cxf.management.interceptor, >>> + >>> org.apache.cxf.management.persistence, >>> + >>> org.apache.cxf.management.utils, >>> + >>> org.apache.cxf.management.jmx, >>> + >>> org.apache.cxf.management.jmx.export.runtime, >>> +org.apache.cxf.tracing* >>> + >>> >>> true >>> >>> This fine-grained export package can avoid including the package from >>> cxf-core module. >>> >>> Best Regards >>> Freeman >>> >>> On Mon, Apr 18, 2022 at 11:50 PM Jim Ma wrote: >>> Thanks Andriy. Jira is filled : https://issues.apache.org/jira/browse/CXF-8695 and PRs are sent. On Sun, Apr 17, 2022 at 9:28 AM Andriy Redko wrote: > Hey Jim, > > This is interesting, I believe it is not needed, only some compiler args > need > tailoring (for JDK-11) but the classes should not be copied to versions/11. > Thanks! > > Best Regards, > Andriy Redko > > JM> When building cxf-rt-management 3.5.1 with JDK11, some api classes are > JM> copied to the jar file. It looks like these classes are copied by the > JM> maven-bundle-plugin from java9-plus profile : > > > > > > > > > > > > > > > > > > > > > > > JM> *java9-plus > [9,) > JM> > JM> org.apache.felix > JM> maven-bundle-plugin > JM> true > JM> NONE > > > JM> > org.apache.cxf.management*,org.apache.cxf.tracing* > JM> > JM> true > JM>* > > JM> Why does cxf-rt-management need to copy these classes to the jar file > ? Is > JM> it still needed to duplicate these classes from cxf-core ? >
Re: Copied classes in cxf-rt-management.jar with JDK11
Hi Jim, Without it, on JDK11 we will see META-INF.versions.11 from the export package part, and we don't want it. And this META-INF.versions.11 thing is from the maven-compiler-plugin in java9-plus profile. The expected Export-Package should be like Export-Package: org.apache.cxf.tracing;version="4.0.0", org.apache.cxf.management.jmx;version="4.0.0", org.apache.cxf.management.jmx.type;version="4.0.0", org.apache.cxf.management.jmx.export.runtime;version="4.0.0", org.apache.cxf.management.utils;version="4.0.0", org.apache.cxf.management.persistence;version="4.0.0", org.apache.cxf.management.counters;version="4.0.0", org.apache.cxf.management.interceptor;version="4.0.0" The mystery in this profile was introduced in the first place to both support JDK8 and JDK11. Since for CXF 4.x the minimum JDK version is JDK11(don't need to consider JDK8 compatible anymore), I believe we are safe to remove java9-plus profile in management/pom.xml all together. Cheers Freeman On Tue, Apr 19, 2022 at 10:34 PM Jim Ma wrote: > Hi Freeman, > Do you know why we don't require this with JDK8 and only for JDK9 and plus > ? > I see the Export package info in META-INF built with JDK11 without this > configuration already has this > export package entry : > > Export-Package: org.apache.cxf.tracing;version="3.5.3",org.apache.cxf. > management.jmx;version="3.5.3",org.apache.cxf.management.jmx.type;ver > sion="3.5.3",org.apache.cxf.management.jmx.export.runtime;version="3. > 5.3",org.apache.cxf.management.utils;version="3.5.3",org.apache.cxf.m > anagement.persistence;version="3.5.3",org.apache.cxf.management.count > ers;version="3.5.3",org.apache.cxf.management.interceptor;version="3. > 5.3",META-INF.versions.11.org.apache.cxf.tracing;version="3.5.3",META > -INF.versions.11.org.apache.cxf.management.jmx;version="3.5.3",META-I > NF.versions.11.org.apache.cxf.management.jmx.type;version="3.5.3",MET > A-INF.versions.11.org.apache.cxf.management.jmx.export.runtime;versio > n="3.5.3",META-INF.versions.11.org.apache.cxf.management.utils;versio > n="3.5.3",META-INF.versions.11.org.apache.cxf.management.persistence; > version="3.5.3",META-INF.versions.11.org.apache.cxf.management.counte > rs;version="3.5.3",META-INF.versions.11.org.apache.cxf.management.int > erceptor;version="3.5.3" > > > Cheers, > Jim > > > On Wed, Apr 20, 2022 at 3:04 AM Freeman Fang > wrote: > >> Hi Jim, >> >> Please change the rt/management/pom.xml like this. >> >> >> NONE >> >> - >> >> org.apache.cxf.management*,org.apache.cxf.tracing* >> + >> + >> org.apache.cxf.management.counters, >> + >> org.apache.cxf.management.interceptor, >> + >> org.apache.cxf.management.persistence, >> + >> org.apache.cxf.management.utils, >> + >> org.apache.cxf.management.jmx, >> + >> org.apache.cxf.management.jmx.export.runtime, >> +org.apache.cxf.tracing* >> + >> >> true >> >> This fine-grained export package can avoid including the package from >> cxf-core module. >> >> Best Regards >> Freeman >> >> On Mon, Apr 18, 2022 at 11:50 PM Jim Ma wrote: >> >>> Thanks Andriy. Jira is filled : >>> https://issues.apache.org/jira/browse/CXF-8695 >>> and PRs are sent. >>> >>> >>> On Sun, Apr 17, 2022 at 9:28 AM Andriy Redko wrote: >>> >>> > Hey Jim, >>> > >>> > This is interesting, I believe it is not needed, only some compiler >>> args >>> > need >>> > tailoring (for JDK-11) but the classes should not be copied to >>> versions/11. >>> > Thanks! >>> > >>> > Best Regards, >>> > Andriy Redko >>> > >>> > JM> When building cxf-rt-management 3.5.1 with JDK11, some api classes >>> are >>> > JM> copied to the jar file. It looks like these classes are copied by >>> the >>> > JM> maven-bundle-plugin from java9-plus profile : >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > JM> *java9-plus >>> > [9,) >>> > JM> >>> > JM> org.apache.felix >>> > JM> maven-bundle-plugin >>> > JM> true >>> > JM> NONE >>> > >>> > >>> > JM> >>> > >>> org.apache.cxf.management*,org.apache.cxf.tracing* >>> > JM> >>> > JM> true >>> > JM>* >>> > >>> > JM> Why does cxf-rt-management need to copy these classes to the jar >>> file >>> > ? Is >>> > JM> it still needed to duplicate these classes from cxf-core ? >>> > >>> > JM> Thanks, >>> > JM> Jim >>> > >>> > >>> >>
[GitHub] [cxf] coheigea commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
coheigea commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1103855956 Thanks, it's in https://github.com/apache/ws-wss4j -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1103854290 > The JPA tests are failing in rt/rs/security/oauth-parent/oauth2 - do we need to follow https://rmannibucau.metawerx.net/openjpa-jakarta-tips.html ? Yeah, we are trying to go module by module :-) but I will check the `security` since it is in a good shape now, thanks @coheigea ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1103852635 > Thanks @reta. When I try to upgrade WSS4J to use ehcache 3.10.0 I get this error, any ideas? > @coheigea it seems like the repositories are not set properly: http:// is blocked. I could take a look, is it for https://github.com/apache/santuario-xml-security-java? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] coheigea commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
coheigea commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1103502697 The JPA tests are failing in rt/rs/security/oauth-parent/oauth2 - do we need to follow https://rmannibucau.metawerx.net/openjpa-jakarta-tips.html ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
