Re: [dpdk-dev] [PATCH] test: adding AES cipher-only tests on QAT PMD

2016-12-13 Thread Yang, GangX
Tested-by: Yang Gang < gangx.y...@intel.com >
- Check patch: success
- Apply patch: success
- compilation: success
  OS: fedora21
  GCC: gcc_x86-64, 4.8.3
  Commit: dpdk-next-crypto( e6c7b6ec57f3527ce55fa3e0d2a8ed1533722253 )
  x86_64-native-linuxapp-gcc: compile pass
- dts validation:
-- Test Commit: 44a66e026d772dd626be32ad3fb0506839136f58
-- OS/Kernel: Fedora21/3.11.10-301.fc20.x86_64
-- GCC: gcc version 4.8.3
-- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
-- NIC: Intel Corporation Ethernet Controller X710 for 10GbE SFP+ [8086:1572]
-- total 2,failed 0 (case1: contain cryptodev_qat_perftest and all of others 
cryptodev cases on unit test .
 case 2: all of the related cases about AES cipher only on 
l2fwd-crypto test)


> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, 
> Pablo
> Sent: Wednesday, November 30, 2016 11:16 PM
> To: Kusztal, ArkadiuszX ; Trahe, Fiona 
> ; dev@dpdk.org
> Cc: Griffin, John 
> Subject: Re: [dpdk-dev] [PATCH] test: adding AES cipher-only tests on 
> QAT PMD
> 
> 
> 
> > -Original Message-
> > From: Kusztal, ArkadiuszX
> > Sent: Friday, November 25, 2016 2:14 PM
> > To: Trahe, Fiona; dev@dpdk.org
> > Cc: De Lara Guarch, Pablo; Griffin, John
> > Subject: RE: [PATCH] test: adding AES cipher-only tests on QAT PMD
> >
> >
> >
> > > -Original Message-
> > > From: Trahe, Fiona
> > > Sent: Thursday, November 24, 2016 6:29 PM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo ; Trahe, 
> > > Fiona ; Griffin, John 
> > > ; Kusztal, ArkadiuszX 
> > > 
> > > Subject: [PATCH] test: adding AES cipher-only tests on QAT PMD
> > >
> > > Extended functional AES-CBC and AES-CTR cipher-only tests to run 
> > > on QAT PMD.
> > > Added AES_CBC cipher-only performance tests on QAT PMD.
> > > No driver changes, but as now tested, QAT documentation is updated 
> > > to remove constraint.
> > >
> > > Signed-off-by: Fiona Trahe 
> > > ---
> > >  app/test/test_cryptodev.c  | 18 ++
> > >  app/test/test_cryptodev_aes_test_vectors.h | 36 +++
> > >  app/test/test_cryptodev_perf.c | 96 +++--
> > 
> > > -
> > >  doc/guides/cryptodevs/qat.rst  |  1 -
> > >  4 files changed, 102 insertions(+), 49 deletions(-)
> > >
> > > --
> > > 2.5.0
> > Acked-by: Arek Kusztal 
> 
> Applied to dpdk-next-crypto.
> Thanks,
> 
> Pablo


[dpdk-dev] [PATCH] test: adding AES cipher-only tests on QAT PMD

2016-11-30 Thread De Lara Guarch, Pablo


> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Friday, November 25, 2016 2:14 PM
> To: Trahe, Fiona; dev at dpdk.org
> Cc: De Lara Guarch, Pablo; Griffin, John
> Subject: RE: [PATCH] test: adding AES cipher-only tests on QAT PMD
> 
> 
> 
> > -Original Message-
> > From: Trahe, Fiona
> > Sent: Thursday, November 24, 2016 6:29 PM
> > To: dev at dpdk.org
> > Cc: De Lara Guarch, Pablo ; Trahe, Fiona
> > ; Griffin, John ; 
> > Kusztal,
> > ArkadiuszX 
> > Subject: [PATCH] test: adding AES cipher-only tests on QAT PMD
> >
> > Extended functional AES-CBC and AES-CTR cipher-only tests to run on QAT
> > PMD.
> > Added AES_CBC cipher-only performance tests on QAT PMD.
> > No driver changes, but as now tested, QAT documentation is updated to
> > remove constraint.
> >
> > Signed-off-by: Fiona Trahe 
> > ---
> >  app/test/test_cryptodev.c  | 18 ++
> >  app/test/test_cryptodev_aes_test_vectors.h | 36 +++
> >  app/test/test_cryptodev_perf.c | 96 +++--
> 
> > -
> >  doc/guides/cryptodevs/qat.rst  |  1 -
> >  4 files changed, 102 insertions(+), 49 deletions(-)
> >
> > --
> > 2.5.0
> Acked-by: Arek Kusztal 

Applied to dpdk-next-crypto.
Thanks,

Pablo


[dpdk-dev] [PATCH] test: adding AES cipher-only tests on QAT PMD

2016-11-25 Thread Kusztal, ArkadiuszX


> -Original Message-
> From: Trahe, Fiona
> Sent: Thursday, November 24, 2016 6:29 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo ; Trahe, Fiona
> ; Griffin, John ; 
> Kusztal,
> ArkadiuszX 
> Subject: [PATCH] test: adding AES cipher-only tests on QAT PMD
> 
> Extended functional AES-CBC and AES-CTR cipher-only tests to run on QAT
> PMD.
> Added AES_CBC cipher-only performance tests on QAT PMD.
> No driver changes, but as now tested, QAT documentation is updated to
> remove constraint.
> 
> Signed-off-by: Fiona Trahe 
> ---
>  app/test/test_cryptodev.c  | 18 ++
>  app/test/test_cryptodev_aes_test_vectors.h | 36 +++
>  app/test/test_cryptodev_perf.c | 96 +++--
> -
>  doc/guides/cryptodevs/qat.rst  |  1 -
>  4 files changed, 102 insertions(+), 49 deletions(-)
> 
> --
> 2.5.0
Acked-by: Arek Kusztal 


[dpdk-dev] [PATCH] test: adding AES cipher-only tests on QAT PMD

2016-11-24 Thread Fiona Trahe
Extended functional AES-CBC and AES-CTR cipher-only
tests to run on QAT PMD.
Added AES_CBC cipher-only performance tests on QAT PMD.
No driver changes, but as now tested, QAT documentation
is updated to remove constraint.

Signed-off-by: Fiona Trahe 
---
 app/test/test_cryptodev.c  | 18 ++
 app/test/test_cryptodev_aes_test_vectors.h | 36 +++
 app/test/test_cryptodev_perf.c | 96 +++---
 doc/guides/cryptodevs/qat.rst  |  1 -
 4 files changed, 102 insertions(+), 49 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 872f8b4..00dced5 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -1530,6 +1530,22 @@ test_AES_chain_qat_all(void)
 }

 static int
+test_AES_cipheronly_qat_all(void)
+{
+   struct crypto_testsuite_params *ts_params = &testsuite_params;
+   int status;
+
+   status = test_blockcipher_all_tests(ts_params->mbuf_pool,
+   ts_params->op_mpool, ts_params->valid_devs[0],
+   RTE_CRYPTODEV_QAT_SYM_PMD,
+   BLKCIPHER_AES_CIPHERONLY_TYPE);
+
+   TEST_ASSERT_EQUAL(status, 0, "Test failed");
+
+   return TEST_SUCCESS;
+}
+
+static int
 test_authonly_openssl_all(void)
 {
struct crypto_testsuite_params *ts_params = &testsuite_params;
@@ -6032,6 +6048,8 @@ static struct unit_test_suite cryptodev_qat_testsuite  = {
test_multi_session),

TEST_CASE_ST(ut_setup, ut_teardown, test_AES_chain_qat_all),
+   TEST_CASE_ST(ut_setup, ut_teardown,
+   test_AES_cipheronly_qat_all),
TEST_CASE_ST(ut_setup, ut_teardown, test_3DES_chain_qat_all),
TEST_CASE_ST(ut_setup, ut_teardown,
test_3DES_cipheronly_qat_all),
diff --git a/app/test/test_cryptodev_aes_test_vectors.h 
b/app/test/test_cryptodev_aes_test_vectors.h
index 1c68f93..efbe7da 100644
--- a/app/test/test_cryptodev_aes_test_vectors.h
+++ b/app/test/test_cryptodev_aes_test_vectors.h
@@ -1024,73 +1024,85 @@ static const struct blockcipher_test_case 
aes_cipheronly_test_cases[] = {
.test_descr = "AES-128-CBC Encryption",
.test_data = &aes_test_data_4,
.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-128-CBC Decryption",
.test_data = &aes_test_data_4,
.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-192-CBC Encryption",
.test_data = &aes_test_data_10,
.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-192-CBC Decryption",
.test_data = &aes_test_data_10,
.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-256-CBC Encryption",
.test_data = &aes_test_data_11,
.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-256-CBC Decryption",
.test_data = &aes_test_data_11,
.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-128-CTR Encryption",
.test_data = &aes_test_data_1,
.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "AES-128-CTR Decryption",
.test_data = &aes_test_data_1,
.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
-   .pmd_mask = BLOCKCIPHER_TEST_TA