[jira] [Commented] (FELIX-4842) CONTEXT.Source.INSTANCE cannot work

2015-04-02 Thread Clement Escoffier (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394102#comment-14394102
 ] 

Clement Escoffier commented on FELIX-4842:
--

How is the instance created ?

Context source does only work for instance declared from XML, @Instantiate and 
@Configuration. 
If you create the instance using the API or the configuration admin, they are 
no way to retrieve the bundle creating the instance.


> CONTEXT.Source.INSTANCE cannot work
> ---
>
> Key: FELIX-4842
> URL: https://issues.apache.org/jira/browse/FELIX-4842
> Project: Felix
>  Issue Type: Bug
>  Components: iPOJO
>Affects Versions: ipojo-runtime-1.12.1
>Reporter: armroe
>
> CONTEXT.Source.INSTANCE annotation cannot work. BundleContext cannot be 
> injected and always null.
> there is no problem with CONTEXT.Source.COMPONENT.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-4842) CONTEXT.Source.INSTANCE cannot work

2015-04-02 Thread armroe (JIRA)
armroe created FELIX-4842:
-

 Summary: CONTEXT.Source.INSTANCE cannot work
 Key: FELIX-4842
 URL: https://issues.apache.org/jira/browse/FELIX-4842
 Project: Felix
  Issue Type: Bug
  Components: iPOJO
Affects Versions: ipojo-runtime-1.12.1
Reporter: armroe


CONTEXT.Source.INSTANCE annotation cannot work. BundleContext cannot be 
injected and always null.
there is no problem with CONTEXT.Source.COMPONENT.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-4840) Asynchronous IO fails in webconsole plugin

2015-04-02 Thread Balazs Zsoldos (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392503#comment-14392503
 ] 

Balazs Zsoldos commented on FELIX-4840:
---

Btw.: I made a workaround in my plugin that I wrap the request in the plugin 
with HttpServletRequestWrapper and override the function of isAsyncSupported() 
in case of non-full page requests.

> Asynchronous IO fails in webconsole plugin
> --
>
> Key: FELIX-4840
> URL: https://issues.apache.org/jira/browse/FELIX-4840
> Project: Felix
>  Issue Type: Bug
>  Components: Web Console
>Affects Versions: webconsole-4.2.8
>Reporter: Balazs Zsoldos
>
> *Issue*
> The following function call always returns with true:
> {code:java}
> ServletRequest.isAsyncSupported()
> {code}
> However, async calls fail even if the webconsole plugin tries to provide some 
> resource (with some special extension on the end of the URI).
> *Reason*
> In the end of the _OSGiManager.service(ServletRequest, ServletResponse)_ 
> function, there is the following:
> {code:java}
> // ensure response has been sent back and response is committed
> // (we are authorative for our URL space and no other servlet should 
> interfere)
> res.flushBuffer();
> {code}
> Due to the reason that _flushBuffer()_ function is called, any asynchronous 
> handling will fail with an exception.
> *Proposed solution*
>  - In case the webconsole plugin is rendered (the path ends with / or .html), 
> the _request.isAsyncSupported()_ method call should return false
>  - In case a custom resource is provided by the webconsole plugin (any 
> extension but html on the end of the path) the _flushBuffer()_ method should 
> not be called
> At least the second part of the fix should be implemented as if a plugin 
> wants to provide bigger files (like a dump), async support can be useful. 
> Also, by the time more and more libraries will support asynchronous IO to 
> provide resources and if a webconsole plugin uses such library, it will fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-4840) Asynchronous IO fails in webconsole plugin

2015-04-02 Thread Balazs Zsoldos (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392473#comment-14392473
 ] 

Balazs Zsoldos commented on FELIX-4840:
---

I am not sure HTTPService implementation should be changed at all. It is up to 
the servlet if async is supported or not. In case of WebConsole, there are two 
different situations:

*A full page is rendered*

In this case async is not supported. I do not think async is an issue as 
plugins would not want to (and cannot) render their fragments asynchronously.

*The request is simply dispatched to the plugin*

This happens if the end of the uri neither ends with extension nor the 
extension is _.html_. When such a request comes, Webconsole should not call any 
function on the response By calling _flushBuffer()_, webconsole horns in on the 
lifecycle of the response although it should not.

> Asynchronous IO fails in webconsole plugin
> --
>
> Key: FELIX-4840
> URL: https://issues.apache.org/jira/browse/FELIX-4840
> Project: Felix
>  Issue Type: Bug
>  Components: Web Console
>Affects Versions: webconsole-4.2.8
>Reporter: Balazs Zsoldos
>
> *Issue*
> The following function call always returns with true:
> {code:java}
> ServletRequest.isAsyncSupported()
> {code}
> However, async calls fail even if the webconsole plugin tries to provide some 
> resource (with some special extension on the end of the URI).
> *Reason*
> In the end of the _OSGiManager.service(ServletRequest, ServletResponse)_ 
> function, there is the following:
> {code:java}
> // ensure response has been sent back and response is committed
> // (we are authorative for our URL space and no other servlet should 
> interfere)
> res.flushBuffer();
> {code}
> Due to the reason that _flushBuffer()_ function is called, any asynchronous 
> handling will fail with an exception.
> *Proposed solution*
>  - In case the webconsole plugin is rendered (the path ends with / or .html), 
> the _request.isAsyncSupported()_ method call should return false
>  - In case a custom resource is provided by the webconsole plugin (any 
> extension but html on the end of the path) the _flushBuffer()_ method should 
> not be called
> At least the second part of the fix should be implemented as if a plugin 
> wants to provide bigger files (like a dump), async support can be useful. 
> Also, by the time more and more libraries will support asynchronous IO to 
> provide resources and if a webconsole plugin uses such library, it will fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-4841) Support HttpSessionIdListener

2015-04-02 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created FELIX-4841:
---

 Summary: Support HttpSessionIdListener
 Key: FELIX-4841
 URL: https://issues.apache.org/jira/browse/FELIX-4841
 Project: Felix
  Issue Type: Sub-task
  Components: HTTP Service
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: http.base-3.0.0, http.jetty-3.1.0


The new http whiteboard specification supports servlet 3.1 including the new 
HttpSessionIdListener



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-4546) Implement HttpServiceRuntime service

2015-04-02 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392445#comment-14392445
 ] 

Carsten Ziegeler commented on FELIX-4546:
-

Thanks for the patch [~tkb] - could you please outline which parts are not 
implemented yet?

> Implement HttpServiceRuntime service
> 
>
> Key: FELIX-4546
> URL: https://issues.apache.org/jira/browse/FELIX-4546
> Project: Felix
>  Issue Type: Sub-task
>  Components: HTTP Service
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
> Fix For: http.base-3.0.0
>
> Attachments: felix-4546.e2a36d1.81e5a8f.patch, 
> felix-4546.failure_dtos.patch, felix-4546.resource_dto.patch, patch.txt
>
>
> Implement the Http Service Runtime service as described in RFC 189



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)