[jira] [Resolved] (FELIX-5989) java.lang.IllegalArgumentException from AbstractLogger.format when logging debug message
[ https://issues.apache.org/jira/browse/FELIX-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Watson resolved FELIX-5989. -- Resolution: Fixed Assignee: Thomas Watson Fix Version/s: scr-2.1.16 Fixed by not passing null arguments to the format when there are no place holders for the arguments in the log message. > java.lang.IllegalArgumentException from AbstractLogger.format when logging > debug message > > > Key: FELIX-5989 > URL: https://issues.apache.org/jira/browse/FELIX-5989 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) >Affects Versions: scr-2.1.12, scr-2.1.14 >Reporter: Thomas Watson >Assignee: Thomas Watson >Priority: Major > Fix For: scr-2.1.16 > > > If an eventFilter for a reference contains special formatting characters > (e.g. ${}) then the debug log message formatting will fail with the following > exception. This is because we are passing null arguments and expecting them > to be substituted into a debug message when there are really no place holders > for substitution. > {code:java} > Unexpected failure enabling component holder > com.ibm.ws.http.internal.HttpEndpointImpl > Bundle:com.ibm.ws.transport.http(id=58) java.lang.IllegalArgumentException: > can't parse argument number: accessLoggingRef > at java.text.MessageFormat.makeFormat(MessageFormat.java:1429) > at java.text.MessageFormat.applyPattern(MessageFormat.java:479) > at java.text.MessageFormat.(MessageFormat.java:362) > at java.text.MessageFormat.format(MessageFormat.java:840) > at > org.apache.felix.scr.impl.logger.AbstractLogger.format(AbstractLogger.java:155) > at > org.apache.felix.scr.impl.logger.AbstractLogger.log(AbstractLogger.java:92) > at org.apache.felix.scr.impl.logger.BundleLogger.log(BundleLogger.java:83) > at > org.apache.felix.scr.impl.BundleComponentActivator.addServiceListener(BundleComponentActivator.java:194) > at > org.apache.felix.scr.impl.manager.ServiceTracker.open(ServiceTracker.java:214) > at > org.apache.felix.scr.impl.manager.ServiceTracker.open(ServiceTracker.java:179) > at > org.apache.felix.scr.impl.manager.DependencyManager.setTargetFilter(DependencyManager.java:2209) > at > org.apache.felix.scr.impl.manager.DependencyManager.setTargetFilter(DependencyManager.java:2026) > at > org.apache.felix.scr.impl.manager.AbstractComponentManager.updateTargets(AbstractComponentManager.java:1150) > at > org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:662) > at > org.apache.felix.scr.impl.manager.AbstractComponentManager.enable(AbstractComponentManager.java:432) > at > org.apache.felix.scr.impl.manager.ConfigurableComponentHolder.enableComponents(ConfigurableComponentHolder.java:665) > at > org.apache.felix.scr.impl.BundleComponentActivator.initialEnable(BundleComponentActivator.java:339) > at org.apache.felix.scr.impl.Activator.loadComponents(Activator.java:381) > at org.apache.felix.scr.impl.Activator.access$200(Activator.java:49) > at org.apache.felix.scr.impl.Activator$ScrExtension.start(Activator.java:263) > at > org.apache.felix.scr.impl.AbstractExtender.createExtension(AbstractExtender.java:196) > at > org.apache.felix.scr.impl.AbstractExtender.modifiedBundle(AbstractExtender.java:169) > at > org.apache.felix.scr.impl.AbstractExtender.modifiedBundle(AbstractExtender.java:49) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FELIX-5989) java.lang.IllegalArgumentException from AbstractLogger.format when logging debug message
Thomas Watson created FELIX-5989: Summary: java.lang.IllegalArgumentException from AbstractLogger.format when logging debug message Key: FELIX-5989 URL: https://issues.apache.org/jira/browse/FELIX-5989 Project: Felix Issue Type: Bug Components: Declarative Services (SCR) Affects Versions: scr-2.1.14, scr-2.1.12 Reporter: Thomas Watson If an eventFilter for a reference contains special formatting characters (e.g. ${}) then the debug log message formatting will fail with the following exception. This is because we are passing null arguments and expecting them to be substituted into a debug message when there are really no place holders for substitution. {code:java} Unexpected failure enabling component holder com.ibm.ws.http.internal.HttpEndpointImpl Bundle:com.ibm.ws.transport.http(id=58) java.lang.IllegalArgumentException: can't parse argument number: accessLoggingRef at java.text.MessageFormat.makeFormat(MessageFormat.java:1429) at java.text.MessageFormat.applyPattern(MessageFormat.java:479) at java.text.MessageFormat.(MessageFormat.java:362) at java.text.MessageFormat.format(MessageFormat.java:840) at org.apache.felix.scr.impl.logger.AbstractLogger.format(AbstractLogger.java:155) at org.apache.felix.scr.impl.logger.AbstractLogger.log(AbstractLogger.java:92) at org.apache.felix.scr.impl.logger.BundleLogger.log(BundleLogger.java:83) at org.apache.felix.scr.impl.BundleComponentActivator.addServiceListener(BundleComponentActivator.java:194) at org.apache.felix.scr.impl.manager.ServiceTracker.open(ServiceTracker.java:214) at org.apache.felix.scr.impl.manager.ServiceTracker.open(ServiceTracker.java:179) at org.apache.felix.scr.impl.manager.DependencyManager.setTargetFilter(DependencyManager.java:2209) at org.apache.felix.scr.impl.manager.DependencyManager.setTargetFilter(DependencyManager.java:2026) at org.apache.felix.scr.impl.manager.AbstractComponentManager.updateTargets(AbstractComponentManager.java:1150) at org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:662) at org.apache.felix.scr.impl.manager.AbstractComponentManager.enable(AbstractComponentManager.java:432) at org.apache.felix.scr.impl.manager.ConfigurableComponentHolder.enableComponents(ConfigurableComponentHolder.java:665) at org.apache.felix.scr.impl.BundleComponentActivator.initialEnable(BundleComponentActivator.java:339) at org.apache.felix.scr.impl.Activator.loadComponents(Activator.java:381) at org.apache.felix.scr.impl.Activator.access$200(Activator.java:49) at org.apache.felix.scr.impl.Activator$ScrExtension.start(Activator.java:263) at org.apache.felix.scr.impl.AbstractExtender.createExtension(AbstractExtender.java:196) at org.apache.felix.scr.impl.AbstractExtender.modifiedBundle(AbstractExtender.java:169) at org.apache.felix.scr.impl.AbstractExtender.modifiedBundle(AbstractExtender.java:49) {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Commit bit for sibling projects committers (was: [DISCUSS] Health checks contribution)
Hi, On Sun, Nov 25, 2018 at 9:52 PM Karl Pauls wrote: > ...As I said before, we don't typically have an issue with making people > committers that want to continue maintaining contributions... FWIW, an idea that I (vaguely) mentioned earlier is making the Felix repositories writable for committers of "sibling projects". Felix would give write access to all committers of OSGi-related Apache projects, and define community rules for how people are expected to use those commit rights. Rules like "feel free to fix non-core simple things directly where test coverage makes things obvious, and discuss everything else on list before committing". We did that between Cocoon, Lenya and Forrest a while ago (well, 15 years maybe ;-) and it worked well. I shall be able to dig out more info if desired, can't find it right now. I'm not saying this needs to happen right now but wanted to mention the idea - it might help make the non-core parts of Felix more dynamic by getting more contributions from those "sibling" OSGi-related projects as well as motivate people to bring modules here that are of general use. -Bertrand (who's not a PMC member here, so just making a suggestion based on past experience)