Geode Native Library Filenames

[Jacob Barrett]

As I ready to drop the pull request to rename all the namespaces in C++ and
.NET sources the next thing we need to decide on is the filename for the
library.

C++
Current: gfcppcache
gfcppcache.dll (Windows), libgfcppcache.so (*nix), libgfcppcache.dylib
(macOS)
Proposed: apache-geode
apache-geode.dll, libapache-geode.so, libapache-geode.dylib
Other libraries have embraced other styles for "branded" libraries.
Camel case: libQtCode.so
Underscore: libsvn_client.so, libboost_atomic-mt.so
Dash: libxcb-compose, libcairo-gobject.so
I prefere dash because I don't have to hit shift. ;)

.NET
Current: GemStone.GemFire.Cache.dll
Proposed: Apache.Geode.dll
There is a bit more of an established norm. It should be part of the
included namespace.
Other option is Apache.Geode.Client.dll but I feel like there are items in
the Client namespace that need to be moved into another namespace as a
sibling. So in my mind it makes more sense to have it be Apache.Geode.dll.
It also makes it consistent with the C++ library.

-Jake

[jira] [Resolved] (GEODE-2292) SPIKE: Investigate methods of limiting class importing when deploying jars

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-2292.
--
Resolution: Not A Problem

> SPIKE: Investigate methods of limiting class importing when deploying jars
> --
>
> Key: GEODE-2292
> URL: https://issues.apache.org/jira/browse/GEODE-2292
> Project: Geode
>  Issue Type: Task
>  Components: gfsh
>Reporter: Kevin Duling
>
> Experimenting with solutions for GEODE-2290



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (GEODE-2292) SPIKE: Investigate methods of limiting class importing when deploying jars

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund closed GEODE-2292.


> SPIKE: Investigate methods of limiting class importing when deploying jars
> --
>
> Key: GEODE-2292
> URL: https://issues.apache.org/jira/browse/GEODE-2292
> Project: Geode
>  Issue Type: Task
>  Components: gfsh
>Reporter: Kevin Duling
>
> Experimenting with solutions for GEODE-2290



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GEODE-1883) AuthInitializer should be made optional

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-1883:
-
Component/s: docs

> AuthInitializer should be made optional
> ---
>
> Key: GEODE-1883
> URL: https://issues.apache.org/jira/browse/GEODE-1883
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, management
>Reporter: Swapnil Bawaskar
>
> {{AuthInitializer}} is the interface that a client must implement that 
> provides credentials that are verified by the server. The same interface is 
> also used for peer authentication. 
> In order to configure {{AuthInitialize}} any Geode property starting with 
> {{security-}} is passed through to the {{AuthInitialize.getCredentials}} 
> method.
> For simple authentication where only a username and a password are required, 
> users should not really be required to implement the AuthInitialize interface 
> in the presence of property passthrough. 
> Geode should detect {{security-username}} and {{security-password}} 
> properties in gemfire.security OR gfsecurity.properties file and use those 
> for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GEODE-1883) AuthInitializer should be made optional

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-1883:
-
Component/s: (was: docs)

> AuthInitializer should be made optional
> ---
>
> Key: GEODE-1883
> URL: https://issues.apache.org/jira/browse/GEODE-1883
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, management
>Reporter: Swapnil Bawaskar
>
> {{AuthInitializer}} is the interface that a client must implement that 
> provides credentials that are verified by the server. The same interface is 
> also used for peer authentication. 
> In order to configure {{AuthInitialize}} any Geode property starting with 
> {{security-}} is passed through to the {{AuthInitialize.getCredentials}} 
> method.
> For simple authentication where only a username and a password are required, 
> users should not really be required to implement the AuthInitialize interface 
> in the presence of property passthrough. 
> Geode should detect {{security-username}} and {{security-password}} 
> properties in gemfire.security OR gfsecurity.properties file and use those 
> for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55742: [GEODE-2324] and what look like a few other bugs in the same method.

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55742/#review162521
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 (line 1578)


Something more like
boolean ignoredInterrupt = false;
.
.
.
} catch (InterruptedException ignore) {
  ignoredInterrupt = true;
}
_finish shutting down other pool_
if (ignoredInterrupt) {
  Thread.currentThread().interrupt();
}
return;


- Bruce Schuchardt


On Jan. 20, 2017, 11:20 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55742/
> ---
> 
> (Updated Jan. 20, 2017, 11:20 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2324
> https://issues.apache.org/jira/browse/GEODE-2324
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> [GEODE-2324] fix AcceptorImpl cleanup.
> 
> * Catch InterruptedException so cleanup continues.
> * Remove top-level exception handler to avoid similar mistakes in the future.
> * Fix a synchronization bug that could cause AcceptorImpl to try to shut down 
> twice.
> * Fix what looks like a bug where if closing the socket throws and 
> IOException, we fail to shut anything else down, though we still have 
> ourselves marked as shut down.
> 
> I'm a little skeptical of whether we're waiting at all for the queue to shut 
> down, as the thread could have been marked as interrupted for quite a while 
> before and never noticed it until the thread got parked. This may warrant 
> more investigation.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  060683de6 
> 
> Diff: https://reviews.apache.org/r/55742/diff/
> 
> 
> Testing
> ---
> 
> precheckin in progress.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Re: Review Request 55742: [GEODE-2324] and what look like a few other bugs in the same method.

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55742/
---

(Updated Jan. 20, 2017, 11:20 p.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Changes
---

Interrupt the thread after catching InterruptedException.


Bugs: GEODE-2324
https://issues.apache.org/jira/browse/GEODE-2324


Repository: geode


Description
---

[GEODE-2324] fix AcceptorImpl cleanup.

* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid similar mistakes in the future.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut down 
twice.
* Fix what looks like a bug where if closing the socket throws and IOException, 
we fail to shut anything else down, though we still have ourselves marked as 
shut down.

I'm a little skeptical of whether we're waiting at all for the queue to shut 
down, as the thread could have been marked as interrupted for quite a while 
before and never noticed it until the thread got parked. This may warrant more 
investigation.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 060683de6 

Diff: https://reviews.apache.org/r/55742/diff/


Testing
---

precheckin in progress.


Thanks,

Galen O'Sullivan

[jira] [Created] (GEODE-2331) Remove org.JSON use in REST API

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-2331:
---

 Summary: Remove org.JSON use in REST API
 Key: GEODE-2331
 URL: https://issues.apache.org/jira/browse/GEODE-2331
 Project: Geode
  Issue Type: Bug
  Components: rest (dev)
Reporter: Bruce Schuchardt


Some of the test classes for the REST API are using org.JSON classes.  Apache 
has determined that org.JSON licensing is incompatible with Apache licensing so 
these uses need to be removed:

JSONFormatterJUnitTest
JSONPdxClientServerDUnitTest
TestObjectForJSONFormatter







--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2282) Provide ability to sort field while creating pdxType for jSON document

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832555#comment-15832555
 ] 

ASF subversion and git services commented on GEODE-2282:


Commit 8b303e43bce0518f4cd290b688f7ee93ebe2da3e in geode's branch 
refs/heads/feature/GEODE-1930-2 from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8b303e4 ]

GEODE-2282 Added ability to sort JSON fields while creating pdxtype.

One can enable this feature by setting java system property(
gemfire.pdx.mapper.sort-json-field-names=true. In this way geode will
not create multiple pdx type ids for JSON document, if different JSON
document has same fields in different order.

Added unit test for it.

updated


> Provide ability to sort field while creating pdxType for jSON document
> --
>
> Key: GEODE-2282
> URL: https://issues.apache.org/jira/browse/GEODE-2282
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Hitesh Khamesra
>Assignee: Joey McAllister
> Fix For: 1.1.0
>
>
> There is the possibility that same JSON document can create multiple pdxType 
> ids, if different JSON docs contain same fields in different order. Thus sort 
> those field while creating the pdxType id. Introduce system property to 
> enable this feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2198) import cluster-config should continue if the running servers have no data in their application regions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832553#comment-15832553
 ] 

ASF subversion and git services commented on GEODE-2198:


Commit 6f418be119d72704215b73e13de902057b18ad4a in geode's branch 
refs/heads/feature/GEODE-1930-2 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6f418be ]

GEODE-2198: close and re-create the cache on a server when importing new 
cluster configuration

* When importing cluster config first check if there is any non-empty region
* close and re-create cache if no data exists when importing new cluster 
configuration
* put the acquire/release lock inside the ClusterConfigurationService instead 
of command execution strategy.


> import cluster-config should continue if the running servers have no data in 
> their application regions
> --
>
> Key: GEODE-2198
> URL: https://issues.apache.org/jira/browse/GEODE-2198
> Project: Geode
>  Issue Type: Sub-task
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2282) Provide ability to sort field while creating pdxType for jSON document

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832556#comment-15832556
 ] 

ASF subversion and git services commented on GEODE-2282:


Commit de070b517e25256e9c33f318f343b0219fb8cc66 in geode's branch 
refs/heads/feature/GEODE-1930-2 from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=de070b5 ]

GEODE-2282 Added license info


> Provide ability to sort field while creating pdxType for jSON document
> --
>
> Key: GEODE-2282
> URL: https://issues.apache.org/jira/browse/GEODE-2282
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Hitesh Khamesra
>Assignee: Joey McAllister
> Fix For: 1.1.0
>
>
> There is the possibility that same JSON document can create multiple pdxType 
> ids, if different JSON docs contain same fields in different order. Thus sort 
> those field while creating the pdxType id. Introduce system property to 
> enable this feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2199) deploy/undeploy should continue even if there is no running servers in the cluster

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832554#comment-15832554
 ] 

ASF subversion and git services commented on GEODE-2199:


Commit e06bf2dba95d67061aed8e376d4da6916959d6e4 in geode's branch 
refs/heads/feature/GEODE-1930-2 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e06bf2d ]

GEODE-2199: be able to deploy jars without running servers

* renamed the CliUtils.findAllMatchingServers to findMembersOrThrow to better 
describe the behavior

(cherry picked from commit 80dd57b)


> deploy/undeploy should continue even if there is no running servers in the 
> cluster
> --
>
> Key: GEODE-2199
> URL: https://issues.apache.org/jira/browse/GEODE-2199
> Project: Geode
>  Issue Type: Sub-task
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>  Labels: DeployCommand, deploy
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2273) Display the server name while listing the Lucene index stats

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832552#comment-15832552
 ] 

ASF subversion and git services commented on GEODE-2273:


Commit edae4abf4def82fd3827a1bd0b7b688b2145294a in geode's branch 
refs/heads/feature/GEODE-1930-2 from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=edae4ab ]

GEODE-2273: Server name is displayed in lucene index stats.

* In gfsh while listing Lucene index stats, it will now display where 
the indexes are hosted.


> Display the server name while listing the Lucene index stats
> 
>
> Key: GEODE-2273
> URL: https://issues.apache.org/jira/browse/GEODE-2273
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.1.0
>
>
> Display the server's name hosting the Lucene indexes while listing the Lucene 
> index stats in gfsh.
> Currently we can't distinguish between the listed pairs.
> {noformat}
> 
> gfsh>list lucene indexes --with-stats
>Index Name | Region Path |  Indexed Fields  | Field 
> Analyzer |   Status| Query Executions | Updates | Commits | Documents
> - | --- |  | 
> -- | --- |  | --- | --- | 
> -
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #445 has FAILED (11 tests failed, no failures were new)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #445 failed.
---
Scheduled
11/1614 tests failed, no failures were new.

https://build.spring.io/browse/SGF-NAG-445/

-
Currently Responsible
-

John Blum 



--
Failing Jobs
--
  - Default Job (Default Stage): 11 of 1614 tests failed.




--
Tests
--
Existing Test Failures (11)
   - ClientSubRegionTest: Org.springframework.data.gemfire.client. client sub 
region test
   - GemFireDataSourceTest: Org.springframework.data.gemfire.client. gem fire 
data source test
   - GemFireDataSourceWithLocalRegionTest: 
Org.springframework.data.gemfire.client. gem fire data source with local region 
test
   - ContinuousQueryListenerContainerNamespaceTest: 
Org.springframework.data.gemfire.config.xml. continuous query listener 
container namespace test
   - ClientCacheFunctionExecutionWithPdxIntegrationTest: 
Org.springframework.data.gemfire.function. client cache function execution with 
pdx integration test
   - FunctionExecutionTests: 
Org.springframework.data.gemfire.function.execution. function execution tests
   - FunctionIntegrationTests: 
Org.springframework.data.gemfire.function.execution. function integration tests
   - GemfireFunctionTemplateTests: 
Org.springframework.data.gemfire.function.execution. gemfire function template 
tests
   - ListenerContainerTests: Org.springframework.data.gemfire.listener. 
listener container tests
   - ContainerXmlSetupTest: Org.springframework.data.gemfire.listener.adapter. 
container xml setup test
   - RepositoryClientRegionTests: 
Org.springframework.data.gemfire.repository.config. repository client region 
tests

--
This message is automatically generated by Atlassian Bamboo

[jira] [Resolved] (GEODE-2298) Executing a Function via Swagger without parameters throws an exception

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling resolved GEODE-2298.
-
   Resolution: Fixed
Fix Version/s: 1.1.0

> Executing a Function via Swagger without parameters throws an exception
> ---
>
> Key: GEODE-2298
> URL: https://issues.apache.org/jira/browse/GEODE-2298
> Project: Geode
>  Issue Type: Bug
>  Components: management, rest (dev)
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.1.0
>
>
> When executing a function with Swagger, if no arguments are specified, the 
> {{FunctionAccessController}} will throw an exception because it incorrectly 
> identifies the JSON of {{"{}"}} to be arguments.  When the JSON deserializer 
> tries to work with it, an NPE is thrown because it's not a key:value pair.
> The solution is to change the test to treat {{"{}"}} as "no arguments".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-2240) unexpected NullPointerException from Tombstone service

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-2240.
-
   Resolution: Fixed
Fix Version/s: 1.1.0

The previous fix caused a deadlock because of lock inversion.
This new fix prevents the lock inversion by added a new lock that is used to 
protect the expiredTombstones ArrayList.

> unexpected NullPointerException from Tombstone service
> --
>
> Key: GEODE-2240
> URL: https://issues.apache.org/jira/browse/GEODE-2240
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
> Fix For: 1.1.0
>
>
> A test failed and the logs were found to be full of NPEs from the tombstone 
> service:[severe 2016/12/20 02:04:35.605 UTC 
> dataStoregemfire7_rs-StorageBTTest-2016-12-19-23-35-42-client-14_19508 
>  tid=0x44] GemFire garbage 
> collection service encountered an unexpected exception
> java.lang.NullPointerException
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.lambda$purgeObsoleteTombstones$1(TombstoneService.java:938)
> at 
> org.apache.geode.internal.cache.TombstoneService$ReplicateTombstoneSweeper.removeExpiredIf(TombstoneService.java:479)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.removeIf(TombstoneService.java:823)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.purgeObsoleteTombstones(TombstoneService.java:937)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.run(TombstoneService.java:880)
> at java.lang.Thread.run(Thread.java:745)
> [severe 2016/12/20 02:05:45.987 UTC 
> dataStoregemfire7_rs-StorageBTTest-2016-12-19-23-35-42-client-14_19508 
>  tid=0x44] GemFire garbage 
> collection service encountered an unexpected exception
> java.lang.NullPointerException
> at 
> org.apache.geode.internal.cache.TombstoneService$ReplicateTombstoneSweeper.expireBatch(TombstoneService.java:524)
> at 
> org.apache.geode.internal.cache.TombstoneService$ReplicateTombstoneSweeper.checkExpiredTombstoneGC(TombstoneService.java:594)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.run(TombstoneService.java:878)
> at java.lang.Thread.run(Thread.java:745)
> Both of these stacks indicate that the "expiredTombstones" ArrayList somehow 
> has nulls in it. It is an ArrayList of Tombstone instances and the only code 
> that adds to it first tests that the item it is adding is not null. The only 
> other modify operation done on it is to remove an item.
> Perhaps unsafe concurrent access is happening causing this code to see nulls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2240) unexpected NullPointerException from Tombstone service

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832493#comment-15832493
 ] 

ASF subversion and git services commented on GEODE-2240:


Commit 4d58778985b832a7899056a06fb0de0f2995f55e in geode's branch 
refs/heads/develop from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4d58778 ]

GEODE-2240: prevent unsafe concurrent access to ArrayList

Fixed deadlock by adding expiredTombstonesLock.


> unexpected NullPointerException from Tombstone service
> --
>
> Key: GEODE-2240
> URL: https://issues.apache.org/jira/browse/GEODE-2240
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>
> A test failed and the logs were found to be full of NPEs from the tombstone 
> service:[severe 2016/12/20 02:04:35.605 UTC 
> dataStoregemfire7_rs-StorageBTTest-2016-12-19-23-35-42-client-14_19508 
>  tid=0x44] GemFire garbage 
> collection service encountered an unexpected exception
> java.lang.NullPointerException
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.lambda$purgeObsoleteTombstones$1(TombstoneService.java:938)
> at 
> org.apache.geode.internal.cache.TombstoneService$ReplicateTombstoneSweeper.removeExpiredIf(TombstoneService.java:479)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.removeIf(TombstoneService.java:823)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.purgeObsoleteTombstones(TombstoneService.java:937)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.run(TombstoneService.java:880)
> at java.lang.Thread.run(Thread.java:745)
> [severe 2016/12/20 02:05:45.987 UTC 
> dataStoregemfire7_rs-StorageBTTest-2016-12-19-23-35-42-client-14_19508 
>  tid=0x44] GemFire garbage 
> collection service encountered an unexpected exception
> java.lang.NullPointerException
> at 
> org.apache.geode.internal.cache.TombstoneService$ReplicateTombstoneSweeper.expireBatch(TombstoneService.java:524)
> at 
> org.apache.geode.internal.cache.TombstoneService$ReplicateTombstoneSweeper.checkExpiredTombstoneGC(TombstoneService.java:594)
> at 
> org.apache.geode.internal.cache.TombstoneService$TombstoneSweeper.run(TombstoneService.java:878)
> at java.lang.Thread.run(Thread.java:745)
> Both of these stacks indicate that the "expiredTombstones" ArrayList somehow 
> has nulls in it. It is an ArrayList of Tombstone instances and the only code 
> that adds to it first tests that the item it is adding is not null. The only 
> other modify operation done on it is to remove an item.
> Perhaps unsafe concurrent access is happening causing this code to see nulls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55742: [GEODE-2324] and what look like a few other bugs in the same method.

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55742/#review162512
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 (line 1577)


Typically we set the interrupt bit on the thread at the end of the block of 
code where we ignore interrupts.  You can see examples of this in 
ShutdownAllRequest, SearchLoadAndWriteProcessor and other places (look for 
Thread.currentThread().interrupt()).

Is there a reason we aren't doing that here?


- Bruce Schuchardt


On Jan. 20, 2017, 9:43 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55742/
> ---
> 
> (Updated Jan. 20, 2017, 9:43 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2324
> https://issues.apache.org/jira/browse/GEODE-2324
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> [GEODE-2324] fix AcceptorImpl cleanup.
> 
> * Catch InterruptedException so cleanup continues.
> * Remove top-level exception handler to avoid similar mistakes in the future.
> * Fix a synchronization bug that could cause AcceptorImpl to try to shut down 
> twice.
> * Fix what looks like a bug where if closing the socket throws and 
> IOException, we fail to shut anything else down, though we still have 
> ourselves marked as shut down.
> 
> I'm a little skeptical of whether we're waiting at all for the queue to shut 
> down, as the thread could have been marked as interrupted for quite a while 
> before and never noticed it until the thread got parked. This may warrant 
> more investigation.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  060683de6 
> 
> Diff: https://reviews.apache.org/r/55742/diff/
> 
> 
> Testing
> ---
> 
> precheckin in progress.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Re: Review Request 55785: GEODE-2297: push new InternalDistributedSystem into AlertAppender

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55785/#review162509
---


Ship it!




Ship It!

- Bruce Schuchardt


On Jan. 20, 2017, 9:13 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55785/
> ---
> 
> (Updated Jan. 20, 2017, 9:13 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jared Stewart, 
> Kevin Duling, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2297
> https://issues.apache.org/jira/browse/GEODE-2297
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2297: push new InternalDistributedSystem into AlertAppender
> 
> * InternalDistributedSystem initialize pushes its instance into
> AlertAppender
> 
> * During AlertAppender shuttingDown, it nulls out the reference
> to InternalDistributedSystem
> 
> This is an initial fix to prevent deadlocks. After merging this fix in, I'd 
> like to start refactoring AlertAppender as a follow-up.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  fad9206583fdc093b1f74397c321442335cf80d4 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/log4j/AlertAppender.java
>  a6c54aba352ba4dd3ece94c94f770292db6e9284 
> 
> Diff: https://reviews.apache.org/r/55785/diff/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Updated] (GEODE-2330) QueryEngine should be able to recognize number in query string

[Hitesh Khamesra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hitesh Khamesra updated GEODE-2330:
---
Description: If query contains long number then it has to append "l" with 
that number otherwise query engine fails to parse that number. I think we 
should not rely on this. See similar ticket GEODE-2327  (was: If query contains 
long number then it has append "l" with that number otherwise query engine 
fails to parse that number. I think we should not rely on this. See similar 
ticket GEODE-2327)

> QueryEngine should be able to recognize number in query string
> --
>
> Key: GEODE-2330
> URL: https://issues.apache.org/jira/browse/GEODE-2330
> Project: Geode
>  Issue Type: Improvement
>  Components: querying
>Reporter: Hitesh Khamesra
>
> If query contains long number then it has to append "l" with that number 
> otherwise query engine fails to parse that number. I think we should not rely 
> on this. See similar ticket GEODE-2327



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (GEODE-2330) QueryEngine should be able to recognize number in query string

[Hitesh Khamesra (JIRA)]

Hitesh Khamesra created GEODE-2330:
--

 Summary: QueryEngine should be able to recognize number in query 
string
 Key: GEODE-2330
 URL: https://issues.apache.org/jira/browse/GEODE-2330
 Project: Geode
  Issue Type: Improvement
  Components: querying
Reporter: Hitesh Khamesra


If query contains long number then it has append "l" with that number otherwise 
query engine fails to parse that number. I think we should not rely on this. 
See similar ticket GEODE-2327



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55742: [GEODE-2324] and what look like a few other bugs in the same method.

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55742/
---

(Updated Jan. 20, 2017, 9:43 p.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2324
https://issues.apache.org/jira/browse/GEODE-2324


Repository: geode


Description
---

[GEODE-2324] fix AcceptorImpl cleanup.

* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid similar mistakes in the future.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut down 
twice.
* Fix what looks like a bug where if closing the socket throws and IOException, 
we fail to shut anything else down, though we still have ourselves marked as 
shut down.

I'm a little skeptical of whether we're waiting at all for the queue to shut 
down, as the thread could have been marked as interrupted for quite a while 
before and never noticed it until the thread got parked. This may warrant more 
investigation.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 060683de6 

Diff: https://reviews.apache.org/r/55742/diff/


Testing (updated)
---

precheckin in progress.


Thanks,

Galen O'Sullivan

[jira] [Commented] (GEODE-2297) AlertAppender.append should avoid synchronizing on InternalDistributedSystem

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832408#comment-15832408
 ] 

ASF subversion and git services commented on GEODE-2297:


Commit 31a81b3518e9e93a60cd97b9a33e8373c58856ef in geode's branch 
refs/heads/feature/GEODE-2297-3 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=31a81b3 ]

GEODE-2297: push new InternalDistributedSystem into AlertAppender

* InternalDistributedSystem initialize pushes its instance into
AlertAppender

* During AlertAppender shuttingDown, it nulls out the reference
to InternalDistributedSystem


> AlertAppender.append should avoid synchronizing on InternalDistributedSystem
> 
>
> Key: GEODE-2297
> URL: https://issues.apache.org/jira/browse/GEODE-2297
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Kirk Lund
>
> AlertAppender.append should avoid synchronizing on InternalDistributedSystem 
> for two reasons:
> 1) risks deadlock
> 2) impacts performance
> {noformat}
> "Pooled High Priority Message Processor 3" daemon prio=10 
> tid=0x7f1cd4009000 nid=0x1e31 waiting for monitor entry 
> [0x7f1d5d965000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.getConnectedInstance(InternalDistributedSystem.java:316)
> - waiting to lock <0x0005cf476e10> (a java.lang.Object)
> at 
> com.gemstone.gemfire.internal.logging.log4j.AlertAppender.append(AlertAppender.java:101)
> at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:99)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:430)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:409)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:412)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:412)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367)
> at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:112)
> at 
> org.apache.logging.log4j.spi.ExtendedLoggerWrapper.logMessage(ExtendedLoggerWrapper.java:127)
> at 
> org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:685)
> at 
> org.apache.logging.log4j.spi.AbstractLogger.warn(AbstractLogger.java:899)
> at 
> com.gemstone.gemfire.internal.tcp.Connection.createSender(Connection.java:1078)
> at 
> com.gemstone.gemfire.internal.tcp.ConnectionTable.handleNewPendingConnection(ConnectionTable.java:358)
> at 
> com.gemstone.gemfire.internal.tcp.ConnectionTable.getUnorderedOrConserveSockets(ConnectionTable.java:474)
> at 
> com.gemstone.gemfire.internal.tcp.ConnectionTable.get(ConnectionTable.java:664)
> at 
> com.gemstone.gemfire.internal.tcp.TCPConduit.getConnection(TCPConduit.java:977)
> at 
> com.gemstone.gemfire.distributed.internal.direct.DirectChannel.getConnections(DirectChannel.java:638)
> at 
> com.gemstone.gemfire.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:396)
> at 
> com.gemstone.gemfire.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:310)
> at 
> com.gemstone.gemfire.distributed.internal.direct.DirectChannel.send(DirectChannel.java:696)
> at 
> com.gemstone.gemfire.distributed.internal.membership.jgroup.JGroupMembershipManager.directChannelSend(JGroupMembershipManager.java:2930)
> at 
> com.gemstone.gemfire.distributed.internal.membership.jgroup.JGroupMembershipManager.send(JGroupMembershipManager.java:3164)
> at 
> com.gemstone.gemfire.distributed.internal.DistributionChannel.send(DistributionChannel.java:79)
> at 
> com.gemstone.gemfire.distributed.internal.DistributionManager.sendOutgoing(DistributionManager.java:3913)
> at 
> com.gemstone.gemfire.distributed.internal.DistributionManager.sendMessage(DistributionManager.java:3954)
> at 
> com.gemstone.gemfire.distributed.internal.DistributionManager.putOutgoing(DistributionManager.java:1957)
> at 
> com.gemstone.gemfire.distributed.internal.StartupMessage.process(StartupMessage.java:321)
> at 
> com.gemstone.gemfire.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:386)
> at 
> com.gemstone.gemfire.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:457)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$W

Re: Review Request 55785: GEODE-2297: push new InternalDistributedSystem into AlertAppender

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55785/#review162505
---


Ship it!




Ship It!

- Hitesh Khamesra


On Jan. 20, 2017, 9:13 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55785/
> ---
> 
> (Updated Jan. 20, 2017, 9:13 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jared Stewart, 
> Kevin Duling, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2297
> https://issues.apache.org/jira/browse/GEODE-2297
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2297: push new InternalDistributedSystem into AlertAppender
> 
> * InternalDistributedSystem initialize pushes its instance into
> AlertAppender
> 
> * During AlertAppender shuttingDown, it nulls out the reference
> to InternalDistributedSystem
> 
> This is an initial fix to prevent deadlocks. After merging this fix in, I'd 
> like to start refactoring AlertAppender as a follow-up.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  fad9206583fdc093b1f74397c321442335cf80d4 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/log4j/AlertAppender.java
>  a6c54aba352ba4dd3ece94c94f770292db6e9284 
> 
> Diff: https://reviews.apache.org/r/55785/diff/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Review Request 55785: GEODE-2297: push new InternalDistributedSystem into AlertAppender

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55785/
---

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jared Stewart, 
Kevin Duling, and Udo Kohlmeyer.


Bugs: GEODE-2297
https://issues.apache.org/jira/browse/GEODE-2297


Repository: geode


Description
---

GEODE-2297: push new InternalDistributedSystem into AlertAppender

* InternalDistributedSystem initialize pushes its instance into
AlertAppender

* During AlertAppender shuttingDown, it nulls out the reference
to InternalDistributedSystem

This is an initial fix to prevent deadlocks. After merging this fix in, I'd 
like to start refactoring AlertAppender as a follow-up.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 fad9206583fdc093b1f74397c321442335cf80d4 
  
geode-core/src/main/java/org/apache/geode/internal/logging/log4j/AlertAppender.java
 a6c54aba352ba4dd3ece94c94f770292db6e9284 

Diff: https://reviews.apache.org/r/55785/diff/


Testing
---

precheckin in progress


Thanks,

Kirk Lund

[jira] [Updated] (GEODE-2267) Add gfsh command to export all cluster artifacts

[Diane Hardman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Diane Hardman updated GEODE-2267:
-
Issue Type: New Feature  (was: Bug)

> Add gfsh command to export all cluster artifacts
> 
>
> Key: GEODE-2267
> URL: https://issues.apache.org/jira/browse/GEODE-2267
> Project: Geode
>  Issue Type: New Feature
>  Components: configuration, docs, gfsh
>Reporter: Diane Hardman
>
> We would like a single gfsh command to collect and export all logfiles and 
> stat files into a single package. This package (zipfile) can then be saved 
> and attached to emails and Jira tickets to help evaluate the Geode cluster 
> status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54586: GEODE-2172: CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54586/#review162488
---


Ship it!




Ship It!

- Anthony Baker


On Dec. 19, 2016, 12:45 p.m., Kai Jiang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54586/
> ---
> 
> (Updated Dec. 19, 2016, 12:45 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kirk Lund, and Dan Smith.
> 
> 
> Bugs: geode-2172
> https://issues.apache.org/jira/browse/geode-2172
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> cacheLogWriterMessageShouldMatchCustomConfig fails with AssertionError.
> 
> The issues is related to incorrect regex pattern. The regex pattern used to 
> match log string contains newline character. To fix this issue, I've replaced 
> Unix newline character in regex pattern into `System.lineSeparator()`, a 
> Platform-dependent newline character in Java.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/logging/log4j/custom/CustomConfiguration.java
>  47515e6 
> 
> Diff: https://reviews.apache.org/r/54586/diff/
> 
> 
> Testing
> ---
> 
> I've run this unit test both on Windows and MacOS. And it passes.
> 
> 
> Thanks,
> 
> Kai Jiang
> 
>

Re: New Committer And PMC Member: Kevin Duling

[Michael Stolz]

Welcome Kevin!

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

On Wed, Jan 18, 2017 at 9:52 PM, Mark Bretl  wrote:

> The Apache Geode Project Management Committee has invited Kevin Duling to
> be committer on the project and join the Geode PMC. We are pleased to
> announce he has accepted.
>
> Please join me in welcoming Kevin!
>
> Sincerely,
>
> Mark Bretl
> On behalf of the Apache Geode PMC
>

[jira] [Commented] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832224#comment-15832224
 ] 

ASF GitHub Bot commented on GEODE-2324:
---

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/349

[GEODE-2324] fixes to AcceptorImpl.close()

If the thread is interrupted during closing, just continue to shut down
what we can.

* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid masking exceptions that
* could short-circuit shutdown.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut
  down twice.
* Fix what looks like a bug where if closing the socket throws an
  IOException, we fail to shut anything else down, though we still have
  ourselves marked as shut down.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-2324

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #349


commit 26f70874102bad830f81b36d496c6469103f2e74
Author: Galen O'Sullivan 
Date:   2017-01-18T23:00:47Z

[GEODE-2324] fixes to AcceptorImpl.close()

If the thread is interrupted during closing, just continue to shut down
what we can.

* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid masking exceptions that
* could short-circuit shutdown.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut
  down twice.
* Fix what looks like a bug where if closing the socket throws an
  IOException, we fail to shut anything else down, though we still have
  ourselves marked as shut down.




> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> --
>
> Key: GEODE-2324
> URL: https://issues.apache.org/jira/browse/GEODE-2324
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.0.0-incubating
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> In {{AcceptorImpl.close()}}, the call to 
> {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, 
> TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which 
> case neither {pool} nor {{hsPool}} or anything else that comes after is 
> properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued 
> (for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode pull request #349: [GEODE-2324] fixes to AcceptorImpl.close()

[galen-pivotal]

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/349

[GEODE-2324] fixes to AcceptorImpl.close()

If the thread is interrupted during closing, just continue to shut down
what we can.

* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid masking exceptions that
* could short-circuit shutdown.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut
  down twice.
* Fix what looks like a bug where if closing the socket throws an
  IOException, we fail to shut anything else down, though we still have
  ourselves marked as shut down.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-2324

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #349


commit 26f70874102bad830f81b36d496c6469103f2e74
Author: Galen O'Sullivan 
Date:   2017-01-18T23:00:47Z

[GEODE-2324] fixes to AcceptorImpl.close()

If the thread is interrupted during closing, just continue to shut down
what we can.

* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid masking exceptions that
* could short-circuit shutdown.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut
  down twice.
* Fix what looks like a bug where if closing the socket throws an
  IOException, we fail to shut anything else down, though we still have
  ourselves marked as shut down.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2298) Executing a Function via Swagger without parameters throws an exception

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling updated GEODE-2298:

Description: 
When executing a function with Swagger, if no arguments are specified, the 
{{FunctionAccessController}} will throw an exception because it incorrectly 
identifies the JSON of {{"{}"}} to be arguments.  When the JSON deserializer 
tries to work with it, an NPE is thrown because it's not a key:value pair.

The solution is to change the test to treat {{"{}"}} as "no arguments".


  was:
When executing a function with Swagger, if no arguments are specified, the 
{{FunctionAccessController}} will throw an exception because it incorrectly 
identifies the JSON of {{"{}"}} to be arguments.

The solution is to change the test to treat {{"{}"}} as "no arguments".



> Executing a Function via Swagger without parameters throws an exception
> ---
>
> Key: GEODE-2298
> URL: https://issues.apache.org/jira/browse/GEODE-2298
> Project: Geode
>  Issue Type: Bug
>  Components: management, rest (dev)
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> When executing a function with Swagger, if no arguments are specified, the 
> {{FunctionAccessController}} will throw an exception because it incorrectly 
> identifies the JSON of {{"{}"}} to be arguments.  When the JSON deserializer 
> tries to work with it, an NPE is thrown because it's not a key:value pair.
> The solution is to change the test to treat {{"{}"}} as "no arguments".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

[Galen O'Sullivan (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832200#comment-15832200
 ] 

Galen O'Sullivan commented on GEODE-2324:
-

Amends the fix in GEODE-1103.

> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> --
>
> Key: GEODE-2324
> URL: https://issues.apache.org/jira/browse/GEODE-2324
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.0.0-incubating
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> In {{AcceptorImpl.close()}}, the call to 
> {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, 
> TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which 
> case neither {pool} nor {{hsPool}} or anything else that comes after is 
> properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued 
> (for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (GEODE-2298) Executing a Function via Swagger without parameters throws an exception

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling reassigned GEODE-2298:
---

Assignee: Kevin Duling

> Executing a Function via Swagger without parameters throws an exception
> ---
>
> Key: GEODE-2298
> URL: https://issues.apache.org/jira/browse/GEODE-2298
> Project: Geode
>  Issue Type: Bug
>  Components: management, rest (dev)
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> When executing a function with Swagger, if no arguments are specified, the 
> {{FunctionAccessController}} will throw an exception because it incorrectly 
> identifies the JSON of {{"{}"}} to be arguments.
> The solution is to change the test to treat {{"{}"}} as "no arguments".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (GEODE-2311) Add CSharp Project for securityImpl for Building Native Client .NET Security Quickstarts

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell closed GEODE-2311.
--

> Add CSharp Project for securityImpl for Building Native Client .NET Security 
> Quickstarts
> 
>
> Key: GEODE-2311
> URL: https://issues.apache.org/jira/browse/GEODE-2311
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>
> Since cmake doesn't yet support C#, we should provide a CSharp project 
> (.csproj file) for easily building the 
> GemStone.GemFire.Templates.Cache.Security.dll, which is needed by the native 
> client C# security quickstarts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832176#comment-15832176
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user scmbuildguy commented on the issue:

https://github.com/apache/geode/pull/342
  
+1 for this round


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode issue #342: GEODE-2309: Replace Pivotal Copyright and add Apache Licen...

[scmbuildguy]

Github user scmbuildguy commented on the issue:

https://github.com/apache/geode/pull/342
  
+1 for this round


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832166#comment-15832166
 ] 

ASF GitHub Bot commented on GEODE-2326:
---

Github user dgkimura closed the pull request at:

https://github.com/apache/geode/pull/346


> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode pull request #346: GEODE-2326: Adjust testLogger hardcoded value

[dgkimura]

Github user dgkimura closed the pull request at:

https://github.com/apache/geode/pull/346


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2311) Add CSharp Project for securityImpl for Building Native Client .NET Security Quickstarts

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2311.
--
Resolution: Fixed

> Add CSharp Project for securityImpl for Building Native Client .NET Security 
> Quickstarts
> 
>
> Key: GEODE-2311
> URL: https://issues.apache.org/jira/browse/GEODE-2311
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>
> Since cmake doesn't yet support C#, we should provide a CSharp project 
> (.csproj file) for easily building the 
> GemStone.GemFire.Templates.Cache.Security.dll, which is needed by the native 
> client C# security quickstarts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2311) Add CSharp Project for securityImpl for Building Native Client .NET Security Quickstarts

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832153#comment-15832153
 ] 

ASF subversion and git services commented on GEODE-2311:


Commit 512b34594c95ab30bd5e6b01fb836fab2729744f in geode's branch 
refs/heads/next-gen-native-client-software-grant from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=512b345 ]

GEODE-2311: Add cmake support for building the C# security dll used by the C# 
security quickstarts.

This closes #345


> Add CSharp Project for securityImpl for Building Native Client .NET Security 
> Quickstarts
> 
>
> Key: GEODE-2311
> URL: https://issues.apache.org/jira/browse/GEODE-2311
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>
> Since cmake doesn't yet support C#, we should provide a CSharp project 
> (.csproj file) for easily building the 
> GemStone.GemFire.Templates.Cache.Security.dll, which is needed by the native 
> client C# security quickstarts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832150#comment-15832150
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/342
  
LGTM, these changes typically take multiple iterations to get right.


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode issue #342: GEODE-2309: Replace Pivotal Copyright and add Apache Licen...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/342
  
LGTM, these changes typically take multiple iterations to get right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/344
  
Any further discussion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2272) Pulse Data Browser export hangs

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2272:
-
Fix Version/s: 1.0.0-incubating

> Pulse Data Browser export hangs
> ---
>
> Key: GEODE-2272
> URL: https://issues.apache.org/jira/browse/GEODE-2272
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Affects Versions: 1.0.0-incubating
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> The Export feature of Pulse Data Browser is prone to hang with large amounts 
> of data as it requires loading all the query results into the browser before 
> they can be exported.  Instead, we should allow a user to Export query 
> results directly to a file without first loading the results into their 
> browser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-2326) Fix broken integration test testLogger

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2326.
--
Resolution: Fixed

> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-2272) Pulse Data Browser export hangs

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart resolved GEODE-2272.
--
Resolution: Fixed

> Pulse Data Browser export hangs
> ---
>
> Key: GEODE-2272
> URL: https://issues.apache.org/jira/browse/GEODE-2272
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Affects Versions: 1.0.0-incubating
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> The Export feature of Pulse Data Browser is prone to hang with large amounts 
> of data as it requires loading all the query results into the browser before 
> they can be exported.  Instead, we should allow a user to Export query 
> results directly to a file without first loading the results into their 
> browser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832144#comment-15832144
 ] 

ASF subversion and git services commented on GEODE-2326:


Commit d777525b93e9bb1f6b66af2a2873c06eb0c54c52 in geode's branch 
refs/heads/next-gen-native-client-software-grant from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d777525 ]

GEODE-2326: Adjust testLogger hardcoded value

This closes #346


> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GEODE-2272) Pulse Data Browser export hangs

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2272:
-
Fix Version/s: (was: 1.0.0-incubating)
   1.1.0

> Pulse Data Browser export hangs
> ---
>
> Key: GEODE-2272
> URL: https://issues.apache.org/jira/browse/GEODE-2272
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Affects Versions: 1.0.0-incubating
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> The Export feature of Pulse Data Browser is prone to hang with large amounts 
> of data as it requires loading all the query results into the browser before 
> they can be exported.  Instead, we should allow a user to Export query 
> results directly to a file without first loading the results into their 
> browser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832136#comment-15832136
 ] 

ASF GitHub Bot commented on GEODE-2326:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/346
  
LGTM


> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode issue #346: GEODE-2326: Adjust testLogger hardcoded value

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/346
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2329) JSONFormatter.fromJSON method has duplicate behavior

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832096#comment-15832096
 ] 

ASF subversion and git services commented on GEODE-2329:


Commit e82cf4192c1e49a095d3a25b54d38e365f80864c in geode's branch 
refs/heads/feature/GEODE-2329 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e82cf41 ]

GEODE-2329: spotless


> JSONFormatter.fromJSON method has duplicate behavior
> 
>
> Key: GEODE-2329
> URL: https://issues.apache.org/jira/browse/GEODE-2329
> Project: Geode
>  Issue Type: Sub-task
>  Components: serialization
>Reporter: Udo Kohlmeyer
> Fix For: 1.1.0
>
>
> refactor the duplicate code in the fromJSON method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55736/
---

(Updated Jan. 20, 2017, 4:50 p.m.)


Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
Khamesra.


Repository: geode


Description
---

the add fields have the same behavior and identical code. Refactored the code 
to use a single method and reduce duplication


Diffs
-

  
geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java
 39d16a57e 
  
geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java
 7f510da15 
  
geode-core/src/test/java/org/apache/geode/pdx/JSONPdxClientServerDUnitTest.java 
396eb1d13 

Diff: https://reviews.apache.org/r/55736/diff/


Testing (updated)
---

precheckin - passed


Thanks,

Udo Kohlmeyer

Re: Review Request 55738: GEODE-2329: Refactor JSONFormatter.fromJSON method to reduce duplication

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55738/
---

(Updated Jan. 20, 2017, 4:45 p.m.)


Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
Khamesra.


Repository: geode


Description (updated)
---

Remove duplicate code from the JSONFormatter.fromJSON method
cleaned up some testing code and fixed a classcast issue


Diffs
-

  geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java 9ee32c913 
  geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java 
7fd6cf2c5 

Diff: https://reviews.apache.org/r/55738/diff/


Testing
---

precheckin - running


Thanks,

Udo Kohlmeyer

Re: Review Request 55738: GEODE-2329: Refactor JSONFormatter.fromJSON method to reduce duplication

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55738/
---

(Updated Jan. 20, 2017, 4:44 p.m.)


Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
Khamesra.


Repository: geode


Description
---

Remove duplicate code from the JSONFormatter.fromJSON method


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java 9ee32c913 
  geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java 
7fd6cf2c5 

Diff: https://reviews.apache.org/r/55738/diff/


Testing
---

precheckin - running


Thanks,

Udo Kohlmeyer

[jira] [Commented] (GEODE-2329) JSONFormatter.fromJSON method has duplicate behavior

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832076#comment-15832076
 ] 

ASF subversion and git services commented on GEODE-2329:


Commit 7c2a70cd8e22ab75debf8ac5f564d14d090e72b4 in geode's branch 
refs/heads/feature/GEODE-2329 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7c2a70c ]

GEODE-2329: Cleanup test code and fix Classcast issue


> JSONFormatter.fromJSON method has duplicate behavior
> 
>
> Key: GEODE-2329
> URL: https://issues.apache.org/jira/browse/GEODE-2329
> Project: Geode
>  Issue Type: Sub-task
>  Components: serialization
>Reporter: Udo Kohlmeyer
> Fix For: 1.1.0
>
>
> refactor the duplicate code in the fromJSON method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2172) CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831643#comment-15831643
 ] 

ASF GitHub Bot commented on GEODE-2172:
---

GitHub user vectorijk opened a pull request:

https://github.com/apache/geode/pull/348

[GEODE-2172] CustomConfigWithCacheIntegrationTest fails with AssertionError 
on Windows

> The issues is related to incorrect regex pattern. The regex pattern used 
to match log string contains newline character. To fix this issue, I've 
replaced Unix newline character in regex pattern into System.lineSeparator(), a 
Platform-dependent newline character in Java.
> 
> I've run this unit test both on Windows and MacOS. And it passes.

Review Board: 
[https://reviews.apache.org/r/54586/](https://reviews.apache.org/r/54586/)

Since this has been marked as `Ship it`, this PR here will be easy for 
merging.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/geode GEODE-2172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #348


commit bc33c54e7afa5c8d09a18ec857ff385559639e0a
Author: Kai Jiang 
Date:   2016-12-09T12:43:16Z

reason

commit e407c12546de05492580b9cfdf1fbe8db7068782
Author: Kai Jiang 
Date:   2016-12-19T12:38:10Z

delete unused test method




> CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows
> -
>
> Key: GEODE-2172
> URL: https://issues.apache.org/jira/browse/GEODE-2172
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.0.0-incubating
> Environment: Windows
>Reporter: Kirk Lund
>Assignee: Kai Jiang
>  Labels: IntegrationTest, Windows
>
> cacheLogWriterMessageShouldMatchCustomConfig fails with AssertionError:
> {noformat}
> java.lang.AssertionError: 
> Expecting:
>   "CUSTOM: level=INFO time=2016/11/30 13:49:13.780 PST message=
> 
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:14.497 PST message=Running in local 
> mode since no locators were specified.
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.496 PST message=Initializing 
> region _monitoringRegion_192.168.1.410
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.542 PST message=Initialization of 
> region _monitoringRegion_192.168.1.410 completed
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:17.492 PST message=this is a log 
> statement from cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
> to contain pattern:
>   "CUSTOM: level=INFO time=.* message=this is a log statement from 
> cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
>   at 
> org.apache.geode.internal.logging.log4j.custom.CustomConfigWithCacheIntegrationTest.cacheLogWriterMessageShouldMatchCustomConfig(CustomConfigWithCacheIntegrationTest.java:149)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatche

[GitHub] geode pull request #348: [GEODE-2172] CustomConfigWithCacheIntegrationTest f...

[vectorijk]

GitHub user vectorijk opened a pull request:

https://github.com/apache/geode/pull/348

[GEODE-2172] CustomConfigWithCacheIntegrationTest fails with AssertionError 
on Windows

> The issues is related to incorrect regex pattern. The regex pattern used 
to match log string contains newline character. To fix this issue, I've 
replaced Unix newline character in regex pattern into System.lineSeparator(), a 
Platform-dependent newline character in Java.
> 
> I've run this unit test both on Windows and MacOS. And it passes.

Review Board: 
[https://reviews.apache.org/r/54586/](https://reviews.apache.org/r/54586/)

Since this has been marked as `Ship it`, this PR here will be easy for 
merging.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/geode GEODE-2172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #348


commit bc33c54e7afa5c8d09a18ec857ff385559639e0a
Author: Kai Jiang 
Date:   2016-12-09T12:43:16Z

reason

commit e407c12546de05492580b9cfdf1fbe8db7068782
Author: Kai Jiang 
Date:   2016-12-19T12:38:10Z

delete unused test method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---