Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/#review175270 --- Ship it! Ship It! - Jared Stewart On May 16, 2017, 11:46 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59324/ > --- > > (Updated May 16, 2017, 11:46 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick > Rhomberg. > > > Bugs: GEODE-1279 > https://issues.apache.org/jira/browse/GEODE-1279 > > > Repository: geode > > > Description > --- > > GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest > > * renamed test class and cleaned up test code > > Bug51193DUnitTest failed once in a recent precheckin of mine. I think this > test might be flaky but I haven't seen it fail again yet. I decided to lookup > TRAC #51193 and change the name to something meaningful. I also added a Rule > and changed the test to use JUnit Params. > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java > 0dfbe6cc1580d890104d907e8d9efb388b892c24 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59324/diff/1/ > > > Testing > --- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/#review175269 --- Ship it! Ship It! - Patrick Rhomberg On May 16, 2017, 11:46 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59324/ > --- > > (Updated May 16, 2017, 11:46 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick > Rhomberg. > > > Bugs: GEODE-1279 > https://issues.apache.org/jira/browse/GEODE-1279 > > > Repository: geode > > > Description > --- > > GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest > > * renamed test class and cleaned up test code > > Bug51193DUnitTest failed once in a recent precheckin of mine. I think this > test might be flaky but I haven't seen it fail again yet. I decided to lookup > TRAC #51193 and change the name to something meaningful. I also added a Rule > and changed the test to use JUnit Params. > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java > 0dfbe6cc1580d890104d907e8d9efb388b892c24 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59324/diff/1/ > > > Testing > --- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/#review175268 --- Ship it! Ship It! - Jinmei Liao On May 16, 2017, 11:46 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59324/ > --- > > (Updated May 16, 2017, 11:46 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick > Rhomberg. > > > Bugs: GEODE-1279 > https://issues.apache.org/jira/browse/GEODE-1279 > > > Repository: geode > > > Description > --- > > GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest > > * renamed test class and cleaned up test code > > Bug51193DUnitTest failed once in a recent precheckin of mine. I think this > test might be flaky but I haven't seen it fail again yet. I decided to lookup > TRAC #51193 and change the name to something meaningful. I also added a Rule > and changed the test to use JUnit Params. > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java > 0dfbe6cc1580d890104d907e8d9efb388b892c24 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59324/diff/1/ > > > Testing > --- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick Rhomberg. Bugs: GEODE-1279 https://issues.apache.org/jira/browse/GEODE-1279 Repository: geode Description --- GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest * renamed test class and cleaned up test code Bug51193DUnitTest failed once in a recent precheckin of mine. I think this test might be flaky but I haven't seen it fail again yet. I decided to lookup TRAC #51193 and change the name to something meaningful. I also added a Rule and changed the test to use JUnit Params. Diffs - geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java 0dfbe6cc1580d890104d907e8d9efb388b892c24 geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59324/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund
