[jira] [Commented] (HIVE-2727) add a testcase for partitioned view on union and base tables have index
[ https://issues.apache.org/jira/browse/HIVE-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548321#comment-13548321 ] Hudson commented on HIVE-2727: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2727 add a testcase for partitioned view on union and base tables have index (He Yongqiang via namit) (Revision 1235864) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1235864 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/queries/clientpositive/union_view.q * /hive/trunk/ql/src/test/results/clientpositive/union_view.q.out > add a testcase for partitioned view on union and base tables have index > --- > > Key: HIVE-2727 > URL: https://issues.apache.org/jira/browse/HIVE-2727 > Project: Hive > Issue Type: Test >Reporter: He Yongqiang >Assignee: He Yongqiang > Fix For: 0.9.0 > > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2727.D1323.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2727.D1323.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2727.D1323.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2727.D1323.4.patch, HIVE-2727.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2727) add a testcase for partitioned view on union and base tables have index
[ https://issues.apache.org/jira/browse/HIVE-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193446#comment-13193446 ] Hudson commented on HIVE-2727: -- Integrated in Hive-trunk-h0.21 #1220 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1220/]) HIVE-2727 add a testcase for partitioned view on union and base tables have index (He Yongqiang via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1235864 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/queries/clientpositive/union_view.q * /hive/trunk/ql/src/test/results/clientpositive/union_view.q.out > add a testcase for partitioned view on union and base tables have index > --- > > Key: HIVE-2727 > URL: https://issues.apache.org/jira/browse/HIVE-2727 > Project: Hive > Issue Type: Test >Reporter: He Yongqiang >Assignee: He Yongqiang > Fix For: 0.9.0 > > Attachments: HIVE-2727.1.patch, HIVE-2727.D1323.1.patch, > HIVE-2727.D1323.2.patch, HIVE-2727.D1323.3.patch, HIVE-2727.D1323.4.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2727) add a testcase for partitioned view on union and base tables have index
[ https://issues.apache.org/jira/browse/HIVE-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190176#comment-13190176 ] Phabricator commented on HIVE-2727: --- njain has commented on the revision "HIVE-2727 [jira] add a testcase for partitioned view on union and base tables have index". INLINE COMMENTS ql/src/test/results/clientpositive/union_view.q.out:308 This needs to be masked or ignored from the diff comparison. This will always fail Can you check for all lastModifiedTime occurences ? ql/src/test/queries/clientpositive/union_view.q:34 needs a order by to make it deterministic ql/src/test/queries/clientpositive/union_view.q:35 same as above ql/src/test/queries/clientpositive/union_view.q:38 same as above (line 39 also) ql/src/test/queries/clientpositive/union_view.q:59 make this and next one ordered ql/src/test/queries/clientpositive/union_view.q:84 basically, there are multiple partitions for ds=2 and ds=3. Can you make this deterministic ? REVISION DETAIL https://reviews.facebook.net/D1323 > add a testcase for partitioned view on union and base tables have index > --- > > Key: HIVE-2727 > URL: https://issues.apache.org/jira/browse/HIVE-2727 > Project: Hive > Issue Type: Test >Reporter: He Yongqiang >Assignee: He Yongqiang > Attachments: HIVE-2727.1.patch, HIVE-2727.D1323.1.patch, > HIVE-2727.D1323.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2727) add a testcase for partitioned view on union and base tables have index
[ https://issues.apache.org/jira/browse/HIVE-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190015#comment-13190015 ] Phabricator commented on HIVE-2727: --- njain has commented on the revision "HIVE-2727 [jira] add a testcase for partitioned view on union and base tables have index". INLINE COMMENTS ql/src/test/results/clientpositive/union_view.q.out:2126 I am not sure - is this correct. Why are we doing a index scan for this table ? I mean src_union_3. We are only looking for index for src_union_1, which is correct. Let us talk offline REVISION DETAIL https://reviews.facebook.net/D1323 > add a testcase for partitioned view on union and base tables have index > --- > > Key: HIVE-2727 > URL: https://issues.apache.org/jira/browse/HIVE-2727 > Project: Hive > Issue Type: Test >Reporter: He Yongqiang >Assignee: He Yongqiang > Attachments: HIVE-2727.1.patch, HIVE-2727.D1323.1.patch, > HIVE-2727.D1323.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2727) add a testcase for partitioned view on union and base tables have index
[ https://issues.apache.org/jira/browse/HIVE-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189363#comment-13189363 ] Phabricator commented on HIVE-2727: --- njain has commented on the revision "HIVE-2727 [jira] add a testcase for partitioned view on union and base tables have index". INLINE COMMENTS ql/src/test/queries/clientpositive/union_view.q:27 The code changes look OK. But, can you change the tests ? Create 2 partitions in each base table. Change the explain to Explain Extended for all the queries, to verify that we are only looking at the relevant partitions of the index. Can you unset all the hooks for this (printhook, lineagehook etc.) Also remove the merge (both map-only and map-reduce only). It will make the test output much smaller, and easier to validate REVISION DETAIL https://reviews.facebook.net/D1323 > add a testcase for partitioned view on union and base tables have index > --- > > Key: HIVE-2727 > URL: https://issues.apache.org/jira/browse/HIVE-2727 > Project: Hive > Issue Type: Test >Reporter: He Yongqiang >Assignee: He Yongqiang > Attachments: HIVE-2727.1.patch, HIVE-2727.D1323.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2727) add a testcase for partitioned view on union and base tables have index
[ https://issues.apache.org/jira/browse/HIVE-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188838#comment-13188838 ] He Yongqiang commented on HIVE-2727: https://reviews.facebook.net/D1323 > add a testcase for partitioned view on union and base tables have index > --- > > Key: HIVE-2727 > URL: https://issues.apache.org/jira/browse/HIVE-2727 > Project: Hive > Issue Type: Test >Reporter: He Yongqiang >Assignee: He Yongqiang > Attachments: HIVE-2727.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
