[jira] [Commented] (HIVE-5643) ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts
[ https://issues.apache.org/jira/browse/HIVE-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806241#comment-13806241 ] Venki Korukanti commented on HIVE-5643: --- RB link: https://reviews.apache.org/r/14978/ ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts Key: HIVE-5643 URL: https://issues.apache.org/jira/browse/HIVE-5643 Project: Hive Issue Type: Bug Components: Locking Affects Versions: 0.12.0 Reporter: Venki Korukanti Assignee: Venki Korukanti Fix For: 0.13.0 Attachments: HIVE-5643.1.patch.txt ZooKeeperHiveLockManager calls the below method to construct the connection string for ZooKeeper connection. {code} private static String getQuorumServers(HiveConf conf) { String hosts = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_QUORUM); String port = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_CLIENT_PORT); return hosts + : + port; } {code} For example: HIVE_ZOOKEEPER_QUORUM=node1, node2, node3 HIVE_ZOOKEEPER_CLIENT_PORT= Connection string given to ZooKeeper object is node1, node2, node3:. ZooKeeper consider the default port as 2181 for hostnames that don't have any port. This works fine as long as HIVE_ZOOKEEPER_CLIENT_PORT is 2181. If it is different then ZooKeeper client object tries to connect to node1 and node2 on port 2181 which always fails. So it has only one choice the last host which receives all the load from Hive. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5643) ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts
[ https://issues.apache.org/jira/browse/HIVE-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806308#comment-13806308 ] Hive QA commented on HIVE-5643: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610466/HIVE-5643.1.patch.txt {color:green}SUCCESS:{color} +1 4484 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1259/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1259/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts Key: HIVE-5643 URL: https://issues.apache.org/jira/browse/HIVE-5643 Project: Hive Issue Type: Bug Components: Locking Affects Versions: 0.12.0 Reporter: Venki Korukanti Assignee: Venki Korukanti Fix For: 0.13.0 Attachments: HIVE-5643.1.patch.txt ZooKeeperHiveLockManager calls the below method to construct the connection string for ZooKeeper connection. {code} private static String getQuorumServers(HiveConf conf) { String hosts = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_QUORUM); String port = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_CLIENT_PORT); return hosts + : + port; } {code} For example: HIVE_ZOOKEEPER_QUORUM=node1, node2, node3 HIVE_ZOOKEEPER_CLIENT_PORT= Connection string given to ZooKeeper object is node1, node2, node3:. ZooKeeper consider the default port as 2181 for hostnames that don't have any port. This works fine as long as HIVE_ZOOKEEPER_CLIENT_PORT is 2181. If it is different then ZooKeeper client object tries to connect to node1 and node2 on port 2181 which always fails. So it has only one choice the last host which receives all the load from Hive. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5643) ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts
[ https://issues.apache.org/jira/browse/HIVE-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806347#comment-13806347 ] Edward Capriolo commented on HIVE-5643: --- +1 ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts Key: HIVE-5643 URL: https://issues.apache.org/jira/browse/HIVE-5643 Project: Hive Issue Type: Bug Components: Locking Affects Versions: 0.12.0 Reporter: Venki Korukanti Assignee: Venki Korukanti Fix For: 0.13.0 Attachments: HIVE-5643.1.patch.txt ZooKeeperHiveLockManager calls the below method to construct the connection string for ZooKeeper connection. {code} private static String getQuorumServers(HiveConf conf) { String hosts = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_QUORUM); String port = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_CLIENT_PORT); return hosts + : + port; } {code} For example: HIVE_ZOOKEEPER_QUORUM=node1, node2, node3 HIVE_ZOOKEEPER_CLIENT_PORT= Connection string given to ZooKeeper object is node1, node2, node3:. ZooKeeper consider the default port as 2181 for hostnames that don't have any port. This works fine as long as HIVE_ZOOKEEPER_CLIENT_PORT is 2181. If it is different then ZooKeeper client object tries to connect to node1 and node2 on port 2181 which always fails. So it has only one choice the last host which receives all the load from Hive. -- This message was sent by Atlassian JIRA (v6.1#6144)