[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884045#comment-13884045 ] Hive QA commented on HIVE-5929: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625484/HIVE-5929.6.patch {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 4962 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_import_exported_table org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_reducers_power_two org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_load_hdfs_file_with_space_in_the_name org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_file_with_header_footer_negative org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20 {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1058/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1058/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12625484 > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch, HIVE-5929.3.patch, > HIVE-5929.4.patch, HIVE-5929.5.patch, HIVE-5929.6.patch > > Original Estimate: 48h > Time Spent: 1.6h > Remaining Estimate: 8h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883705#comment-13883705 ] Ashutosh Chauhan commented on HIVE-5929: LGTM +1 > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch, HIVE-5929.3.patch, > HIVE-5929.4.patch, HIVE-5929.5.patch, HIVE-5929.6.patch > > Original Estimate: 48h > Time Spent: 1.6h > Remaining Estimate: 8h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883564#comment-13883564 ] Thejas M Nair commented on HIVE-5929: - HIVE-5929.6.patch - addresses review comments > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch, HIVE-5929.3.patch, > HIVE-5929.4.patch, HIVE-5929.5.patch, HIVE-5929.6.patch > > Original Estimate: 48h > Time Spent: 1.6h > Remaining Estimate: 8h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883513#comment-13883513 ] Thejas M Nair commented on HIVE-5929: - HIVE-5929.5.patch - fixes the unit test failures (change in SessionState.java, to create a copy of HiveConf before calling Hive.get(conf) ). This problem was not seen earlier because one of the calls from SessionState.setupAuth() was leading to a new HiveObject being created with HiveConf copy. As a side effect of not calling SessionState.setupAuth() from SessionState.start() this bug showed up. > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch, HIVE-5929.3.patch, > HIVE-5929.4.patch, HIVE-5929.5.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881808#comment-13881808 ] Hive QA commented on HIVE-5929: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12624926/HIVE-5929.4.patch {color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 4959 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_part_inherit_tbl_props org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_part_inherit_tbl_props_with_star org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_url_hook org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_import_exported_table org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_load_hdfs_file_with_space_in_the_name org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_add_partition_with_whitelist org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_alter_partition_with_whitelist org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_disallow_incompatible_type_change_on1 org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_dynamic_partitions_with_whitelist org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_file_with_header_footer_negative {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1012/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1012/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 11 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12624926 > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch, HIVE-5929.3.patch, > HIVE-5929.4.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879348#comment-13879348 ] Ashutosh Chauhan commented on HIVE-5929: +1 pending tests > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch, HIVE-5929.3.patch, > HIVE-5929.4.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) SQL std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879104#comment-13879104 ] Ashutosh Chauhan commented on HIVE-5929: Left some comments on RB. Also, you may want to mark it Patch Available to get Hive QA run on it. > SQL std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair > Attachments: HIVE-5929.1.patch, HIVE-5929.2.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5929) sql std auth - Access control statement updates
[ https://issues.apache.org/jira/browse/HIVE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838219#comment-13838219 ] Thejas M Nair commented on HIVE-5929: - Things to be done include - In grant/revoke statements, identify user vs role and make appropriate call - For grant-role, add checks to prevent cycles in role relationship > sql std auth - Access control statement updates > --- > > Key: HIVE-5929 > URL: https://issues.apache.org/jira/browse/HIVE-5929 > Project: Hive > Issue Type: Sub-task > Components: Authorization >Reporter: Thejas M Nair > Original Estimate: 48h > Remaining Estimate: 48h > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . -- This message was sent by Atlassian JIRA (v6.1#6144)