[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960795#comment-13960795 ] Lars Francke commented on HIVE-6331: The patch is a doc only patch and as such shouldn't affect any tests. They seem unrelated to me. > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch, HIVE-6331.2.patch, HIVE-6331.3.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947102#comment-13947102 ] Xuefu Zhang commented on HIVE-6331: --- [~lars_francke] I'm wondering if the test failures are related to your change. I guess not, but could you confirm? > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch, HIVE-6331.2.patch, HIVE-6331.3.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944641#comment-13944641 ] Hive QA commented on HIVE-6331: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12635984/HIVE-6331.3.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5442 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority2 org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20 {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1932/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1932/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12635984 > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch, HIVE-6331.2.patch, HIVE-6331.3.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942208#comment-13942208 ] Swarnim Kulkarni commented on HIVE-6331: Can we not remove the statement "UDAF classes are REQUIRED to inherit from this class." completely. IMHO, the statement "Base class for all User-defined Aggregation Function (UDAF) classes." is good enough indication that new UDAFs are required to inherit from this class. The previous statement with the deprecation statement makes things a little confusing. > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch, HIVE-6331.2.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942081#comment-13942081 ] Lefty Leverenz commented on HIVE-6331: -- +1 > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch, HIVE-6331.2.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939793#comment-13939793 ] Hive QA commented on HIVE-6331: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12635056/HIVE-6331.2.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5411 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin6 {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1868/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1868/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12635056 > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch, HIVE-6331.2.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937468#comment-13937468 ] Lefty Leverenz commented on HIVE-6331: -- Trivial review comments: 1. "support" should be "supports" since UDAF is singular: {code} + * Optional for a UDAF class (by implementing these two methods, the user declares + * that the UDAF support partial aggregations): {code} 2. Second should be indented like the first one: {code} + * + * Implement a single method called {@code evaluatePartial} that returns the PARTIAL aggregation result. + * {@code evaluatePartial} should never return {@code null} or an Exception will be thrown. + * Implement a single method called {@code aggregatePartial} that takes a PARTIAL {code} > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912698#comment-13912698 ] Lars Francke commented on HIVE-6331: I accidentally named the patch after the wrong issue but it's still correct for this one. > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Attachments: HIVE-5279.1.patch > > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
[ https://issues.apache.org/jira/browse/HIVE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889137#comment-13889137 ] Navis commented on HIVE-6331: - UDAF was deprecated long time before HIVE-5279 and I just added the annotation along with the patch but I should have fixed the javadoc also. Currently, implementing GenericUDAFResolver2 or extending AbstractGenericUDAFResolver is the standard way to implement aggregation function. > HIVE-5279 deprecated UDAF class without explanation/documentation/alternative > - > > Key: HIVE-6331 > URL: https://issues.apache.org/jira/browse/HIVE-6331 > Project: Hive > Issue Type: Bug >Reporter: Lars Francke >Priority: Minor > > HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment > in that class says {quote}UDAF classes are REQUIRED to inherit from this > class.{quote} > One of these two needs to be updated. Either remove the annotation or > document why it was deprecated and what to use instead. > Unfortunately [~navis] did not leave any documentation about his intentions. > I'm happy to provide a patch once I know the intentions. -- This message was sent by Atlassian JIRA (v6.1.5#6160)