[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946279#comment-13946279
]
Lefty Leverenz commented on HIVE-6687:
--
Added the new configuration parameter to the wiki here:
* [Configuration Properties: hive.resultset.use.unique.column.names
|https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.resultset.use.unique.column.names]
After HIVE-6037 gets committed, this parameter will have to be added to
HiveConf.java again -- see HIVE-6586:
* [comment for hive.resultset.use.unique.column.names
|https://issues.apache.org/jira/browse/HIVE-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946274#comment-13946274]
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.13.0
Attachments: HIVE-6687.4.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944744#comment-13944744
]
Laljo John Pullokkaran commented on HIVE-6687:
--
Modified unit test print_header.q log file.
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.4.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943945#comment-13943945
]
Ashutosh Chauhan commented on HIVE-6687:
Seems like checked-in .q.out file is incorrect, what we are getting now seems
more appropriate.
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943398#comment-13943398
]
Laljo John Pullokkaran commented on HIVE-6687:
--
Apparently view schema also uses same result set schema.
Modified patch to:
1. Separate out View Schema vs Result Set Schema.
2. View Schema won't use qualified table names. View schema would also ensure
that column names are unique.
3. ResultSet schema by default would use table aliases if provided (select *,
or user provided qualified projections select r1.x..)
4. To get old behavior for result set schema, introduced a config param
hive.resultset.use.unique.column.names; this is set to true by default. User
will have to set this to false for old behavior.
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Fix For: 0.12.1
Attachments: HIVE-6687.2.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943399#comment-13943399
]
Laljo John Pullokkaran commented on HIVE-6687:
--
Vaibhav, I modified the test cases that seems like could get affected. If we
are not using JDBC1 then its a no-op.
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Fix For: 0.12.1
Attachments: HIVE-6687.2.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943552#comment-13943552
]
Ashutosh Chauhan commented on HIVE-6687:
[~jpullokkaran] Can you also update RB with latest patch?
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943568#comment-13943568
]
Lefty Leverenz commented on HIVE-6687:
--
The documentation of *hive.resultset.use.unique.column.names* looks good to me.
When the time comes I'll add it to the wiki.
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943587#comment-13943587
]
Laljo John Pullokkaran commented on HIVE-6687:
--
Review Board: https://reviews.apache.org/r/19551/
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943611#comment-13943611
]
Ashutosh Chauhan commented on HIVE-6687:
+1 LGTM
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943874#comment-13943874
]
Prasad Mujumdar commented on HIVE-6687:
---
+1
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943907#comment-13943907
]
Hive QA commented on HIVE-6687:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12636089/HIVE-6687.3.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 5437 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_print_header
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1898/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1898/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12636089
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Labels: documentation
Fix For: 0.12.1
Attachments: HIVE-6687.3.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941528#comment-13941528
]
Vaibhav Gumashta commented on HIVE-6687:
[~jpullokkaran] Can you upload the patch to review board - makes an easier read?
Quickly went through and noticed that some tests are added to TestJdbcDriver.
Actually that class is used to tests the JDBC-1 driver compatible with
HiveServer1. I don't think there's much development there. TestJdbcDriver2
supersedes it. Thanks!
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Fix For: 0.12.1
Attachments: HIVE-6687.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6687) JDBC ResultSet fails to get value by qualified projection name
[
https://issues.apache.org/jira/browse/HIVE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942417#comment-13942417
]
Harish Butani commented on HIVE-6687:
-
Review is at https://reviews.apache.org/r/19503/
JDBC ResultSet fails to get value by qualified projection name
--
Key: HIVE-6687
URL: https://issues.apache.org/jira/browse/HIVE-6687
Project: Hive
Issue Type: Bug
Components: HiveServer2
Affects Versions: 0.12.0
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
Fix For: 0.12.1
Attachments: HIVE-6687.patch
Getting value from result set using fully qualified name would throw
exception. Only solution today is to use position of the column as opposed to
column label.
{code}
String sql = select r1.x, r2.x from r1 join r2 on r1.y=r2.y;
ResultSet res = stmt.executeQuery(sql);
res.getInt(r1.x);
{code}
res.getInt(r1.x); would throw exception unknown column even though sql
specifies it.
Fix is to fix resultsetschema in semantic analyzer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
