[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120383#comment-14120383 ] Hive QA commented on HIVE-7944: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12666289/HIVE-7944.2.patch {color:green}SUCCESS:{color} +1 6142 tests passed Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/621/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/621/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-621/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12666289 > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > Attachments: HIVE-7944.1.patch, HIVE-7944.2.patch > > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120263#comment-14120263 ] Ashutosh Chauhan commented on HIVE-7944: +1 > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > Attachments: HIVE-7944.1.patch, HIVE-7944.2.patch > > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120254#comment-14120254 ] pengcheng xiong commented on HIVE-7944: --- After I tested this with mysql which has tables pre-created (not auto created via datanucleus), I find that my method does not work. Thus, I followed the "revert idea" https://reviews.apache.org/r/25281/ > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > Attachments: HIVE-7944.1.patch, HIVE-7944.2.patch > > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120161#comment-14120161 ] Eugene Koifman commented on HIVE-7944: -- +1 for the revert idea > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > Attachments: HIVE-7944.1.patch > > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120011#comment-14120011 ] Ashutosh Chauhan commented on HIVE-7944: [~pxiong] Have you tested this with mysql which has tables pre-created (not auto created via mysql)? I think there might be issues because in those cases csid & partid being null wont be inserted in db. I think let just simply revert HIVE-7876 before we figure out proper fix for this. > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > Attachments: HIVE-7944.1.patch > > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119667#comment-14119667 ] Hive QA commented on HIVE-7944: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12666101/HIVE-7944.1.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6142 tests executed *Failed tests:* {noformat} org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/613/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/613/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-613/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12666101 > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > Attachments: HIVE-7944.1.patch > > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118926#comment-14118926 ] pengcheng xiong commented on HIVE-7944: --- yes, im generating a roll-back patch > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7944) current update stats for columns of a partition of a table is not correct
[ https://issues.apache.org/jira/browse/HIVE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118924#comment-14118924 ] Eugene Koifman commented on HIVE-7944: -- Since that fix effectively broke stats, can it be rolled back until a proper fix is made? > current update stats for columns of a partition of a table is not correct > - > > Key: HIVE-7944 > URL: https://issues.apache.org/jira/browse/HIVE-7944 > Project: Hive > Issue Type: Bug >Reporter: pengcheng xiong >Assignee: pengcheng xiong > > We worked hard towards faster update stats for columns of a partition of a > table previously > https://issues.apache.org/jira/browse/HIVE-7736 > and > https://issues.apache.org/jira/browse/HIVE-7876 > Although there is some improvement, it is only correct in the first run. > There will be duplicate column stats later. Thanks to [~ekoifman] 's comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)