[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171756#comment-13171756 ] Phabricator commented on HIVE-2655: --- jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". This is a work in progress. Can't test right now because builtins are not loading for me in the test suite. How does this general framework look though? REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172663#comment-13172663 ] Phabricator commented on HIVE-2655: --- ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". This is awesome! And looks quite short. :) INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java:105 don't you need to at least register function here? REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172665#comment-13172665 ] Phabricator commented on HIVE-2655: --- jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java:105 Yes. Hence work in progress =). REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183350#comment-13183350 ] Phabricator commented on HIVE-2655: --- jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". pingping REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183787#comment-13183787 ] Phabricator commented on HIVE-2655: --- ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". Looks good, see inline. What do I have to do to have power to accept hive diffs? :) INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:43 why stateful? (is that related to serialization?) also it should probably be undeterministic since it can expres undeterministic function. later you can make it check body to see if it is deterministic, and than do what is needed in initialize. But no need. REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184552#comment-13184552 ] Phabricator commented on HIVE-2655: --- jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". To accept diffs you have to become a committer. I think it's a pretty arduous process =/. REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184710#comment-13184710 ] Phabricator commented on HIVE-2655: --- ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:66-72 I don't think this works for GenericUDF ? FunctionRegistry looks like is only looking at annotations. REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184713#comment-13184713 ] Phabricator commented on HIVE-2655: --- jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:66-72 See above @ 1106 and 1113 of FunctionRegistry in this diff. REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185329#comment-13185329 ] Phabricator commented on HIVE-2655: --- ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". Cool, in the long run it might be good to give that option to all GenericUDFs, but this is good for this diff. Now you have to find somebody that can accept this :) P.S. Can't wait to use this :) REVISION DETAIL https://reviews.facebook.net/D915 > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265201#comment-13265201 ] Phabricator commented on HIVE-2655: --- cwsteinbach has requested changes to the revision "HIVE-2655 [jira] Ability to define functions in HQL". INLINE COMMENTS ql/src/test/queries/clientpositive/macro.q:3 The test coverage for this feature needs to be expanded. What happens if the macro references a hiveconf or hivevar parameter? Missing positive coverage for: * Macro with zero input parameters * Macro with two input parameters * EXPLAIN output for a query using each variation of the above. * EXPLAIN EXTENDED output for a query using each variation of the above. Negative coverage for: * macro body references an undefined input parameter * input parameter not referenced in macro body * macro that defines two input parameters with the same name * Defining the same macro twice. * Droping a macro that doesn't exist. REVISION DETAIL https://reviews.facebook.net/D915 BRANCH macro > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265419#comment-13265419 ] Phabricator commented on HIVE-2655: --- cwsteinbach has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". INLINE COMMENTS ql/src/test/queries/clientpositive/macro.q:3 A couple more: * Reference the same macro twice in the same query * Reference two different macros in the same query REVISION DETAIL https://reviews.facebook.net/D915 BRANCH macro > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, > HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659195#comment-13659195 ] Edward Capriolo commented on HIVE-2655: --- +1. Sorry for the delay. Patch does not apply clean now. Please rebase and I will commit. > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677438#comment-13677438 ] Brock Noland commented on HIVE-2655: Actually that latest patch is bad. Regenerating. > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-10.patch, > HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683015#comment-13683015 ] Edward Capriolo commented on HIVE-2655: --- Patch is clean. Running tests now. > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-10.patch, > HIVE-2655-10.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683992#comment-13683992 ] Edward Capriolo commented on HIVE-2655: --- +1 Committed to trunk. Thanks Brock and Jonathon! Really cool. > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-10.patch, > HIVE-2655-10.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683998#comment-13683998 ] Brock Noland commented on HIVE-2655: Nice! Thank you Edward and Jonathon! > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-10.patch, > HIVE-2655-10.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[
https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684044#comment-13684044
]
Edward Capriolo commented on HIVE-2655:
---
Can you think of any reason why nonreserved_keywords_input37.q is failing?
{quote}
CREATE TABLE table(string string) STORED AS TEXTFILE;
LOAD DATA LOCAL INPATH '../data/files/docurl.txt' INTO TABLE table;
SELECT table, count(1)
FROM
(
FROM table
SELECT TRANSFORM (table.string)
USING 'java -cp ../build/ql/test/classes
org.apache.hadoop.hive.scripts.extracturl' AS (table, count)
) subq
GROUP BY table;
{
> Ability to define functions in HQL
> --
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
>Reporter: Jonathan Perlow
>Assignee: Brock Noland
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-10.patch,
> HIVE-2655-10.patch, HIVE-2655-9.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[
https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684047#comment-13684047
]
Brock Noland commented on HIVE-2655:
Hi,
I wonder if it's an environmental issue? I cannot reproduce with the following
command:
{noformat}
ant clean package && ant test -Dtestcase=TestCliDriver
-Dqfile=nonreserved_keywords_input37.q
{noformat}
> Ability to define functions in HQL
> --
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
>Reporter: Jonathan Perlow
>Assignee: Brock Noland
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-10.patch,
> HIVE-2655-10.patch, HIVE-2655-9.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576734#comment-13576734 ] Brock Noland commented on HIVE-2655: Jonathan, I haven't seen any updates to this JIRA in a while. Are you still working on it? If not, would you mind if I took it forward? Brock > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576870#comment-13576870 ] Jonathan Chang commented on HIVE-2655: -- Yeah, I haven't had a chance to work on this. Looks like all that needs to be done at this point is unittests. I would be more than happy to have you take this the rest of the way! > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576882#comment-13576882 ] Brock Noland commented on HIVE-2655: Hi, OK great! Yes the patch required only minor rebasing. I'll work on the unit tests and then post the resulting patch here. Thanks! Brock > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577188#comment-13577188 ] Phabricator commented on HIVE-2655: --- brock has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL". Regarding * Defining the same macro twice. * Dropping a macro that doesn't exist. I assume the behavior should be the same as functions with allows both of these behaviors. As such I wonder why they were listed under negative tests? REVISION DETAIL https://reviews.facebook.net/D915 BRANCH macro ARCANIST PROJECT hive To: JIRA, jsichi, cwsteinbach, jonchang Cc: jonchang, ikabiljo, brock > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Jonathan Chang > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580692#comment-13580692 ] Brock Noland commented on HIVE-2655: Namit, Thanks for moving this to "Open". I should have noticed that. I took this patch over from Jonathan and have added a bunch of tests, error messages, and a little functionality. I will have a new patch posted in a day or two. Cheers! Brock > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590981#comment-13590981 ] Carl Steinbach commented on HIVE-2655: -- @Brock: Can you open a new phabricator review request for your updated version of the patch? Thanks. > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590986#comment-13590986 ] Brock Noland commented on HIVE-2655: [~cwsteinbach] I did here https://reviews.facebook.net/D8673 and setup as a weblink not sure why it's not updating the JIRA automatically. > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601243#comment-13601243 ] Brock Noland commented on HIVE-2655: Ping :) > Ability to define functions in HQL > -- > > Key: HIVE-2655 > URL: https://issues.apache.org/jira/browse/HIVE-2655 > Project: Hive > Issue Type: New Feature > Components: SQL >Reporter: Jonathan Perlow >Assignee: Brock Noland > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.3.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2655.D915.4.patch, HIVE-2655-9.patch > > > Ability to create functions in HQL as a substitute for creating them in Java. > Jonathan Chang requested I create this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
