[PATCH 30730] mod_actions and Server-Status (Patch review request).

[Basant Kukreja]

Hi,
   I am Basant and I work for Sun Microsystems Inc. in web tier group.

I have submitted the patch for 30730.
Bug Id : 30730 http://issues.apache.org/bugzilla/show_bug.cgi?id=30730
Summary : mod_actions and Server-Status 
Patch uri : http://issues.apache.org/bugzilla/attachment.cgi?id=19706

I would like to make a humble review request for the patch.

Thanks and Regards,
Basant.

reference out of date?

[Sam Carleton]

Many moons ago, around 2001 I believe, I purchased the book "Writing
Apache Modules with Perl and C" by Lincoln Stein and Doug MacEachern.
I have not dug it up yet, but I am guessing that it was written for
Apache 1.x.  For my needs, handling basic requests, will it be out of
date?

Sam

Re: mod_ftp, status and progress?

[Guenter Knauf]

Hi,
>> also want to ask if it is ok when I add NetWare makefiles?

> Be our guest :)  Keep it mind it's ment to be built against installed
> httpd, or built in tree (within modules/ftp/) as desired.

sorry, but for now only inside tree; 
anyway all NetWare compile is sort of cross-compile, and way more complex than 
anything other I came over. No paths are really fix, nor does our installed 
Apache ship with the headers / libs by default; and the NetWare build system 
isnt really prepared for such. Although we can create an 'Apache SDK' this 
lacks currently of the needed files which all makefiles include, and so a 
makefile which works with that looks completely different. I will though look 
if I can fix that over the time with the SDK, and then update the makefiles.

Guenter.

Re: mod_ftp, status and progress?

[William A. Rowe, Jr.]

Guenter Knauf wrote:
> Hi,
> is it possible that with your last commit changes you forgot to update 
> mod_ftp.h too?

Feh - yup.  My bad - thanks!

> also want to ask if it is ok when I add NetWare makefiles?

Be our guest :)  Keep it mind it's ment to be built against installed
httpd, or built in tree (within modules/ftp/) as desired.

Re: mod_ftp, status and progress?

[Guenter Knauf]

Hi,
is it possible that with your last commit changes you forgot to update 
mod_ftp.h too?

I tried to compile for NetWare, and needed this in order to get it compiled:

--- mod_ftp.h.orig  Tue Mar 27 13:27:22 2007
+++ mod_ftp.h   Tue Mar 27 13:49:04 2007
@@ -250,6 +250,8 @@
 const char *readme;
 const char *path;
 int readme_isfile;
+apr_fileperms_t fileperms;
+apr_fileperms_t dirperms;
 };
 
 /* 

also want to ask if it is ok when I add NetWare makefiles?

Guenter.