Re: Ignite Extensions tests

[Petr Ivanov]

I've updated Extensions template to use only Linux agents.

Will wait for ticket in master, thanks!



> On 10 Feb 2021, at 01:05, Mikhail Petrov  wrote:
> 
> Hi, Petr.
> 
> It seems that the problem is in an outdated version of the maven surefire 
> plugin that is used in ignite-extensions.
> 
> I created the corresponding ticket [1].
> 
> I also faced that current ignite-extensions build is broken on windows agents 
> - [2]. It fails with the following error:
> 
> /[22:47:43]'#!' is not recognized as an internal or external command,
> [22:47:43]operable program or batch file.
> [22:47:43]Environment variable -o nounset; set -o errexit; set -o pipefail; 
> set -o errtrace; set -o functrace not defined
> [22:47:43]Environment variable -x not defined
> [22:47:43]'rm' is not recognized as an internal or external command,
> [22:47:43]operable program or batch file.
> [22:47:43]The syntax of the command is incorrect.
> [22:47:43]'cp' is not recognized as an internal or external command,
> [22:47:43]operable program or batch file.
> [22:47:43]Process exited with code 1/
> 
> 
> Could you check it, please?
> 
> 
> [1] - https://issues.apache.org/jira/browse/IGNITE-14150
> 
> [2] - 
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteExtensions_Tests_Flink&branch_IgniteExtensions_Tests=%3Cdefault%3E&tab=buildTypeStatusDiv
> 
> On 09.02.2021 13:36, Petr Ivanov wrote:
>> Hi, Nikolay.
>> 
>> 
>> I've created a set of tests for extensions, and part of them are failing 
>> with:
>> 
>> JUnit4Provider.invoke:159->executeTestSet:238->executeWithRerun:273->execute:365
>>  » NoSuchMethod
>> java.lang.NoSuchMethodError: 
>> org.apache.maven.surefire.report.SimpleReportEntry.withException(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/maven/surefire/report/StackTraceWriter;)Lorg/apache/maven/surefire/report/SimpleReportEntry;
>> at 
>> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>> at 
>> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>> at 
>> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>> at 
>> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>> 
>> 
>> Could you check [1] please?
>> 
>> 
>> [1] 
>> https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/5864907?buildTab=dependencies&mode=list
>> 

[MTCGA]: new failures in builds [5864246] needs to be handled

[dpavlov . tasks]

Hi Igniters,

 I've detected some new issue on TeamCity to be handled. You are more than 
welcomed to help.

 If your changes can lead to this failure(s): We're grateful that you were a 
volunteer to make the contribution to this project, but things change and you 
may no longer be able to finalize your contribution.
 Could you respond to this email and indicate if you wish to continue and fix 
test failures or step down and some committer may revert you commit. 

 *New test failure in master 
GridCacheContinuousQueryMultiNodesFilteringTest.testWithNodeFilter 
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-3060366423503188690&branch=%3Cdefault%3E&tab=testDetails
 Changes may lead to failure were done by 
 - pavel tupitsyn  
https://ci.ignite.apache.org/viewModification.html?modId=916449

 - Here's a reminder of what contributors were agreed to do 
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute 
 - Should you have any questions please contact dev@ignite.apache.org 

Best Regards,
Apache Ignite TeamCity Bot 
https://github.com/apache/ignite-teamcity-bot
Notification generated at 01:29:48 10-02-2021 

Re: Ignite Extensions tests

[Mikhail Petrov]

Hi, Petr.

It seems that the problem is in an outdated version of the maven 
surefire plugin that is used in ignite-extensions.


I created the corresponding ticket [1].

I also faced that current ignite-extensions build is broken on windows 
agents - [2]. It fails with the following error:


/[22:47:43]'#!' is not recognized as an internal or external command,
[22:47:43]operable program or batch file.
[22:47:43]Environment variable -o nounset; set -o errexit; set -o 
pipefail; set -o errtrace; set -o functrace not defined

[22:47:43]Environment variable -x not defined
[22:47:43]'rm' is not recognized as an internal or external command,
[22:47:43]operable program or batch file.
[22:47:43]The syntax of the command is incorrect.
[22:47:43]'cp' is not recognized as an internal or external command,
[22:47:43]operable program or batch file.
[22:47:43]Process exited with code 1/


Could you check it, please?


[1] - https://issues.apache.org/jira/browse/IGNITE-14150

[2] - 
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteExtensions_Tests_Flink&branch_IgniteExtensions_Tests=%3Cdefault%3E&tab=buildTypeStatusDiv


On 09.02.2021 13:36, Petr Ivanov wrote:

Hi, Nikolay.


I've created a set of tests for extensions, and part of them are failing with:

JUnit4Provider.invoke:159->executeTestSet:238->executeWithRerun:273->execute:365
 » NoSuchMethod
java.lang.NoSuchMethodError: 
org.apache.maven.surefire.report.SimpleReportEntry.withException(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/maven/surefire/report/StackTraceWriter;)Lorg/apache/maven/surefire/report/SimpleReportEntry;
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)


Could you check [1] please?


[1] 
https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/5864907?buildTab=dependencies&mode=list

[jira] [Created] (IGNITE-14151) Set up commit status publisher on TC

[Valentin Kulichenko (Jira)]

Valentin Kulichenko created IGNITE-14151:


 Summary: Set up commit status publisher on TC
 Key: IGNITE-14151
 URL: https://issues.apache.org/jira/browse/IGNITE-14151
 Project: Ignite
  Issue Type: Task
Reporter: Valentin Kulichenko
Assignee: Peter Ivanov


'Run All' build should publish the status to the appropriate PR on GitHub. We 
will then update the process to allow merges only with successful builds.

See here: https://www.jetbrains.com/help/teamcity/commit-status-publisher.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (IGNITE-14150) Update version of surefire plugin in ignite-extensions

[Mikhail Petrov (Jira)]

Mikhail Petrov created IGNITE-14150:
---

 Summary: Update version of surefire plugin in ignite-extensions
 Key: IGNITE-14150
 URL: https://issues.apache.org/jira/browse/IGNITE-14150
 Project: Ignite
  Issue Type: Bug
Reporter: Mikhail Petrov
Assignee: Mikhail Petrov


It's needed to update version of surefire plugin in ignite-extensions to 
3.0.0-M4. 

Mismatch of surefire plugin version between ignite-tools and ignite-extensions 
causes the following error during tests execution:
{code:java}
java.lang.NoSuchMethodError: 
org.apache.maven.surefire.report.SimpleReportEntry.withException(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/maven/surefire/report/StackTraceWriter;)Lorg/apache/maven/surefire/report/SimpleReportEntry;
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (IGNITE-14149) Implement the raft facade

[Alexey Scherbakov (Jira)]

Alexey Scherbakov created IGNITE-14149:
--

 Summary: Implement the raft facade
 Key: IGNITE-14149
 URL: https://issues.apache.org/jira/browse/IGNITE-14149
 Project: Ignite
  Issue Type: Task
Reporter: Alexey Scherbakov
Assignee: Alexey Scherbakov


We need the raft facade API.

It should include:
 # Raft group management: add/remove peers, learners, etc.
 # Submitting a task to a raft group leader.
 # State machine abstraction.
 # Linearizable reading from the raft group.

The goal is to make it compatible with different raft implementations until the 
choice is finalized.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [DISCUSS] Missed (non-suited) tests

[Ilya Kasnacheev]

Hello again!

Of course it's 20 minutes, not 20 seconds.

Regards,
-- 
Ilya Kasnacheev


вт, 9 февр. 2021 г. в 16:45, Ilya Kasnacheev :

> Hello!
>
> Java part kicks in if the target not found in pom.xml. Ideally we should
> skip this build if target check-test-suites is not in pom.xml
>
> I have changed its timeout to 20 second which should terminate its
> progression on older builds. Maybe that would be sufficient for now.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вт, 9 февр. 2021 г. в 14:09, Petr Ivanov :
>
>> As much as I understood — we execute internal class as plugin, where all
>> the magic is done.
>> Seems pretty solid in Maven part. Java part, unfortunately, cannot check.
>>
>>
>>
>> Regards,
>> *Petr Ivanov*
>> Head of IT
>> IT & Development Solutions |
>> *GRIDGAIN SYSTEMS*+7 (911) 945-00-59
>>
>> On 9 Feb 2021, at 12:32, Ilya Kasnacheev 
>> wrote:
>>
>> Hello Peter,
>>
>> Thanks for chiming in. The code is under
>> https://github.com/apache/ignite/pull/8367
>>
>> Regards,
>> --
>> Ilya Kasnacheev
>>
>>
>> вт, 9 февр. 2021 г. в 12:20, Petr Ivanov :
>>
>>> Hi, Ilya.
>>>
>>>
>>> I've added Inspections to Run All.
>>> Checkstyle is currently integrated to Build and can be deleted.
>>>
>>>
>>> Where can I find the code for check-test-suites profile?
>>>
>>>
>>> Regards,
>>> *Petr Ivanov*
>>> Head of IT
>>> IT & Development Solutions |
>>> *GRIDGAIN SYSTEMS*+7 (911) 945-00-59
>>>
>>> On 9 Feb 2021, at 12:16, Ilya Kasnacheev 
>>> wrote:
>>>
>>> Hello!
>>>
>>> I have found one issue where it would cause tests to be run if the
>>> change is not present in the target branch.
>>>
>>> This includes e.g. 2.10 nightlies.
>>>
>>> What can we do to avoid that? Is specifying -DskipTests sufficient? Any
>>> chance that it will break the missed tests check?
>>>
>>> Regards,
>>> --
>>> Ilya Kasnacheev
>>>
>>>
>>> пн, 8 февр. 2021 г. в 14:13, Ilya Kasnacheev >> >:
>>>
 Hello!

 I have created a TC suite:

 https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_MissingTests?mode=builds

 + Peter Ivanov

 Can you please check if everything is alright?

 BTW, it seems that Inspections [Core] is only in Run All Basic (but not
 in Run All), and Check Code Style is not triggered by either one. Is it
 correct?

 Regards,
 --
 Ilya Kasnacheev


 пн, 8 февр. 2021 г. в 10:22, Max Timonin :

> Hi!
>
> Yes, now it's a part of the Travis check, and there is already a first
> successful build [1]. But I think it's also required to run the check
> on TC
> too, along with jobs for checking licenses, code style, and core
> inspections.
>
>
> [1] https://travis-ci.com/github/apache/ignite/builds/216363067
>
> On Fri, Feb 5, 2021 at 7:13 PM Ilya Kasnacheev <
> ilya.kasnach...@gmail.com>
> wrote:
>
> > Hello!
> >
> > I have merged it to master!
> >
> > I wonder what happens next. It will run as a part of travis check?
> Do we
> > also need to add it as a TC suite?
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > ср, 3 февр. 2021 г. в 18:50, Ilya Kasnacheev <
> ilya.kasnach...@gmail.com>:
> >
> > > Hello!
> > >
> > > Code mostly looks good, I have added a minor request. I will check
> how it
> > > works and then we may commit.
> > >
> > > + zaleslaw@gmail.com
> > >
> > > Can you please check whether the new ML suites make sense?
> > > math/distances/DistancesTestSuite.java
> > > naivebayes/NaiveBayesTestSuite.java
> > >
> > > Would we need to add them to some TC runs?
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пн, 25 янв. 2021 г. в 22:07, Max Timonin  >:
> > >
> > >> Hi, Ilya!
> > >>
> > >> I made a fix to the check. Now it aggregates info about tests and
> suites
> > >> from all modules and then validates it. Could you please review
> the PR
> > >> [1]?
> > >>
> > >> I tried to move some tests between modules, but unfortunately it
> still
> > >> looks like spaghetti. So I reverted all changes to testsuites
> (new and
> > >> splitted suites) and reworked the check.
> > >>
> > >> [1] https://github.com/apache/ignite/pull/8367
> > >>
> > >> On Mon, Dec 28, 2020 at 2:03 PM Ilya Kasnacheev <
> > >> ilya.kasnach...@gmail.com>
> > >> wrote:
> > >>
> > >> > Hello!
> > >> >
> > >> > You could try to move these tests as .java files between
> modules in a
> > >> > separate commit. I think I could review it.
> > >> >
> > >> > Regards,
> > >> > --
> > >> > Ilya Kasnacheev
> > >> >
> > >> >
> > >> > пт, 25 дек. 2020 г. в 17:19, Max Timonin <
> timonin.ma...@gmail.com>:
> > >> >
> > >> > > Hi!
> > >> > >
> > >> > > Ilya thanks for the reply! I agree that it's a va

Re: [DISCUSS] Missed (non-suited) tests

[Ilya Kasnacheev]

Hello!

Java part kicks in if the target not found in pom.xml. Ideally we should
skip this build if target check-test-suites is not in pom.xml

I have changed its timeout to 20 second which should terminate its
progression on older builds. Maybe that would be sufficient for now.

Regards,
-- 
Ilya Kasnacheev


вт, 9 февр. 2021 г. в 14:09, Petr Ivanov :

> As much as I understood — we execute internal class as plugin, where all
> the magic is done.
> Seems pretty solid in Maven part. Java part, unfortunately, cannot check.
>
>
>
> Regards,
> *Petr Ivanov*
> Head of IT
> IT & Development Solutions |
> *GRIDGAIN SYSTEMS*+7 (911) 945-00-59
>
> On 9 Feb 2021, at 12:32, Ilya Kasnacheev 
> wrote:
>
> Hello Peter,
>
> Thanks for chiming in. The code is under
> https://github.com/apache/ignite/pull/8367
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вт, 9 февр. 2021 г. в 12:20, Petr Ivanov :
>
>> Hi, Ilya.
>>
>>
>> I've added Inspections to Run All.
>> Checkstyle is currently integrated to Build and can be deleted.
>>
>>
>> Where can I find the code for check-test-suites profile?
>>
>>
>> Regards,
>> *Petr Ivanov*
>> Head of IT
>> IT & Development Solutions |
>> *GRIDGAIN SYSTEMS*+7 (911) 945-00-59
>>
>> On 9 Feb 2021, at 12:16, Ilya Kasnacheev 
>> wrote:
>>
>> Hello!
>>
>> I have found one issue where it would cause tests to be run if the change
>> is not present in the target branch.
>>
>> This includes e.g. 2.10 nightlies.
>>
>> What can we do to avoid that? Is specifying -DskipTests sufficient? Any
>> chance that it will break the missed tests check?
>>
>> Regards,
>> --
>> Ilya Kasnacheev
>>
>>
>> пн, 8 февр. 2021 г. в 14:13, Ilya Kasnacheev :
>>
>>> Hello!
>>>
>>> I have created a TC suite:
>>>
>>> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_MissingTests?mode=builds
>>>
>>> + Peter Ivanov
>>>
>>> Can you please check if everything is alright?
>>>
>>> BTW, it seems that Inspections [Core] is only in Run All Basic (but not
>>> in Run All), and Check Code Style is not triggered by either one. Is it
>>> correct?
>>>
>>> Regards,
>>> --
>>> Ilya Kasnacheev
>>>
>>>
>>> пн, 8 февр. 2021 г. в 10:22, Max Timonin :
>>>
 Hi!

 Yes, now it's a part of the Travis check, and there is already a first
 successful build [1]. But I think it's also required to run the check
 on TC
 too, along with jobs for checking licenses, code style, and core
 inspections.


 [1] https://travis-ci.com/github/apache/ignite/builds/216363067

 On Fri, Feb 5, 2021 at 7:13 PM Ilya Kasnacheev <
 ilya.kasnach...@gmail.com>
 wrote:

 > Hello!
 >
 > I have merged it to master!
 >
 > I wonder what happens next. It will run as a part of travis check? Do
 we
 > also need to add it as a TC suite?
 >
 > Regards,
 > --
 > Ilya Kasnacheev
 >
 >
 > ср, 3 февр. 2021 г. в 18:50, Ilya Kasnacheev <
 ilya.kasnach...@gmail.com>:
 >
 > > Hello!
 > >
 > > Code mostly looks good, I have added a minor request. I will check
 how it
 > > works and then we may commit.
 > >
 > > + zaleslaw@gmail.com
 > >
 > > Can you please check whether the new ML suites make sense?
 > > math/distances/DistancesTestSuite.java
 > > naivebayes/NaiveBayesTestSuite.java
 > >
 > > Would we need to add them to some TC runs?
 > >
 > > Regards,
 > > --
 > > Ilya Kasnacheev
 > >
 > >
 > > пн, 25 янв. 2021 г. в 22:07, Max Timonin :
 > >
 > >> Hi, Ilya!
 > >>
 > >> I made a fix to the check. Now it aggregates info about tests and
 suites
 > >> from all modules and then validates it. Could you please review
 the PR
 > >> [1]?
 > >>
 > >> I tried to move some tests between modules, but unfortunately it
 still
 > >> looks like spaghetti. So I reverted all changes to testsuites (new
 and
 > >> splitted suites) and reworked the check.
 > >>
 > >> [1] https://github.com/apache/ignite/pull/8367
 > >>
 > >> On Mon, Dec 28, 2020 at 2:03 PM Ilya Kasnacheev <
 > >> ilya.kasnach...@gmail.com>
 > >> wrote:
 > >>
 > >> > Hello!
 > >> >
 > >> > You could try to move these tests as .java files between modules
 in a
 > >> > separate commit. I think I could review it.
 > >> >
 > >> > Regards,
 > >> > --
 > >> > Ilya Kasnacheev
 > >> >
 > >> >
 > >> > пт, 25 дек. 2020 г. в 17:19, Max Timonin <
 timonin.ma...@gmail.com>:
 > >> >
 > >> > > Hi!
 > >> > >
 > >> > > Ilya thanks for the reply! I agree that it's a valid case when
 a
 > test
 > >> is
 > >> > > part of multiple suites in different modules. But it is
 definitely a
 > >> bug
 > >> > > that the test is written in a module where it can't be run at
 all
 > and
 > >> > aimed
 > >> > > to run within different modules (core tests in core that
 requi

[jira] [Created] (IGNITE-14148) SQL. Calcite: Failed to map fragment to location. Replicated query parts are not co-located on all nodes (state=50000,code=1)

[Fedor Malchikov (Jira)]

Fedor Malchikov  created IGNITE-14148:
-

 Summary: SQL. Calcite:  Failed to map fragment to location. 
Replicated query parts are not co-located on all nodes (state=5,code=1)
 Key: IGNITE-14148
 URL: https://issues.apache.org/jira/browse/IGNITE-14148
 Project: Ignite
  Issue Type: Bug
Reporter: Fedor Malchikov 
 Attachments: caches.xml, data-reg.xml, 
dml_merge_with_memory..calcite.sql.log, ignite.1.node1.1.log, server.xml

Problem reproduced only for tables with "TEMPLATE=repl-atomic-full_sync" or 
"TEMPLATE=repl-tx-full_sync".

STR:

{code:SQL}
CREATE TABLE t7 ( id INT NOT NULL, bool_col BOOLEAN, tinyint_col TINYINT, 
smallint_col SMALLINT, int_col INT, bigint_col BIGINT, varchar_col VARCHAR, 
char_col CHAR, float_col FLOAT, double_col DOUBLE, time_col TIME, PRIMARY KEY 
(id)
) WITH "TEMPLATE=repl-tx-full_sync";
INSERT INTO t7 
(id,bool_col,tinyint_col,smallint_col,int_col,bigint_col,varchar_col,char_col,float_col,double_col,time_col)
 VALUES 
(8,TRUE,0,0,0,0,'string_8','string_8',0,8,'05:46:48'),(9,FALSE,-1,-1,-1,-1,'string_9','string_9',-1.1,9,'05:46:49'),(10,TRUE,1,1,1,1,'string_10','string_10',1.1,10,'05:46:50'),(-11,FALSE,-128,-32768,-2147483648,-9223372036854775808,'string_11','string_11',-11,11,'05:46:51'),(12,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL),(13,FALSE,-127,-32767,-2147483647,-9223372036854775807,'string_13','string_13',13,13,'05:46:53'),(14,TRUE,126,32766,2147483646,9223372036854775806,'string_14','string_14',14,14,'05:46:54'),(15,FALSE,15,15,15,15,'string_15','string_15',15,15,'05:46:55'),(-16,TRUE,-16,-16,-16,-16,'string_16','string_16',-16,16,'05:46:56'),(17,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);
SELECT * FROM t7 WHERE id=7 OR id=10001 ORDER BY id;
{code}

Errors:

{code:java}
Error: 
org.apache.ignite.internal.processors.query.calcite.metadata.ColocationMappingException:
 Failed to map fragment to location. Replicated query parts are not co-located 
on all nodes (state=5,code=1)
java.sql.SQLException: 
org.apache.ignite.internal.processors.query.calcite.metadata.ColocationMappingException:
 Failed to map fragment to location. Replicated query parts are not co-located 
on all nodes
at 
org.apache.ignite.internal.jdbc.thin.JdbcThinConnection.sendRequest(JdbcThinConnection.java:1009)
at 
org.apache.ignite.internal.jdbc.thin.JdbcThinStatement.execute0(JdbcThinStatement.java:234)
at 
org.apache.ignite.internal.jdbc.thin.JdbcThinStatement.execute(JdbcThinStatement.java:560)
at sqlline.Commands.execute(Commands.java:823)
at sqlline.Commands.sql(Commands.java:733)
at sqlline.SqlLine.dispatch(SqlLine.java:795)
at sqlline.SqlLine.runCommands(SqlLine.java:1706)
at sqlline.Commands.run(Commands.java:1317)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
sqlline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:38)
at sqlline.SqlLine.dispatch(SqlLine.java:791)
at sqlline.SqlLine.initArgs(SqlLine.java:595)
at sqlline.SqlLine.begin(SqlLine.java:643)
at sqlline.SqlLine.start(SqlLine.java:373)
at sqlline.SqlLine.main(SqlLine.java:265)
{code}

Ignite log:

{code:java}
[16:05:13,485][SEVERE][client-connector-#62][ClientListenerNioListener] Failed 
to process client request [req=JdbcQueryExecuteRequest [schemaName=PUBLIC, 
pageSize=1024, maxRows=0, sqlQry=SELECT * FROM t6 WHERE id=6 OR id=10001, 
args=Object[] [], stmtType=ANY_STATEMENT_TYPE, autoCommit=true, 
partResReq=false, explicitTimeout=false, super=JdbcRequest [type=2, reqId=58]]]
java.lang.AssertionError: 
org.apache.ignite.internal.processors.query.calcite.metadata.ColocationMappingException:
 Failed to map fragment to location. Replicated query parts are not co-located 
on all nodes
at 
org.apache.ignite.internal.processors.query.calcite.metadata.FragmentMapping.create(FragmentMapping.java:82)
at 
org.apache.ignite.internal.processors.query.calcite.metadata.IgniteMdFragmentMapping.fragmentMapping(IgniteMdFragmentMapping.java:196)
at 
GeneratedMetadataHandler_FragmentMappingMetadata.fragmentMapping_$(Unknown 
Source)
at 
GeneratedMetadataHandler_FragmentMappingMetadata.fragmentMapping(Unknown Source)
at 
org.apache.ignite.internal.processors.query.calcite.metadata.RelMetadataQueryEx.fragmentMapping(RelMetadataQueryEx.java:97)
at 
org.apache.ignite.internal.processors.query.calcite.metadata.IgniteMdFragmentMapping._fragmentMapping(IgniteMdFragmentMapping.java:216)
at 
org.apache.ignite.internal.processors.query.calcite.prepare.Fragment.mapping(Fr

[jira] [Created] (IGNITE-14147) Long execution of index validation in the presence of all modules in classpath on ducktape tests

[Sergei Ryzhov (Jira)]

Sergei Ryzhov created IGNITE-14147:
--

 Summary: Long execution of index validation in the presence of all 
modules in classpath on ducktape tests
 Key: IGNITE-14147
 URL: https://issues.apache.org/jira/browse/IGNITE-14147
 Project: Ignite
  Issue Type: Task
Reporter: Sergei Ryzhov


Long execution of index validation in the presence of all modules in classpath 
on ducktape tests.
reproducer:
run snapshot_test.py on dev version without EXCLUDE_MODULES
https://github.com/apache/ignite/pull/8575/files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [DISCUSS] Missed (non-suited) tests

[Petr Ivanov]

As much as I understood — we execute internal class as plugin, where all the 
magic is done.
Seems pretty solid in Maven part. Java part, unfortunately, cannot check.



Regards,
Petr Ivanov
Head of IT
IT & Development Solutions | GRIDGAIN SYSTEMS
+7 (911) 945-00-59

> On 9 Feb 2021, at 12:32, Ilya Kasnacheev  wrote:
> 
> Hello Peter,
> 
> Thanks for chiming in. The code is under 
> https://github.com/apache/ignite/pull/8367 
> 
> 
> Regards,
> -- 
> Ilya Kasnacheev
> 
> 
> вт, 9 февр. 2021 г. в 12:20, Petr Ivanov  >:
> Hi, Ilya.
> 
> 
> I've added Inspections to Run All.
> Checkstyle is currently integrated to Build and can be deleted.
> 
> 
> Where can I find the code for check-test-suites profile?
> 
> 
> Regards,
> Petr Ivanov
> Head of IT
> IT & Development Solutions | GRIDGAIN SYSTEMS
> +7 (911) 945-00-59
> 
>> On 9 Feb 2021, at 12:16, Ilya Kasnacheev > > wrote:
>> 
>> Hello!
>> 
>> I have found one issue where it would cause tests to be run if the change is 
>> not present in the target branch.
>> 
>> This includes e.g. 2.10 nightlies.
>> 
>> What can we do to avoid that? Is specifying -DskipTests sufficient? Any 
>> chance that it will break the missed tests check?
>> 
>> Regards,
>> -- 
>> Ilya Kasnacheev
>> 
>> 
>> пн, 8 февр. 2021 г. в 14:13, Ilya Kasnacheev > >:
>> Hello!
>> 
>> I have created a TC suite:
>> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_MissingTests?mode=builds
>>  
>> 
>> 
>> + Peter Ivanov
>> 
>> Can you please check if everything is alright?
>> 
>> BTW, it seems that Inspections [Core] is only in Run All Basic (but not in 
>> Run All), and Check Code Style is not triggered by either one. Is it correct?
>> 
>> Regards,
>> -- 
>> Ilya Kasnacheev
>> 
>> 
>> пн, 8 февр. 2021 г. в 10:22, Max Timonin > >:
>> Hi!
>> 
>> Yes, now it's a part of the Travis check, and there is already a first
>> successful build [1]. But I think it's also required to run the check on TC
>> too, along with jobs for checking licenses, code style, and core
>> inspections.
>> 
>> 
>> [1] https://travis-ci.com/github/apache/ignite/builds/216363067 
>> 
>> 
>> On Fri, Feb 5, 2021 at 7:13 PM Ilya Kasnacheev > >
>> wrote:
>> 
>> > Hello!
>> >
>> > I have merged it to master!
>> >
>> > I wonder what happens next. It will run as a part of travis check? Do we
>> > also need to add it as a TC suite?
>> >
>> > Regards,
>> > --
>> > Ilya Kasnacheev
>> >
>> >
>> > ср, 3 февр. 2021 г. в 18:50, Ilya Kasnacheev > > >:
>> >
>> > > Hello!
>> > >
>> > > Code mostly looks good, I have added a minor request. I will check how it
>> > > works and then we may commit.
>> > >
>> > > + zaleslaw@gmail.com 
>> > >
>> > > Can you please check whether the new ML suites make sense?
>> > > math/distances/DistancesTestSuite.java
>> > > naivebayes/NaiveBayesTestSuite.java
>> > >
>> > > Would we need to add them to some TC runs?
>> > >
>> > > Regards,
>> > > --
>> > > Ilya Kasnacheev
>> > >
>> > >
>> > > пн, 25 янв. 2021 г. в 22:07, Max Timonin > > > >:
>> > >
>> > >> Hi, Ilya!
>> > >>
>> > >> I made a fix to the check. Now it aggregates info about tests and suites
>> > >> from all modules and then validates it. Could you please review the PR
>> > >> [1]?
>> > >>
>> > >> I tried to move some tests between modules, but unfortunately it still
>> > >> looks like spaghetti. So I reverted all changes to testsuites (new and
>> > >> splitted suites) and reworked the check.
>> > >>
>> > >> [1] https://github.com/apache/ignite/pull/8367 
>> > >> 
>> > >>
>> > >> On Mon, Dec 28, 2020 at 2:03 PM Ilya Kasnacheev <
>> > >> ilya.kasnach...@gmail.com >
>> > >> wrote:
>> > >>
>> > >> > Hello!
>> > >> >
>> > >> > You could try to move these tests as .java files between modules in a
>> > >> > separate commit. I think I could review it.
>> > >> >
>> > >> > Regards,
>> > >> > --
>> > >> > Ilya Kasnacheev
>> > >> >
>> > >> >
>> > >> > пт, 25 дек. 2020 г. в 17:19, Max Timonin > > >> > >:
>> > >> >
>> > >> > > Hi!
>> > >> > >
>> > >> > > Ilya thanks for the reply! I agree that it's a valid case when a
>> > test
>> > >> is
>> > >> > > part of multiple suites in different modules. But it is definitely a
>> > >> bug
>> > >> > > that the test is written in a module where it can't be run at all
>> > and
>> > >> > aimed
>> > >> > > to run within different modules (core tests in core that require
>> > h2).
>> > >> I
>> > >> > > propose to fix this issue.
>> > >> > >
>> > >> > > I'm goin

Re: [DISCUSS] Missed (non-suited) tests

[Petr Ivanov]

Hi, Ilya.


I've added Inspections to Run All.
Checkstyle is currently integrated to Build and can be deleted.


Where can I find the code for check-test-suites profile?


Regards,
Petr Ivanov
Head of IT
IT & Development Solutions | GRIDGAIN SYSTEMS
+7 (911) 945-00-59

> On 9 Feb 2021, at 12:16, Ilya Kasnacheev  wrote:
> 
> Hello!
> 
> I have found one issue where it would cause tests to be run if the change is 
> not present in the target branch.
> 
> This includes e.g. 2.10 nightlies.
> 
> What can we do to avoid that? Is specifying -DskipTests sufficient? Any 
> chance that it will break the missed tests check?
> 
> Regards,
> -- 
> Ilya Kasnacheev
> 
> 
> пн, 8 февр. 2021 г. в 14:13, Ilya Kasnacheev  >:
> Hello!
> 
> I have created a TC suite:
> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_MissingTests?mode=builds
>  
> 
> 
> + Peter Ivanov
> 
> Can you please check if everything is alright?
> 
> BTW, it seems that Inspections [Core] is only in Run All Basic (but not in 
> Run All), and Check Code Style is not triggered by either one. Is it correct?
> 
> Regards,
> -- 
> Ilya Kasnacheev
> 
> 
> пн, 8 февр. 2021 г. в 10:22, Max Timonin  >:
> Hi!
> 
> Yes, now it's a part of the Travis check, and there is already a first
> successful build [1]. But I think it's also required to run the check on TC
> too, along with jobs for checking licenses, code style, and core
> inspections.
> 
> 
> [1] https://travis-ci.com/github/apache/ignite/builds/216363067 
> 
> 
> On Fri, Feb 5, 2021 at 7:13 PM Ilya Kasnacheev  >
> wrote:
> 
> > Hello!
> >
> > I have merged it to master!
> >
> > I wonder what happens next. It will run as a part of travis check? Do we
> > also need to add it as a TC suite?
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > ср, 3 февр. 2021 г. в 18:50, Ilya Kasnacheev  > >:
> >
> > > Hello!
> > >
> > > Code mostly looks good, I have added a minor request. I will check how it
> > > works and then we may commit.
> > >
> > > + zaleslaw@gmail.com 
> > >
> > > Can you please check whether the new ML suites make sense?
> > > math/distances/DistancesTestSuite.java
> > > naivebayes/NaiveBayesTestSuite.java
> > >
> > > Would we need to add them to some TC runs?
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пн, 25 янв. 2021 г. в 22:07, Max Timonin  > > >:
> > >
> > >> Hi, Ilya!
> > >>
> > >> I made a fix to the check. Now it aggregates info about tests and suites
> > >> from all modules and then validates it. Could you please review the PR
> > >> [1]?
> > >>
> > >> I tried to move some tests between modules, but unfortunately it still
> > >> looks like spaghetti. So I reverted all changes to testsuites (new and
> > >> splitted suites) and reworked the check.
> > >>
> > >> [1] https://github.com/apache/ignite/pull/8367 
> > >> 
> > >>
> > >> On Mon, Dec 28, 2020 at 2:03 PM Ilya Kasnacheev <
> > >> ilya.kasnach...@gmail.com >
> > >> wrote:
> > >>
> > >> > Hello!
> > >> >
> > >> > You could try to move these tests as .java files between modules in a
> > >> > separate commit. I think I could review it.
> > >> >
> > >> > Regards,
> > >> > --
> > >> > Ilya Kasnacheev
> > >> >
> > >> >
> > >> > пт, 25 дек. 2020 г. в 17:19, Max Timonin  > >> > >:
> > >> >
> > >> > > Hi!
> > >> > >
> > >> > > Ilya thanks for the reply! I agree that it's a valid case when a
> > test
> > >> is
> > >> > > part of multiple suites in different modules. But it is definitely a
> > >> bug
> > >> > > that the test is written in a module where it can't be run at all
> > and
> > >> > aimed
> > >> > > to run within different modules (core tests in core that require
> > h2).
> > >> I
> > >> > > propose to fix this issue.
> > >> > >
> > >> > > I'm going to check all such tests and move them to the right module.
> > >> As I
> > >> > > can see there are about 100 such test classes, but I hope that most
> > of
> > >> > them
> > >> > > follow only a few patterns.
> > >> > >
> > >> > > On Fri, Dec 25, 2020 at 2:58 PM Ivan Daschinsky <
> > ivanda...@gmail.com >
> > >> > > wrote:
> > >> > >
> > >> > > > Hi!
> > >> > > > >> I'm not sure that we should assume every test is only run from
> > >> one
> > >> > > test
> > >> > > > suite. One test may be run from different test suites located in
> > >> > > different
> > >> > > > modules.
> > >> > > > Agree. For example, if we introduce this limitation, zk suites
> > will
> > >> be
> > >> > > > broken.
> > >> > > >
> > >> > > >
> > >> > > > пт, 25 дек. 2020 г. в 14:48, Ilya Kas

[jira] [Created] (IGNITE-14146) Migrate Spring Cache integration to igntie-extensions

[Mikhail Petrov (Jira)]

Mikhail Petrov created IGNITE-14146:
---

 Summary: Migrate Spring Cache integration to igntie-extensions
 Key: IGNITE-14146
 URL: https://issues.apache.org/jira/browse/IGNITE-14146
 Project: Ignite
  Issue Type: Improvement
Reporter: Mikhail Petrov
Assignee: Mikhail Petrov


It's needed to migrate Spring Cache integration to ignite-extensions repository.
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (IGNITE-14145) ConfigurationUtil should be moved to internal package, visitor should be refactored.

[Ivan Bessonov (Jira)]

Ivan Bessonov created IGNITE-14145:
--

 Summary: ConfigurationUtil should be moved to internal package, 
visitor should be refactored.
 Key: IGNITE-14145
 URL: https://issues.apache.org/jira/browse/IGNITE-14145
 Project: Ignite
  Issue Type: Sub-task
Reporter: Ivan Bessonov
Assignee: Ivan Bessonov


See a comment in IGNITE-14121. Also we should add return values to 
configuration visitor and split Config(root=true) from Config(root=false) for 
simplicity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Ignite Extensions tests

[Petr Ivanov]

Hi, Nikolay.


I've created a set of tests for extensions, and part of them are failing with:

JUnit4Provider.invoke:159->executeTestSet:238->executeWithRerun:273->execute:365
 » NoSuchMethod
java.lang.NoSuchMethodError: 
org.apache.maven.surefire.report.SimpleReportEntry.withException(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/maven/surefire/report/StackTraceWriter;)Lorg/apache/maven/surefire/report/SimpleReportEntry;
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)


Could you check [1] please?


[1] 
https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/5864907?buildTab=dependencies&mode=list

Re: [DISCUSS] Missed (non-suited) tests

[Ilya Kasnacheev]

Hello Peter,

Thanks for chiming in. The code is under
https://github.com/apache/ignite/pull/8367

Regards,
-- 
Ilya Kasnacheev


вт, 9 февр. 2021 г. в 12:20, Petr Ivanov :

> Hi, Ilya.
>
>
> I've added Inspections to Run All.
> Checkstyle is currently integrated to Build and can be deleted.
>
>
> Where can I find the code for check-test-suites profile?
>
>
> Regards,
> *Petr Ivanov*
> Head of IT
> IT & Development Solutions |
> *GRIDGAIN SYSTEMS*+7 (911) 945-00-59
>
> On 9 Feb 2021, at 12:16, Ilya Kasnacheev 
> wrote:
>
> Hello!
>
> I have found one issue where it would cause tests to be run if the change
> is not present in the target branch.
>
> This includes e.g. 2.10 nightlies.
>
> What can we do to avoid that? Is specifying -DskipTests sufficient? Any
> chance that it will break the missed tests check?
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 8 февр. 2021 г. в 14:13, Ilya Kasnacheev :
>
>> Hello!
>>
>> I have created a TC suite:
>>
>> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_MissingTests?mode=builds
>>
>> + Peter Ivanov
>>
>> Can you please check if everything is alright?
>>
>> BTW, it seems that Inspections [Core] is only in Run All Basic (but not
>> in Run All), and Check Code Style is not triggered by either one. Is it
>> correct?
>>
>> Regards,
>> --
>> Ilya Kasnacheev
>>
>>
>> пн, 8 февр. 2021 г. в 10:22, Max Timonin :
>>
>>> Hi!
>>>
>>> Yes, now it's a part of the Travis check, and there is already a first
>>> successful build [1]. But I think it's also required to run the check on
>>> TC
>>> too, along with jobs for checking licenses, code style, and core
>>> inspections.
>>>
>>>
>>> [1] https://travis-ci.com/github/apache/ignite/builds/216363067
>>>
>>> On Fri, Feb 5, 2021 at 7:13 PM Ilya Kasnacheev <
>>> ilya.kasnach...@gmail.com>
>>> wrote:
>>>
>>> > Hello!
>>> >
>>> > I have merged it to master!
>>> >
>>> > I wonder what happens next. It will run as a part of travis check? Do
>>> we
>>> > also need to add it as a TC suite?
>>> >
>>> > Regards,
>>> > --
>>> > Ilya Kasnacheev
>>> >
>>> >
>>> > ср, 3 февр. 2021 г. в 18:50, Ilya Kasnacheev <
>>> ilya.kasnach...@gmail.com>:
>>> >
>>> > > Hello!
>>> > >
>>> > > Code mostly looks good, I have added a minor request. I will check
>>> how it
>>> > > works and then we may commit.
>>> > >
>>> > > + zaleslaw@gmail.com
>>> > >
>>> > > Can you please check whether the new ML suites make sense?
>>> > > math/distances/DistancesTestSuite.java
>>> > > naivebayes/NaiveBayesTestSuite.java
>>> > >
>>> > > Would we need to add them to some TC runs?
>>> > >
>>> > > Regards,
>>> > > --
>>> > > Ilya Kasnacheev
>>> > >
>>> > >
>>> > > пн, 25 янв. 2021 г. в 22:07, Max Timonin :
>>> > >
>>> > >> Hi, Ilya!
>>> > >>
>>> > >> I made a fix to the check. Now it aggregates info about tests and
>>> suites
>>> > >> from all modules and then validates it. Could you please review the
>>> PR
>>> > >> [1]?
>>> > >>
>>> > >> I tried to move some tests between modules, but unfortunately it
>>> still
>>> > >> looks like spaghetti. So I reverted all changes to testsuites (new
>>> and
>>> > >> splitted suites) and reworked the check.
>>> > >>
>>> > >> [1] https://github.com/apache/ignite/pull/8367
>>> > >>
>>> > >> On Mon, Dec 28, 2020 at 2:03 PM Ilya Kasnacheev <
>>> > >> ilya.kasnach...@gmail.com>
>>> > >> wrote:
>>> > >>
>>> > >> > Hello!
>>> > >> >
>>> > >> > You could try to move these tests as .java files between modules
>>> in a
>>> > >> > separate commit. I think I could review it.
>>> > >> >
>>> > >> > Regards,
>>> > >> > --
>>> > >> > Ilya Kasnacheev
>>> > >> >
>>> > >> >
>>> > >> > пт, 25 дек. 2020 г. в 17:19, Max Timonin >> >:
>>> > >> >
>>> > >> > > Hi!
>>> > >> > >
>>> > >> > > Ilya thanks for the reply! I agree that it's a valid case when a
>>> > test
>>> > >> is
>>> > >> > > part of multiple suites in different modules. But it is
>>> definitely a
>>> > >> bug
>>> > >> > > that the test is written in a module where it can't be run at
>>> all
>>> > and
>>> > >> > aimed
>>> > >> > > to run within different modules (core tests in core that require
>>> > h2).
>>> > >> I
>>> > >> > > propose to fix this issue.
>>> > >> > >
>>> > >> > > I'm going to check all such tests and move them to the right
>>> module.
>>> > >> As I
>>> > >> > > can see there are about 100 such test classes, but I hope that
>>> most
>>> > of
>>> > >> > them
>>> > >> > > follow only a few patterns.
>>> > >> > >
>>> > >> > > On Fri, Dec 25, 2020 at 2:58 PM Ivan Daschinsky <
>>> > ivanda...@gmail.com>
>>> > >> > > wrote:
>>> > >> > >
>>> > >> > > > Hi!
>>> > >> > > > >> I'm not sure that we should assume every test is only run
>>> from
>>> > >> one
>>> > >> > > test
>>> > >> > > > suite. One test may be run from different test suites located
>>> in
>>> > >> > > different
>>> > >> > > > modules.
>>> > >> > > > Agree. For example, if we introduce this limitation, zk suites
>>> > will
>>> > >> be
>>> > >> > > > broken.
>>> > >> > > >
>>> > >> > > >
>>> > >> > > > пт, 25 дек.

Re: [DISCUSS] Missed (non-suited) tests

[Ilya Kasnacheev]

Hello!

I have found one issue where it would cause tests to be run if the change
is not present in the target branch.

This includes e.g. 2.10 nightlies.

What can we do to avoid that? Is specifying -DskipTests sufficient? Any
chance that it will break the missed tests check?

Regards,
-- 
Ilya Kasnacheev


пн, 8 февр. 2021 г. в 14:13, Ilya Kasnacheev :

> Hello!
>
> I have created a TC suite:
>
> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_MissingTests?mode=builds
>
> + Peter Ivanov
>
> Can you please check if everything is alright?
>
> BTW, it seems that Inspections [Core] is only in Run All Basic (but not in
> Run All), and Check Code Style is not triggered by either one. Is it
> correct?
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 8 февр. 2021 г. в 10:22, Max Timonin :
>
>> Hi!
>>
>> Yes, now it's a part of the Travis check, and there is already a first
>> successful build [1]. But I think it's also required to run the check on
>> TC
>> too, along with jobs for checking licenses, code style, and core
>> inspections.
>>
>>
>> [1] https://travis-ci.com/github/apache/ignite/builds/216363067
>>
>> On Fri, Feb 5, 2021 at 7:13 PM Ilya Kasnacheev > >
>> wrote:
>>
>> > Hello!
>> >
>> > I have merged it to master!
>> >
>> > I wonder what happens next. It will run as a part of travis check? Do we
>> > also need to add it as a TC suite?
>> >
>> > Regards,
>> > --
>> > Ilya Kasnacheev
>> >
>> >
>> > ср, 3 февр. 2021 г. в 18:50, Ilya Kasnacheev > >:
>> >
>> > > Hello!
>> > >
>> > > Code mostly looks good, I have added a minor request. I will check
>> how it
>> > > works and then we may commit.
>> > >
>> > > + zaleslaw@gmail.com
>> > >
>> > > Can you please check whether the new ML suites make sense?
>> > > math/distances/DistancesTestSuite.java
>> > > naivebayes/NaiveBayesTestSuite.java
>> > >
>> > > Would we need to add them to some TC runs?
>> > >
>> > > Regards,
>> > > --
>> > > Ilya Kasnacheev
>> > >
>> > >
>> > > пн, 25 янв. 2021 г. в 22:07, Max Timonin :
>> > >
>> > >> Hi, Ilya!
>> > >>
>> > >> I made a fix to the check. Now it aggregates info about tests and
>> suites
>> > >> from all modules and then validates it. Could you please review the
>> PR
>> > >> [1]?
>> > >>
>> > >> I tried to move some tests between modules, but unfortunately it
>> still
>> > >> looks like spaghetti. So I reverted all changes to testsuites (new
>> and
>> > >> splitted suites) and reworked the check.
>> > >>
>> > >> [1] https://github.com/apache/ignite/pull/8367
>> > >>
>> > >> On Mon, Dec 28, 2020 at 2:03 PM Ilya Kasnacheev <
>> > >> ilya.kasnach...@gmail.com>
>> > >> wrote:
>> > >>
>> > >> > Hello!
>> > >> >
>> > >> > You could try to move these tests as .java files between modules
>> in a
>> > >> > separate commit. I think I could review it.
>> > >> >
>> > >> > Regards,
>> > >> > --
>> > >> > Ilya Kasnacheev
>> > >> >
>> > >> >
>> > >> > пт, 25 дек. 2020 г. в 17:19, Max Timonin > >:
>> > >> >
>> > >> > > Hi!
>> > >> > >
>> > >> > > Ilya thanks for the reply! I agree that it's a valid case when a
>> > test
>> > >> is
>> > >> > > part of multiple suites in different modules. But it is
>> definitely a
>> > >> bug
>> > >> > > that the test is written in a module where it can't be run at all
>> > and
>> > >> > aimed
>> > >> > > to run within different modules (core tests in core that require
>> > h2).
>> > >> I
>> > >> > > propose to fix this issue.
>> > >> > >
>> > >> > > I'm going to check all such tests and move them to the right
>> module.
>> > >> As I
>> > >> > > can see there are about 100 such test classes, but I hope that
>> most
>> > of
>> > >> > them
>> > >> > > follow only a few patterns.
>> > >> > >
>> > >> > > On Fri, Dec 25, 2020 at 2:58 PM Ivan Daschinsky <
>> > ivanda...@gmail.com>
>> > >> > > wrote:
>> > >> > >
>> > >> > > > Hi!
>> > >> > > > >> I'm not sure that we should assume every test is only run
>> from
>> > >> one
>> > >> > > test
>> > >> > > > suite. One test may be run from different test suites located
>> in
>> > >> > > different
>> > >> > > > modules.
>> > >> > > > Agree. For example, if we introduce this limitation, zk suites
>> > will
>> > >> be
>> > >> > > > broken.
>> > >> > > >
>> > >> > > >
>> > >> > > > пт, 25 дек. 2020 г. в 14:48, Ilya Kasnacheev <
>> > >> > ilya.kasnach...@gmail.com
>> > >> > > >:
>> > >> > > >
>> > >> > > > > Hello!
>> > >> > > > >
>> > >> > > > > Sorry for the long wait.
>> > >> > > > >
>> > >> > > > > I'm not sure that we should assume every test is only run
>> from
>> > one
>> > >> > test
>> > >> > > > > suite. One test may be run from different test suites
>> located in
>> > >> > > > different
>> > >> > > > > modules.
>> > >> > > > >
>> > >> > > > > I wonder if we can drop this requirement, check all the
>> modules
>> > >> > > > > transitively for used/unused tests.
>> > >> > > > >
>> > >> > > > > Regards,
>> > >> > > > > --
>> > >> > > > > Ilya Kasnacheev
>> > >> > > > >
>> > >> > > > >
>> > >> > > > > ср, 2 дек. 2020 г. в 18:23, Max Timonin <