[jira] [Assigned] (ISIS-1636) Support for Java 8 Time API

2017-10-26 Thread Andi Huber (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ISIS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reassigned ISIS-1636:


Assignee: Andi Huber

Feature is done. Branched off on DN 5.1. 
Branch is waiting to be merged. Possibly into 2.0.0-M2, which will come later 
this year.

> Support for Java 8 Time API
> ---
>
> Key: ISIS-1636
> URL: https://issues.apache.org/jira/browse/ISIS-1636
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0
>
>
> ISIS should support domain object properties of type
> * java.time.LocalDate
> * java.time.LocalDateTime
> * java.time.OffsetDateTime
> Sooner or later the new Java 8 time API will conquer the developers minds and 
> those using ISIS will demand ISIS built-in support for these basic types.
> Note: JDO support for the types listed above is already there (via plugin). 
> So the persistence part of the problem is solved, only the UI part is missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (ISIS-1738) ObjectMember's compator is not transitive

2017-10-26 Thread Andi Huber (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ISIS-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1738.

Resolution: Resolved

fix merged into master

> ObjectMember's compator is not transitive
> -
>
> Key: ISIS-1738
> URL: https://issues.apache.org/jira/browse/ISIS-1738
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Oscar Bou
>Assignee: Oscar Bou
> Fix For: 2.0.0
>
>
> If both elements are null, depending on the order they're passed as params, 
> it would return one result or another.
> It failed on the TimeSort in some cases, throwing the following stacktrace:
> java.lang.IllegalArgumentException: Comparison method violates its general 
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:773)
> at java.util.TimSort.mergeAt(TimSort.java:510)
> at java.util.TimSort.mergeCollapse(TimSort.java:437)
> at java.util.TimSort.sort(TimSort.java:241)
> at java.util.Arrays.sort(Arrays.java:1438)
> at 
> com.google.common.collect.Ordering.immutableSortedCopy(Ordering.java:888)
> at 
> com.google.common.collect.FluentIterable.toSortedList(FluentIterable.java:501)
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:467)
> at 
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at 
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:167)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at 
> org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at 
> org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.addUnderlyingViews(CollectionContentsMultipleViewsPanel.java:118)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.onInitialize(CollectionContentsMultipleViewsPanel.java:87)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1076)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1072)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:192)
> at 
> org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:983)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1071)
> at org.apache.wicket.Page.internalPrepareForRender(Page.java:240)
> at org.apache.wicket.Component.render(Component.java:2325)
> at org.apache.wicket.Page.renderPage(Page.java:1018)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:195)
> at 
> org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
> at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:895)
> at 
> org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
> at 
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:265)
> at 
>

[jira] [Resolved] (ISIS-1636) Support for Java 8 Time API

2017-10-26 Thread Andi Huber (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ISIS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber resolved ISIS-1636.
--
Resolution: Implemented

> Support for Java 8 Time API
> ---
>
> Key: ISIS-1636
> URL: https://issues.apache.org/jira/browse/ISIS-1636
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
>  Labels: Ready-for-Merge
> Fix For: 2.0.0
>
>
> ISIS should support domain object properties of type
> * java.time.LocalDate
> * java.time.LocalDateTime
> * java.time.OffsetDateTime
> Sooner or later the new Java 8 time API will conquer the developers minds and 
> those using ISIS will demand ISIS built-in support for these basic types.
> Note: JDO support for the types listed above is already there (via plugin). 
> So the persistence part of the problem is solved, only the UI part is missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1757) JEE Support - container-provided connection pools

2017-10-26 Thread Andi Huber (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220084#comment-16220084
 ] 

Andi Huber commented on ISIS-1757:
--

Does not affect core's code-base, but we need to think about providing
* a 'Hello JEE-World' artifact
* documentation on how to configure DataNucleus to work with JNDI provided 
connection pools

> JEE Support - container-provided connection pools
> -
>
> Key: ISIS-1757
> URL: https://issues.apache.org/jira/browse/ISIS-1757
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> I use JEE container provided connection pools and bind them to  Isis/JDO via 
> JNDI. I'm not an expert on this, but I believe this works  totally sane.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1752) Extend RO viewer, return a menu.layout.xml resource

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220089#comment-16220089
 ] 

ASF subversion and git services commented on ISIS-1752:
---

Commit 19a47a8ad16f03a5eb5f69db12519a377882abdc in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=19a47a8 ]

Merge branch 'ISIS-1752-menu-layout-resource'


> Extend RO viewer, return a menu.layout.xml resource
> ---
>
> Key: ISIS-1752
> URL: https://issues.apache.org/jira/browse/ISIS-1752
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220096#comment-16220096
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 10b9e0436116242353bd214231a83a2bb189a625 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=10b9e04 ]

ISIS-1742: replaces Filter with Predicate in new MenuBarsServiceDefault


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1752) Extend RO viewer, return a menu.layout.xml resource

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220092#comment-16220092
 ] 

ASF subversion and git services commented on ISIS-1752:
---

Commit bc5fdbe8de369c6e8c45d38992000f242812be4e in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bc5fdbe ]

ISIS-1752: fixes unit test


> Extend RO viewer, return a menu.layout.xml resource
> ---
>
> Key: ISIS-1752
> URL: https://issues.apache.org/jira/browse/ISIS-1752
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1752) Extend RO viewer, return a menu.layout.xml resource

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220093#comment-16220093
 ] 

ASF subversion and git services commented on ISIS-1752:
---

Commit 1b9db57f9ad8529b0b18db3eb0ee8fa4c297cbb0 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1b9db57 ]

ISIS-1752: removes unused import


> Extend RO viewer, return a menu.layout.xml resource
> ---
>
> Key: ISIS-1752
> URL: https://issues.apache.org/jira/browse/ISIS-1752
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1572) RestfulObjects viewer - Service members empty

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220091#comment-16220091
 ] 

ASF subversion and git services commented on ISIS-1572:
---

Commit 0b7f44552d81ac7aa0172b1c6cad6d24778db518 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0b7f445 ]

ISIS-1572: adds outline docs for MenuBarsService


> RestfulObjects viewer - Service members empty
> -
>
> Key: ISIS-1572
> URL: https://issues.apache.org/jira/browse/ISIS-1572
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.13.0
> Environment: Web.xml is patched according to 
> https://github.com/danhaywood/isis-angularjs-simpleapp in order to cope with 
> CORS issues.
>Reporter: Jörg Rade
> Fix For: 1.15.0
>
>
> _Sometimes_ the members section of the response to 
> http://localhost:9090/restful/services/Applications/ is empty - sometimes it 
> is not:
> {code|language=javascript}
> {
>   "links" : [ {
> "rel" : "self",
> "href" : "http://localhost:9090/restful/services/Applications";,
> "method" : "GET",
> "type" : 
> "application/json;profile=\"urn:org.restfulobjects:repr-types/object\"",
> "title" : "Applications"
>   }, {
> "rel" : "describedby",
> "href" : 
> "http://localhost:9090/restful/domain-types/ife.dep.Applications";,
> "method" : "GET",
> "type" : 
> "application/json;profile=\"urn:org.restfulobjects:repr-types/domain-type\""
>   }, {
> "rel" : "up",
> "href" : "http://localhost:9090/restful/services";,
> "method" : "GET",
> "type" : 
> "application/json;profile=\"urn:org.restfulobjects:repr-types/list\""
>   } ],
>   "extensions" : {
> "oid" : "ife.dep.Applications:1",
> "isService" : true,
> "isPersistent" : true
>   },
>   "title" : "Applications",
>   "serviceId" : "Applications",
>   "members" : { }
> }
> {code}
> After some time the app was  accessed via the wicket viewer. It first 
> delivered the homepage and then I invoked the listAll operation via the 
> respective menu item.
> Invoking  http://localhost:9090/restful/services/Applications/ afterwards 
> showed the expected response including the members.
> In another case there was a difference between:
> * http://localhost:9090/restful/services/Applications/ (with members) and
> * http://localhost:9090/restful/services/Applications (without members)
> In yet another case both URL's delivered a result without 'members' filled, 
> even after the 'workaround' described above.
> https://github.com/joerg-rade/isis-app-todoapp shows the same behavior:
> * http://localhost:/restful/services/todo.ToDoItems/ whereas
> * http://localhost:/restful/domain-types/todoapp.dom.todoitem.ToDoItems 
> shows the members



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220095#comment-16220095
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit ec9ee590771388cd3f4cbe5d5be695d4c87de6a2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ec9ee59 ]

ISIS-1742: removes merge conflict markers accidentally left in file


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1752) Extend RO viewer, return a menu.layout.xml resource

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220090#comment-16220090
 ] 

ASF subversion and git services commented on ISIS-1752:
---

Commit d70337f97c1cfd347ea7515d58b736651d4ff74e in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d70337f ]

ISIS-1752: factors out MenuBarsService, refactors Wicket UI to use 
MenuBarsService.


> Extend RO viewer, return a menu.layout.xml resource
> ---
>
> Key: ISIS-1752
> URL: https://issues.apache.org/jira/browse/ISIS-1752
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220094#comment-16220094
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 70e6bd11008332dcc3c209b15ffb2d0a2e6d61dc in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=70e6bd1 ]

Merge branch 'master' into dev/2.0.0/ISIS-1742-remove-deprecations


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1754) JEE Support - replace Class.forName with TCL.loadClass (+ patching DN)

2017-10-26 Thread Andi Huber (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220114#comment-16220114
 ] 

Andi Huber commented on ISIS-1754:
--

I need to investigate DN's customize-able class-loading mechanism via 
{code}JDOClassLoaderResolver [1]{code}

Maybe we can adopt some concepts they have into Isis. Patching DN should not be 
required.

[1] 
http://www.datanucleus.org/products/accessplatform/extensions/extensions.html#_plugins_in_a_non_managed_environment

> JEE Support - replace Class.forName with TCL.loadClass (+ patching DN)
> --
>
> Key: ISIS-1754
> URL: https://issues.apache.org/jira/browse/ISIS-1754
> Project: Isis
>  Issue Type: Improvement
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> Class.forName(...), so we need a plug-able class-loading mechanism. 
> (What worked for me is 
> Thread.currentThread().getContextClassLoader().loadClass(...)). 
> Unfortunately this applies also to DataNucleus. So I had to patch their 
> class loading mechanism. (Sounds dramatic, but was just a single line of 
> code.)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (ISIS-1738) ObjectMember's compator is not transitive

2017-10-26 Thread Andi Huber (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ISIS-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reopened ISIS-1738:
--

need to change issue's fix-version

> ObjectMember's compator is not transitive
> -
>
> Key: ISIS-1738
> URL: https://issues.apache.org/jira/browse/ISIS-1738
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Oscar Bou
>Assignee: Oscar Bou
> Fix For: 1.16.0
>
>
> If both elements are null, depending on the order they're passed as params, 
> it would return one result or another.
> It failed on the TimeSort in some cases, throwing the following stacktrace:
> java.lang.IllegalArgumentException: Comparison method violates its general 
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:773)
> at java.util.TimSort.mergeAt(TimSort.java:510)
> at java.util.TimSort.mergeCollapse(TimSort.java:437)
> at java.util.TimSort.sort(TimSort.java:241)
> at java.util.Arrays.sort(Arrays.java:1438)
> at 
> com.google.common.collect.Ordering.immutableSortedCopy(Ordering.java:888)
> at 
> com.google.common.collect.FluentIterable.toSortedList(FluentIterable.java:501)
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:467)
> at 
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at 
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:167)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at 
> org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at 
> org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.addUnderlyingViews(CollectionContentsMultipleViewsPanel.java:118)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.onInitialize(CollectionContentsMultipleViewsPanel.java:87)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1076)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1072)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:192)
> at 
> org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:983)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1071)
> at org.apache.wicket.Page.internalPrepareForRender(Page.java:240)
> at org.apache.wicket.Component.render(Component.java:2325)
> at org.apache.wicket.Page.renderPage(Page.java:1018)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:195)
> at 
> org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
> at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:895)
> at 
> org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
> at 
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:265)
> at 
> org.apac

[jira] [Updated] (ISIS-1738) ObjectMember's compator is not transitive

2017-10-26 Thread Andi Huber (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ISIS-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-1738:
-
Fix Version/s: (was: 2.0.0)
   1.16.0

> ObjectMember's compator is not transitive
> -
>
> Key: ISIS-1738
> URL: https://issues.apache.org/jira/browse/ISIS-1738
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Oscar Bou
>Assignee: Oscar Bou
> Fix For: 1.16.0
>
>
> If both elements are null, depending on the order they're passed as params, 
> it would return one result or another.
> It failed on the TimeSort in some cases, throwing the following stacktrace:
> java.lang.IllegalArgumentException: Comparison method violates its general 
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:773)
> at java.util.TimSort.mergeAt(TimSort.java:510)
> at java.util.TimSort.mergeCollapse(TimSort.java:437)
> at java.util.TimSort.sort(TimSort.java:241)
> at java.util.Arrays.sort(Arrays.java:1438)
> at 
> com.google.common.collect.Ordering.immutableSortedCopy(Ordering.java:888)
> at 
> com.google.common.collect.FluentIterable.toSortedList(FluentIterable.java:501)
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:467)
> at 
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at 
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:167)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at 
> org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at 
> org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.addUnderlyingViews(CollectionContentsMultipleViewsPanel.java:118)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.onInitialize(CollectionContentsMultipleViewsPanel.java:87)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1076)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1072)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:192)
> at 
> org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:983)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1071)
> at org.apache.wicket.Page.internalPrepareForRender(Page.java:240)
> at org.apache.wicket.Component.render(Component.java:2325)
> at org.apache.wicket.Page.renderPage(Page.java:1018)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:195)
> at 
> org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
> at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:895)
> at 
> org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
> at 
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:2

[jira] [Closed] (ISIS-1738) ObjectMember's compator is not transitive

2017-10-26 Thread Andi Huber (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ISIS-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1738.

Resolution: Fixed

closing issue again, with proper fix-version

> ObjectMember's compator is not transitive
> -
>
> Key: ISIS-1738
> URL: https://issues.apache.org/jira/browse/ISIS-1738
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Oscar Bou
>Assignee: Oscar Bou
> Fix For: 1.16.0
>
>
> If both elements are null, depending on the order they're passed as params, 
> it would return one result or another.
> It failed on the TimeSort in some cases, throwing the following stacktrace:
> java.lang.IllegalArgumentException: Comparison method violates its general 
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:773)
> at java.util.TimSort.mergeAt(TimSort.java:510)
> at java.util.TimSort.mergeCollapse(TimSort.java:437)
> at java.util.TimSort.sort(TimSort.java:241)
> at java.util.Arrays.sort(Arrays.java:1438)
> at 
> com.google.common.collect.Ordering.immutableSortedCopy(Ordering.java:888)
> at 
> com.google.common.collect.FluentIterable.toSortedList(FluentIterable.java:501)
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:467)
> at 
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at 
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:167)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at 
> org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at 
> org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.addUnderlyingViews(CollectionContentsMultipleViewsPanel.java:118)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel.onInitialize(CollectionContentsMultipleViewsPanel.java:87)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1076)
> at 
> org.apache.wicket.MarkupContainer$3.component(MarkupContainer.java:1072)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:162)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123)
> at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:192)
> at 
> org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:983)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1071)
> at org.apache.wicket.Page.internalPrepareForRender(Page.java:240)
> at org.apache.wicket.Component.render(Component.java:2325)
> at org.apache.wicket.Page.renderPage(Page.java:1018)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124)
> at 
> org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:195)
> at 
> org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
> at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:895)
> at 
> org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
> at 
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.ja

[jira] [Commented] (ISIS-1740) New Feature: Where am I

2017-10-26 Thread Andi Huber (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220171#comment-16220171
 ] 

Andi Huber commented on ISIS-1740:
--

This feature will introduce some Java 8+ utility classes. Designated location 
for these ...
{code:java}
isis-core-applib/o.a.i.core.commons.xxx
{code}

Feature will branch off on 
{code:java}
dev/2.0.0/ISIS-1742-remove-deprecations
{code}




> New Feature: Where am I
> ---
>
> Key: ISIS-1740
> URL: https://issues.apache.org/jira/browse/ISIS-1740
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
> Fix For: 2.0.0
>
> Attachments: Clipboard01.png, Clipboard02.png, Clipboard03.png, 
> Clipboard04.png
>
>
> Its common practice to display a navigation hint somewhere at top of an 
> application's page or below the main menu, indicating where the user 
> currently has navigated to. (Typically within a navigable tree-structure.) 
> Let's call this the *WhereAmI hint*. We could integrate such a feature into 
> ISIS.
> +Examples+
> [^Clipboard01.png]
> [^Clipboard02.png]
> [^Clipboard03.png]
> Note: we could optionally include the DomainObject's icons
> +Proposal+
> For any DomainObject/View currently displayed ISIS would need to know its 
> corresponding
> navigable tree-structure. Let's call this the DomainObject's *WhereAmI tree*.
> All the framework needs to known to build the relevant sub-tree, is to know 
> the parent node of any DomainObject/View that 'takes part' in the tree.
> We could provide this 'who is your parent' meta information similar to the 
> existing 'what is your title' mechanism:
> {code:java}
> // Who is your parent? if null there is none
> public AnyDomainObjectOrView parent()
> {
> return foo;
> }
> {code}
> or
> {code:java}
> // Who is your parent? if null there is none
> @Parent
> public AnyDomainObjectOrView anyMethodName()
> {
> return foo;
> }
> {code}
> The typical layout.xml could look like this:
> {code:xml}
> 
> 
> 
> 
> 
> ...
> 
> 
>  ...
> 
> {code}
> +Implementation Notes+
> # The framework needs to ensure that the chain of parent references starting 
> at the current DomainObject/View is finite. (No circular or self references.) 
> If it detects a circle, be nice and just stop the 'tree-up' traversal there.
> # For standalone Collection Views we could display a WhereAmI hint that 
> allows back navigation to the DomainObject/View that had produced the 
> collection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (ISIS-1740) New Feature: Where am I

2017-10-26 Thread Andi Huber (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220171#comment-16220171
 ] 

Andi Huber edited comment on ISIS-1740 at 10/26/17 8:45 AM:


This feature will introduce some Java 8+ utility classes. Designated location 
for these ...
{code}
isis-core-metamodel/o.a.i.core.commons.xxx
{code}

Feature will branch off on 
{code}
dev/2.0.0/ISIS-1742-remove-deprecations
{code}





was (Author: hobrom):
This feature will introduce some Java 8+ utility classes. Designated location 
for these ...
{code:java}
isis-core-applib/o.a.i.core.commons.xxx
{code}

Feature will branch off on 
{code:java}
dev/2.0.0/ISIS-1742-remove-deprecations
{code}




> New Feature: Where am I
> ---
>
> Key: ISIS-1740
> URL: https://issues.apache.org/jira/browse/ISIS-1740
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
> Fix For: 2.0.0
>
> Attachments: Clipboard01.png, Clipboard02.png, Clipboard03.png, 
> Clipboard04.png
>
>
> Its common practice to display a navigation hint somewhere at top of an 
> application's page or below the main menu, indicating where the user 
> currently has navigated to. (Typically within a navigable tree-structure.) 
> Let's call this the *WhereAmI hint*. We could integrate such a feature into 
> ISIS.
> +Examples+
> [^Clipboard01.png]
> [^Clipboard02.png]
> [^Clipboard03.png]
> Note: we could optionally include the DomainObject's icons
> +Proposal+
> For any DomainObject/View currently displayed ISIS would need to know its 
> corresponding
> navigable tree-structure. Let's call this the DomainObject's *WhereAmI tree*.
> All the framework needs to known to build the relevant sub-tree, is to know 
> the parent node of any DomainObject/View that 'takes part' in the tree.
> We could provide this 'who is your parent' meta information similar to the 
> existing 'what is your title' mechanism:
> {code:java}
> // Who is your parent? if null there is none
> public AnyDomainObjectOrView parent()
> {
> return foo;
> }
> {code}
> or
> {code:java}
> // Who is your parent? if null there is none
> @Parent
> public AnyDomainObjectOrView anyMethodName()
> {
> return foo;
> }
> {code}
> The typical layout.xml could look like this:
> {code:xml}
> 
> 
> 
> 
> 
> ...
> 
> 
>  ...
> 
> {code}
> +Implementation Notes+
> # The framework needs to ensure that the chain of parent references starting 
> at the current DomainObject/View is finite. (No circular or self references.) 
> If it detects a circle, be nice and just stop the 'tree-up' traversal there.
> # For standalone Collection Views we could display a WhereAmI hint that 
> allows back navigation to the DomainObject/View that had produced the 
> collection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1755) JEE Support - dummy bean as workaround for CDI

2017-10-26 Thread Andi Huber (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220178#comment-16220178
 ] 

Andi Huber commented on ISIS-1755:
--

The dummy Enterprise Java Bean (EJB) requires annotations 

* javax.ejb.Stateless
* javax.enterprise.inject.Produces

from 

{code:xml}

javax
javaee-api

{code}

If we integrate this EJB into Isis we have an additional dependency. This seems 
fine to me, but needs to be discussed.


> JEE Support - dummy bean as workaround for CDI
> --
>
> Key: ISIS-1755
> URL: https://issues.apache.org/jira/browse/ISIS-1755
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> During JEE-Application bootstrapping the JEE container identifies a 
> list of Isis classes it feels responsible for, but does not know how to 
> instantiate; so errors are thrown. For me it was sufficient to provide a 
> single stateless JEE bean that states, that it produces all these 
> classes. As long as you deploy your Isis application including this 
> dummy-bean, CDI does not complain.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

2017-10-26 Thread Andi Huber (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220190#comment-16220190
 ] 

Andi Huber commented on ISIS-1756:
--

Introduces a new javax.servlet.Filter that extends on 
org.apache.wicket.protocol.http.WicketFilter, which must be configured with 
web.xml.

{code:java}
@Log
public class DomainAppFilter extends WicketFilter {

@Override
public void init(boolean isServlet, FilterConfig filterConfig) throws 
ServletException {

log.info("DomainAppFilter on init ...");
super.init(isServlet, filterConfig); 
}

@Override
public void destroy() {
log.info("DomainAppFilter on destroy ...");
super.destroy();
IsisContext.testReset();
}
}
{code}

While IsisContext.testReset() needs a simple fix and could be renamed to 
'destroy()'.




> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220244#comment-16220244
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit d96dc04587a80db6b87f5f6f67ba11fe477ca983 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d96dc04 ]

Proper lifecycling in preparation of ISIS-1756

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: 'Where am I' feature

2017-10-26 Thread Andi Huber 
[Message lost in encryption: so I'm sending it again]

Thanks Dan,

great work, I totally agree with your comments ...


On 26.10.2017 00:24, Dan Haywood wrote:
> Hi Andi
>
> cc'ing dev@ on this...
>
>
> On Tue, 24 Oct 2017 at 21:22 Andi Huber  > wrote:
>
> Hi Dan,
>
> I could start with work on the integration of the 'Where am I' feature
> (ISIS-1740) into core.
>
> Cool.  I've slotted the ticket into the 2.0.0 release.
>
>  
>
> With that I'd like to add some utility classes,  that utilize Java 8
> features (Streams and Lamdas). Those are utilities like Reflection
> Helper, Bean Utility, Weak Reference Cache, Null Safe Utilities,
> etc. I
> would call these internal utilities, not meant to contribute to the
> public API. (But I think I will put some work into javadoc
> completeness
> and treat them like they where public API, just in case.)
>
>
> Great stuff. 
>
> Do you have a designated project/package where to put these? Maybe
> under
> org.apache.isis.applib.util?
>
>
> If this isn't intended to be public API, then it shouldn't go in
> isis-core-applib.  
>
> Instead, I think the place to put this stuff is in
> isis-core-metamodel, I think, probably under the o.a.i.core.commons
> package.
>
> Create subpackages under there as you see fit, eg
> o.a.i.core.commons.streams.
>
>
>
>  
>
> I guess its Ok, if I branch this new feature off on
> dev/2.0.0/ISIS-1276-dn-5-1.
>
>
> I've done more work on the dev/2.0.0/ISIS-1742-remove-deprecations
> branch, so I suggest you branch from there.
>
> What I'm thinking of doing is to do an "2.0.0-M1" milestone release
> based on that branch, which will be basically 1.15.1 release but
> updated to Java 8 + removed deprecations but NOT upgraded to DN 5.1. 
> Later on an M2 milestone would merge in the DN 5.1 upgrade.  (In fact,
> I think I might do a rebase of the ISIS-1276-dn-5-1 branch on top of
> ISIS-1742).
>
>  
>
> ---
>
> I'm also eager to help with the JEE roadmap. First we could extract
> ToDos from our last conversation and organize them into Jira Issues. I
> could do that if you like. First goal could be to provide an
> 'works out
> of the box' experience for users with Isis on JEE 7+ servers.
> Subsequent
> goals like CDI managed Domain Objects or deprecation of Rest Easy
> would
> follow later. (The hard part to solve for the first goal is
> class-loading, which also affects Data-Nucleus.)
>
>
> Great.  I've gone ahead and created tickets, ISIS-1754 through
> ISIS-1757.  I've put them into 2.0.0 release as well.  Again, suggest
> create branches from the dev/2.0.0/ISIS-1742-remove-deprecations brac.
>
>  
>
> In Jira I'm not allowed to assign tasks to myself yet. Not sure
> whom to
> contact, to get the permission. 
>
>
> Had a look, seems like I had the karma to grant out permissions, so
> you should be set to go.
>  
>
Confirmed: I'm able to assign tasks to myself now.
>
> Alternatively, what's the progress on
> the idea of using github's issue tracking?
>
>
> The github integration simplifies applying pull requests, and it means
> that we push directly to github of course as well, but we've not
> discussed whether to leverage any of it other features.
>
> While I'm not a huge fan of JIRA (who is?), I'm not sure that there's
> a lot of benefit in transferring all of our backlog over to github...
> and we might well miss some of JIRA's features once there.   Any other
> views on this?
>
>
Sorry for my confusion: I had thought there was a plan to migrate to
github's issue tracking. I was not implying any preferences and I'm
happy with Jira as well.
> Cheers
> Dan
>
>
>  
>
> Cheers Andi
>
>
Cheers, Andi

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

2017-10-26 Thread Dan Haywood (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221307#comment-16221307
 ] 

Dan Haywood commented on ISIS-1756:
---

Hi [~hobrom], quick request: could you format commit messages as:

ISIS-: active sentence which describes the change

for example:

ISIS-1756: adds destroy() method to IsisContext, and deprecates testReset()

Also (very minor point), when I deprecate I use both the javadoc @deprecated 
and also the @Deprecated annotation.  

thx
Dan

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221311#comment-16221311
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit d96dc04587a80db6b87f5f6f67ba11fe477ca983 in isis's branch 
refs/heads/ISIS-1632-meta-annotations from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d96dc04 ]

Proper lifecycling in preparation of ISIS-1756

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221313#comment-16221313
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 9c0ea74e59f2c729db7b1e6daf60937f92859885 in isis's branch 
refs/heads/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9c0ea74 ]

ISIS-1742: deletes unused OptionHandlerXxx classes (Debug, Quiet, Verbose)


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1632) Support meta annotations for @Property/@Collection/@Action + @XxxLayout

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221315#comment-16221315
 ] 

ASF subversion and git services commented on ISIS-1632:
---

Commit 197fa8376d246468b72b6f0c69cf4b078cdd8a6a in isis's branch 
refs/heads/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=197fa83 ]

ISIS-1632: adds initial support for @Meta annotation.

However, these are not recursive, and does not merge in multiple definitions of 
various attributes at different levels.


> Support meta annotations for @Property/@Collection/@Action + @XxxLayout
> ---
>
> Key: ISIS-1632
> URL: https://issues.apache.org/jira/browse/ISIS-1632
> Project: Isis
>  Issue Type: New Feature
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221312#comment-16221312
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit e6bfa0f017e82ad9fc4af327ce5599eb8d308fcf in isis's branch 
refs/heads/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e6bfa0f ]

ISIS-1742: removes support for exploration prefix for actions


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221314#comment-16221314
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit a6cf98a148d2c58757595b1a4227d77011908b23 in isis's branch 
refs/heads/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a6cf98a ]

ISIS-1742: updates todo list


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221310#comment-16221310
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 10b9e0436116242353bd214231a83a2bb189a625 in isis's branch 
refs/heads/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=10b9e04 ]

ISIS-1742: replaces Filter with Predicate in new MenuBarsServiceDefault


> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1636) Support for Java 8 Time API

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221342#comment-16221342
 ] 

ASF subversion and git services commented on ISIS-1636:
---

Commit 65294dc7f29a9ef9ceca05c4b07ee756e0a7826e in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=65294dc ]

ISIS-1636 UI enhancement - java 8 Time

> Support for Java 8 Time API
> ---
>
> Key: ISIS-1636
> URL: https://issues.apache.org/jira/browse/ISIS-1636
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
>  Labels: Ready-for-Merge
> Fix For: 2.0.0
>
>
> ISIS should support domain object properties of type
> * java.time.LocalDate
> * java.time.LocalDateTime
> * java.time.OffsetDateTime
> Sooner or later the new Java 8 time API will conquer the developers minds and 
> those using ISIS will demand ISIS built-in support for these basic types.
> Note: JDO support for the types listed above is already there (via plugin). 
> So the persistence part of the problem is solved, only the UI part is missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1276) Update DN to 5.1.x (from DN 4.1.x)

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221334#comment-16221334
 ] 

ASF subversion and git services commented on ISIS-1276:
---

Commit 2af08d35e515cc4cd9a5497c91f68acc0e0e8757 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2af08d3 ]

ISIS-1276: fixes compile issues in metamodel and runtime


> Update DN to 5.1.x (from DN 4.1.x)
> --
>
> Key: ISIS-1276
> URL: https://issues.apache.org/jira/browse/ISIS-1276
> Project: Isis
>  Issue Type: Dependency upgrade
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>
> Note that this will break IsisJdoSupport since the TypesafeQuery class is 
> removed.  While strictly speaking we ought to bump to Isis v2.0.0 because it 
> is a breaking change, I think in this particular instance we make an 
> exception: my guess is that not may are using that particular API.
> http://www.datanucleus.org/products/accessplatform_5_1/migration.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1728) Rework helloworld and simpleapp to use typesafe queries.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221341#comment-16221341
 ] 

ASF subversion and git services commented on ISIS-1728:
---

Commit 26ff9ea322756e3e69ea698adf3ee2409024d8bb in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=26ff9ea ]

ISIS-1728: uses typesafe queries for helloworld


> Rework helloworld and simpleapp to use typesafe queries.
> 
>
> Key: ISIS-1728
> URL: https://issues.apache.org/jira/browse/ISIS-1728
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1723) Remove JDO applib's Auditable interface and @Auditable annotation

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221336#comment-16221336
 ] 

ASF subversion and git services commented on ISIS-1723:
---

Commit 5421e8309c4316cea248acfd1c03aa001b3f6de2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5421e83 ]

ISIS-1723: removes jdo applib's Auditable interface and @Auditable annotation


> Remove JDO applib's Auditable interface and @Auditable annotation
> -
>
> Key: ISIS-1723
> URL: https://issues.apache.org/jira/browse/ISIS-1723
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> These have been deprecated for a long while, with equivalents in the regular 
> applib.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1724) Remove JDO applib's IsisJdoSupport

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221337#comment-16221337
 ] 

ASF subversion and git services commented on ISIS-1724:
---

Commit c53336e4b0a65961ffb77be4b62395a7794c1453 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c53336e ]

ISIS-1724: removes the deprecated IsisJdoSupport in the jdo applib


> Remove JDO applib's IsisJdoSupport
> --
>
> Key: ISIS-1724
> URL: https://issues.apache.org/jira/browse/ISIS-1724
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> This has been deprecated for a long while



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1727) Minor internal refactorings from upgrade to JDK 8

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221339#comment-16221339
 ] 

ASF subversion and git services commented on ISIS-1727:
---

Commit 1d599e03be0458409e4a205ab5bacd525369adc2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1d599e0 ]

ISIS-1727: uses lambda in IsisSessionFactoryBuilder


> Minor internal refactorings from upgrade to JDK 8
> -
>
> Key: ISIS-1727
> URL: https://issues.apache.org/jira/browse/ISIS-1727
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1276) Update DN to 5.1.x (from DN 4.1.x)

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221335#comment-16221335
 ] 

ASF subversion and git services commented on ISIS-1276:
---

Commit 96c6b362411814b51d0ac54fa1181aace3190ba2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=96c6b36 ]

ISIS-1276: fixes algorithm for lookup of datastore id's, at least


> Update DN to 5.1.x (from DN 4.1.x)
> --
>
> Key: ISIS-1276
> URL: https://issues.apache.org/jira/browse/ISIS-1276
> Project: Isis
>  Issue Type: Dependency upgrade
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>
> Note that this will break IsisJdoSupport since the TypesafeQuery class is 
> removed.  While strictly speaking we ought to bump to Isis v2.0.0 because it 
> is a breaking change, I think in this particular instance we make an 
> exception: my guess is that not may are using that particular API.
> http://www.datanucleus.org/products/accessplatform_5_1/migration.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1725) Simplify bootstrapping logic by requiring an AppManifest to be supplied, remoev cfg property

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221338#comment-16221338
 ] 

ASF subversion and git services commented on ISIS-1725:
---

Commit f98b0ede171e88824aa7f96195f5fac170eb2af5 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f98b0ed ]

ISIS-1725: requires that an AppManifest is supplied (used to obtain list of 
entities).


> Simplify bootstrapping logic by requiring an AppManifest to be supplied, 
> remoev cfg property
> 
>
> Key: ISIS-1725
> URL: https://issues.apache.org/jira/browse/ISIS-1725
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> implies that the isis.persistor.datanucleus.RegisterEntities.packagePrefix 
> config property is not longer used
> // no longer used ...
> public final static String PACKAGE_PREFIX_KEY = 
> "isis.persistor.datanucleus.RegisterEntities.packagePrefix";
> in ISIS-1276-dn-5-1 branch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1726) Support DataNucleus meta annotations for @PersistenceCapable.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221340#comment-16221340
 ] 

ASF subversion and git services commented on ISIS-1726:
---

Commit 8c3577452a6c9fff3c9fd4b177be4b16cff342a2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1636-j8-time from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8c35774 ]

ISIS-1726: generalizes the logic that searches for @PersistenceCapable 
entities, to also take into account meta-annotations.


> Support DataNucleus meta annotations for @PersistenceCapable.
> -
>
> Key: ISIS-1726
> URL: https://issues.apache.org/jira/browse/ISIS-1726
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

rebased dev/2.0.0/ISIS-1276-dn-5-1 and dev/2.0.0/ISIS-1638-j8-time

2017-10-26 Thread Dan Haywood 
Hi Andi,

Hope it's okay, I've rebased the dn-5-1 branch and the j8 branch also, on
top of the dev/2.0.0/ISIS-1742-remove-deprecations ... just so they don't
get too far out of line with all the work being done on that branch.

So, you may need to reset your local branches when you pull these down.

Thx
Dan

[jira] [Commented] (ISIS-1276) Update DN to 5.1.x (from DN 4.1.x)

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221353#comment-16221353
 ] 

ASF subversion and git services commented on ISIS-1276:
---

Commit 96c6b362411814b51d0ac54fa1181aace3190ba2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=96c6b36 ]

ISIS-1276: fixes algorithm for lookup of datastore id's, at least


> Update DN to 5.1.x (from DN 4.1.x)
> --
>
> Key: ISIS-1276
> URL: https://issues.apache.org/jira/browse/ISIS-1276
> Project: Isis
>  Issue Type: Dependency upgrade
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>
> Note that this will break IsisJdoSupport since the TypesafeQuery class is 
> removed.  While strictly speaking we ought to bump to Isis v2.0.0 because it 
> is a breaking change, I think in this particular instance we make an 
> exception: my guess is that not may are using that particular API.
> http://www.datanucleus.org/products/accessplatform_5_1/migration.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1724) Remove JDO applib's IsisJdoSupport

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221355#comment-16221355
 ] 

ASF subversion and git services commented on ISIS-1724:
---

Commit c53336e4b0a65961ffb77be4b62395a7794c1453 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c53336e ]

ISIS-1724: removes the deprecated IsisJdoSupport in the jdo applib


> Remove JDO applib's IsisJdoSupport
> --
>
> Key: ISIS-1724
> URL: https://issues.apache.org/jira/browse/ISIS-1724
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> This has been deprecated for a long while



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1276) Update DN to 5.1.x (from DN 4.1.x)

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221351#comment-16221351
 ] 

ASF subversion and git services commented on ISIS-1276:
---

Commit c07d669272113ca66b47d924ee0520a2f2e9a06f in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c07d669 ]

ISIS-1276: updates applib, replaces references of TypesafeQuery to be instead 
JDOQLTypedQuery


> Update DN to 5.1.x (from DN 4.1.x)
> --
>
> Key: ISIS-1276
> URL: https://issues.apache.org/jira/browse/ISIS-1276
> Project: Isis
>  Issue Type: Dependency upgrade
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>
> Note that this will break IsisJdoSupport since the TypesafeQuery class is 
> removed.  While strictly speaking we ought to bump to Isis v2.0.0 because it 
> is a breaking change, I think in this particular instance we make an 
> exception: my guess is that not may are using that particular API.
> http://www.datanucleus.org/products/accessplatform_5_1/migration.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1726) Support DataNucleus meta annotations for @PersistenceCapable.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221358#comment-16221358
 ] 

ASF subversion and git services commented on ISIS-1726:
---

Commit 8c3577452a6c9fff3c9fd4b177be4b16cff342a2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8c35774 ]

ISIS-1726: generalizes the logic that searches for @PersistenceCapable 
entities, to also take into account meta-annotations.


> Support DataNucleus meta annotations for @PersistenceCapable.
> -
>
> Key: ISIS-1726
> URL: https://issues.apache.org/jira/browse/ISIS-1726
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1728) Rework helloworld and simpleapp to use typesafe queries.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221359#comment-16221359
 ] 

ASF subversion and git services commented on ISIS-1728:
---

Commit 26ff9ea322756e3e69ea698adf3ee2409024d8bb in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=26ff9ea ]

ISIS-1728: uses typesafe queries for helloworld


> Rework helloworld and simpleapp to use typesafe queries.
> 
>
> Key: ISIS-1728
> URL: https://issues.apache.org/jira/browse/ISIS-1728
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1723) Remove JDO applib's Auditable interface and @Auditable annotation

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221354#comment-16221354
 ] 

ASF subversion and git services commented on ISIS-1723:
---

Commit 5421e8309c4316cea248acfd1c03aa001b3f6de2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5421e83 ]

ISIS-1723: removes jdo applib's Auditable interface and @Auditable annotation


> Remove JDO applib's Auditable interface and @Auditable annotation
> -
>
> Key: ISIS-1723
> URL: https://issues.apache.org/jira/browse/ISIS-1723
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> These have been deprecated for a long while, with equivalents in the regular 
> applib.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1727) Minor internal refactorings from upgrade to JDK 8

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221357#comment-16221357
 ] 

ASF subversion and git services commented on ISIS-1727:
---

Commit 1d599e03be0458409e4a205ab5bacd525369adc2 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1d599e0 ]

ISIS-1727: uses lambda in IsisSessionFactoryBuilder


> Minor internal refactorings from upgrade to JDK 8
> -
>
> Key: ISIS-1727
> URL: https://issues.apache.org/jira/browse/ISIS-1727
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1725) Simplify bootstrapping logic by requiring an AppManifest to be supplied, remoev cfg property

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221356#comment-16221356
 ] 

ASF subversion and git services commented on ISIS-1725:
---

Commit f98b0ede171e88824aa7f96195f5fac170eb2af5 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f98b0ed ]

ISIS-1725: requires that an AppManifest is supplied (used to obtain list of 
entities).


> Simplify bootstrapping logic by requiring an AppManifest to be supplied, 
> remoev cfg property
> 
>
> Key: ISIS-1725
> URL: https://issues.apache.org/jira/browse/ISIS-1725
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> implies that the isis.persistor.datanucleus.RegisterEntities.packagePrefix 
> config property is not longer used
> // no longer used ...
> public final static String PACKAGE_PREFIX_KEY = 
> "isis.persistor.datanucleus.RegisterEntities.packagePrefix";
> in ISIS-1276-dn-5-1 branch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ISIS-1276) Update DN to 5.1.x (from DN 4.1.x)

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221352#comment-16221352
 ] 

ASF subversion and git services commented on ISIS-1276:
---

Commit 2af08d35e515cc4cd9a5497c91f68acc0e0e8757 in isis's branch 
refs/heads/dev/2.0.0/ISIS-1276-dn-5-1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2af08d3 ]

ISIS-1276: fixes compile issues in metamodel and runtime


> Update DN to 5.1.x (from DN 4.1.x)
> --
>
> Key: ISIS-1276
> URL: https://issues.apache.org/jira/browse/ISIS-1276
> Project: Isis
>  Issue Type: Dependency upgrade
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 2.0.0
>
>
> Note that this will break IsisJdoSupport since the TypesafeQuery class is 
> removed.  While strictly speaking we ought to bump to Isis v2.0.0 because it 
> is a breaking change, I think in this particular instance we make an 
> exception: my guess is that not may are using that particular API.
> http://www.datanucleus.org/products/accessplatform_5_1/migration.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: rebased dev/2.0.0/ISIS-1276-dn-5-1 and dev/2.0.0/ISIS-1638-j8-time

2017-10-26 Thread Andi Huber 
Fine with me.


On 27.10.2017 00:28, Dan Haywood wrote:
> Hi Andi,
>
> Hope it's okay, I've rebased the dn-5-1 branch and the j8 branch also,
> on top of the dev/2.0.0/ISIS-1742-remove-deprecations ... just so they
> don't get too far out of line with all the work being done on that branch.
>
> So, you may need to reset your local branches when you pull these down.
>
> Thx
> Dan

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

2017-10-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221400#comment-16221400
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit 0c4dccf92d43fe18d8dd6facd5978fa43039bcef in isis's branch 
refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0c4dccf ]

ISIS-1756: adds @Deprecated annotation to IsisContext.testReset()

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
> Fix For: 2.0.0
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)