[GitHub] [jackrabbit-oak] thomasmueller opened a new pull request #211: OAK-9065 JMX feature to remove large disabled indexes (recursive delete)

[GitBox]

thomasmueller opened a new pull request #211:
URL: https://github.com/apache/jackrabbit-oak/pull/211


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] thomasmueller closed pull request #211: OAK-9065 JMX feature to remove large disabled indexes (recursive delete)

[GitBox]

thomasmueller closed pull request #211:
URL: https://github.com/apache/jackrabbit-oak/pull/211


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (JCRVLT-429) Switch to bnd-maven-plugin

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111884#comment-17111884
 ] 

Konrad Windszus commented on JCRVLT-429:


[~tripod] It is unclear how the bundle 
https://github.com/apache/jackrabbit-filevault/tree/trunk/vault-diff is 
supposed to work. It contains an Import-Package header to {{difflib}} due to 
the dependency 
https://github.com/apache/jackrabbit-filevault/blob/7b47a90e10a4b6dce6232cf87e8526ab549216bb/vault-diff/pom.xml#L46.
 However the latter is not an OSGi bundle and is neither embedded. Who are the 
consumer's of that bundle and in which environment is that supposed to resolve?

> Switch to bnd-maven-plugin
> --
>
> Key: JCRVLT-429
> URL: https://issues.apache.org/jira/browse/JCRVLT-429
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> We should switch to using the bnd maven plugins directly instead of using the 
> Felix wrapper. They have less overhead and are used since quite a while 
> successfully in Apache Sling now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Reopened] (JCRVLT-429) Switch to bnd-maven-plugin

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCRVLT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reopened JCRVLT-429:


> Switch to bnd-maven-plugin
> --
>
> Key: JCRVLT-429
> URL: https://issues.apache.org/jira/browse/JCRVLT-429
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> We should switch to using the bnd maven plugins directly instead of using the 
> Felix wrapper. They have less overhead and are used since quite a while 
> successfully in Apache Sling now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (JCRVLT-429) Switch to bnd-maven-plugin

[Tobias Bocanegra (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111947#comment-17111947
 ] 

Tobias Bocanegra edited comment on JCRVLT-429 at 5/20/20, 8:56 AM:
---

AFAIRC, this library is never used as bundle.

it is only used in the command line tools.


was (Author: tripod):
AFAIRC, this library is never used as bundle.

> Switch to bnd-maven-plugin
> --
>
> Key: JCRVLT-429
> URL: https://issues.apache.org/jira/browse/JCRVLT-429
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> We should switch to using the bnd maven plugins directly instead of using the 
> Felix wrapper. They have less overhead and are used since quite a while 
> successfully in Apache Sling now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCRVLT-429) Switch to bnd-maven-plugin

[Tobias Bocanegra (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111947#comment-17111947
 ] 

Tobias Bocanegra commented on JCRVLT-429:
-

AFAIRC, this library is never used as bundle.

> Switch to bnd-maven-plugin
> --
>
> Key: JCRVLT-429
> URL: https://issues.apache.org/jira/browse/JCRVLT-429
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> We should switch to using the bnd maven plugins directly instead of using the 
> Felix wrapper. They have less overhead and are used since quite a while 
> successfully in Apache Sling now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCRVLT-429) Switch to bnd-maven-plugin

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111954#comment-17111954
 ] 

Konrad Windszus commented on JCRVLT-429:


Thanks for the answer, but I don't even see it referenced in 
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-cli/pom.xml. 

Anyhow, I would now just convert that to a regular JAR then.

> Switch to bnd-maven-plugin
> --
>
> Key: JCRVLT-429
> URL: https://issues.apache.org/jira/browse/JCRVLT-429
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> We should switch to using the bnd maven plugins directly instead of using the 
> Felix wrapper. They have less overhead and are used since quite a while 
> successfully in Apache Sling now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (JCRVLT-436) VLT-RCP bundle no longer working with older Jackrabbit/Oak versions

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111354#comment-17111354
 ] 

Konrad Windszus edited comment on JCRVLT-436 at 5/20/20, 10:58 AM:
---

In https://github.com/apache/jackrabbit-filevault/pull/78/commits I leverage 
{{bnd-resolve-maven-plugin}} to make sure that all constraints (e.g. 
Import-Package header) can be resolved in a minimum supported OSGi container 
(baseline is AEM 6.3). That way the build will fail, if the generated bundles 
(Core, RCP and Sync) will no longer resolve in such an environment.


was (Author: kwin):
In https://github.com/apache/jackrabbit-filevault/pull/78/commits I leverage 
{{bnd-resolve-maven-plugin}} to make sure that all constraints (e.g. 
Import-Package header) can be resolved in a minimum supported OSGi container 
(baseline is AEM 6.3). That way the build will fail, if the generated bundles 
(both RCP and Core) will no longer resolve in such an environment.

> VLT-RCP bundle no longer working with older Jackrabbit/Oak versions
> ---
>
> Key: JCRVLT-436
> URL: https://issues.apache.org/jira/browse/JCRVLT-436
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: RCP
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
> Attachments: Screenshot 2020-05-13 at 16.28.08.png
>
>
> Due to the upgrade of the dependencies in 
> https://issues.apache.org/jira/browse/JCRVLT-344 and 
> https://issues.apache.org/jira/browse/JCRVLT-399 the vlt-rcp bundle does no 
> longer start on older distributions.
> E.g. on AEM 6.5.4 the following imports can no be resolved:
> # org.apache.jackrabbit.util,version=[2.5.0,3) -- Cannot be resolved 
> (exported in older version by bundle 
> org.apache.jackrabbit.jackrabbit-jcr-commons)
> # org.apache.jackrabbit.api.security,version=[2.4.1,2.5) -- Cannot be 
> resolved (exported in older version by bundle 
> org.apache.jackrabbit.jackrabbit-api)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCRVLT-398) Migrate Filevault to Git

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112077#comment-17112077
 ] 

Konrad Windszus commented on JCRVLT-398:


I triggered the migration now in 
https://issues.apache.org/jira/browse/INFRA-20285.

> Migrate Filevault to Git
> 
>
> Key: JCRVLT-398
> URL: https://issues.apache.org/jira/browse/JCRVLT-398
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: Misc
>Affects Versions: 3.4.2, package-maven-plugin-1.0.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> As discussed in 
> https://lists.apache.org/thread.html/8ea0d827d9e8488183648f2364ecd4e178b6d82e03193735aae6b5cd%40%3Coak-dev.jackrabbit.apache.org%3E
>  we should migrate to Git.
> Good candidates are both repos for FileVault which should each get a 
> dedicated Git repository.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCRVLT-436) VLT-RCP bundle no longer working with older Jackrabbit/Oak versions

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112083#comment-17112083
 ] 

Konrad Windszus commented on JCRVLT-436:


Fixed in http://svn.apache.org/r1877947.

> VLT-RCP bundle no longer working with older Jackrabbit/Oak versions
> ---
>
> Key: JCRVLT-436
> URL: https://issues.apache.org/jira/browse/JCRVLT-436
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: RCP
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
> Attachments: Screenshot 2020-05-13 at 16.28.08.png
>
>
> Due to the upgrade of the dependencies in 
> https://issues.apache.org/jira/browse/JCRVLT-344 and 
> https://issues.apache.org/jira/browse/JCRVLT-399 the vlt-rcp bundle does no 
> longer start on older distributions.
> E.g. on AEM 6.5.4 the following imports can no be resolved:
> # org.apache.jackrabbit.util,version=[2.5.0,3) -- Cannot be resolved 
> (exported in older version by bundle 
> org.apache.jackrabbit.jackrabbit-jcr-commons)
> # org.apache.jackrabbit.api.security,version=[2.4.1,2.5) -- Cannot be 
> resolved (exported in older version by bundle 
> org.apache.jackrabbit.jackrabbit-api)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (JCRVLT-436) VLT-RCP bundle no longer working with older Jackrabbit/Oak versions

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCRVLT-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved JCRVLT-436.

Resolution: Fixed

> VLT-RCP bundle no longer working with older Jackrabbit/Oak versions
> ---
>
> Key: JCRVLT-436
> URL: https://issues.apache.org/jira/browse/JCRVLT-436
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: RCP
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
> Attachments: Screenshot 2020-05-13 at 16.28.08.png
>
>
> Due to the upgrade of the dependencies in 
> https://issues.apache.org/jira/browse/JCRVLT-344 and 
> https://issues.apache.org/jira/browse/JCRVLT-399 the vlt-rcp bundle does no 
> longer start on older distributions.
> E.g. on AEM 6.5.4 the following imports can no be resolved:
> # org.apache.jackrabbit.util,version=[2.5.0,3) -- Cannot be resolved 
> (exported in older version by bundle 
> org.apache.jackrabbit.jackrabbit-jcr-commons)
> # org.apache.jackrabbit.api.security,version=[2.4.1,2.5) -- Cannot be 
> resolved (exported in older version by bundle 
> org.apache.jackrabbit.jackrabbit-api)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (JCRVLT-429) Switch to bnd-maven-plugin

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCRVLT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved JCRVLT-429.

Resolution: Fixed

Finished migration with http://svn.apache.org/r1877947.

> Switch to bnd-maven-plugin
> --
>
> Key: JCRVLT-429
> URL: https://issues.apache.org/jira/browse/JCRVLT-429
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> We should switch to using the bnd maven plugins directly instead of using the 
> Felix wrapper. They have less overhead and are used since quite a while 
> successfully in Apache Sling now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [jackrabbit-oak] synox opened a new pull request #212: Feature/oak 9068 aws improvements

[GitBox]

synox opened a new pull request #212:
URL: https://github.com/apache/jackrabbit-oak/pull/212


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (JCRVLT-427) Allow installation of packages with hook for users without admin privileges

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/JCRVLT-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112207#comment-17112207
 ] 

Konrad Windszus commented on JCRVLT-427:


Ok, I am gonna propose a PR with dedicated config options. I am wondering 
though whether the check should be moved to the PackageManager/PackageRegistry 
instead. Leaving it at the Package level forces me to pass those configuration 
options along for each package.
[~tripod] WDYT?

> Allow installation of packages with hook for users without admin privileges
> ---
>
> Key: JCRVLT-427
> URL: https://issues.apache.org/jira/browse/JCRVLT-427
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: vlt
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> Currently due to the check in 
> https://github.com/apache/jackrabbit-filevault/blob/e257001ec22ea06bcc987cbf79f0cc9b15c4e186/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L184
>  packages containing a hook can only be installed by admins.
> Although I do understand the intent of that I think this is not flexible 
> enough as currently that only gives the rights to users "admin", "system" or 
> members of group "administrators". Instead there should be an OSGi 
> configuration which allows to configure to grant the right to install 
> packages with hooks to other groups as well!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [jackrabbit-oak] dulceanu commented on a change in pull request #212: Feature/oak 9068 aws improvements

[GitBox]

dulceanu commented on a change in pull request #212:
URL: https://github.com/apache/jackrabbit-oak/pull/212#discussion_r428044503



##
File path: oak-segment-aws/pom.xml
##
@@ -175,13 +175,13 @@
 org.apache.jackrabbit
 oak-segment-tar
 ${project.version}
-provided
+compile

Review comment:
   @synox, I don't think we need to change the scope of these two 
dependencies, for both oak-segment-aws and oak-segment-azure modules.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #213: OAK-9069 Remove unnecessary (un)boxing in oak-auth-external

[GitBox]

larsgrefer opened a new pull request #213:
URL: https://github.com/apache/jackrabbit-oak/pull/213


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #214: OAK-9070 Remove unnecessary (un)boxing in oak-authorization-principalbased

[GitBox]

larsgrefer opened a new pull request #214:
URL: https://github.com/apache/jackrabbit-oak/pull/214


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #215: OAK-9071 Remove unnecessary (un)boxing in oak-benchmarks

[GitBox]

larsgrefer opened a new pull request #215:
URL: https://github.com/apache/jackrabbit-oak/pull/215


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #216: OAK-9072 Remove unnecessary (un)boxing in oak-blob-plugins

[GitBox]

larsgrefer opened a new pull request #216:
URL: https://github.com/apache/jackrabbit-oak/pull/216


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #217: OAK-9073 Remove unnecessary (un)boxing in oak-commons

[GitBox]

larsgrefer opened a new pull request #217:
URL: https://github.com/apache/jackrabbit-oak/pull/217


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #218: OAK-9074 Remove unnecessary (un)boxing in oak-core

[GitBox]

larsgrefer opened a new pull request #218:
URL: https://github.com/apache/jackrabbit-oak/pull/218


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #219: OAK-9075 Remove unnecessary (un)boxing in oak-exercise

[GitBox]

larsgrefer opened a new pull request #219:
URL: https://github.com/apache/jackrabbit-oak/pull/219


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #220: OAK-9076 Remove unnecessary (un)boxing in oak-jcr

[GitBox]

larsgrefer opened a new pull request #220:
URL: https://github.com/apache/jackrabbit-oak/pull/220


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #221: OAK-9077 Remove unnecessary (un)boxing in oak-lucene

[GitBox]

larsgrefer opened a new pull request #221:
URL: https://github.com/apache/jackrabbit-oak/pull/221


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #222: OAK-9078 Remove unnecessary (un)boxing in oak-run

[GitBox]

larsgrefer opened a new pull request #222:
URL: https://github.com/apache/jackrabbit-oak/pull/222


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #223: OAK-9079 Remove unnecessary (un)boxing in oak-security-spi

[GitBox]

larsgrefer opened a new pull request #223:
URL: https://github.com/apache/jackrabbit-oak/pull/223


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #224: OAK-9080 Remove unnecessary (un)boxing in oak-segment-azure

[GitBox]

larsgrefer opened a new pull request #224:
URL: https://github.com/apache/jackrabbit-oak/pull/224


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #225: OAK-9081 Remove unnecessary (un)boxing in oak-solr-core

[GitBox]

larsgrefer opened a new pull request #225:
URL: https://github.com/apache/jackrabbit-oak/pull/225


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #226: OAK-9082 Remove unnecessary (un)boxing in oak-store-composite

[GitBox]

larsgrefer opened a new pull request #226:
URL: https://github.com/apache/jackrabbit-oak/pull/226


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #227: OAK-9083 Remove unnecessary (un)boxing in oak-store-document

[GitBox]

larsgrefer opened a new pull request #227:
URL: https://github.com/apache/jackrabbit-oak/pull/227


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #228: OAK-9084 Remove unnecessary (un)boxing in oak-store-spi

[GitBox]

larsgrefer opened a new pull request #228:
URL: https://github.com/apache/jackrabbit-oak/pull/228


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #229: OAK-9085 Remove unnecessary (un)boxing in oak-webapp

[GitBox]

larsgrefer opened a new pull request #229:
URL: https://github.com/apache/jackrabbit-oak/pull/229


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer commented on pull request #203: OAK-9026 Performance Improvement: Unnecessary boxing and unboxing

[GitBox]

larsgrefer commented on pull request #203:
URL: https://github.com/apache/jackrabbit-oak/pull/203#issuecomment-631649890


   I'm closing this in favor of:
   
   #206 
   #207 
   #213 
   #214 
   #215 
   #216 
   #217 
   #218 
   #219 
   #220 
   #221 
   #222 
   #223 
   #224 
   #225 
   #226 
   #227 
   #228 
   #229 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer closed pull request #203: OAK-9026 Performance Improvement: Unnecessary boxing and unboxing

[GitBox]

larsgrefer closed pull request #203:
URL: https://github.com/apache/jackrabbit-oak/pull/203


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] larsgrefer commented on pull request #213: OAK-9069 Remove unnecessary (un)boxing in oak-auth-external

[GitBox]

larsgrefer commented on pull request #213:
URL: https://github.com/apache/jackrabbit-oak/pull/213#issuecomment-631652969


   I've just split #203 up by module as requested here: 
https://issues.apache.org/jira/browse/OAK-9026?focusedCommentId=17091262&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17091262
   
   But I agree that these changes aren't that important :smile: 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (JCR-4169) make WebdavServerTests run automatically

[Manfred Baedke (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCR-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke updated JCR-4169:

Attachment: JCR-4158-prelimary.patch

> make WebdavServerTests run automatically
> 
>
> Key: JCR-4169
> URL: https://issues.apache.org/jira/browse/JCR-4169
> Project: Jackrabbit Content Repository
>  Issue Type: Sub-task
>  Components: jackrabbit-jcr-server
>Reporter: Julian Reschke
>Assignee: Manfred Baedke
>Priority: Minor
> Attachments: JCR-4158-prelimary.patch
>
>
> These tests aren't currently run automatically, as they require a separate 
> jackrabbit-standalone instance running.
> Consider starting this up as part of the test fixture.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCR-4169) make WebdavServerTests run automatically

[Manfred Baedke (Jira)]

[ 
https://issues.apache.org/jira/browse/JCR-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112574#comment-17112574
 ] 

Manfred Baedke commented on JCR-4169:
-

[~reschke], please take a look at JCR-4158-prelimary.patch. It contains 
proposed changes to jackrabbit-webdav necessary to make RFC4918IfHeaderTest 
pass. If these make sense I'll open a new issue for them. Please review.

> make WebdavServerTests run automatically
> 
>
> Key: JCR-4169
> URL: https://issues.apache.org/jira/browse/JCR-4169
> Project: Jackrabbit Content Repository
>  Issue Type: Sub-task
>  Components: jackrabbit-jcr-server
>Reporter: Julian Reschke
>Assignee: Manfred Baedke
>Priority: Minor
> Attachments: JCR-4158-prelimary.patch
>
>
> These tests aren't currently run automatically, as they require a separate 
> jackrabbit-standalone instance running.
> Consider starting this up as part of the test fixture.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [GitHub] [jackrabbit-oak] larsgrefer opened a new pull request #226: OAK-9082 Remove unnecessary (un)boxing in oak-store-composite

[Torgeir Veimo]

Maybe it would be an idea to have a separate mailing list for the pull-requests?

On Thu, 21 May 2020 at 04:24, GitBox  wrote:
>
>
> larsgrefer opened a new pull request #226:
> URL: https://github.com/apache/jackrabbit-oak/pull/226
>
>
>
>
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>


-- 
-Tor

[jira] [Commented] (JCR-4536) Feature/enable insecure https host

[Max Barrass (Jira)]

[ 
https://issues.apache.org/jira/browse/JCR-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112683#comment-17112683
 ] 

Max Barrass commented on JCR-4536:
--

[~reschke] thank you for feedback.

The code only has the changes needed, this was already pointed out and cleaned 
up. Anything, in particular, you want to be reviewed?

This came about from using Adobes and Vendor environments where devs do not 
have control to update environments to have the proper config of SSL.

This behaviour is similar to when you run curl with --insecure option, this is 
not a default option and requires an explicit parameter to activate, its not 
something that you unintentionally would do.

Happy to add Logging message if it's beneficial, do you want me to add this?

> Feature/enable insecure https host
> --
>
> Key: JCR-4536
> URL: https://issues.apache.org/jira/browse/JCR-4536
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Max Barrass
>Priority: Major
>
> Adding support for insecure parameter to allow access to https with invalid 
> certs.
> Enabling optional support for expired ssl certs when using https on 
> development server with self generated certificates.
> Pull request already created and ready for review 
> [https://github.com/apache/jackrabbit/pull/88]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [jackrabbit] wildone commented on pull request #88: JCR-4536: Feature/enable insecure https host

[GitBox]

wildone commented on pull request #88:
URL: https://github.com/apache/jackrabbit/pull/88#issuecomment-631806490


   thank @kwin do you want me to add logging to prompt the user that insecure 
option being used? Any preference what the message for prompt should be?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (JCR-4536) Feature/enable insecure https host

[Max Barrass (Jira)]

[ 
https://issues.apache.org/jira/browse/JCR-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112684#comment-17112684
 ] 

Max Barrass commented on JCR-4536:
--

[~reschke] Any preference what the message for prompt should be?

> Feature/enable insecure https host
> --
>
> Key: JCR-4536
> URL: https://issues.apache.org/jira/browse/JCR-4536
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Max Barrass
>Priority: Major
>
> Adding support for insecure parameter to allow access to https with invalid 
> certs.
> Enabling optional support for expired ssl certs when using https on 
> development server with self generated certificates.
> Pull request already created and ready for review 
> [https://github.com/apache/jackrabbit/pull/88]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCR-4536) Feature/enable insecure https host

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/JCR-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112758#comment-17112758
 ] 

Julian Reschke commented on JCR-4536:
-

Can you please reply to the feedback in 
?

> Feature/enable insecure https host
> --
>
> Key: JCR-4536
> URL: https://issues.apache.org/jira/browse/JCR-4536
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Max Barrass
>Priority: Major
>
> Adding support for insecure parameter to allow access to https with invalid 
> certs.
> Enabling optional support for expired ssl certs when using https on 
> development server with self generated certificates.
> Pull request already created and ready for review 
> [https://github.com/apache/jackrabbit/pull/88]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [jackrabbit-oak] synox commented on pull request #212: Feature/oak 9068 aws improvements

[GitBox]

synox commented on pull request #212:
URL: https://github.com/apache/jackrabbit-oak/pull/212#issuecomment-631901433


   Thanks, I will update and create patch. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] synox closed pull request #212: Feature/oak 9068 aws improvements

[GitBox]

synox closed pull request #212:
URL: https://github.com/apache/jackrabbit-oak/pull/212


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org