[jira] [Commented] (KAFKA-2606) Remove kafka.utils.Time in favour of o.a.kafka.common.utils.Time
[ https://issues.apache.org/jira/browse/KAFKA-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941998#comment-14941998 ] Ismael Juma commented on KAFKA-2606: Sorry, my bad, I couldn't find it when I searched for it. We can close this but maybe mention the scheduler aspect on the other issue? > Remove kafka.utils.Time in favour of o.a.kafka.common.utils.Time > > > Key: KAFKA-2606 > URL: https://issues.apache.org/jira/browse/KAFKA-2606 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8.2.2 >Reporter: Ismael Juma >Priority: Minor > Labels: newbie > > They duplicate each other at the moment and some server classes actually need > an instance of both types, which is annoying. > It's worth noting that `kafka.utils.MockTime` includes a `scheduler` that is > used by some tests while `o.a.kafka.common.utils.Time` does not. We either > need to add this functionality or change the tests not to need it anymore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2606) Remove kafka.utils.Time in favour of o.a.kafka.common.utils.Time
[ https://issues.apache.org/jira/browse/KAFKA-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941984#comment-14941984 ] Aditya Auradkar commented on KAFKA-2606: [~ijuma] This is a duplicate of https://issues.apache.org/jira/browse/KAFKA-2247 If you plan to work on this, I'll close the other one. Otherwise, I can close this. > Remove kafka.utils.Time in favour of o.a.kafka.common.utils.Time > > > Key: KAFKA-2606 > URL: https://issues.apache.org/jira/browse/KAFKA-2606 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8.2.2 >Reporter: Ismael Juma >Priority: Minor > Labels: newbie > > They duplicate each other at the moment and some server classes actually need > an instance of both types, which is annoying. > It's worth noting that `kafka.utils.MockTime` includes a `scheduler` that is > used by some tests while `o.a.kafka.common.utils.Time` does not. We either > need to add this functionality or change the tests not to need it anymore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)