[jira] [Commented] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2017-05-18 Thread Bharat Viswanadham (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016258#comment-16016258
 ] 

Bharat Viswanadham commented on KAFKA-4171:
---

[~ewencp] The behavior is changed in AbstractConfig logUnsed() method to print 
only keys not values. As a part of KAFKA-4056: Kafka logs values of sensitive 
configs like passwords  In case of unknown configs, only list the name without 
the value. So, I think this jira can be closed as fixed.

> Kafka-connect prints outs keystone and truststore password in log2
> --
>
> Key: KAFKA-4171
> URL: https://issues.apache.org/jira/browse/KAFKA-4171
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Akshath Patkar
>Assignee: Bharat Viswanadham
>
> Kafka-connect prints outs keystone and truststore password in log
> [2016-09-14 16:30:33,971] WARN The configuration 
> consumer.ssl.truststore.password = X was supplied but isn't a known 
> config. (org.apache.kafka.clients.consumer.ConsumerConfig:186)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2017-05-18 Thread Ewen Cheslack-Postava (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016189#comment-16016189
 ] 

Ewen Cheslack-Postava commented on KAFKA-4171:
--

[~bharatviswa] I'm not aware of any fixes made for this, but we can close if we 
can verify it no longer logs this. This might be related to the fact that the 
config may be specified multiple times in a worker config (for the worker 
itself and prefixed by consumer. and producer.). In this case the ones with the 
extra prefixes might be the ones that are getting logged, i.e. in some places 
in the log it may have the correct behavior but in other locations it may have 
the incorrect behavior.

> Kafka-connect prints outs keystone and truststore password in log2
> --
>
> Key: KAFKA-4171
> URL: https://issues.apache.org/jira/browse/KAFKA-4171
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Akshath Patkar
>Assignee: Bharat Viswanadham
>
> Kafka-connect prints outs keystone and truststore password in log
> [2016-09-14 16:30:33,971] WARN The configuration 
> consumer.ssl.truststore.password = X was supplied but isn't a known 
> config. (org.apache.kafka.clients.consumer.ConsumerConfig:186)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2017-05-17 Thread Bharat Viswanadham (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014528#comment-16014528
 ] 

Bharat Viswanadham commented on KAFKA-4171:
---

Hi Ewen,
Please let me know any more work is pending for this work item?

> Kafka-connect prints outs keystone and truststore password in log2
> --
>
> Key: KAFKA-4171
> URL: https://issues.apache.org/jira/browse/KAFKA-4171
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Akshath Patkar
>Assignee: Bharat Viswanadham
>
> Kafka-connect prints outs keystone and truststore password in log
> [2016-09-14 16:30:33,971] WARN The configuration 
> consumer.ssl.truststore.password = X was supplied but isn't a known 
> config. (org.apache.kafka.clients.consumer.ConsumerConfig:186)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2017-05-17 Thread Bharat Viswanadham (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014526#comment-16014526
 ] 

Bharat Viswanadham commented on KAFKA-4171:
---

Hi,
I think this issue got resolved, I think this issue has been resolved. Now 
logUnsed() method is logging the only key, it is not printing the value.
So, this issue will not be seen.


> Kafka-connect prints outs keystone and truststore password in log2
> --
>
> Key: KAFKA-4171
> URL: https://issues.apache.org/jira/browse/KAFKA-4171
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Akshath Patkar
>Assignee: Bharat Viswanadham
>
> Kafka-connect prints outs keystone and truststore password in log
> [2016-09-14 16:30:33,971] WARN The configuration 
> consumer.ssl.truststore.password = X was supplied but isn't a known 
> config. (org.apache.kafka.clients.consumer.ConsumerConfig:186)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2016-09-14 Thread Ewen Cheslack-Postava (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491532#comment-15491532
 ] 

Ewen Cheslack-Postava commented on KAFKA-4171:
--

Yeah, that's almost definitely what's happening [~criccomini]. I'm not sure 
that actually stripping them out will solve this problem though because the 
consumer.* prefixed version will probably also be printed by the worker config. 
We can try to remove the settings in each case, although this is also just a 
more general problem with the way Kafka handles configs (e.g. a sensitive 
serializer setting, e.g. something like SSL settings for a schema registry, 
can't possibly be known by the framework and so would always be logged). So I 
think we can fix this immediate issue, but the way configs are logged might 
still be an issue.

> Kafka-connect prints outs keystone and truststore password in log2
> --
>
> Key: KAFKA-4171
> URL: https://issues.apache.org/jira/browse/KAFKA-4171
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Akshath Patkar
>Assignee: Ewen Cheslack-Postava
>
> Kafka-connect prints outs keystone and truststore password in log
> [2016-09-14 16:30:33,971] WARN The configuration 
> consumer.ssl.truststore.password = X was supplied but isn't a known 
> config. (org.apache.kafka.clients.consumer.ConsumerConfig:186)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2016-09-14 Thread Chris Riccomini (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491164#comment-15491164
 ] 

Chris Riccomini commented on KAFKA-4171:


Wondering if KC is just putting configuration from consumer.* into the config 
without the consumer.*, but leaving the config with the consumer. prefix 
floating around still? Seems like the prefix should be stripped when forwarding 
config on to the underlying Kafka consumer.

> Kafka-connect prints outs keystone and truststore password in log2
> --
>
> Key: KAFKA-4171
> URL: https://issues.apache.org/jira/browse/KAFKA-4171
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Akshath Patkar
>Assignee: Ewen Cheslack-Postava
>
> Kafka-connect prints outs keystone and truststore password in log
> [2016-09-14 16:30:33,971] WARN The configuration 
> consumer.ssl.truststore.password = X was supplied but isn't a known 
> config. (org.apache.kafka.clients.consumer.ConsumerConfig:186)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)