[jira] [Commented] (KAFKA-2485) Allow producer performance to take properties from a file via --producer.config command line parameter

2015-08-27 Thread Dong Lin (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717963#comment-14717963
 ] 

Dong Lin commented on KAFKA-2485:
-

[~ewencp] I didn't add this to the Java producer performance because I am not 
sure when the class is used -- I have never used that class for producer 
performance test. I can certainly add it there if anyone thinks it is useful.

And thanks for fixing the title :)

> Allow producer performance to take properties from a file via 
> --producer.config command line parameter
> --
>
> Key: KAFKA-2485
> URL: https://issues.apache.org/jira/browse/KAFKA-2485
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Dong Lin
>Assignee: Dong Lin
>
> In order to allow ProducerPerformance to produce via ssl connection, we need 
> the following (example) configuration:
> security.protocol=SSL
> ssl.protocol=TLS
> ssl.truststore.type=JKS
> ssl.truststore.location=serverkeystore.jks
> ssl.truststore.password=password
> ssl.keymanager.algorithm=SunX509
> ssl.trustmanager.algorithm=SunX509
> There are two ways to achieve it: 1) extend ProducerPerformance to explicitly 
> accept all 7 ssl-related parameters; 2) allow ProducerPerformance to take 
> properties from a file via --consumer.config command line parameter.
> It seems option 2) is better, because it requires less code, allows new 
> options to be easily added in the future, and doesn't require user to specify 
> password in the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-2485) Allow producer performance to take properties from a file via --producer.config command line parameter

2015-08-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723924#comment-14723924
 ] 

ASF GitHub Bot commented on KAFKA-2485:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/174


> Allow producer performance to take properties from a file via 
> --producer.config command line parameter
> --
>
> Key: KAFKA-2485
> URL: https://issues.apache.org/jira/browse/KAFKA-2485
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Dong Lin
>Assignee: Dong Lin
>
> In order to allow ProducerPerformance to produce via ssl connection, we need 
> the following (example) configuration:
> security.protocol=SSL
> ssl.protocol=TLS
> ssl.truststore.type=JKS
> ssl.truststore.location=serverkeystore.jks
> ssl.truststore.password=password
> ssl.keymanager.algorithm=SunX509
> ssl.trustmanager.algorithm=SunX509
> There are two ways to achieve it: 1) extend ProducerPerformance to explicitly 
> accept all 7 ssl-related parameters; 2) allow ProducerPerformance to take 
> properties from a file via --consumer.config command line parameter.
> It seems option 2) is better, because it requires less code, allows new 
> options to be easily added in the future, and doesn't require user to specify 
> password in the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)